Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds

On Wed, May 25, 2022 at 10:05 PM Gurjeet Singh wrote: > I have added a comment to be_tls_init(), which I hope explains this > difference in treatment of errors. I have also added comments to > be_tls_init(), explaining why we don't destroy/free the global > SSL_context variable in case of an error

Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT

On Wed, May 25, 2022 at 9:44 PM Robert Haas wrote: > On Sat, May 21, 2022 at 9:09 AM Justin Pryzby wrote: > > It looks like the docs weren't updated in 6f6b99d13 for v11. > > In my defense, that commit definitely contained documentation changes. > It updated alter_table.sgml and create_table.sgml

Re: Handle infinite recursion in logical replication setup

On Thu, May 26, 2022 at 3:08 PM Amit Kapila wrote: > > On Thu, May 26, 2022 at 7:06 AM Peter Smith wrote: > > > > > > 3. doc/src/sgml/catalogs.sgml > > > > + > > + If true, the subscription will request that the publisher send > > locally > > + originated changes. False indicat

Re: Authorizing select count()

I wrote: > I'm fairly sure that in the past we've considered this idea and rejected > it, mainly on the grounds that it's a completely gratuitous departure > from SQL standard. After some more digging I found the thread that (I think) the "mere pedantry" comment was referring to: https://www.post

Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds

On Mon, May 23, 2022 at 8:51 PM Tom Lane wrote: > > Daniel Gustafsson writes: > >> On 22 May 2022, at 08:41, Gurjeet Singh wrote: > >> The initialization in PostmasterMain() blindly turns on LoadedSSL, > >> irrespective of the outcome of secure_initialize(). > > > This call is invoked with isSer

Re: Add --{no-,}bypassrls flags to createuser

On 2022-05-25 12:47, Michael Paquier wrote: On Wed, May 25, 2022 at 11:07:52AM +0900, Kyotaro Horiguchi wrote: I reproduced the same failure at my hand and identified the cause. Windows' version of getopt_long seems to dislike that non-optional parameters precedes options. Tweaking the list of

Re: Handle infinite recursion in logical replication setup

On Thu, May 26, 2022 at 7:06 AM Peter Smith wrote: > > > 3. doc/src/sgml/catalogs.sgml > > + > + If true, the subscription will request that the publisher send locally > + originated changes. False indicates that the publisher sends any > changes > + regardless of their or

Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds

On Sun, May 22, 2022 at 12:17 AM Daniel Gustafsson wrote: > > On 22 May 2022, at 08:41, Gurjeet Singh wrote: > > > The initialization in PostmasterMain() blindly turns on LoadedSSL, > > irrespective of the outcome of secure_initialize(). > > This call is invoked with isServerStart set to true so

Re: Handle infinite recursion in logical replication setup

On Thu, May 26, 2022 at 2:20 PM Amit Kapila wrote: > > On Thu, May 26, 2022 at 7:06 AM Peter Smith wrote: > > > > Here are my review comments for patch v15-0001. > > > > == > > > > 1. Commit message > > > > Should this also say new test cases were added for the test_decoding plugin? > > > > ~

Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~

On Thu, May 26, 2022 at 04:16:40PM +1200, Thomas Munro wrote: > I think we should drop everything older than Win 10 for PG16, as > argued in various threads where various pain points came up. For one > thing, that would make a lot of future work simpler (ie not needing to > test alternative code p

Re: Handle infinite recursion in logical replication setup

On Thu, May 26, 2022 at 7:06 AM Peter Smith wrote: > > Here are my review comments for patch v15-0001. > > == > > 1. Commit message > > Should this also say new test cases were added for the test_decoding plugin? > > ~~~ Shall we take this out as a separate test-case patch? I think it is a go

Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~

On Thu, May 26, 2022 at 2:59 PM Michael Paquier wrote: > On the thread about the removal of VS 2013, Jose (in CC) has mentioned > that bumping MIN_WINNT independently would make sense, as the > simplication of locales would expose under MinGW some code for > GetLocaleInfoEx(): > https://www.postgr

Re: fix stats_fetch_consistency value in postgresql.conf.sample

At Wed, 25 May 2022 21:25:53 -0500, Justin Pryzby wrote in > On Thu, May 26, 2022 at 11:10:18AM +0900, Kyotaro Horiguchi wrote: > > Yeah, "boot_val" is appropreate here. And I noticed that pg_settings > > has the "unit" field. I'll try using them. > > I wrote this in guc.sql, which seems prom

Re: ccache, MSVC, and meson

On Sun, May 22, 2022 at 06:26:06PM -0500, Justin Pryzby wrote: > ccache 4.6.1 was released which allows compiling postgres 4.6.1 is now in choco. This is required to use with the current msbuild process. > But with the existing build system, it's no faster anyway, I guess due to poor > use of pa

Re: bogus: logical replication rows/cols combinations

On Tue, May 24, 2022 at 3:19 PM Amit Kapila wrote: > > On Fri, May 20, 2022 at 8:36 AM Amit Kapila wrote: > > > > On Thu, May 19, 2022 at 7:54 PM Tom Lane wrote: > > > > > > Justin Pryzby writes: > > > > On Thu, May 19, 2022 at 10:33:13AM +0530, Amit Kapila wrote: > > > >> I have committed the

Re: ccache, MSVC, and meson

On Tue, May 24, 2022 at 09:48:17PM -0700, Andres Freund wrote: > > And when I pass /Oy- to "avoid omitting" frame pointers, several tests > > crash... > > Huh. Do you get a backtrace containing anything remotely meaningful? They are interesting, but maybe not meaningful. I tested a bunch of dif

Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~

Hi all, On the thread about the removal of VS 2013, Jose (in CC) has mentioned that bumping MIN_WINNT independently would make sense, as the simplication of locales would expose under MinGW some code for GetLocaleInfoEx(): https://www.postgresql.org/message-id/cac+axb3himfh+-pgro1cyju6zf2hlh6vmwpb

Re: [RFC] building postgres with meson

Andres Freund writes: > On 2022-05-25 21:38:33 -0400, Tom Lane wrote: >> I think the main thing I didn't like about the way you have it in the >> meson file is the loss of greppability. > What would you want to grep for? Places that specify additional flags? Or just > places using flex? Well, th

Re: [RFC] building postgres with meson

Hi, On 2022-05-25 21:38:33 -0400, Tom Lane wrote: > Andres Freund writes: > > in the meson unconference session you'd spotted flex flags for > > psqlscanslash.l > > (I think) being "hardcoded". As far as I can tell that's largely just copied > > from the Makefile): > > > src/backend/parser/Make

Re: Build-farm - intermittent error in 031_column_list.pl

On Wed, May 25, 2022 at 6:54 PM Tomas Vondra wrote: > > On 5/25/22 13:26, Amit Kapila wrote: > > On Wed, May 25, 2022 at 8:16 AM Kyotaro Horiguchi > > wrote: > >> > >> It does "fix" the case of [1]. But AFAIS > >> RelationSyncEntry.replicate_valid is only used to inhibit repeated > >> loading in

Re: adding status for COPY progress report

On Wed, May 25, 2022 at 5:51 PM Michael Paquier wrote: > On Wed, May 25, 2022 at 09:34:51AM -0700, Zhihong Yu wrote: > > Let's look at the sequences of user activity for long running COPY > command. > > The user would likely issue queries to pg_stat_progress_copy over time. > > Let's say on Nth i

Re: "ERROR: latch already owned" on gharial

Thomas Munro writes: > Sorry for the ambiguity -- I have no evidence of miscompilation. My > "just BTW" paragraph was a reaction to the memory of the last couple > of times Noah and I wasted hours chasing red herrings on this system, > which is pretty demotivating when looking into an unexplained

Re: Multi-Master Logical Replication

On Wed, May 25, 2022 at 12:13:17PM +0530, Amit Kapila wrote: > > You still have not answered my question above. "Without these features, > > what workload would this help with?" You have only explained how the > > patch would fix one of the many larger problems. > > > > It helps with setting up

Re: fix stats_fetch_consistency value in postgresql.conf.sample

On Thu, May 26, 2022 at 11:10:18AM +0900, Kyotaro Horiguchi wrote: > Yeah, "boot_val" is appropreate here. And I noticed that pg_settings > has the "unit" field. I'll try using them. I wrote this in guc.sql, which seems promising, but it needs to be rewritten in check_guc.pl to access postgresql

Re: First draft of the PG 15 release notes

On Thu, May 26, 2022 at 11:17 AM Bruce Momjian wrote: > On Thu, May 26, 2022 at 10:31:14AM +0900, Amit Langote wrote: > > * I think it's better to s/...or a LIST partition/...or with a LIST > > partition > > > > * The capitalization of DEFAULT and LIST seems unnecessary. > > > > Updated the patch

Re: First draft of the PG 15 release notes

On Thu, May 26, 2022 at 10:31:14AM +0900, Amit Langote wrote: > * I think it's better to s/...or a LIST partition/...or with a LIST partition > > * The capitalization of DEFAULT and LIST seems unnecessary. > > Updated the patch on those points. I went with this text: Previously, a parti

Re: fix stats_fetch_consistency value in postgresql.conf.sample

At Thu, 26 May 2022 08:53:55 +0900, Michael Paquier wrote in > On Wed, May 25, 2022 at 04:12:07PM +0900, Kyotaro Horiguchi wrote: > > (sigh..) As the result, no need to fix in this area for now, and I > > don't think there's any generic and reliable way to detect > > inconsistencies of guc varia

Re: "ERROR: latch already owned" on gharial

On Thu, May 26, 2022 at 2:25 AM Tom Lane wrote: > Noah Misch writes: > > +1, this is at least the third non-obvious miscompilation from gharial. > > Is there any evidence that this is a compiler-sourced problem? > Maybe it is, but it's sure not obvious to me (he says, eyeing his > buildfarm anima

Re: [RFC] building postgres with meson

Andres Freund writes: > in the meson unconference session you'd spotted flex flags for psqlscanslash.l > (I think) being "hardcoded". As far as I can tell that's largely just copied > from the Makefile): > src/backend/parser/Makefile:scan.c: FLEXFLAGS = -CF -p -p > src/backend/utils/adt/Makefile:

Re: Handle infinite recursion in logical replication setup

Here are my review comments for patch v15-0001. == 1. Commit message Should this also say new test cases were added for the test_decoding plugin? ~~~ 2. contrib/test_decoding/sql/replorigin.sql @@ -119,3 +119,18 @@ SELECT data FROM pg_logical_slot_get_changes('regression_slot_no_lsn', NUL

Re: First draft of the PG 15 release notes

On Wed, May 25, 2022 at 1:04 PM Amit Langote wrote: > On Wed, May 25, 2022 at 12:44 PM David Rowley wrote: > > On Wed, 25 May 2022 at 15:01, Amit Langote wrote: > > > +Previously, a partitioned table with DEFAULT partition or a LIST > > > partition containing multiple values could not be used fo

Re: Authorizing select count()

Michael Paquier writes: > On Wed, May 25, 2022 at 12:26:47PM +0200, Laetitia Avrot wrote: >> You will find enclosed a patch proposal to allow count to be used without a >> star. I, on purpose, decided not to document this behavior, maybe that's >> wrong. > This originates from 108fe47, most likel

Re: [RFC] Improving multi-column filter cardinality estimation using MCVs and HyperLogLog

On Wed, May 25, 2022 at 11:55:40AM +0200, Tomas Vondra wrote: > It's the same as combining multiple HLL filters. HLL is essentially just > an array of counters, and to calculate a union (i.e. HLL for elements in > at least one of the input HLL sketches), you can just do Max() of the > counters. For

Re: Remove support for Visual Studio 2013

On Wed, May 18, 2022 at 10:06:50AM +0200, Juan José Santamaría Flecha wrote: > On Wed, May 18, 2022 at 2:27 AM Michael Paquier wrote: >> At the end, this would >> mean dropping support for Windows XP and Windows Server 2003 as >> run-time environments as listed in [1], which are not supported >> o

Re: Invalid memory alloc request size for repeat()

On Wed, 25 May 2022 at 22:50, Tom Lane wrote: > Japin Li writes: >> Today, I try to use repeat() to generate 1GB text, and it occurs invalid >> memory >> alloc request size [1]. It is a limit from palloc(), then I try to reduce >> it, >> it still complains out of memory which comes from enla

Re: Invalid memory alloc request size for repeat()

On Wed, 25 May 2022 at 22:41, David G. Johnston wrote: > On Wednesday, May 25, 2022, Japin Li wrote: > >> >> Hi, >> >> Today, I try to use repeat() to generate 1GB text, and it occurs invalid >> memory >> alloc request size [1]. It is a limit from palloc(), then I try to reduce >> it, >> it s

Re: adding status for COPY progress report

On Wed, May 25, 2022 at 09:34:51AM -0700, Zhihong Yu wrote: > Let's look at the sequences of user activity for long running COPY command. > The user would likely issue queries to pg_stat_progress_copy over time. > Let's say on Nth invocation, the user sees X tuples copied. > On (N+1)st invocation,

Re: [RFC] building postgres with meson

Hi Tom, in the meson unconference session you'd spotted flex flags for psqlscanslash.l (I think) being "hardcoded". As far as I can tell that's largely just copied from the Makefile): src/backend/parser/Makefile:scan.c: FLEXFLAGS = -CF -p -p src/backend/utils/adt/Makefile:jsonpath_scan.c: FLEXFLA

Re: Authorizing select count()

On Wed, May 25, 2022 at 12:26:47PM +0200, Laetitia Avrot wrote: > You will find enclosed a patch proposal to allow count to be used without a > star. I, on purpose, decided not to document this behavior, maybe that's > wrong. This originates from 108fe47, most likely as part of this thread. The p

Re: fix stats_fetch_consistency value in postgresql.conf.sample

On Wed, May 25, 2022 at 04:12:07PM +0900, Kyotaro Horiguchi wrote: > (sigh..) As the result, no need to fix in this area for now, and I > don't think there's any generic and reliable way to detect > inconsistencies of guc variable definitions. Hmm. Making the automation test painless in terms of

Re: logical decoding and replication of sequences

> But of course, if we expect/require to have a perfect snapshot for that > exact position in the transaction, this won't work. IMO the whole idea > that we can have non-transactional bits in naturally transactional > decoding seems a bit suspicious (at least in hindsight). > > No matter what we do

Re: allow building trusted languages without the untrusted versions

Stephen Frost writes: > I agree that this seems to need more discussion and explanation as it > isn't actually sufficient by itself for "anyone who wants to disallow > file system access" as the initial post claimed. If there isn't > sufficient explanation coming forward to support this change by

Re: allow building trusted languages without the untrusted versions

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > The very specific "it'd be nice to build PG w/o having untrusted > > languages compiled in" is at least reasonably clearly contained and > > reasonable to see if we are, in fact, doing what we claim we're doing > > with

Re: allow building trusted languages without the untrusted versions

Stephen Frost writes: > The very specific "it'd be nice to build PG w/o having untrusted > languages compiled in" is at least reasonably clearly contained and > reasonable to see if we are, in fact, doing what we claim we're doing > with such a switch. I agree that it's specific and easily measur

Re: allow building trusted languages without the untrusted versions

On Wed, May 25, 2022 at 4:07 PM Stephen Frost wrote: > The very specific "it'd be nice to build PG w/o having untrusted > languages compiled in" is at least reasonably clearly contained and > reasonable to see if we are, in fact, doing what we claim we're doing > with such a switch. A switch that

Re: allow building trusted languages without the untrusted versions

On Wed, May 25, 2022 at 2:28 PM Tom Lane wrote: > I'm a little skeptical that our present design direction really moves > the needle very far in this area. We've sliced and diced superuser > aplenty, but that doesn't make individual capabilities such as > pg_write_all_data or ALTER SYSTEM any les

Re: allow building trusted languages without the untrusted versions

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > I really don't think this is going to be anywhere near as > > straight-forward as it might appear to be to prevent a superuser from > > being able to break out of PG. > > This gets back to the point I made before about

Re: allow building trusted languages without the untrusted versions

Stephen Frost writes: > I really don't think this is going to be anywhere near as > straight-forward as it might appear to be to prevent a superuser from > being able to break out of PG. This gets back to the point I made before about it not being worthwhile to implement half-measures. There is

Re: allow building trusted languages without the untrusted versions

Greetings, * Nathan Bossart (nathandboss...@gmail.com) wrote: > I guess I'd ask again whether we can do both... We've got predefined roles > like pg_execute_server_program that allow access to COPY TO/FROM PROGRAM, > but I have no way to categorically disable that ѕort of thing if I wanted > to r

Re: adding status for COPY progress report

On Wed, May 25, 2022 at 8:20 AM Matthias van de Meent < boekewurm+postg...@gmail.com> wrote: > On Wed, 25 May 2022 at 16:32, Zhihong Yu wrote: > > > > On Wed, May 25, 2022 at 3:55 AM Matthias van de Meent < > boekewurm+postg...@gmail.com> wrote: > >> > >> On Wed, 25 May 2022 at 10:15, Zhihong Yu

Re: adding status for COPY progress report

On Wed, 25 May 2022 at 16:32, Zhihong Yu wrote: > > On Wed, May 25, 2022 at 3:55 AM Matthias van de Meent > wrote: >> >> On Wed, 25 May 2022 at 10:15, Zhihong Yu wrote: >> > >> > Hi, >> > Patch v3 follows advice from Matthias (status field has been dropped). >> >> Could you argue why you think

Re: Invalid memory alloc request size for repeat()

Japin Li writes: > Today, I try to use repeat() to generate 1GB text, and it occurs invalid > memory > alloc request size [1]. It is a limit from palloc(), then I try to reduce it, > it still complains out of memory which comes from enlargeStringInfo() [2]. > The > documentation about repect()

Re: Invalid memory alloc request size for repeat()

On Wednesday, May 25, 2022, Japin Li wrote: > > Hi, > > Today, I try to use repeat() to generate 1GB text, and it occurs invalid > memory > alloc request size [1]. It is a limit from palloc(), then I try to reduce > it, > it still complains out of memory which comes from enlargeStringInfo() > [2

Invalid memory alloc request size for repeat()

Hi, Today, I try to use repeat() to generate 1GB text, and it occurs invalid memory alloc request size [1]. It is a limit from palloc(), then I try to reduce it, it still complains out of memory which comes from enlargeStringInfo() [2]. The documentation about repect() [3] doesn't mentaion the

Re: adding status for COPY progress report

On Wed, May 25, 2022 at 3:55 AM Matthias van de Meent < boekewurm+postg...@gmail.com> wrote: > On Wed, 25 May 2022 at 10:15, Zhihong Yu wrote: > > > > Hi, > > Patch v3 follows advice from Matthias (status field has been dropped). > > Could you argue why you think that this should be added to the

Re: Build-farm - intermittent error in 031_column_list.pl

Tomas Vondra writes: > The other aspect I dislike is that we just stop caching publication > info, forcing us to reload it for every replicated change/row. Ouch --- that seems likely to be completely horrid. At the very least I'd want to see some benchmark numbers before concluding we could live

Re: "ERROR: latch already owned" on gharial

Noah Misch writes: > +1, this is at least the third non-obvious miscompilation from gharial. Is there any evidence that this is a compiler-sourced problem? Maybe it is, but it's sure not obvious to me (he says, eyeing his buildfarm animals with even older gcc versions). r

Re: Build-farm - intermittent error in 031_column_list.pl

On 5/25/22 13:26, Amit Kapila wrote: > On Wed, May 25, 2022 at 8:16 AM Kyotaro Horiguchi > wrote: >> >> It does "fix" the case of [1]. But AFAIS >> RelationSyncEntry.replicate_valid is only used to inhibit repeated >> loading in get_rel_sync_entry and the function doesn't seem to be >> assumed to

Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT

On Sat, May 21, 2022 at 9:09 AM Justin Pryzby wrote: > It looks like the docs weren't updated in 6f6b99d13 for v11. In my defense, that commit definitely contained documentation changes. It updated alter_table.sgml and create_table.sgml. I guess we missed create_foreign_table.sgml, though. > The

Re: PG15 beta1 sort performance regression due to Generation context change

On Wed, 25 May 2022 at 15:09, David Rowley wrote: > I didn't test the performance of an aset.c context. I imagine it's > likely to be less overhead due to aset.c being generally slower from > having to jump through a few more hoops during palloc/pfree. I've attached the results from doing the sam

Re: HOLD_INTERRUPTS() vs ProcSignalBarrier

On Tue, May 24, 2022 at 11:47 PM Thomas Munro wrote: > The concrete example I have in mind is the one created by me in > 637668fb. That can reach a walkdir() that unlinks a ton of temporary > files, and has a CFI() in it. Hmm, I missed that commit, and I have to say I'm a bit doubtful about it.

Re: Handle infinite recursion in logical replication setup

On Tue, May 24, 2022 at 8:06 AM shiy.f...@fujitsu.com wrote: > > On Tue, May 24, 2022 1:34 AM vignesh C wrote: > > > > Thanks for the comments, the attached v15 patch has the fixes for the same. > > > > Thanks for updating the patch. I have a comment on the document in 0002 patch. > > @@ -300,6 +

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em qua., 25 de mai. de 2022 às 07:13, Tomas Vondra < tomas.von...@enterprisedb.com> escreveu: > > > On 5/25/22 11:07, Ranier Vilela wrote: > > Em qua., 25 de mai. de 2022 às 00:46, Andres Freund > > escreveu: > > > > Hi Andres, thank you for taking a look. > > > > > >

Re: Build-farm - intermittent error in 031_column_list.pl

On Wed, May 25, 2022 at 8:16 AM Kyotaro Horiguchi wrote: > > It does "fix" the case of [1]. But AFAIS > RelationSyncEntry.replicate_valid is only used to inhibit repeated > loading in get_rel_sync_entry and the function doesn't seem to be > assumed to return a invalid entry. (Since the flag is no

Re: adding status for COPY progress report

On Wed, 25 May 2022 at 10:15, Zhihong Yu wrote: > > Hi, > Patch v3 follows advice from Matthias (status field has been dropped). Could you argue why you think that this should be added to the pg_stat_progress_copy view? Again, the progress reporting subsystem is built to "report the progress of c

Authorizing select count()

Hello, Vik Fearing pointed out the inconsistency in the SQL Standard that imposes using count(*) (with a star) but row)number() without it. Vik's point of view is that we should be able to use row_number with a star, which is already implemented in Postgres. My point of view is we could add supp

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

On 5/25/22 11:07, Ranier Vilela wrote: > Em qua., 25 de mai. de 2022 às 00:46, Andres Freund > escreveu: > > Hi Andres, thank you for taking a look. > > > On 2022-05-24 12:28:20 -0300, Ranier Vilela wrote: > > Linux Ubuntu 64 bits (gcc 9.4) > > ./pgbenc

Re: [RFC] Improving multi-column filter cardinality estimation using MCVs and HyperLogLog

On 5/25/22 00:16, Bruce Momjian wrote: > On Mon, May 16, 2022 at 12:09:41AM +0200, Tomas Vondra wrote: >> I think it's an interesting idea. In principle it allows deducing the >> multi-column MCV for arbitrary combination of columns, not determined in >> advance. We'd have the MCV with HLL inste

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em qua., 25 de mai. de 2022 às 00:56, Andres Freund escreveu: > Hi, > > On 2022-05-24 13:23:43 -0300, Ranier Vilela wrote: > > It certainly helps, but I trust that's not the only reason, in all the > > tests I did, there was an improvement in performance, even before using > > this feature. > > I

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em qua., 25 de mai. de 2022 às 00:46, Andres Freund escreveu: Hi Andres, thank you for taking a look. > > On 2022-05-24 12:28:20 -0300, Ranier Vilela wrote: > > Linux Ubuntu 64 bits (gcc 9.4) > > ./pgbench -M prepared -c $conns -j $conns -S -n -U postgres > > > > conns tps head

Re: adding status for COPY progress report

On Tue, May 24, 2022 at 3:02 PM Zhihong Yu wrote: > > > On Tue, May 24, 2022 at 2:12 PM Matthias van de Meent < > boekewurm+postg...@gmail.com> wrote: > >> On Tue, 24 May 2022 at 22:12, Zhihong Yu wrote: >> > >> > On Tue, May 24, 2022 at 12:37 PM Matthias van de Meent < >> boekewurm+postg...@gma

Re: Multi-Master Logical Replication

On Wed, May 25, 2022 at 4:43 PM Amit Kapila wrote: > > On Tue, May 24, 2022 at 5:57 PM Bruce Momjian wrote: > > > > On Sat, May 14, 2022 at 12:20:05PM +0530, Amit Kapila wrote: > > > On Sat, May 14, 2022 at 12:33 AM Bruce Momjian wrote: > > > > > > > > Uh, without these features, what workload w

Re: pg_upgrade test writes to source directory

On Wed, May 25, 2022 at 08:21:26AM +0200, Peter Eisentraut wrote: > The 002_pg_upgrade.pl test leaves a file delete_old_cluster.sh in the source > directory. In vpath builds, there shouldn't be any files written to the > source directory. > > Note that the TAP tests run with the source directory a

Re: Assert name/short_desc to prevent SHOW ALL segfault

Thank you for the reviews Nathan, Michael. I agree with handling NULL in ShowAllGUCConfig() instead. I've attached the updated patch. -- Steve Chavez Engineering at https://supabase.com/ On Tue, 24 May 2022 at 20:21, Michael Paquier wrote: > On Tue, May 24, 2022 at 11:41:49AM -0700, Nathan Bo

Re: fix stats_fetch_consistency value in postgresql.conf.sample

At Wed, 25 May 2022 15:56:23 +0900 (JST), Kyotaro Horiguchi wrote in > The following results are not deeply confirmed yet. > > 13 apparent inconsistencies are found. These should be fixed. > > archive_command = "(disabled)" != "" The "(disabled)" is the representation of "". > bgwriter_flush