On Thu, May 26, 2022 at 3:08 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Thu, May 26, 2022 at 7:06 AM Peter Smith <smithpb2...@gmail.com> wrote: > > > > > > 3. doc/src/sgml/catalogs.sgml > > > > + <para> > > + If true, the subscription will request that the publisher send > > locally > > + originated changes. False indicates that the publisher sends any > > changes > > + regardless of their origin. > > + </para></entry> > > > > SUGGESTION > > If true, the subscription will request the publisher to only send > > changes that originated locally. > > > > ~~~ > > > > I think it is a good idea to keep the description related to the > 'False' value as without that it is slightly unclear. > > > 4. doc/src/sgml/ref/create_subscription.sgml > > > > + <para> > > + Specifies whether the subscription will request the publisher to > > send > > + locally originated changes at the publisher node, or send any > > + publisher node changes regardless of their origin. The default is > > + <literal>false</literal>. > > + </para> > > > > This wording should be more similar to the same information in catalogs.sgml > > > > SUGGESTION > > Specifies whether the subscription will request the publisher to only > > send changes that originated locally, or to send any changes > > regardless of origin. > > > > ~~~ > > > > Here, also, let's keep the wording related to the default value. > > --
I agree. Probably I was not being clear enough with those review comments. My suggestions were only meant as substitutes for the FIRST sentences of those patch fragments, not the entire paragraph. ------ Kind Regards, Peter Smith. Fujitsu Australia
