At Thu, 28 Oct 2021 09:54:42 +0530, Amul Sul wrote in
> On Thu, Oct 28, 2021 at 9:07 AM Bossart, Nathan wrote:
> >
> > Hi hackers,
> >
> > I've seen a few cases now for v13 where the startup process on a
> > standby appears to be stuck on StandbyReleaseLockList(). It looks
> > like most of the
Hi,
Rebased, and added the patches below into the patchset.
- (0006) Let wal_pmem_map be constant unless --with-libpmem
wal_pmem_map never changes from false in that case, so let it be
constant. Thanks, Matthias!
- (0007) Ensure WAL mappings before assertion
This fixes SIGSEGV abortion in GetXL
On Thu, Oct 28, 2021 at 1:29 PM Amit Kapila wrote:
>
> On Wed, Oct 27, 2021 at 4:07 PM Amit Kapila wrote:
> >
> > On Wed, Oct 27, 2021 at 8:32 AM Masahiko Sawada
> > wrote:
> > >
> > > On Tue, Oct 26, 2021 at 7:29 PM Amit Kapila
> > > wrote:
> > > >
> > > > You have a point. The other alterna
On Thu, Oct 28, 2021 at 1:05 PM Amit Kapila wrote:
>
> On Thu, Oct 28, 2021 at 7:49 AM Masahiko Sawada wrote:
> >
> > On Wed, Oct 27, 2021 at 2:43 PM Amit Kapila wrote:
> > >
> > > On Wed, Oct 27, 2021 at 10:43 AM Masahiko Sawada
> > > wrote:
> > > >
> > > > > > BTW how useful is specifying LS
On Wed, Oct 27, 2021 at 7:02 PM Amit Kapila wrote:
>
> On Thu, Oct 21, 2021 at 10:29 AM Masahiko Sawada
> wrote:
> >
> >
> > I've attached updated patches.
Thank you for the comments!
>
> Few comments:
> ==
> 1. Is the patch cleaning tablesync error entries except via vacuum? If
>
On Wed, Oct 27, 2021 at 4:07 PM Amit Kapila wrote:
>
> On Wed, Oct 27, 2021 at 8:32 AM Masahiko Sawada wrote:
> >
> > On Tue, Oct 26, 2021 at 7:29 PM Amit Kapila wrote:
> > >
> > > You have a point. The other alternatives on this line could be:
> > >
> > > Alter Subscription SKIP ( subscription
On Thu, Oct 28, 2021 at 8:12 AM Amit Kapila wrote:
>
> On Mon, Oct 25, 2021 at 3:09 PM Amit Kapila wrote:
> >
> > On Mon, Oct 25, 2021 at 1:11 PM vignesh C wrote:
> > >
> > > I have fixed this in the v47 version attached.
> > >
> >
> > Thanks, the first patch in the series "Allow publishing the
On Thu, Oct 28, 2021 at 9:07 AM Bossart, Nathan wrote:
>
> Hi hackers,
>
> I've seen a few cases now for v13 where the startup process on a
> standby appears to be stuck on StandbyReleaseLockList(). It looks
> like most of the time is spent on list_delete_first(). I believe this
> is related to
On Thu, Oct 28, 2021 at 8:14 AM Bharath Rupireddy
wrote:
>
> > LOG: level: 1; AV worker: 8192 total in 1 blocks; 7928 free (0 chunks);
> > 264 used
>
> Good catch. I've seen the use of "AV" in some of the mem context
> names, why that? Let's be specific and say "Autovacuum". Attached
> patch doe
On Thu, Oct 28, 2021 at 7:49 AM Masahiko Sawada wrote:
>
> On Wed, Oct 27, 2021 at 2:43 PM Amit Kapila wrote:
> >
> > On Wed, Oct 27, 2021 at 10:43 AM Masahiko Sawada
> > wrote:
> > >
> > > > > BTW how useful is specifying LSN instead of XID in practice? Given
> > > > > that this skipping behav
On Thu, Oct 28, 2021 at 7:24 AM Michael Paquier wrote:
>
> On Wed, Oct 27, 2021 at 02:20:50PM +0900, Michael Paquier wrote:
> > ok(!-f $recovery_end_command_file,
> > - 'recovery_end_command executed after promotion');
> > + 'recovery_end_command not executed yet');
> > Indeed :p
>
> While lo
On Wed, Oct 27, 2021 at 4:39 PM Dilip Kumar wrote:
>
> On Tue, Oct 26, 2021 at 9:19 AM Amit Kapila wrote:
> >
> > >
> > > Thanks, both your patches look good to me except that we need to
> > > remove the sentence related to the revert of ade24dab97 from the
> > > commit message. I think we should
On Thu, Oct 28, 2021 at 7:11 AM Kyotaro Horiguchi
wrote:
>
> At Wed, 27 Oct 2021 14:26:11 -0500, Justin Pryzby
> wrote in
> > On Wed, Oct 27, 2021 at 07:05:10PM +, Bossart, Nathan wrote:
> > > My vote is to just change it to
> > >
> > > ereport(WARNING,
> > > (errmsg(
On Mon, Oct 25, 2021 at 3:09 PM Amit Kapila wrote:
>
> On Mon, Oct 25, 2021 at 1:11 PM vignesh C wrote:
> >
> > I have fixed this in the v47 version attached.
> >
>
> Thanks, the first patch in the series "Allow publishing the tables of
> schema." looks good to me. Unless there are more
> comment
On 2021-10-28 07:21, Mark Dilger wrote:
On Oct 25, 2021, at 10:09 PM, Shinya Kato
wrote:
Hi! Thank you for the patch.
I too think that CREATEROLE escalation attack is problem.
I have three comments.
1. Is there a function to check the owner of a role, it would be nice
to be able to check wi
On Wed, Oct 27, 2021 at 2:43 PM Amit Kapila wrote:
>
> On Wed, Oct 27, 2021 at 10:43 AM Masahiko Sawada
> wrote:
> >
> > On Wed, Oct 27, 2021 at 12:35 PM Amit Kapila
> > wrote:
> > >
> > > On Wed, Oct 27, 2021 at 8:32 AM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Tue, Oct 26, 2021 at 7:
On Tue, Oct 26, 2021 at 02:43:26PM +0900, Michael Paquier wrote:
> Indeed. There was also a problem in the regex itself, where '|' was
> not escaped so the regex was not strict enough. While on it, I have
> added a policy in the set copied to the new database. Testing the
> case where the set of
On Wed, Oct 27, 2021 at 02:20:50PM +0900, Michael Paquier wrote:
> ok(!-f $recovery_end_command_file,
> - 'recovery_end_command executed after promotion');
> + 'recovery_end_command not executed yet');
> Indeed :p
While looking at that this morning, I have noticed an extra bug. If
the path o
At Wed, 27 Oct 2021 14:26:11 -0500, Justin Pryzby wrote
in
> On Wed, Oct 27, 2021 at 07:05:10PM +, Bossart, Nathan wrote:
> > My vote is to just change it to
> >
> > ereport(WARNING,
> > (errmsg("autovacuum worker took too long to start;
> > canceled")));
> >
> > a
On 10/27/21 18:18, Arjan van de Ven wrote:
> +/*
> + * Special case each of the possible base values (8, 10, 16) to
> avoid an
> + * expensive divide operation
> + * (the compiler will use a multiply, shift or boolean ops for this)
> + */
Was 'boolean' the
On 10/26/2021 6:39 PM, Tom Lane wrote:
Japin Li writes:
Why do we need likely() for base=10, however, base=16 and base=8 don't need?
Yeah, I was a little unconvinced about that too. I concur with writing
it as an if/else chain instead of a switch, but I'm not sure that likely()
adds anything
On 10/27/21, 2:19 PM, "Robert Haas" wrote:
> I am not sure I understand what the advantage of this is supposed to be.
There are a couple of other related threads with some additional
context:
https://www.postgresql.org/message-id/flat/20211026224731.115337-1-joshua.brindle%40crunchydata
On Wed, Oct 27, 2021 at 5:20 PM Joshua Brindle
wrote:
>
> On Wed, Oct 27, 2021 at 5:16 PM Robert Haas wrote:
> >
> > On Wed, Oct 27, 2021 at 5:14 PM Joshua Brindle
> > wrote:
> > > Attached is an updated version of the patch to replace
> > > is_member_of_role with has_privs_for_role for predefin
On Wed, Oct 27, 2021 at 5:16 PM Robert Haas wrote:
>
> On Wed, Oct 27, 2021 at 5:14 PM Joshua Brindle
> wrote:
> > Attached is an updated version of the patch to replace
> > is_member_of_role with has_privs_for_role for predefined roles. It
> > does not remove is_member_of_role from acl.h but it
On Wed, Oct 27, 2021 at 5:14 PM Joshua Brindle
wrote:
> Attached is an updated version of the patch to replace
> is_member_of_role with has_privs_for_role for predefined roles. It
> does not remove is_member_of_role from acl.h but it does add a warning
> not to use that function for privilege chec
Attached is an updated version of the patch to replace
is_member_of_role with has_privs_for_role for predefined roles. It
does not remove is_member_of_role from acl.h but it does add a warning
not to use that function for privilege checking.
Please consider this for the upcoming commitfest.
0001
> On 27 Oct 2021, at 22:34, Peter Smith wrote:
>
> PSA a smalll patch to fix some typos (acccidental 3x repeated
> lettters) in code commments.
Applied, thanks.
--
Daniel Gustafsson https://vmware.com/
PSA a smalll patch to fix some typos (acccidental 3x repeated
lettters) in code commments.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
v1-0001-Fix-PG-comment-typos.patch
Description: Binary data
On Mon, Oct 25, 2021 at 3:25 PM Robert Haas wrote:
> But also, Noah writes: "Also, it's currently a best practice for only
> non-LOGIN roles to have members. The proposed approach invites folks
> to abandon that best practice."
>
> The kind of mechanism you're proposing here doesn't seem to make
Postgres weekly came today with this interesting article:
https://hakibenita.com/sql-medium-text-performance
The problem it explains is when you have no one records being stored on
toast, even if they are toastable. That is because the size of that column
fits on toast_tuple_target size, so it doe
On Wed, Oct 27, 2021 at 07:05:10PM +, Bossart, Nathan wrote:
> On 10/27/21, 9:29 AM, "Bharath Rupireddy"
> wrote:
> > Is there a specific reason that we have a generic WARNING "worker took
> > too long to start; canceled" for an autovacuum worker? Isn't it better
> > with "autovacuum worker t
On 10/27/21, 9:29 AM, "Bharath Rupireddy"
wrote:
> Is there a specific reason that we have a generic WARNING "worker took
> too long to start; canceled" for an autovacuum worker? Isn't it better
> with "autovacuum worker took too long to start; canceled"? It is
> confusing to see the generic mess
"Bossart, Nathan" writes:
> On 10/27/21, 10:22 AM, "Joshua Brindle"
> wrote:
>> On Wed, Oct 27, 2021 at 1:12 PM Mark Dilger
>> wrote:
>>> I don't understand the purpose of this. You are defining
>>> can_set_role(member,role) as a simple wrapper around
>>> is_member_of_role(member,role). Cou
On Wed, Oct 27, 2021 at 1:34 PM Bossart, Nathan wrote:
>
> On 10/27/21, 10:28 AM, "Joshua Brindle"
> wrote:
> > I'm new to contributing here but I've been told that the string
> > changes get taken care of later, is that not true?
>
> I will sometimes leave out tests and docs until I get buy-in
On Wed, 2021-10-27 at 12:53 -0400, Jonathan S. Katz wrote:
> The patch I propose just layers on top of the existing functionality --
> you could even argue that it's "fixing a bug" that we did not add the
> current "map" support for the case of "clientcert=verify-full" given we
> do introspect
On 10/27/21, 10:28 AM, "Joshua Brindle" wrote:
> I'm new to contributing here but I've been told that the string
> changes get taken care of later, is that not true?
I will sometimes leave out tests and docs until I get buy-in on the
approach. But for serious consideration, I think the patch has
On 10/27/21, 10:22 AM, "Joshua Brindle" wrote:
> On Wed, Oct 27, 2021 at 1:12 PM Mark Dilger
> wrote:
>> I don't understand the purpose of this. You are defining
>> can_set_role(member,role) as a simple wrapper around
>> is_member_of_role(member,role). Couldn't the comment:
>>
>> + *
>> + * D
On Wed, Oct 27, 2021 at 1:20 PM Bossart, Nathan wrote:
>
> On 10/26/21, 3:50 PM, "Joshua Brindle" wrote:
> > Generally if a role is granted membership to another role with NOINHERIT
> > they must use SET ROLE to access the privileges of that role, however
> > with predefined roles the membership
On 10/26/21, 3:50 PM, "Joshua Brindle" wrote:
> Generally if a role is granted membership to another role with NOINHERIT
> they must use SET ROLE to access the privileges of that role, however
> with predefined roles the membership and privilege is conflated, as
> demonstrated by:
I think it make
On Wed, Oct 27, 2021 at 1:12 PM Mark Dilger
wrote:
>
>
>
> > On Oct 27, 2021, at 9:26 AM, Joshua Brindle
> > wrote:
> >
> > As a follow-on to Conflation of member/privs for predefined roles,
> > this removes is_member_of_role from the header to dissuade it's use
> > for privilege checking. Since
> On Oct 27, 2021, at 9:26 AM, Joshua Brindle
> wrote:
>
> As a follow-on to Conflation of member/privs for predefined roles,
> this removes is_member_of_role from the header to dissuade it's use
> for privilege checking. Since SET ROLE must use membership rather than
> privileges a new, expl
On 10/27/21 12:14 PM, Jacob Champion wrote:
On Tue, 2021-10-26 at 18:16 -0400, Tom Lane wrote:
Per "21.2. User Name Maps", I think that the map parameter is supposed
to translate from the startup packet's user name to the SQL role name.
I may have misunderstood what you wrote, but IIUC the sta
On Wed, 2021-10-27 at 10:12 -0400, Andrew Dunstan wrote:
> Possibly slightly off topic, but
>
> The cert+map pattern is very useful in conjunction with pgbouncer. Using
> it with an auth query to get the password pgbouncer doesn't even need to
> have a list of users, and we in effect delegate auth
As a follow-on to Conflation of member/privs for predefined roles,
this removes is_member_of_role from the header to dissuade it's use
for privilege checking. Since SET ROLE must use membership rather than
privileges a new, explicitly named can_set_role() function is
exported.
is_member_of_role_no
Hi,
Is there a specific reason that we have a generic WARNING "worker took
too long to start; canceled" for an autovacuum worker? Isn't it better
with "autovacuum worker took too long to start; canceled"? It is
confusing to see the generic message in the server logs while
debugging an issue for a
On Tue, 2021-10-26 at 18:16 -0400, Tom Lane wrote:
> Per "21.2. User Name Maps", I think that the map parameter is supposed
> to translate from the startup packet's user name to the SQL role name.
I may have misunderstood what you wrote, but IIUC the startup packet's
user name _is_ the SQL role na
On Wed, Oct 27, 2021 at 1:02 AM Pavel Borisov wrote:
> AFAIK Gin is lossy for phrase queries as we don't store word position in the
> posting list. For purely logical queries, where position doesn't matter, it's
> not lossy.
GIN is always lossy, in the sense that it provides only a
gingetbitmap
Op 27-10-2021 om 16:33 schreef Gilles Darold:
- Fix documentation about some sgml tag broken.
About ROWTYPE generating an error when SELECT * INTO or RETURNING * INTO
is used with unexpanded column, I have kept things like that because it
is the normal behavior. I have checked on others databa
I've been investigating the poor performance of a WITH RECURSIVE
query, which I've recreated with test data.
The first thing was to re-write the query, which helped improve
performance by about 30%, but the plan was still very bad. With a
small patch I've been able to improve performance by about
On Wed, Sep 29, 2021 at 5:10 AM Michael Paquier wrote:
> On Tue, Sep 28, 2021 at 04:15:22PM +0200, Magnus Hagander wrote:
> > Is there a reason the "only" is missing from the -s option? AFAIK that's
> > what it means, so the attached patch should be correct?
>
> I cannot think of a reason. This
On 10/26/21 18:16, Tom Lane wrote:
> "Jonathan S. Katz" writes:
>> On 10/26/21 3:26 PM, Tom Lane wrote:
>>> I think this is conflating two different things: a mapping from the
>>> username given in the startup packet, and a mapping from the TLS
>>> certificate CN. Using the same keyword and ter
Hi hackers,
> I'm going to mark it as "Ready for Committer" unless anyone objects.
I updated the status of the patch.
To clarify, Alexander and I replied almost at the same time. The
drawbacks noted by Alexander are fixed in the v2 version of the patch.
--
Best regards,
Aleksander Alekseev
Hi there !
What's about GSoC 2022 ?
Best regards,
Oleg
On Tue, Apr 20, 2021 at 4:38 AM Andreas 'ads' Scherbaum wrote:
>
> Hello,
>
> On Sat, Apr 17, 2021 at 8:42 PM Nhi Dang wrote:
>
>>
>>
> Thank you for this document.
>
> It looks like there are a couple problems with this - at least if thi
On Wed, Oct 27, 2021 at 4:55 PM Matthias van de Meent
wrote:
>
> On Wed, 27 Oct 2021 at 12:58, Amit Kapila wrote:
> >
> > On Wed, Oct 27, 2021 at 2:32 AM Robert Haas wrote:
> > >
> > > On Tue, Oct 5, 2021 at 6:50 AM Simon Riggs
> > > wrote:
> > > > With unique data, starting at 1 and monotonic
On Wed, 27 Oct 2021 at 12:58, Amit Kapila wrote:
>
> On Wed, Oct 27, 2021 at 2:32 AM Robert Haas wrote:
> >
> > On Tue, Oct 5, 2021 at 6:50 AM Simon Riggs
> > wrote:
> > > With unique data, starting at 1 and monotonically ascending, hash
> > > indexes will grow very nicely from 0 to 10E7 rows w
On Tue, Oct 26, 2021 at 9:19 AM Amit Kapila wrote:
>
> On Mon, Oct 25, 2021 at 4:21 PM Amit Kapila wrote:
> >
> > On Thu, Oct 21, 2021 at 11:20 AM Dilip Kumar wrote:
> > >
> > > On Thu, Oct 21, 2021 at 9:11 AM Amit Kapila
> > > wrote:
> > > >
> > >
> > > v5-0001, incorporates all the comment f
On Wed, Oct 27, 2021 at 2:32 AM Robert Haas wrote:
>
> On Tue, Oct 5, 2021 at 6:50 AM Simon Riggs
> wrote:
> > With unique data, starting at 1 and monotonically ascending, hash
> > indexes will grow very nicely from 0 to 10E7 rows without causing >1
> > overflow block to be allocated for any buc
On Wed, Oct 27, 2021 at 8:32 AM Masahiko Sawada wrote:
>
> On Tue, Oct 26, 2021 at 7:29 PM Amit Kapila wrote:
> >
> > On Tue, Oct 26, 2021 at 2:27 PM Greg Nancarrow wrote:
> > >
> > > On Tue, Oct 26, 2021 at 5:16 PM Amit Kapila
> > > wrote:
> > > >
> > > > I agree that we will need a separate
On Thu, Oct 21, 2021 at 10:29 AM Masahiko Sawada wrote:
>
>
> I've attached updated patches.
>
Few comments:
==
1. Is the patch cleaning tablesync error entries except via vacuum? If
not, can't we send a message to remove tablesync errors once tablesync
is successful (say when we rese
Hi
út 5. 10. 2021 v 14:30 odesílatel Daniel Gustafsson
napsal:
> > On 1 Oct 2021, at 15:19, Daniel Gustafsson wrote:
>
> > I'm still not happy with the docs, I need to take another look there and
> see if
> > I make them more readable but otherwise I don't think there are any open
> issues
> >
On Tue, Oct 26, 2021 at 3:24 PM Peter Smith wrote:
>
> PSA new set of patches:
>
> v34-0001 = the "main" patch from Euler. No change
>
> v34-0002 = tab auto-complete. No change
>
> v34-0003 = cache updates. Addresses Tomas review comment #3 [1].
>
> v34-0004 = filter validation replica identity. A
Le mercredi 27 octobre 2021, 10:00:40 CEST Ronan Dunklau a écrit :
> Le mercredi 27 octobre 2021, 04:17:28 CEST Kyotaro Horiguchi a écrit :
> > +my @walfiles = glob "$slot_dir/*";
> >
> > This is not used.
>
> Sorry, fixed in attached version.
>
> > Each pg_receivewal run stalls for about 10 or
>
> It's no coincidence that GIN indexes (which
> have some of the same issues) only support lossy index scans.
>
AFAIK Gin is lossy for phrase queries as we don't store word position in
the posting list. For purely logical queries, where position doesn't
matter, it's not lossy.
One more considera
Le mercredi 27 octobre 2021, 04:17:28 CEST Kyotaro Horiguchi a écrit :
> +my @walfiles = glob "$slot_dir/*";
>
> This is not used.
>
Sorry, fixed in attached version.
> Each pg_receivewal run stalls for about 10 or more seconds before
> finishing, which is not great from the standpoint of recen
On Wed, Oct 27, 2021 at 03:54:03PM +0900, Shinya Kato wrote:
> In my opinion, it is written in the documentation, so tab-completion of
> "PROCEDURAL"is good.
It does not mean that we need to add everything either, especially
here as there is a shorter option.
> How about a completion with "LANGUA
65 matches
Mail list logo
