On Wed, Oct 27, 2021 at 1:34 PM Bossart, Nathan <bossa...@amazon.com> wrote: > > On 10/27/21, 10:28 AM, "Joshua Brindle" <joshua.brin...@crunchydata.com> > wrote: > > I'm new to contributing here but I've been told that the string > > changes get taken care of later, is that not true? > > I will sometimes leave out tests and docs until I get buy-in on the > approach. But for serious consideration, I think the patch has to be > more-or-less complete. >
Thanks, I'll fix those and resubmit both patches in a single email since one depends on the other.