On Thu, Oct 28, 2021 at 7:24 AM Michael Paquier <mich...@paquier.xyz> wrote: > > On Wed, Oct 27, 2021 at 02:20:50PM +0900, Michael Paquier wrote: > > ok(!-f $recovery_end_command_file, > > - 'recovery_end_command executed after promotion'); > > + 'recovery_end_command not executed yet'); > > Indeed :p > > While looking at that this morning, I have noticed an extra bug. If > the path of the data folder included a space, the command would have > failed. I have to wonder if we should do something like > cp_history_files, but that did not seem necessary to me once we rely > on each command being executed from the root of the data folder. > > Anyway, I am curious to see what the buildfarm thinks about all that, > particularly with Msys, so I have applied the patch. I am keeping an > eye on things, though.
Thanks a lot, Michael. Regards, Amul