On Fri, Sep 24, 2021 at 4:44 PM Antonin Houska wrote:
>
> Amit Kapila wrote:
>
> > On Mon, Sep 20, 2021 at 10:24 AM Antonin Houska wrote:
> > >
> > > Amit Kapila wrote:
> > >
> > > > On Fri, Sep 17, 2021 at 9:50 PM Dmitry Dolgov <9erthali...@gmail.com>
> > > > wrote:
> > > > >
> > > > > > On T
On Mon, Sep 20, 2021 at 3:17 PM Ajin Cherian wrote:
>
> I have not changed any of the first 5 patches, just added my patch 006
> at the end. Do let me know of any comments on this approach.
>
I have a question regarding v29-0003-PS-ExprState-cache-modifications.
In pgoutput_row_filter, for row_fi
On Sat, Sep 25, 2021 at 3:07 AM Tomas Vondra
wrote:
>
> On 9/24/21 8:09 AM, Amit Kapila wrote:
> > On Thu, Sep 23, 2021 at 6:03 PM Tomas Vondra
> > wrote:
> >>
> >> 13) turning update into insert
> >>
> >> I agree with Ajin Cherian [4] that looking at just old or new row for
> >> updates is not t
On Fri, Sep 24, 2021 at 05:33:13PM -0700, Mark Dilger wrote:
> A few TAP tests in the project appear to be sensitive to reductions of the
> PostgresNode's max_wal_size setting, resulting in tests failing due to wal
> files having been removed too soon. The failures in the logs typically are
> of t
On Sat, Sep 25, 2021 at 3:30 AM Tomas Vondra
wrote:
>
> On 9/24/21 7:20 AM, Amit Kapila wrote:
> >
> > I think the right way to support functions is by the explicit marking
> > of functions and in one of the emails above Jeff Davis also agreed
> > with the same. I think we should probably introduc
On Fri, Sep 24, 2021 at 7:44 PM Peter Geoghegan wrote:
> The scheduling of autovacuum is itself a big problem for the two big
> BenchmarkSQL tables I'm always going on about -- though it did get a
> lot better with the introduction of the
> autovacuum_vacuum_insert_scale_factor stuff in Postgres 1
On Fri, Sep 24, 2021 at 11:48 AM Robert Haas wrote:
> Actually, I have. I've been focusing on trying to create a general
> infrastructure for conveyor belt storage. An incomplete and likely
> quite buggy version of this can be found here:
>
> https://git.postgresql.org/gitweb/?p=users/rhaas/postgr
From Fri, Sep 24, 2021 9:25 PM Alvaro Herrera wrote:
> On 2021-Sep-23, Amit Kapila wrote:
>
> > Alvaro, do you have any thoughts on these proposed grammar changes?
>
> Yeah, I think pubobj_name remains a problem in that you don't know its return
> type -- could be a String or a RangeVar, and the
On Thu, Sep 23, 2021 at 10:42 PM Masahiko Sawada wrote:
> On Thu, Sep 16, 2021 at 7:09 AM Peter Geoghegan wrote:
> > Enabling index-only scans is a good enough reason to pursue this
> > project, even on its own.
>
> +1
I was hoping that you might be able to work on opportunistically
freezing who
Hackers,
A few TAP tests in the project appear to be sensitive to reductions of the
PostgresNode's max_wal_size setting, resulting in tests failing due to wal
files having been removed too soon. The failures in the logs typically are of
the "requested WAL segment %s has already been removed" v
On 2021-Sep-25, Tomas Vondra wrote:
> On 9/25/21 12:24 AM, Alvaro Herrera wrote:
> > On 2021-Sep-24, Tomas Vondra wrote:
> >
> > > But that's not the column filtering patch, right? Why would this patch
> > > depend on "schema level support", but maybe the consensus is there's some
> > > common pa
On Fri, Sep 24, 2021 at 05:37:48PM -0400, Andrew Dunstan wrote:
> It probably wouldn't be a bad thing to have something somewhere
> (src/test/perl/README ?) that explains when and why we need to bump
> $Test::Builder::Level.
I have some ideas about that. So I propose to move the discussion to
a n
On 9/25/21 12:24 AM, Alvaro Herrera wrote:
On 2021-Sep-24, Tomas Vondra wrote:
But that's not the column filtering patch, right? Why would this patch
depend on "schema level support", but maybe the consensus is there's some
common part that we need to get in first?
Yes, the grammar needs to b
On 2021-Sep-24, Tomas Vondra wrote:
> But that's not the column filtering patch, right? Why would this patch
> depend on "schema level support", but maybe the consensus is there's some
> common part that we need to get in first?
Yes, the grammar needs to be common. I posted a proposed grammar in
On 9/24/21 7:20 AM, Amit Kapila wrote:
On Thu, Sep 23, 2021 at 6:03 PM Tomas Vondra
wrote:
6) parse_oper.c
I'm having some second thoughts about (not) allowing UDFs ...
Yes, I get that if the function starts failing, e.g. because querying a
dropped table or something, that breaks the repl
On Thu, Sep 23, 2021 at 5:05 PM Melanie Plageman
wrote:
>
> The attached v8 patchset is rewritten to add in an additional dimension
> -- buffer type. Now, a backend keeps track of how many buffers of a
> particular type (e.g. shared, local) it has accessed in a particular way
> (e.g. alloc, write)
A compilation of fixes for master.
The first patch should be applied to v13 - the typo was already fixed in master
but not backpatched.
>From 8496bfa328d40cce9afdc4b491243a3ab9b0b528 Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Fri, 24 Sep 2021 16:19:54 -0500
Subject: [PATCH] unused COLUMNS
On 9/23/21 5:20 PM, Peter Eisentraut wrote:
> On 23.09.21 12:34, Michael Paquier wrote:
>> On Wed, Sep 22, 2021 at 03:18:43PM +, Jacob Champion wrote:
>>> On Wed, 2021-09-22 at 10:20 +0200, Peter Eisentraut wrote:
This should be added to each level of a function call that
represents
On 9/24/21 8:09 AM, Amit Kapila wrote:
On Thu, Sep 23, 2021 at 6:03 PM Tomas Vondra
wrote:
13) turning update into insert
I agree with Ajin Cherian [4] that looking at just old or new row for
updates is not the right solution, because each option will "break" the
replica in some case. So I
On 9/24/21 7:05 AM, vignesh C wrote:
On Fri, Sep 24, 2021 at 8:40 AM Amit Kapila wrote:
On Fri, Sep 24, 2021 at 12:45 AM Tomas Vondra
wrote:
Hi,
I wanted to do a review of this patch, but I'm a bit confused about
which patch(es) to review. There's the v5 patch, and then these two
patche
On 9/24/21 7:08 PM, Robert Haas wrote:
On Fri, Sep 24, 2021 at 3:50 AM Dilip Kumar wrote:
Tomas, can you share your test script, I would like to repeat the same
test in my environment and with different batching sizes.
I think it's probably the run.sh file attached to
http://postgr.es/m/d76a7
On 9/24/21 1:43 AM, Robert Haas wrote:
On Thu, Sep 23, 2021 at 5:36 PM Tomas Vondra
wrote:
(c) This can't explain the slowdown for cases without any Gather nodes
(and it's ~17%, so unlikely due to binary layout).
Yeah, but none of the modified code would even execute in those cases,
so it's e
On 9/24/21 12:28 PM, Robert Haas wrote:
On Thu, Sep 16, 2021 at 7:26 PM Bossart, Nathan wrote:
What do you think?
I think this is committable. I also went back and looked at your
previous proposal to do files in batches, and I think that's also
committable. After some reflection, I think I ha
Robert Haas writes:
> On Fri, Sep 24, 2021 at 3:42 PM Tom Lane wrote:
>> I think the basic idea is about right, but I'm not happy with the
>> three-way delayChkpt business; that seems too cute by three-quarters.
> Nobody, but the version of the patch that I was looking at uses a
> separate bit f
On Fri, Sep 24, 2021 at 3:42 PM Tom Lane wrote:
> Robert Haas writes:
> > I like this patch.
>
> I think the basic idea is about right, but I'm not happy with the
> three-way delayChkpt business; that seems too cute by three-quarters.
> I think two independent boolean flags, one saying "I'm preve
Robert Haas writes:
> I like this patch.
I think the basic idea is about right, but I'm not happy with the
three-way delayChkpt business; that seems too cute by three-quarters.
I think two independent boolean flags, one saying "I'm preventing
checkpoint start" and one saying "I'm preventing check
Hi,
On 9/23/21 12:27 PM, Peter Eisentraut wrote:
On 30.07.21 20:26, Tomas Vondra wrote:
Here's a an updated version of this patch - rebased to current master,
and fixing some of the issues raised in Peter's review.
This patch needs an update, as various conflicts have arisen now.
As was disc
Etsuro Fujita writes:
> One thing I noticed is that collatable operators/functions sent to the
> remote might also cause an unexpected result when the default
> collations are not compatible. Consider this example (even with your
> patch):
> ...
> where ft1 is a foreign table with an integer colu
On Wed, Sep 15, 2021 at 6:08 PM Peter Geoghegan wrote:
> Have you started any work on this project? I think that it's a very good idea.
Actually, I have. I've been focusing on trying to create a general
infrastructure for conveyor belt storage. An incomplete and likely
quite buggy version of this
On Fri, Sep 24, 2021 at 2:28 PM tushar wrote:
> Please refer this scenario where publication on v14RC1 and subscription
> on HEAD (w/patch)
>
> --create a subscription with parameter two_phase=1 on HEAD
>
> postgres=# CREATE SUBSCRIPTION r1015 CONNECTION 'dbname=postgres
> host=localhost port=545
On 9/24/21 11:57 PM, tushar wrote:
postgres=# select two_phase from pg_replication_slots where
slot_name='r105';
Correction -Please read 'r105' to 'r1015'
--
regards,tushar
EnterpriseDB https://www.enterprisedb.com/
The Enterprise PostgreSQL Company
On 9/24/21 10:36 PM, Robert Haas wrote:
Here's v9, fixing the issue reported by Fujii Masao.
Please refer this scenario where publication on v14RC1 and subscription
on HEAD (w/patch)
--create a subscription with parameter two_phase=1 on HEAD
postgres=# CREATE SUBSCRIPTION r1015 CONNECTION
Robert Haas writes:
> The commit message for 0001 is not clear enough for me to understand
> what problem it's supposed to be fixing. The code comments aren't
> really either. They make it sound like there's some problem with
> copying symlinks but mostly they just talk about callbacks, which
> do
On 9/24/21 10:36 PM, Robert Haas wrote:
I am not able to reproduce this failure. I suspect you made a mistake
in testing, because my test case before sending the patch was
basically the same as yours, except that I was testing with v13. But I
tried again with v12 and it seems fine:
Right, on a
Hi Alvaro,
I just started reading this thread, but maybe you can confirm or
refute my understanding of what was done.
In the first email you write
> As mentioned in the course of thread [1], we're missing a fix for
streaming replication to avoid sending records that the primary hasn't
fully flus
On Fri, Sep 24, 2021 at 1:19 AM Dilip Kumar wrote:
> I am looking at the "query-results.ods" file shared by Tomas, with a
> million tuple I do not really see where the patch hurts? because I am
> seeing in most of the cases the time taken by the patch is 60-80%
> compared to the head. And the wor
On Fri, Sep 24, 2021 at 3:50 AM Dilip Kumar wrote:
> Tomas, can you share your test script, I would like to repeat the same
> test in my environment and with different batching sizes.
I think it's probably the run.sh file attached to
http://postgr.es/m/d76a759d-9240-94f5-399e-ae244e5f0...@enterpr
On Fri, Sep 24, 2021 at 7:28 AM tushar wrote:
> On 9/23/21 8:35 PM, Robert Haas wrote:
> > Thanks. Looks like that version had some stupid mistakes. Here's a new one.
>
> Thanks, the reported issue seems to be fixed now for HEAD w/patch
> (publication) to HEAD w/patch (subscription) but still gett
[ a couple of random thoughts after quickly scanning this thread ... ]
David Christensen writes:
> I assume this would look something like:
> ALTER TABLE foo ALTER CONSTRAINT my_fkey ON UPDATE CASCADE ON DELETE RESTRICT
> with omitted referential_action implying preserving the existing one.
I se
On Fri, Sep 24, 2021 at 12:01 AM Fujii Masao
wrote:
> You seem to accidentally remove the index term for BASE_BACKUP.
Good catch.
> +ident_or_keyword:
> + IDENT
> { $$ = $1; }
>
> ident_or_keyword seems to be used only for
Hi,
I'm trying to set up a postgres server with version 11 in targeted
recovery mode (for the first time after my journey started with
postgres) and I came across the explanation at [1] in PG 12 and newer
versions that we have a clear differentiation as to what is the
"standby" mode or "targeted r
On Thu, Sep 16, 2021 at 7:26 PM Bossart, Nathan wrote:
> What do you think?
I think this is committable. I also went back and looked at your
previous proposal to do files in batches, and I think that's also
committable. After some reflection, I think I have a slight preference
for the batching ap
On 9/15/21 3:28 PM, Andrew Dunstan wrote:
> On 9/13/21 9:20 AM, Andrew Dunstan wrote:
>> On 9/12/21 2:41 PM, Andrew Dunstan wrote:
>>> On 9/11/21 8:51 PM, Justin Pryzby wrote:
@Andrew: did you have any comment on this part ?
|Subject: buildfarm xversion diff
|Forking
htt
When PG11 added the ability for ALTER TABLE ADD COLUMN to set a constant
default value without rewriting the table the doc changes did not note
how the new feature interplayed with ADD COLUMN DEFAULT NOT NULL.
Previously such a new column required a verification table scan to
ensure no values were
On Fri, Sep 24, 2021 at 10:42:36AM -0300, Alvaro Herrera wrote:
> I think the most reasonable action is to push the patch in
> https://postgr.es/m/20201123193957.GA21810@alvherre.pgsql to all
> branches, closing the immediate hole, and we can see about the xact-hook
> stuff (when we have it) to mas
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
The cfbot seems to be happy with the updated patch.
The new
On 2021-Sep-24, Jaime Casanova wrote:
> Do you plan to work on this for this CF?
I think the most reasonable action is to push the patch in
https://postgr.es/m/20201123193957.GA21810@alvherre.pgsql to all
branches, closing the immediate hole, and we can see about the xact-hook
stuff (when we have
On 2021-Sep-23, Amit Kapila wrote:
> Alvaro, do you have any thoughts on these proposed grammar changes?
Yeah, I think pubobj_name remains a problem in that you don't know its
return type -- could be a String or a RangeVar, and the user of that
production can't distinguish. So you're still (unne
On Fri, Sep 24, 2021 at 5:53 PM houzj.f...@fujitsu.com
wrote:
>
> On Tuesday, September 21, 2021 12:53 PM Masahiko Sawada
> wrote:
> >
> > I've attached the updated version patches. Please review them.
>
> Thanks for updating the patch,
> here are a few comments on the v14-0001 patch.
Thank you
On Fri, Sep 24, 2021 at 5:27 PM Greg Nancarrow wrote:
>
> On Tue, Sep 21, 2021 at 2:53 PM Masahiko Sawada wrote:
> >
> > I've attached the updated version patches. Please review them.
> >
>
> A few review comments for the v14-0002 patch:
Thank you for the comments!
>
> (1)
> I suggest a small u
On Fri, Sep 24, 2021 at 8:01 PM Amit Kapila wrote:
>
> On Tue, Sep 21, 2021 at 10:23 AM Masahiko Sawada
> wrote:
> >
> > I've attached the updated version patches. Please review them.
> >
>
> Review comments for v14-0001-Add-pg_stat_subscription_errors-statistics-view
> =
Em sex., 24 de set. de 2021 às 09:39, Jean-Christophe Arnu
escreveu:
>
>
> Le ven. 24 sept. 2021 à 13:03, Ranier Vilela a
> écrit :
>
>>
>> Comments are more than welcome!
>>>
>> 1. Would be better to add this test-and-error before tsvector_bsearch
>> call.
>>
>> + if (lex_len == 0)
>> + ereport
>
> Still, there's got to be a simple way to make this work, and it can't
> involve setting autoFlush. Like, look at this:
>
> https://github.com/lz4/lz4/blob/dev/examples/frameCompress.c
>
> That uses the same APIs that we're here and a fixed-size input buffer
> and a fixed-size output buffer, jus
Hi Fabien,
> Attached a v10 which is some kind of compromise where the interface uses
> inclusive min and max bounds, so that all values can be reached.
Just wanted to let you know that cfbot [1] doesn't seem to be happy with
the patch. Apparently, some tests are falling. To be honest, I didn't
i
On 22.07.21 16:58, Fabien COELHO wrote:
Ok. I noticed. The patch got significantly broken by the watch pager
commit. I also have to enhance the added tests (per Peter request).
I wrote a test to check psql query cancel support. I checked that it
fails against the patch that was reverted. May
Le ven. 24 sept. 2021 à 13:03, Ranier Vilela a écrit :
>
> Comments are more than welcome!
>>
> 1. Would be better to add this test-and-error before tsvector_bsearch call.
>
> + if (lex_len == 0)
> + ereport(ERROR,
> + (errcode(ERRCODE_ZERO_LENGTH_CHARACTER_STRING),
> + errmsg("lexeme array may n
Hi David,
> Please find attached the next revision :)
The patch didn't apply and couldn't pass cfbot [1]. The (hopefully)
corrected patch is attached. Other than that it looks OK to me but let's
see what cfbot will tell.
[1]: http://cfbot.cputube.org/patch_34_3113.log
--
Best regards,
Aleksand
On 9/24/21 12:49 AM, Platon Pronko wrote:
> On 2021-09-23 22:28, Andrew Dunstan wrote:
>>
>> 2. It would possibly be better to pass the relevant parts of the options
>> to print_aligned_vertical_line() rather than the whole options
>> structure. It feels odd to pass both that and opt_border.
>
>
On Thu, Sep 23, 2021 at 11:56 PM Robert Haas wrote:
>
> On Mon, Sep 20, 2021 at 11:20 AM Amul Sul wrote:
> > Ok, understood, I have separated my changes into 0001 and 0002 patch,
> > and the refactoring patches start from 0003.
>
> I think it would be better in the other order, with the refactori
On 9/23/21 8:35 PM, Robert Haas wrote:
Thanks. Looks like that version had some stupid mistakes. Here's a new one.
Thanks, the reported issue seems to be fixed now for HEAD w/patch
(publication) to HEAD w/patch (subscription) but still getting the same
error if we try to perform v12(publicati
Amit Kapila wrote:
> On Mon, Sep 20, 2021 at 10:24 AM Antonin Houska wrote:
> >
> > Amit Kapila wrote:
> >
> > > On Fri, Sep 17, 2021 at 9:50 PM Dmitry Dolgov <9erthali...@gmail.com>
> > > wrote:
> > > >
> > > > > On Tue, Sep 14, 2021 at 10:51:42AM +0200, Antonin Houska wrote:
> > > >
> > > >
Em sex., 24 de set. de 2021 às 05:47, Jean-Christophe Arnu
escreveu:
> Hello Hackers,
>
> This is my second proposal for a patch, so I hope not to make "rookie"
> mistakes.
>
> This proposal patch is based on a simple use case :
>
> If one creates a table this way
> CREATE TABLE tst_table AS (SEL
On Tue, Sep 21, 2021 at 10:23 AM Masahiko Sawada wrote:
>
> I've attached the updated version patches. Please review them.
>
Review comments for v14-0001-Add-pg_stat_subscription_errors-statistics-view
==
1.
+ command text
+
On Tuesday, September 21, 2021 12:53 PM Masahiko Sawada
wrote:
>
> I've attached the updated version patches. Please review them.
Thanks for updating the patch,
here are a few comments on the v14-0001 patch.
1)
+ hash_ctl.keysize = sizeof(Oid);
+
Hello Hackers,
This is my second proposal for a patch, so I hope not to make "rookie"
mistakes.
This proposal patch is based on a simple use case :
If one creates a table this way
CREATE TABLE tst_table AS (SELECT array_to_tsvector(ARRAY['','abc','def']));
the table content is :
array_to_tsvec
On Fri, Sep 24, 2021 at 12:19 PM Dilip Kumar wrote:
>
> On Fri, Sep 24, 2021 at 12:04 PM Amit Kapila wrote:
> >
> > One possibility in this regard could be that we enhance Replica
> > Identity .. Include (column_list) where all the columns in the include
> > list won't be sent
>
> Instead of RI's
On Wed, Mar 10, 2021 at 08:24:50AM -0500, David Steele wrote:
> On 12/1/20 5:25 PM, Justin Pryzby wrote:
> > On Tue, Dec 01, 2020 at 03:57:24PM -0300, Alvaro Herrera wrote:
> >
> > > > Another idea is if perform_work_item() were responsible for discarding
> > > > relations which disappear. Curren
On Fri, Sep 10, 2021 at 8:42 PM Etsuro Fujita wrote:
> On Fri, Sep 10, 2021 at 1:00 AM Tom Lane wrote:
> > Etsuro Fujita writes:
> > > Having said that, I think another option for this would be to left the
> > > code as-is; assume that 1) the foreign var has "COLLATE default”, not
> > > an unkno
On Tue, Sep 21, 2021 at 2:53 PM Masahiko Sawada wrote:
>
> I've attached the updated version patches. Please review them.
>
A few review comments for the v14-0002 patch:
(1)
I suggest a small update to the patch comment:
BEFORE:
ALTER SUBSCRIPTION ... RESET command resets subscription
parameter
On Tue, Jun 22, 2021 at 02:15:26AM +1200, David Rowley wrote:
[...]
>
> I've come up with a new hash table implementation that I've called
> generichash. It works similarly to simplehash in regards to the
Hi David,
Are you planning to work on this in this CF?
This is marked as "Ready for commi
Hello,
I've recently been working with a database containing bcrypt hashes generated
by a 3rd-party which use the $2b$ prefix. This prefix was introduced in 2014
and has since been recognised by a number of bcrypt implementations.
[1][2][3][4]
At the moment, pgcrypto’s `crypt` doesn’t recognis
Hi
On Tuesday, March 16, 2021 1:35 AM Oh, Mike wrote:
> We noticed that the logical replication could fail when the
> Standby::RUNNING_XACT record is generated in the middle of a catalog
> modifying transaction and if the logical decoding has to restart from the
> RUNNING_XACT
> WAL entry.
...
>
On Fri, Sep 24, 2021 at 1:30 AM Tomas Vondra
wrote:
>
> On 9/23/21 9:31 PM, Robert Haas wrote:
> > On Wed, Sep 8, 2021 at 2:06 AM Dilip Kumar wrote:
> >> But I am attaching both the patches in case you want to play around.
> >
> > I don't really see any reason not to commit 0001. Perhaps some ver
Hi Amit-san,
On Fri, Sep 24, 2021 at 3:34 PM Amit Langote wrote:
> I think there's a word missing in the following comment:
>
> /*
> * See if the partition bounds for inputs are exactly the same, in
> * which case we don't need to work hard: the join rel have the same
>
74 matches
Mail list logo
