> Generally I have the impression that we are not too keen on spending
> planning time on optimizing cases that can be trivially improved by
> rewriting the query.
Well in some cases they can't, when the query is not emitting redundant
predicates by itself but they are added by something else lik
On 2021/06/22 11:30, torikoshia wrote:
On Thu, Jun 10, 2021 at 11:09 AM torikoshia wrote:
On 2021-06-09 23:04, Fujii Masao wrote:
> auto_explain can log the plan of even nested statement
> if auto_explain.log_nested_statements is enabled.
> But ISTM that pg_log_current_plan() cannot log t
On Thu, Jul 1, 2021 at 1:06 AM Rahila Syed wrote:
>
> Hi,
>
> Filtering of columns at the publisher node will allow for selective
> replication of data between publisher and subscriber. In case the updates on
> the publisher are targeted only towards specific columns, the user will have
> an o
On Wed, Jun 30, 2021 at 9:55 PM Fabien COELHO wrote:
> >> Fabien, thanks for the updated patch, I'm looking at it.
>
> After looking at it again, here is an update which ensure 64 bits on
> epoch_shift computation.
Hi Fabien,
The code in pgbench 13 aggregates into buckets that begin on the
bound
On Wed, Jun 30, 2021 at 10:59 PM David Rowley wrote:
> Back when working on 959d00e9d, to allow ordered partition scans for
> LIST and RANGE partitioned tables, I mentioned [1] that if we had a
> field that recorded a Bitmapset of the non-pruned partitions, we could
> use that to do a more thoroug
patchOn Thu, 1 Jul 2021 at 13:00, David Rowley wrote:
> I've only looked at the numeric-agg-sumX2-overflow-v2.patch one and it
> all looks mostly ok.
I forgot to mention earlier, after looking at the code a bit more I
wondered if we should just serialise the NumericSumAccum instead of
the Numeri
On Thu, Jul 01, 2021 at 01:20:48AM -0400, Tom Lane wrote:
> Noah Misch writes:
> > On Wed, Jun 30, 2021 at 11:45:10PM -0400, Tom Lane wrote:
> >> we're still left with the question of why
> >> Solaris' "nm" doesn't support the POSIX-required options.
>
> > In POSIX, -g and -u are mutually exclusi
Noah Misch writes:
> On Wed, Jun 30, 2021 at 11:45:10PM -0400, Tom Lane wrote:
>> we're still left with the question of why
>> Solaris' "nm" doesn't support the POSIX-required options.
> In POSIX, -g and -u are mutually exclusive. Solaris ignores all but the first
> of these in a command:
I've
On 30/6/21 18:55, Laurenz Albe wrote:
On Wed, 2021-06-30 at 14:21 +0300, Andrey Lepikhov wrote:
I think, here we could ask more general question: do we want to remove a
'IS NOT NULL' clause from the clause list if the rest of the list
implicitly implies it?
Generally I have the impression that
On Wed, Jun 30, 2021 at 11:45:10PM -0400, Tom Lane wrote:
> we're still left with the question of why
> Solaris' "nm" doesn't support the POSIX-required options.
In POSIX, -g and -u are mutually exclusive. Solaris ignores all but the first
of these in a command:
[nm@gcc-solaris11 5:0 2021-07-01T
On Thu, Jul 1, 2021 at 8:23 AM Fujii Masao wrote:
> The recent commit 61d599ede7 documented that the type of those options is
> floating point. But the docs still use "is a numeric value" in the
> descriptions
> of them. Probably it should be replaced with "is a floating point value"
> there.
>
On Wed, Jun 30, 2021 at 4:35 PM Amit Kapila wrote:
>
> On Mon, Jun 28, 2021 at 10:12 AM Masahiko Sawada
> wrote:
> >
> >
> > 0003 patch adds pg_stat_logical_replication_error statistics view
> > discussed on another thread[1]. The apply worker sends the error
> > information to the stats collect
On Thu, Jul 1, 2021 at 2:14 AM Tom Lane wrote:
>
> The Core Team would like to extend our congratulations to
> Daniel Gustafsson and John Naylor, who have accepted invitations
> to become our newest Postgres committers.
>
Many congratulations to Daniel & John !
Regards,
Amul
On Mon, Jun 28, 2021 at 7:51 PM Amit Kapila wrote:
>
> Among the above options, I would personally prefer (b) mainly because
> of the consistent handling for partition and non-partition table cases
> but I am fine with approach (a) as well if that is what other people
> feel is better.
>
> Thought
Alvaro Herrera writes:
> On 2021-Jun-30, Noah Misch wrote:
>> No, and wrasse still succeeds at "git checkout e45b0df^". Solaris
>> /usr/bin/grep doesn't support "-e":
> I think this means the rule should use $(GREP), which is /usr/bin/ggrep
> in wrasse,
Ah, my mistake. Although we're still lef
Attached is a combined diff for a set of related patches to the built-in
pgbench workloads. One commit adds an INSERT workload. One fixes the long
standing 0 length filler issue. A new --extra-indexes option adds the
indexes needed for lookups added by the --foreign-keys option.
The commits are
On Thu, Jul 1, 2021 at 2:14 AM Tom Lane wrote:
>
> The Core Team would like to extend our congratulations to
> Daniel Gustafsson and John Naylor, who have accepted invitations
> to become our newest Postgres committers.
>
Many congratulations to Daniel and John!
--
With Regards,
Amit Kapila.
On 2021/06/30 23:31, Bharath Rupireddy wrote:
On Wed, Jun 30, 2021 at 5:53 PM Fujii Masao wrote:
On 2021/05/20 1:01, Bharath Rupireddy wrote:
Thanks for the comments. I added separate messages, changed the error
code from ERRCODE_SYNTAX_ERROR to ERRCODE_INVALID_PARAMETER_VALUE and
also quo
On 2021-Jun-30, Noah Misch wrote:
> No, and wrasse still succeeds at "git checkout e45b0df^". Solaris
> /usr/bin/grep doesn't support "-e":
I think this means the rule should use $(GREP), which is /usr/bin/ggrep
in wrasse,
checking for grep that handles long lines and -e... /usr/bin/ggrep
--
On Wednesday, June 30, 2021 7:43 PM vignesh C
mailto:vignes...@gmail.com>> wrote:
>
> Thanks for reporting this issue, the attached v9 patch fixes this issue. This
> also fixes the other issue you reported at [1].
Thanks for your patch. I confirmed that the two issues I reported has been
fi
On Wed, Jun 30, 2021 at 12:06:47PM -0400, Tom Lane wrote:
> I wrote:
> > OK, thanks, will push a fix momentarily.
>
> Did so, and look what popped up on wrasse [1]:
>
> ! nm -A -g -u libpq.so.5.15 2>/dev/null | grep -v __cxa_atexit | grep exit
> libpq.so.5.15: [765] | 232544|
On Thu, 1 Jul 2021 at 13:00, Thomas Munro wrote:
>
> On Wed, Jun 30, 2021 at 11:14 PM David Rowley wrote:
> > 1) Since I really need 8-byte buckets in the hash table to make this
> > as fast as possible, I want to use the array index for the hash status
> > and that means changing the simplehash
The proposed patch is attached.
Best regards,
--
Gurjeet Singh http://gurjeet.singh.im/
On Wed, Jun 30, 2021 at 5:56 PM Gurjeet Singh wrote:
>
> (Re-sending this email, because the Commitfest app mistakenly [3]
> considered previous email [4] to be part of the old thread, whereas it
> should not
Thanks for the updated patch
On Tue, 29 Jun 2021 at 22:29, Dean Rasheed wrote:
> I'm not a fan of the *serialize() function names in numeric.c though
> (e.g., the name numeric_serialize() seems quite misleading for what it
> actually does). So rather than adding to those, I've kept the original
>
On Wed, Jun 30, 2021 at 11:14 PM David Rowley wrote:
> On Wed, 23 Jun 2021 at 12:17, Thomas Munro wrote:
> Thanks for taking an interest in this. I started looking at your idea
> and I've now changed my mind from just not liking it to thinking that
> the whole idea is just completely horrible :-(
(Re-sending this email, because the Commitfest app mistakenly [3]
considered previous email [4] to be part of the old thread, whereas it
should not be considered that way)
I came across this thread [1] to disallow canceling a transaction not
yet confirmed by a synchronous replica. I think my propo
On Fri, Jun 18, 2021, at 8:40 AM, Amit Kapila wrote:
> I have rebased the patch so that you can try it out. The main thing I
> have done is to remove changes in worker.c and created a specialized
> function to create estate for pgoutput.c as I don't think we need what
> is done in worker.c.
>
> Eu
> v13 patches gave a compiler warning...
>
> $ make >/dev/null
> pgbench.c: In function ‘commandError’:
> pgbench.c:3071:17: warning: unused variable ‘command’ [-Wunused-variable]
> const Command *command = sql_script[st->use_file].commands[st->command];
> ^~~
There is a ty
Hi all,
Ashwin, Deep, and I were discussing this patch today. We agree that
it's fairly difficult to review in its current state, and the lack of a
concrete implementation of the new API isn't helping. (A big chunk of
the context for the patch exists in the zedstore megathread, which
isn't exactly
On 6/30/21 4:43 PM, Tom Lane wrote:
> The Core Team would like to extend our congratulations to
> Daniel Gustafsson and John Naylor, who have accepted invitations
> to become our newest Postgres committers.
>
> Please join me in wishing them much success and few bugs.
>
>
On Wed, Jun 30, 2021 at 11:44 PM Tom Lane wrote:
>
> The Core Team would like to extend our congratulations to
> Daniel Gustafsson and John Naylor, who have accepted invitations
> to become our newest Postgres committers.
>
> Please join me in wishing them much success and few bugs.
Congratulatio
David Rowley writes:
> Now that the pg15 branch is open, does anyone have any objections to this
> patch?
Just reading it over quickly, I noticed a comment mentioning
"aggcombinedfn" which I suppose should be "aggcombinefn".
No particular opinion on whether this is a net reduction
of logical co
Michael Paquier writes:
> On Wed, Jun 30, 2021 at 03:47:19PM +, Jacob Champion wrote:
>> But until/unless that is changed, an #ifndef seems like a good way to
>> prevent issues for the current code.
> Sounds sensible to do that as well for 14 before the release. Any
> thoughts about that?
I
On Wed, 2021-06-30 at 18:56 -0400, Tom Lane wrote:
> Jacob Champion writes:
> > On Wed, 2021-06-30 at 18:29 -0400, Tom Lane wrote:
> > > Looks like we'd have to make use of a dummy stamp-file, more or less
> > > as attached. Any objections?
> > Spitballing -- if you don't like the stamp file, you
Jacob Champion writes:
> On Wed, 2021-06-30 at 18:29 -0400, Tom Lane wrote:
>> Looks like we'd have to make use of a dummy stamp-file, more or less
>> as attached. Any objections?
> Spitballing -- if you don't like the stamp file, you could add the
> check to the end of the $(shlib) rule, surrou
On Sat, 12 Jun 2021 at 23:03, David Rowley wrote:
> I've rebased this and I'd like to propose this small cleanup for pg15.
Now that the pg15 branch is open, does anyone have any objections to this patch?
David
On Thu, 1 Jul 2021 at 02:58, Amit Langote wrote:
>
> On Wed, Jun 30, 2021 at 23:34 David Rowley wrote:
>> + while ((rti = bms_next_member(checkPermRels, rti)) > 0)
>> {
>> - RangeTblEntry *rte = (RangeTblEntry *) lfirst(l);
>> + RangeTblEntry *rte = (RangeTblEntry *) list_nth(rangeTable, rti -
On Thu, 1 Jul 2021 at 09:48, Michael Paquier wrote:
> Congratulations to Daniel and John!
+1. Well deserved!
David
On Wed, Jun 30, 2021 at 03:47:19PM +, Jacob Champion wrote:
> On Wed, 2021-06-30 at 11:03 -0400, Tom Lane wrote:
>> It does not look to me like json_errdetail can sensibly be used in
>> frontend, since it returns palloc'd strings in some paths and
>> constants in others. There'd be no way to a
On Wed, 2021-06-30 at 18:29 -0400, Tom Lane wrote:
> I wrote:
> > Peter Eisentraut writes:
> > > Could we set this rule up a little bit differently so that it is only
> > > run when the library is built.
> > > Right now, make world on a built tree makes 17 calls to this "nm" line,
> > > and make
On Sat, 2021-06-26 at 09:47 +0900, Michael Paquier wrote:
> On Fri, Jun 25, 2021 at 11:40:33PM +, Jacob Champion wrote:
> > I can definitely move it (into, say, auth-sasl.c?). I'll probably do
> > that in a second commit, though, since keeping it in place during the
> > refactor makes the revie
I wrote:
> Peter Eisentraut writes:
>> Could we set this rule up a little bit differently so that it is only
>> run when the library is built.
>> Right now, make world on a built tree makes 17 calls to this "nm" line,
>> and make check-world calls it 81 times. I think once would be enough. ;-)
> I attached the patch updated according with your suggestion.
v13 patches gave a compiler warning...
$ make >/dev/null
pgbench.c: In function ‘commandError’:
pgbench.c:3071:17: warning: unused variable ‘command’ [-Wunused-variable]
const Command *command = sql_script[st->use_file].commands[st-
On Tue, Jun 29, 2021 at 07:36:47PM +0100, Simon Riggs wrote:
> Perhaps we should also add this text from the commit message to ensure
> the importance is understood:
> "This is extremely useful in cases where CIC/RC can run for a very long
> time, because that used to be a significant headache
On 2021-Jun-30, Zhihong Yu wrote:
> Hi,
> In that case, I wonder whether nindexes can be negated following the call
> to vac_open_indexes().
>
> vac_open_indexes(onerel, AccessShareLock, &nindexes, &Irel);
> + nindexes = -nindexes;
>
> That way, hasindex can be dropped.
> vac_updat
On Wed, Jun 30, 2021 at 2:32 PM Álvaro Herrera
wrote:
> On 2021-Jun-30, Zhihong Yu wrote:
>
> > Hi,
> > nit:
> > - if (hasindex)
> > + if (nindexes > 0)
> >
> > It seems hasindex is no longer needed since nindexes is checked.
>
> It's still used to call vac_update_relstats(). We want
On Wed, Jun 30, 2021 at 04:43:58PM -0400, Tom Lane wrote:
> The Core Team would like to extend our congratulations to
> Daniel Gustafsson and John Naylor, who have accepted invitations
> to become our newest Postgres committers.
>
> Please join me in wishing them much success and few bugs.
Congra
On 2021-Jun-30, Zhihong Yu wrote:
> Hi,
> nit:
> - if (hasindex)
> + if (nindexes > 0)
>
> It seems hasindex is no longer needed since nindexes is checked.
It's still used to call vac_update_relstats(). We want nindexes to be 0
for partitioned tables, but still pass true when there
> On 30 Jun 2021, at 22:39, Heikki Linnakangas wrote:
> In general, I think it's weird that the latest option wins. If you specify
> the same option multiple times, and it's not something like --rmgr or --table
> where it makes sense, it's most likely user error. Printing an error would be
> n
> On 30 Jun 2021, at 20:20, Peter Eisentraut
> wrote:
> I am not in favor of this direction. I think it just adds tediousness and
> doesn't really help anyone. If we are worried about correct terminology,
> then we should just change everything to TLS.
I actually think SSL/TLS has won the d
The Core Team would like to extend our congratulations to
Daniel Gustafsson and John Naylor, who have accepted invitations
to become our newest Postgres committers.
Please join me in wishing them much success and few bugs.
regards, tom lane
On 28/06/2021 13:34, Daniel Gustafsson wrote:
On 18 May 2021, at 15:50, Heikki Linnakangas wrote:
The reason is that if you specify multiple --rmgr options, only the last one
takes effect.
That's in line with how options are handled for most binaries, so this will go
against that. That be
Peter Eisentraut writes:
> Could we set this rule up a little bit differently so that it is only
> run when the library is built.
> Right now, make world on a built tree makes 17 calls to this "nm" line,
> and make check-world calls it 81 times. I think once would be enough. ;-)
Hmm, didn't re
Peter Eisentraut writes:
> On 26.06.21 19:43, Tom Lane wrote:
>> fe-print.c's handling of OOM isn't nice at all:
>> fprintf(stderr, libpq_gettext("out of memory\n"));
>> abort();
>> Although fe-print.c is semi-deprecated, it still seems like it'd
>> be a good idea to clean that up.
> Th
Hi,
Filtering of columns at the publisher node will allow for selective
replication of data between publisher and subscriber. In case the updates
on the publisher are targeted only towards specific columns, the user will
have an option to reduce network consumption by not sending the data
corresp
Álvaro Herrera писал 2021-06-30 21:54:
On 2021-Jun-30, Alexander Pyhalov wrote:
I've seen the following effect on PostgreSQL 14 stable branch.
Index, created on partitioned table, disappears from pg_dump or psql
\d
output.
This seems to begin after analyze. Partitoned relation relhasindex
pg
Hi,
Yes, I want to do that for sure.
On Wed, Jun 30, 2021 at 6:33 PM Daniel Gustafsson wrote:
> > On 30 Jun 2021, at 15:31, vignesh C wrote:
>
> > The next commit fest is going to begin soon.
> > I would like to volunteer as commit fest manager for 2021-07 if the
> > role is not filled and the
On Wed, Jun 30, 2021 at 11:54 AM Álvaro Herrera
wrote:
> On 2021-Jun-30, Alexander Pyhalov wrote:
>
> > I've seen the following effect on PostgreSQL 14 stable branch.
> > Index, created on partitioned table, disappears from pg_dump or psql \d
> > output.
> > This seems to begin after analyze. Par
On 2021-Jun-30, Alexander Pyhalov wrote:
> I've seen the following effect on PostgreSQL 14 stable branch.
> Index, created on partitioned table, disappears from pg_dump or psql \d
> output.
> This seems to begin after analyze. Partitoned relation relhasindex pg_class
> field suddenly becomes false
On Wed, 2021-06-30 at 20:20 +0200, Peter Eisentraut wrote:
> I note that popular places such as the Apache and nginx SSL/TLS modules
> just use SSL in their documentation, and they are probably under much
> more scrutiny in this area.
For Apache, that's not strictly true [1, 2]. mod_ssl and its
On 15.06.21 15:59, Daniel Gustafsson wrote:
Looking at the docs it turns out that we have a mix of SSL (with one ssl),
SSL/TLS and TLS for referring to the same thing. The attached changes the
documentation to consistently use SSL/TLS when referring to an encrypted
connection using a TLS protoco
On Wed, Jun 30, 2021 at 6:46 AM Robert Haas wrote:
> The problem is that the setting is measuring something that is a
> pretty poor proxy for the thing we actually care about. It's measuring
> the XID age at which we're going to start forcing vacuums on tables
> that don't otherwise need to be vac
Antonin Houska wrote:
> tsunakawa.ta...@fujitsu.com wrote:
>
> > I'm crawling like a snail to read the patch set. Below are my first set of
> > review comments, which are all minor.
>
> Thanks.
I've added the patch to the upcoming CF [1], so it possibly gets more review
and makes some progr
On 26.06.21 23:29, Tom Lane wrote:
After some thought I propose that what we really want is to prevent
any calls of abort() or exit() from inside libpq. Attached is a
draft patch to do that.
Could we set this rule up a little bit differently so that it is only
run when the library is built.
On 26.06.21 19:43, Tom Lane wrote:
I spent some time looking for other undesirable symbol dependencies
in libpq, and soon found a couple. PGTHREAD_ERROR potentially calls
abort(), which seems even worse than exit-on-OOM, although I don't
think we've ever heard a report of that being hit. Also,
On Wed, Jun 30, 2021 at 7:18 AM Heikki Linnakangas wrote:
> Hmm, there's one more simple trick we can do: We can have a separate
> fast-path version of the loop when there are at least 8 bytes of input
> left, skipping all the length checks. With that:
Good idea, and the numbers look good on Pow
-hackers,
This patch adds the concept of "multiconnect" to pgbench (better
terminology welcome). The basic idea here is to allow connections made
with pgbench to use different auth values or connect to multiple
databases. We implement this using a user-provided PGSERVICEFILE and
choosing a PGSERV
On Tue, Jun 29, 2021 at 06:49:45PM +0200, Daniel Gustafsson wrote:
> > On 29 Jun 2021, at 18:50, Zhihong Yu wrote:
>
> > Now that PG 15 is open for commit, do you think the patch can land ?
>
> Adding it to the commitfest patch tracker is a good way to ensure it's not
> forgotten about:
>
>
On Thu, Jun 17, 2021 at 7:37 PM Jeff Davis wrote:
> What if we simply mandate that a Sync must be sent before the server
> will respond with CopyInResponse/CopyBothResponse, and the client must
> send another Sync after CopyDone/CopyFail (or after receiving an
> ErrorResponse, if the client isn't
I wrote:
> OK, thanks, will push a fix momentarily.
Did so, and look what popped up on wrasse [1]:
! nm -A -g -u libpq.so.5.15 2>/dev/null | grep -v __cxa_atexit | grep exit
libpq.so.5.15: [765]| 232544| 248|FUNC |GLOB
|3|14 |PQexitPipelineMode
This make
On Wed, 2021-06-30 at 14:21 +0300, Andrey Lepikhov wrote:
> I think, here we could ask more general question: do we want to remove a
> 'IS NOT NULL' clause from the clause list if the rest of the list
> implicitly implies it?
>
> EXPLAIN (ANALYZE, VERBOSE)
> SELECT *
> FROM a WHERE (X IS NOT N
On Wed, 2021-06-30 at 11:03 -0400, Tom Lane wrote:
> It does not look to me like json_errdetail can sensibly be used in
> frontend, since it returns palloc'd strings in some paths and
> constants in others. There'd be no way to avoid a memory leak
> in a frontend usage. So I think the dependency
Alvaro Herrera writes:
> When PostgresNode::system_or_bail() fails, it's quite opaque as to what
> is happening. This patch improves things by printing some detail, as
> suggested in Perl's doc for system().
+1 for adding the extra details, but another thing that I've always found
very confusing
> On 30 Jun 2021, at 17:24, Alvaro Herrera wrote:
>
> When PostgresNode::system_or_bail() fails, it's quite opaque as to what
> is happening. This patch improves things by printing some detail, as
> suggested in Perl's doc for system().
+1 on this from reading the patch.
+
Hello Yugo-san,
Thanks for the update!
Patch seems to apply cleanly with "git apply", but does not compile on my
host: "undefined reference to `conditional_stack_reset'".
However it works better when using the "patch". I'm wondering why git
apply fails silently…
Hmm, I don't know why your c
When PostgresNode::system_or_bail() fails, it's quite opaque as to what
is happening. This patch improves things by printing some detail, as
suggested in Perl's doc for system().
--
Álvaro Herrera39°49'30"S 73°17'W
https://www.Enterprise
On 6/30/21 2:55 PM, Andrey Lepikhov wrote:
Sorry, I forgot to send CC into pgsql-hackers.
On 29/6/21 13:23, Tomas Vondra wrote:
Because sampling is fairly expensive, especially if you have to do it
for large number of child relations. And you'd have to do that every
time *any* child triggers au
Hello Fabien,
On Sat, 26 Jun 2021 12:15:38 +0200 (CEST)
Fabien COELHO wrote:
>
> Hello Yugo-san,
>
> # About v12.2
>
> ## Compilation
>
> Patch seems to apply cleanly with "git apply", but does not compile on my
> host: "undefined reference to `conditional_stack_reset'".
>
> However it wor
Michael Paquier writes:
> Attached is a suggestion of patch to rework that a bit. Some extra
> elog()s could be added for the backend, as well as a new error code to
> use as default of report_parse_error(), but that does not seem to gain
> much. And this item looks independent of switching this
On Wed, Jun 30, 2021 at 23:34 David Rowley wrote:
> On Thu, 1 Jul 2021 at 01:34, Amit Langote wrote:
> > For now, I have implemented the idea 2 as the attached patch.
>
> I only just had a fleeting glance at the patch. Aren't you
> accidentally missing the 0th RTE here?
>
> + while ((rti = bms_n
On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote:
>
> On Fri, May 7, 2021 at 6:44 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached patch has the fix for the same.
>
> The patch was not applying on the head, attached patch which is rebased on
> HEAD.
The patch was not applying on
Alvaro Herrera writes:
> (BTW since the _eprintf.o stuff comes from _abort, I suppose you're
> going to remove that grep -v too?)
Right, I did that.
regards, tom lane
On 2021-Jun-30, Tom Lane wrote:
> OK, thanks, will push a fix momentarily.
(BTW since the _eprintf.o stuff comes from _abort, I suppose you're
going to remove that grep -v too?)
--
Álvaro Herrera39°49'30"S 73°17'W
https://www.Enterprise
On 2021-Jun-30, Alexander Pyhalov wrote:
> Hi.
>
> I've seen the following effect on PostgreSQL 14 stable branch.
> Index, created on partitioned table, disappears from pg_dump or psql \d
> output.
> This seems to begin after analyze. Partitoned relation relhasindex pg_class
> field suddenly beco
Alvaro Herrera writes:
> On 2021-Jun-30, Tom Lane wrote:
>> You mentioned __gcov_exit, but I'm not sure if we need an
>> exception for that. I see it referenced by the individual .o
>> files, but the completed .so has no such reference, so at least
>> on RHEL8 it's apparently satisfied during .so
On 2021-Jun-30, Tom Lane wrote:
> Alvaro Herrera writes:
> > Maybe there's something about the linker flags being used.
> > ... ah yeah, if I configure with coverage enabled on my machine, it fails
> > in the same way.
>
> Ah-hah, yeah, I see it too if I enable profiling. I can confirm
> that
On Thu, 1 Jul 2021 at 01:34, Amit Langote wrote:
> For now, I have implemented the idea 2 as the attached patch.
I only just had a fleeting glance at the patch. Aren't you
accidentally missing the 0th RTE here?
+ while ((rti = bms_next_member(checkPermRels, rti)) > 0)
{
- RangeTblEntry *rte =
Alexander Pyhalov писал 2021-06-30 17:26:
Hi.
Sorry, test had an issue.
--
Best regards,
Alexander Pyhalov,
Postgres ProfessionalFrom 2aabf5e8e86d222e6a73b25ccc652fe645e12fc4 Mon Sep 17 00:00:00 2001
From: Alexander Pyhalov
Date: Wed, 30 Jun 2021 17:22:37 +0300
Subject: [PATCH] Set relhasin
On Wed, Jun 30, 2021 at 5:53 PM Fujii Masao wrote:
>
> On 2021/05/20 1:01, Bharath Rupireddy wrote:
> > Thanks for the comments. I added separate messages, changed the error
> > code from ERRCODE_SYNTAX_ERROR to ERRCODE_INVALID_PARAMETER_VALUE and
> > also quoted the option name in the error messa
Hi.
I've seen the following effect on PostgreSQL 14 stable branch.
Index, created on partitioned table, disappears from pg_dump or psql \d
output.
This seems to begin after analyze. Partitoned relation relhasindex
pg_class field suddenly becomes false.
The issue happens after
commit 0e69f705
On Thu, May 13, 2021 at 8:09 PM vignesh C wrote:
>
> On Thu, May 13, 2021 at 4:58 AM Alvaro Herrera
> wrote:
> >
>
> Thanks for the comments, Attached patch has the changes for the same.
>
The Patch was not applying on Head, the attached patch is rebased on
top of Head.
Regards,
Vignesh
From f
Alvaro Herrera writes:
> Maybe there's something about the linker flags being used.
> ... ah yeah, if I configure with coverage enabled on my machine, it fails in
> the same way.
Ah-hah, yeah, I see it too if I enable profiling. I can confirm
that it's not from the abort() call in path.c, becau
On Wed, Jun 30, 2021 at 11:11 AM Amit Kapila wrote:
>
> On Tue, Jun 29, 2021 at 8:56 PM Bharath Rupireddy
> wrote:
> >
> > On Tue, Jun 29, 2021 at 4:37 PM Amit Kapila wrote:
> > > Few comments:
> > > ===
> >
> > > 2.
> > > +parse_subscription_options(List *stmt_options, SubOpts *opts
On Wed, Jun 30, 2021 at 10:52 AM Amit Kapila wrote:
>
> On Tue, Jun 29, 2021 at 9:41 PM Alvaro Herrera
> wrote:
> >
> > On 2021-Jun-29, Bharath Rupireddy wrote:
> >
> > > On Tue, Jun 29, 2021 at 4:37 PM Amit Kapila
> > > wrote:
> > > > Few comments:
> > > > ===
> > > > 1.
> > > > +
Back when working on 959d00e9d, to allow ordered partition scans for
LIST and RANGE partitioned tables, I mentioned [1] that if we had a
field that recorded a Bitmapset of the non-pruned partitions, we could
use that to do a more thorough check to see if ordered scans are
possible.
At the moment t
On 2021-Jun-30, Alvaro Herrera wrote:
> If I remove -fprofile-arcs from CFLAGS, then abort is no longer present,
> but we still get a fail because of __gcov_exit. I suppose if you'd add
> an exception for __cxa_atexit, the same place could use one for
> __gcov_exit.
I tried the attached patch, a
On Mon, Jun 28, 2021 at 8:52 AM Andrew Dunstan wrote:
> But if you're really worried about people setting
> autovacuum_freeze_max_age too high, then maybe we should be talking
> about capping it at a lower level rather than adjusting the docs that
> most users don't read.
The problem is that the
Hi,
Last year in [1], I had briefly mentioned $subject. I'm starting this
thread to propose a small patch to alleviate the inefficiency of that
case.
As also mentioned in [1], when running -Mprepared benchmarks
(plan_cache_mode = force_generic_plan) using partitioned tables,
ExecRTCheckPerms() t
> On 30 Jun 2021, at 15:31, vignesh C wrote:
> The next commit fest is going to begin soon.
> I would like to volunteer as commit fest manager for 2021-07 if the
> role is not filled and there are no objections.
Ibrar Ahmed has already volunteered since a while back, so let's see if he is
still
Hi all,
The next commit fest is going to begin soon.
I would like to volunteer as commit fest manager for 2021-07 if the
role is not filled and there are no objections.
Regards,
Vignesh
1 - 100 of 130 matches
Mail list logo
