> On 30 Jun 2021, at 17:24, Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote:
> 
> When PostgresNode::system_or_bail() fails, it's quite opaque as to what
> is happening.  This patch improves things by printing some detail, as
> suggested in Perl's doc for system().

+1 on this from reading the patch.

+                       BAIL_OUT("system $_[0] failed: $!\n");
I wonder if we should take more inspiration from the Perl manual and change it
to "failed to execute" to make it clear that the failure was in executing the
program, not from the program itself?

--
Daniel Gustafsson               https://vmware.com/



Reply via email to