Thanks Suraj for reviewing the patch.
> 1:
> +RESET timezone;
> +
> +
> CREATE TABLE TIMESTAMPTZ_TST (a int , b timestamptz);
>
> Extra line.
>
> 2:
> +SET timezone = '00:00';
> +SELECT to_char(now(), 'of') as "Of", to_char(now(), 'tzh:tzm') as
"tzh:tzm";
I have fixed these comments.
> I am not
On Thu, May 20, 2021 at 11:18 AM Pengchengliu wrote:
>
> Hi Greg,
>Thanks a lot for you explanation and your fix.
>
>I think your fix can resolve the core dump issue. As with your fix,
> parallel process reset Transaction Xmin from ActiveSnapshot.
>But it will change Transaction snaps
On Tue, May 18, 2021 at 10:49:39AM +0900, Michael Paquier wrote:
> Makes sense. For now, I'll update this patch set so as it is possible
> to use custom dumps, as an option in parallel of pg_regress when
> specifying a different source code path. I'll also decouple the
> business with probin upda
On Tue, May 18, 2021 at 6:52 AM Peter Smith wrote:
>
> >
> > Yeah, have you checked it in the back branches?
> >
>
> Yes, the apply_handle_truncate function was introduced in April/2018 [1].
>
> REL_11_0 was tagged in Oct/2018.
>
> The "ERROR: deadlock detected" log is reproducible in PG 11.0.
>
From: Tom Lane
> Greg Nancarrow writes:
> > On Sun, Feb 7, 2021 at 10:03 AM Tom Lane wrote:
> >> I think either the bit about rule_action is unnecessary, or most of
> >> the code immediately above this is wrong, because it's only updating
> >> flags in sub_action. Why do you think it's necessar
On Wed, May 19, 2021 at 8:15 PM David Rowley wrote:
> On Mon, 17 May 2021 at 14:52, Andy Fan wrote:
> > Would marking the new added RestrictInfo.norm_selec > 1 be OK?
>
> There would be cases you'd want to not count the additional clauses in
> the selectivity estimation and there would be cases
Hi,
I have upgraded the patch for the 14th version.
>Вторник, 16 марта 2021, 14:32 +03:00 от Ivan Panchenko :
>
>Hi,
>
>Thank you, Konstantin, for this very good feature with numerous use cases.
>Please find the modified patch attached.
>
>I’ve added the ‘enable_client_connection_trigger’ GUC to
On 2021/05/11 13:37, Masahiko Sawada wrote:
> I've attached the updated patches that incorporated comments from
> Zhihong and Ikeda-san.
Thanks for updating the patches!
I have other comments including trivial things.
a. about "foreign_transaction_resolver_timeout" parameter
Now, the defaul
On Wed, May 19, 2021 at 6:13 PM Bharath Rupireddy
wrote:
> Thanks. I will work on the new structure ParseSubOption only for
> subscription options.
PSA v2 patch that has changes for 1) new ParseSubOption structure 2)
the error reporting code refactoring.
With Regards,
Bharath Rupireddy.
Enterpri
Currently we are using a custom/generic strategy to handle the data skew
issue. However, it doesn't work well all the time. For example: SELECT *
FROM t WHERE a between $1 and $2. We assume the selectivity is 0.0025,
But users may provide a large range every time. Per our current strategy,
a gener
+1 for the change.
I quickly reviewed the patch and overall it looks good to me.
Few cosmetic suggestions:
1:
+RESET timezone;
+
+
CREATE TABLE TIMESTAMPTZ_TST (a int , b timestamptz);
Extra line.
2:
+SET timezone = '00:00';
+SELECT to_char(now(), 'of') as "Of", to_char(now(), 'tzh:tzm') as
"t
Michael Paquier writes:
> Could it be possible to install regress.so at least in the same
> location as pg_regress?
I don't think this is a great idea. Aside from the fact that
we'd be littering the install tree with a .so of no use to end
users, I'm failing to see how it really gets you anywher
Hi all,
While diving into a transformation of the tests of pg_upgrade to TAP,
I am getting annoyed by the fact that regress.so is needed if you
upgrade an older instance that holds the regression objects from the
main regression test suite. The buildfarm code is using a trick to
copy regress.so f
Hi Greg,
Thanks a lot for you explanation and your fix.
I think your fix can resolve the core dump issue. As with your fix, parallel
process reset Transaction Xmin from ActiveSnapshot.
But it will change Transaction snapshot for all parallel scenarios. I don't
know whether it bring
Michael Paquier writes:
> On Wed, May 19, 2021 at 04:23:55PM -0400, Tom Lane wrote:
>> * Replace the edata->resultRelInfo field with two fields, one for
>> the original parent and one for the actual/current target. Perhaps
>> this is worth doing, not sure.
> This one sounds more natural to me, t
On 2021/05/19 11:40, Fujii Masao wrote:
> Thanks for updating the patch! I modified some comments slightly and
> pushed that version of the patch.
Thanks a lot!
Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION
On Wed, May 19, 2021 at 03:35:00PM -0400, Tom Lane wrote:
> Magnus Hagander writes:
>> Changing that to look globally can certainly be done. It takes a bit
>> of work I think, as there are no API endpoints today that will do
>> that, but those could be added.
>
> Ah. Personally, I'd settle for i
On Thu, 20 May 2021 at 12:20, tsunakawa.ta...@fujitsu.com
wrote:
> Yes, I want to make/keep it possible that application developers can be
> unaware of partitions. I believe that's why David-san, Alvaro-san, and you
> have made great efforts to improve partitioning performance. So, I'm +1 for
On Thu, May 20, 2021 at 5:23 AM Tom Lane wrote:
> Amit Langote writes:
> > IOW, the patch you posted earlier seems like the way to go.
>
> I really dislike that patch. I think it's doubling down on the messy,
> unstructured coding patterns that got us into this situation to begin
> with. I'd pr
On Thu, 20 May 2021 at 01:17, Amit Langote wrote:
> I gave a shot to implementing your idea and ended up with the attached
> PoC patch, which does pass make check-world.
I only had a quick look at this.
+ if ((dispatch->key->strategy == PARTITION_STRATEGY_RANGE ||
+ dispatch->key->strategy == PA
From: Amit Langote
> On Tue, May 18, 2021 at 11:11 AM houzj.f...@fujitsu.com
> wrote:
> > For some big data scenario, we sometimes transfer data from one table(only
> store not expired data)
> > to another table(historical data) for future analysis.
> > In this case, we import data into historica
On Wed, May 19, 2021 at 02:36:03PM -0400, Andrew Dunstan wrote:
> Yeah, this area needs substantial improvement. I have seen similar sorts
> of nasty hangs, where the script is waiting forever for some process
> that hasn't got the shutdown message. At least we probably need some way
> of making su
On Wed, May 19, 2021 at 04:23:55PM -0400, Tom Lane wrote:
> I really dislike that patch. I think it's doubling down on the messy,
> unstructured coding patterns that got us into this situation to begin
> with. I'd prefer to expend a little effort on refactoring so that
> the ExecCleanupTupleRouti
On 2021-May-19, Andrew Dunstan wrote:
> It's just a reference after all. So someone supplies a reference to an
> email on an out of the way list. What's the evil that will occur? Not
> much really AFAICT.
... as long as it doesn't leak data from private lists ...
--
Álvaro Herrera
On Wed, May 19, 2021 at 10:19 AM Christoph Berg wrote:
>
> Fwiw, if the PostgreSQL projects is considering moving the #postgresql
> IRC channel(s) elsewhere given [1,2], I'm a member of OFTC.net's network
> operations committee and would be happy to help.
>
> [1] https://gist.github.com/aaronmdjon
Amit Langote writes:
> IOW, the patch you posted earlier seems like the way to go.
I really dislike that patch. I think it's doubling down on the messy,
unstructured coding patterns that got us into this situation to begin
with. I'd prefer to expend a little effort on refactoring so that
the Ex
On 5/19/21 3:07 PM, Magnus Hagander wrote:
> On Wed, May 19, 2021 at 7:39 PM Tom Lane wrote:
>> Stephen Frost writes:
>>> * Laurenz Albe (laurenz.a...@cybertec.at) wrote:
Since we have a "documentation" section in the commitfest, it would
be useful to allow links to the -docs archives
Magnus Hagander writes:
> On Wed, May 19, 2021 at 7:39 PM Tom Lane wrote:
>> IIRC, the CF app also rejects threads on pgsql-bugs, which is even
>> more pointlessly annoying. Couldn't we just remove that restriction
>> altogether, and allow anything posted to some pgsql list?
> It's not technica
On 5/19/21 6:43 AM, Paul Guo wrote:
> Several weeks ago I saw this issue in a production environment. The
> read only file looks like a credential file. Michael told me that
> usually such kinds of files should be better kept in non-pgdata
> directories in production environments. Thought further
On Tue, May 18, 2021 at 01:49:12PM -0400, Robert Haas wrote:
> I see that you have made a theoretical argument for why this should be
> good for performance, but it would be better to have some test results
> that show that it works out in practice. Sometimes things seem like
> they ought to be mor
> Created a table with one column of type 'int' and partitioned by that
> column. Created 1 million partitions using following queries.
Sorry. It's not 1 million. Its 10,000 partitions.
--
Thanks & Regards,
Nitin Jadhav
On Thu, May 20, 2021 at 12:21 AM Nitin Jadhav
wrote:
>
> > 'git apply' is v
On Wed, May 19, 2021 at 7:39 PM Tom Lane wrote:
>
> Stephen Frost writes:
> > * Laurenz Albe (laurenz.a...@cybertec.at) wrote:
> >> Since we have a "documentation" section in the commitfest, it would
> >> be useful to allow links to the -docs archives.
>
> > ... or get rid of the pgsql-docs maili
On 5/19/21 1:01 PM, Dagfinn Ilmari Mannsåker wrote:
> Daniel Gustafsson writes:
>
>> In order to be able to test extensions with SSL connections, allow
>> configure_test_server_for_ssl to create any extensions passed as
>> comma separated list. Each extension is created in all the test
>> databa
On 5/19/21 1:39 PM, Tom Lane wrote:
> Stephen Frost writes:
>> * Laurenz Albe (laurenz.a...@cybertec.at) wrote:
>>> Since we have a "documentation" section in the commitfest, it would
>>> be useful to allow links to the -docs archives.
>> ... or get rid of the pgsql-docs mailing list, as has bee
> 'git apply' is very picky. Use 'patch -p1' to apply your patches instead.
>
> Also, use 'git diff --check' or 'git log --check' before generating
> patches to send, and fix any whitespace errors before submitting.
Thanks for the suggestion. I will follow these.
> I see that you have made a theo
On 5/19/21 6:32 AM, Fabien COELHO wrote:
>
>
>> Confirmed, thanks for looking. I can reproduce it on my machine with
>> -m32. It's somewhat annoying that the buildfarm didn't pick it up
>> sooner :-(
>>
>> On Wed, 19 May 2021 at 08:28, Michael Paquier
>> wrote:
>>>
>>> On Wed, May 19, 2021 at 09
On 5/18/21 11:03 PM, Michael Paquier wrote:
>
>> 3. Once the subscriber1 postmaster has exited, the TAP
>> test will eventually time out, and then this happens:
>>
>> [.. logs ..]
>>
>> That is, because we failed to shut down subscriber1, the
>> test script neglects to shut down subscriber2, and
> On 19 May 2021, at 19:39, Tom Lane wrote:
>
> Stephen Frost writes:
>> * Laurenz Albe (laurenz.a...@cybertec.at) wrote:
>>> Since we have a "documentation" section in the commitfest, it would
>>> be useful to allow links to the -docs archives.
>
>> ... or get rid of the pgsql-docs mailing lis
Hi,
I let this drop off my radar a few months ago, but I'm going to try to get
back into the habit of looking at a few items a week. As before, let me
know in the next few days if anyone has thoughts or objections.
(Optimizer / Executor)
- Consider increasing the default values of from_collapse_
Stephen Frost writes:
> * Laurenz Albe (laurenz.a...@cybertec.at) wrote:
>> Since we have a "documentation" section in the commitfest, it would
>> be useful to allow links to the -docs archives.
> ... or get rid of the pgsql-docs mailing list, as has been suggested
> before.
IIRC, the CF app als
Alvaro Herrera writes:
> On 2021-May-19, Tom Lane wrote:
>> +1, except that you should add documentation for NO_INSTALL to the
>> list of definable symbols at the head of pgxs.mk, and to the list
>> in extend.sgml (compare that for NO_INSTALLCHECK).
> I propose this.
WFM.
On Wed, 2021-05-19 at 10:31 -0400, Stephen Frost wrote:
> * Laurenz Albe (laurenz.a...@cybertec.at) wrote:
> > I revently tried to upgrade a standby following the documentation,
> > but I found it hard to understand, [...]
>
> Haven't had a chance to look at this in depth but improving things here
Daniel Gustafsson writes:
> In order to be able to test extensions with SSL connections, allow
> configure_test_server_for_ssl to create any extensions passed as
> comma separated list. Each extension is created in all the test
> databases which may or may not be useful.
Why the comma-separated
Greetings,
* Laurenz Albe (laurenz.a...@cybertec.at) wrote:
> I would like to add a thread on pgsql-docs to the commitfest, but I
> found that that cannot be done.
>
> What is the best way to proceed?
> Since we have a "documentation" section in the commitfest, it would
> be useful to allow links
I would like to add a thread on pgsql-docs to the commitfest, but I
found that that cannot be done.
What is the best way to proceed?
Since we have a "documentation" section in the commitfest, it would
be useful to allow links to the -docs archives.
Yours,
Laurenz Albe
On Wed, May 19, 2021 at 5:20 PM Fujii Masao wrote:
>
> ereport(ERROR,
>
> (errcode(ERRCODE_SYNTAX_ERROR),
> -errmsg("%s requires a
> non-negative numeric value",
> +
Hi, hackers.
I've been playing with "autoprepared" patch, and have got isolation
"freeze-the-dead" test stuck on first VACUUM FREEZE statement.
After some research I found issue is reproduced with unmodified master
branch if extended protocol used. I've prepared ruby script for
demonstration (cau
On Wed, May 19, 2021 at 5:02 PM Fujii Masao wrote:
> On 2021/05/19 14:34, Bharath Rupireddy wrote:
> > On Wed, May 19, 2021 at 8:28 AM Fujii Masao
> > wrote:
> > I agree with throwing an error for non-numeric junk though.
> > Allowing that on the grounds of backwards compatibility
>
On 2021-May-19, Tom Lane wrote:
> Peter Eisentraut writes:
> > On 10.05.21 20:26, Peter Eisentraut wrote:
> >> The reason this is there is that the test suite uses PGXS to build the
> >> test program, and so things get installed automatically. I suggest that
> >> we should either write out the
Or, (3) remove this test? I am not quite sure what there is to gain
with this extra test considering all the other tests with permute()
already present in this script.
Yes, I think removing the test is the best option. It was originally
added because there was a separate code path for larger
Peter Eisentraut writes:
> On 10.05.21 20:26, Peter Eisentraut wrote:
>> The reason this is there is that the test suite uses PGXS to build the
>> test program, and so things get installed automatically. I suggest that
>> we should either write out the build system by hand to avoid this, or
>>
These sound weird since markup was added in 6a5bde7d4:
https://www.postgresql.org/docs/devel/release-14.html
| Remove server and Chapter 34 support for the version 2 wire protocol (Heikki
Linnakangas)
...
| Pass doubled quote marks in Chapter 36 SQL command strings literally (Tom
Lane)
-Remove s
On Tue, May 18, 2021 at 9:20 PM Alvaro Herrera wrote:
>
> On 2021-May-14, vignesh C wrote:
>
> > While I was reviewing one of the logical decoding features, I found
> > Streaming and binary options were missing in tab completion for the
> > alter subscription set option, the attached patch has the
Fwiw, if the PostgreSQL projects is considering moving the #postgresql
IRC channel(s) elsewhere given [1,2], I'm a member of OFTC.net's network
operations committee and would be happy to help.
[1] https://gist.github.com/aaronmdjones/1a9a93ded5b7d162c3f58bdd66b8f491
[2] https://fuchsnet.ch/freenod
While playing around with the recent SSL testharness changes I wrote a test
suite for sslinfo as a side effect, which seemed valuable in its own right as
we currently have no coverage of this code. The small change needed to the
testharness is to support installing modules, which is broken out int
On Tue, May 18, 2021 at 11:11 AM houzj.f...@fujitsu.com
wrote:
> > > Hmm, does this seem common enough for the added complexity to be
> > worthwhile?
> >
> > I'd also like to know if there's some genuine use case for this. For testing
> > purposes does not seem to be quite a good enough reason.
>
On Tue, May 18, 2021 at 10:28 AM David Rowley wrote:
> On Tue, 18 May 2021 at 01:31, Amit Langote wrote:
> > Hmm, does this seem common enough for the added complexity to be worthwhile?
>
> I'd also like to know if there's some genuine use case for this. For
> testing purposes does not seem to be
On 5/19/21 1:42 AM, Tom Lane wrote:
I discovered $SUBJECT after wondering why hyrax hadn't reported
in recently, and trying to run check-world under CCA to see if
anything got stuck. Indeed it did --- although this doesn't
explain the radio silence from hyrax, because that animal doesn't
run any
On Wed, May 19, 2021 at 5:56 PM Amit Kapila wrote:
>
> On Wed, May 19, 2021 at 4:42 PM Bharath Rupireddy
> wrote:
> >
> > On Wed, May 19, 2021 at 4:10 PM Amit Kapila wrote:
> > >
> > > On Wed, May 19, 2021 at 3:08 PM Bharath Rupireddy
> > > wrote:
> > > >
> > > > On Wed, May 19, 2021 at 2:33 PM
On Wed, May 19, 2021 at 5:33 PM Mathis Rudolf wrote:
>
> Hello,
>
> we had a Customer-Report in which `refresh materialized view
> CONCURRENTLY` failed with: `ERROR: column reference "mv" is ambiguous`
>
> They're using `mv` as an alias for one column and this is causing a
> collision with an inte
On Wed, May 19, 2021 at 4:42 PM Bharath Rupireddy
wrote:
>
> On Wed, May 19, 2021 at 4:10 PM Amit Kapila wrote:
> >
> > On Wed, May 19, 2021 at 3:08 PM Bharath Rupireddy
> > wrote:
> > >
> > > On Wed, May 19, 2021 at 2:33 PM Amul Sul wrote:
> > > >
> > > > On Wed, May 19, 2021 at 2:09 PM Bharat
On Tue, May 18, 2021 at 12:22 PM Kyotaro Horiguchi
wrote:
> And finally I think I could reach the situation the commit wanted to fix.
>
> I took a basebackup from a standby just before replaying the first
> checkpoint of the new timeline (by using debugger), without copying
> pg_wal. In this bac
On Mon, 17 May 2021 at 14:52, Andy Fan wrote:
> Would marking the new added RestrictInfo.norm_selec > 1 be OK?
There would be cases you'd want to not count the additional clauses in
the selectivity estimation and there would be cases you would want to.
For example:
SELECT ... FROM t1 INNER JOIN
On Wed, 19 May 2021 at 12:07, Fabien COELHO wrote:
>
> Attached patch disactivates the test with comments to outline that there
> is an issue to fix… so it is *not* removed.
>
I opted to just remove the test rather than comment it out, since the
issue highlighted isn't specific to permute(). Also
Hello,
we had a Customer-Report in which `refresh materialized view
CONCURRENTLY` failed with: `ERROR: column reference "mv" is ambiguous`
They're using `mv` as an alias for one column and this is causing a
collision with an internal alias. They also made it reproducible like this:
```
creat
On Fri, May 14, 2021 at 6:24 PM houzj.f...@fujitsu.com
wrote:
>
> Thanks for the comments, I have posted new version patches with this change.
>
> > How about reorganisation of the patches like the following?
> > 0001: CREATE ALTER TABLE PARALLEL DML
> > 0002: parallel-SELECT-for-INSERT (planner c
On 2021/05/19 20:01, Bharath Rupireddy wrote:
On Mon, May 17, 2021 at 4:23 PM Amit Kapila wrote:
On Tue, May 11, 2021 at 11:28 AM Bharath Rupireddy
wrote:
On Mon, May 10, 2021 at 7:39 PM Tom Lane wrote:
Bharath Rupireddy writes:
On Mon, May 10, 2021 at 12:00 PM Tom Lane wrote:
Yea
On 2021/05/19 14:34, Bharath Rupireddy wrote:
On Wed, May 19, 2021 at 8:28 AM Fujii Masao wrote:
I agree with throwing an error for non-numeric junk though.
Allowing that on the grounds of backwards compatibility
seems like too much of a stretch.
+1.
+1.
+1
Thanks all for your inputs
Hi,
While working on [1], I found that some parts of the code is using
strtol and atoi without checking for non-numeric junk input strings. I
found this strange. Most of the time users provide proper numeric
strings but there can be some scenarios where these strings are not
user-supplied but gene
On Wed, 19 May 2021 at 11:32, Fabien COELHO wrote:
>
> >> Or, (3) remove this test? I am not quite sure what there is to gain
> >> with this extra test considering all the other tests with permute()
> >> already present in this script.
> >
> > Yes, I think removing the test is the best option. It
On Wed, May 19, 2021 at 4:10 PM Amit Kapila wrote:
>
> On Wed, May 19, 2021 at 3:08 PM Bharath Rupireddy
> wrote:
> >
> > On Wed, May 19, 2021 at 2:33 PM Amul Sul wrote:
> > >
> > > On Wed, May 19, 2021 at 2:09 PM Bharath Rupireddy
> > > wrote:
> > > >
> > > > Hi,
> > > >
> > > > parse_subscrip
Hello Dean,
Or, (3) remove this test? I am not quite sure what there is to gain
with this extra test considering all the other tests with permute()
already present in this script.
Yes, I think removing the test is the best option. It was originally
added because there was a separate code pat
On Mon, May 17, 2021 at 4:23 PM Amit Kapila wrote:
>
> On Tue, May 11, 2021 at 11:28 AM Bharath Rupireddy
> wrote:
> >
> > On Mon, May 10, 2021 at 7:39 PM Tom Lane wrote:
> > >
> > > Bharath Rupireddy writes:
> > > > On Mon, May 10, 2021 at 12:00 PM Tom Lane wrote:
> > > >> Yeah, this error me
Several weeks ago I saw this issue in a production environment. The
read only file looks like a credential file. Michael told me that
usually such kinds of files should be better kept in non-pgdata
directories in production environments. Thought further it seems that
pg_rewind should be more user f
On Wed, May 19, 2021 at 3:08 PM Bharath Rupireddy
wrote:
>
> On Wed, May 19, 2021 at 2:33 PM Amul Sul wrote:
> >
> > On Wed, May 19, 2021 at 2:09 PM Bharath Rupireddy
> > wrote:
> > >
> > > Hi,
> > >
> > > parse_subscription_options function has some similar code when
> > > throwing errors [with
On Wednesday, May 19, 2021 1:52 PM Amit Kapila wrote:
> > > I am not sure but I
> > > > think we should prohibit truncate on user_catalog_tables as we
> > > > prohibit truncate on system catalog tables (see below [1]) if we
> > > > want plugin to lock them, otherwise, as you said it might lead to
Confirmed, thanks for looking. I can reproduce it on my machine with
-m32. It's somewhat annoying that the buildfarm didn't pick it up
sooner :-(
On Wed, 19 May 2021 at 08:28, Michael Paquier wrote:
On Wed, May 19, 2021 at 09:06:16AM +0200, Fabien COELHO wrote:
I see two simple approaches:
Hi
I've been discussing about user_catalog_table
and the possibility of deadlock during synchronous mode
of logical replication in [1]. I'll launch a new thread
and summarize the contents so that anyone who is
interested in this title can join the discussion.
We don't have any example of user_ca
On 2021/05/19 16:43, Kyotaro Horiguchi wrote:
+1 for adding some tests for pg_wal_replay_pause() but the test seems
like checking only that pg_get_wal_replay_pause_state() returns the
expected state value. Don't we need to check that the recovery is
actually paused and that the promotion happe
On 10.05.21 20:26, Peter Eisentraut wrote:
The test program libpq_pipeline produced by the test suite in
src/test/modules/libpq_pipeline/ is installed into tmp_install as part
of make check. This isn't a real problem by itself, but I think it
creates a bit of an asymmetric situation that might
On Wed, May 19, 2021 at 2:33 PM Amul Sul wrote:
>
> On Wed, May 19, 2021 at 2:09 PM Bharath Rupireddy
> wrote:
> >
> > Hi,
> >
> > parse_subscription_options function has some similar code when
> > throwing errors [with the only difference in the option]. I feel we
> > could just use a variable f
On Tue, May 18, 2021 at 10:06:18PM -0500, Justin Pryzby wrote:
> On Mon, May 17, 2021 at 04:44:11PM +0900, Michael Paquier wrote:
>> On Sun, Mar 21, 2021 at 02:30:04PM -0500, Justin Pryzby wrote:
>>
>> For this patch, this is going to require a bit more in terms of library
>> linking as the block
On Wed, May 19, 2021 at 2:09 PM Bharath Rupireddy
wrote:
>
> Hi,
>
> parse_subscription_options function has some similar code when
> throwing errors [with the only difference in the option]. I feel we
> could just use a variable for the option and use it in the error.
> While this has no benefit
Hi,
parse_subscription_options function has some similar code when
throwing errors [with the only difference in the option]. I feel we
could just use a variable for the option and use it in the error.
While this has no benefit at all, it saves some LOC and makes the code
look better with lesser er
On Tue, May 18, 2021 at 9:21 PM Alvaro Herrera wrote:
>
> On 2021-May-14, vignesh C wrote:
>
> > While I was reviewing one of the logical decoding features, I found
> > Streaming and binary options were missing in tab completion for the
> > alter subscription set option, the attached patch has the
On Wed, 19 May 2021 at 00:35, Thomas Munro wrote:
>
> FWIW this is reproducible on my local Debian/gcc box with -m32,
Confirmed, thanks for looking. I can reproduce it on my machine with
-m32. It's somewhat annoying that the buildfarm didn't pick it up
sooner :-(
On Wed, 19 May 2021 at 08:28, Mi
On Wed, May 19, 2021 at 11:55 AM Kyotaro Horiguchi
wrote:
>
> At Wed, 19 May 2021 11:19:13 +0530, Dilip Kumar wrote
> in
> > On Wed, May 19, 2021 at 10:16 AM Fujii Masao
> > wrote:
> > >
> > > On 2021/05/18 15:46, Michael Paquier wrote:
> > > > On Tue, May 18, 2021 at 12:48:38PM +0900, Fujii Ma
On Tue, Apr 27, 2021 at 12:58:52PM +0300, Aleksander Alekseev wrote:
> I've noticed there is no tab completion for ALTER TABLE xxx ADD. Here
> is an alternative version of the patch that fixes this as well. Not
> sure if this should be in the same commit though.
- /* If we have ALTER TABLE DROP
At Wed, 19 May 2021 16:21:58 +0900, Fujii Masao
wrote in
>
>
> On 2021/05/19 15:25, Kyotaro Horiguchi wrote:
> > At Wed, 19 May 2021 11:19:13 +0530, Dilip Kumar
> > wrote in
> >> On Wed, May 19, 2021 at 10:16 AM Fujii Masao
> >> wrote:
> >>>
> >>> On 2021/05/18 15:46, Michael Paquier wrote:
On Wed, May 19, 2021 at 09:06:16AM +0200, Fabien COELHO wrote:
> I see two simple approaches:
>
> (1) use another PRNG inside pgbench, eg Knuth's which was used in some
> previous submission and is very simple and IMHO better than the rand48
> stuff.
>
> (2) extend pg_*rand48() to provide an unsi
On 2021/05/19 15:25, Kyotaro Horiguchi wrote:
At Wed, 19 May 2021 11:19:13 +0530, Dilip Kumar wrote in
On Wed, May 19, 2021 at 10:16 AM Fujii Masao
wrote:
On 2021/05/18 15:46, Michael Paquier wrote:
On Tue, May 18, 2021 at 12:48:38PM +0900, Fujii Masao wrote:
Currently a promotion causes
Forgot to post the actual values:
r = 2563421694876090368
r = 2563421694876090365
Smells a bit like a precision problem in the workings of pg_erand48(),
but as soon as I saw floating point numbers I closed my laptop and ran
for the door.
Yup. This test has a touching, but entirel
92 matches
Mail list logo
