On Wed, May 19, 2021 at 2:09 PM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > Hi, > > parse_subscription_options function has some similar code when > throwing errors [with the only difference in the option]. I feel we > could just use a variable for the option and use it in the error. > While this has no benefit at all, it saves some LOC and makes the code > look better with lesser ereport(ERROR statements. PSA patch. > > Thoughts?
I don't have a strong opinion on this, but the patch should add __translator__ help comment for the error msg. Regards, Amul
