On Sat, May 15, 2021, at 08:42, Jaime Casanova wrote:
> A customer here has 20+ GIN indexes in a big heavily used table and
> every time one of the indexes reaches gin_pending_list_limit (because of
> an insert or update) a user feels the impact.
>
> So, currently we have a cronjob running periodi
On Sat, May 15, 2021 at 08:12:51AM +0200, Joel Jacobson wrote:
> On Mon, Apr 5, 2021, at 16:47, Jaime Casanova wrote:
> > On Mon, Apr 05, 2021 at 10:41:22AM -0300, Euler Taveira wrote:
> > > On Mon, Apr 5, 2021, at 3:31 AM, Jaime Casanova wrote:
> > > > When AV worker items where introduced 4 years
Hello Andres,
It finally failed with a core on 8f72bba, in llvm_shutdown, AFAIKS in a
free while doing malloc-related housekeeping.
My guess is that there is an actual memory corruption somewhere. It is
unobvious whether it is in bleeding-edge llvm or bleeding-edge postgres
though.
The is
On Mon, Apr 5, 2021, at 16:47, Jaime Casanova wrote:
> On Mon, Apr 05, 2021 at 10:41:22AM -0300, Euler Taveira wrote:
> > On Mon, Apr 5, 2021, at 3:31 AM, Jaime Casanova wrote:
> > > When AV worker items where introduced 4 years ago, i was suggested that
> > > it could be used for other things like
On Sat, May 15, 2021 at 3:58 AM Robert Haas wrote:
>
> I did notice, but keep in mind that this was more than 8 years ago.
> Even if Heikki is reading this thread, he may not remember why he
> changed 1 line of code one way rather than another in 2013. I mean if
> he does that's great, but it's as
On Fri, May 14, 2021 at 7:10 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
>
> On Fri, May 14, 2021 at 6:51 PM vignesh C wrote:
> >
> > On Fri, May 14, 2021 at 12:25 PM Bharath Rupireddy
> > wrote:
> > >
> > > On Fri, May 14, 2021 at 12:00 PM vignesh C
wrote:
> > > >
> >
Hi Greg,
It is really weird. Could you make sure is the SnapShot overflow in you ENV?
It is very impoint.
Abount SnapShot overflow and Subtrans, you can refer this
https://www.cybertec-postgresql.com/en/subtransactions-and-performance-in-postgresql/.
In the script sub_120.sql, for one
Hi,
(Adding Andrew in CC for the buildfarm and PostgresNode parts.)
$subject has been around for a couple of years now, with the following
threads:
https://www.postgresql.org/message-id/20180126080026.gi17...@paquier.xyz
https://www.postgresql.org/message-id/cab7npqrdan1a1ynjxnl9t1juewct8ttqq29dnv
On Fri, May 14, 2021 at 07:50:13PM -0400, Alvaro Herrera wrote:
> +++ b/doc/src/sgml/config.sgml
> @@ -7643,7 +7643,12 @@ COPY postgres_log FROM '/full/path/to/logfile.csv'
> WITH csv;
> identifier to be computed. Note that an external module can
> alternatively be used if the i
On 2021-May-14, Julien Rouhaud wrote:
> On Fri, May 14, 2021 at 12:20:00PM +0900, Fujii Masao wrote:
> > +void
> > +EnableQueryId(void)
> > +{
> > + if (compute_query_id == COMPUTE_QUERY_ID_AUTO)
> > + auto_query_id_enabled = true;
> >
> > Shouldn't EnableQueryId() enable auto_query_
I wrote:
> So the question for us is whether it's worth trying to make pgreadlink
> conform to the letter of the POSIX spec in this detail. TBH, I can't
> get excited about that, at least not so far as zic's usage is concerned.
Hmmm ... on closer inspection, though, it might not be that hard.
pgr
Ranier Vilela writes:
> Per Coverity.
> CID 1412632 (#1 of 1): Out-of-bounds access (OVERRUN)1.
> overrun-buffer-val: Overrunning buffer pointed to by &c of 1 bytes by
> passing it to a function which accesses it at byte offset 4.
> For some people, Coverity opinions count zero.
This particular
On Fri, May 14, 2021 at 12:59 AM Dilip Kumar wrote:
> I am not sure that have you noticed the commit id which changed the
> definition of expectedTLEs, Heikki has committed that change so adding
> him in the list to know his opinion.
I did notice, but keep in mind that this was more than 8 years
Hi,
Per Coverity.
CID 1412632 (#1 of 1): Out-of-bounds access (OVERRUN)1.
overrun-buffer-val: Overrunning buffer pointed to by &c of 1 bytes by
passing it to a function which accesses it at byte offset 4.
For some people, Coverity opinions count zero.
Who knows for others, it helps.
It doesn't m
Alvaro Herrera writes:
> On 2021-May-14, Tom Lane wrote:
>> An idea I'd been toying with was to make invals probabilistic, that is
>> there would be X% chance of an inval being forced at any particular
>> opportunity. Then you could dial X up or down to make a tradeoff
>> between speed and the ex
Andres Freund writes:
> On 2021-05-14 16:53:16 -0400, Tom Lane wrote:
>> An idea I'd been toying with was to make invals probabilistic, that is
>> there would be X% chance of an inval being forced at any particular
>> opportunity. Then you could dial X up or down to make a tradeoff
>> between spe
On 2021-May-14, Tom Lane wrote:
> An idea I'd been toying with was to make invals probabilistic, that is
> there would be X% chance of an inval being forced at any particular
> opportunity. Then you could dial X up or down to make a tradeoff
> between speed and the extent of coverage you get from
Hi,
On 2021-05-14 16:53:16 -0400, Tom Lane wrote:
> Andres Freund writes:
> > In essence, debug_invalidate_system_caches_always=1 in some important
> > aspects
> > behaves like debug_invalidate_system_caches_always=3, due to the syscache
> > involvement.
>
> Yeah. I think it's important to tes
Andres Freund writes:
> In essence, debug_invalidate_system_caches_always=1 in some important aspects
> behaves like debug_invalidate_system_caches_always=3, due to the syscache
> involvement.
Yeah. I think it's important to test those recursive invalidation
scenarios, but it could likely be don
Alvaro Herrera writes:
> This comment made me remember a patch I've had for a while, which splits
> the CHECK_FOR_INTERRUPTS() definition in two -- one of them is
> INTERRUPTS_PENDING_CONDITION() which let us test the condition
> separately; that allows the lock we hold to be released prior to
> a
On Fri, May 14, 2021 at 03:39:39PM -0400, Tom Lane wrote:
> Bruce Momjian writes:
> > On Thu, May 13, 2021 at 09:01:41PM -0500, Justin Pryzby wrote:
> >> New SQL-accessible functionality should be included:
> >>> 8c15a29745 Allow ALTER TYPE to update an existing type's typsubscript
> >>> value.
>
Bruce Momjian writes:
> On Thu, May 13, 2021 at 09:01:41PM -0500, Justin Pryzby wrote:
>> New SQL-accessible functionality should be included:
>>> 8c15a29745 Allow ALTER TYPE to update an existing type's typsubscript value.
> OK, text is:
>
>
>
> Allow ALTER T
Stephen Frost writes:
> * Chapman Flack (c...@anastigmatix.net) wrote:
>> If pg_hba syntax changes are being entertained, I would love to be able
>> to set ssl_min_protocol_version locally in a hostssl rule.
>> Some clients at $work are stuck with ancient SSL libraries, but I would
>> much rather
Greetings,
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Andrew Dunstan writes:
> > On 5/13/21 7:38 PM, Bossart, Nathan wrote:
> >> I've attached a small patch that allows specifying only direct members
> >> of a group in pg_hba.conf.
>
> > Do we really want to be creating two classes of role members
Greetings,
* Chapman Flack (c...@anastigmatix.net) wrote:
> If pg_hba syntax changes are being entertained, I would love to be able
> to set ssl_min_protocol_version locally in a hostssl rule.
>
> Some clients at $work are stuck with ancient SSL libraries, but I would
> much rather be able to wea
pá 14. 5. 2021 v 19:28 odesílatel Bruce Momjian napsal:
> On Fri, May 14, 2021 at 12:21:23PM -0400, Bruce Momjian wrote:
> > On Fri, May 14, 2021 at 12:04:05PM -0400, Andrew Dunstan wrote:
> > > > On May 14, 2021, at 8:35 AM, Bruce Momjian wrote:
> > > >
> > > > On Thu, May 13, 2021 at 09:41:42
On Fri, May 14, 2021 at 8:56 PM Tom Lane wrote:
>
> Bharath Rupireddy writes:
> > On Fri, May 14, 2021 at 7:58 PM vignesh C wrote:
> >> I have changed it to:
> >> ADD adds additional publications,
> >> - DROP removes publications from the list of
> >> + DROP removes publications to/fro
On Fri, May 14, 2021 at 12:21:23PM -0400, Bruce Momjian wrote:
> On Fri, May 14, 2021 at 12:04:05PM -0400, Andrew Dunstan wrote:
> > > On May 14, 2021, at 8:35 AM, Bruce Momjian wrote:
> > >
> > > On Thu, May 13, 2021 at 09:41:42PM -0400, Bruce Momjian wrote:
> > > I think keeping the output as
Thanks for these corrections -- I applied them and a few minor changes
from myself, and pushed. Another set of eyes over the result would be
most welcome.
I hope we can close this now :-)
--
Álvaro Herrera39°49'30"S 73°17'W
"Those who use electric razors are infidels
On Thu, May 13, 2021 at 09:01:41PM -0500, Justin Pryzby wrote:
> On Mon, May 10, 2021 at 09:40:45AM -0500, Justin Pryzby wrote:
> > Should any of these be included?
>
> New SQL-accessible functionality should be included:
> > 8c15a29745 Allow ALTER TYPE to update an existing type's typsubscript va
On Fri, May 14, 2021 at 8:36 PM Pengchengliu wrote:
> Did you use pgbench with the script sub_120.sql which I provide in
> attachment?
yes
>
> Did you increase the number PGPROC_MAX_CACHED_SUBXIDS? Please don't change
> any codes, now we just use the origin codes in PG13.2.
>
No, I have m
pá 14. 5. 2021 v 18:21 odesílatel Bruce Momjian napsal:
> On Fri, May 14, 2021 at 12:04:05PM -0400, Andrew Dunstan wrote:
> > > On May 14, 2021, at 8:35 AM, Bruce Momjian wrote:
> > >
> > > On Thu, May 13, 2021 at 09:41:42PM -0400, Bruce Momjian wrote:
> > > I think keeping the output as 'auto'
On Fri, May 14, 2021 at 12:04:05PM -0400, Andrew Dunstan wrote:
> > On May 14, 2021, at 8:35 AM, Bruce Momjian wrote:
> >
> > On Thu, May 13, 2021 at 09:41:42PM -0400, Bruce Momjian wrote:
> > I think keeping the output as 'auto', and documenting that this query
> > must be run to determine if t
On Fri, May 14, 2021 at 12:04:05PM -0400, Andrew Dunstan wrote:
>
> > On May 14, 2021, at 8:35 AM, Bruce Momjian wrote:
> >
> > On Thu, May 13, 2021 at 09:41:42PM -0400, Bruce Momjian wrote:
> >>> On Fri, May 14, 2021 at 09:40:15AM +0800, Julien Rouhaud wrote:
> >>> On Fri, May 14, 2021 at 8:13
Sent from my iPhone
> On May 14, 2021, at 8:35 AM, Bruce Momjian wrote:
>
> On Thu, May 13, 2021 at 09:41:42PM -0400, Bruce Momjian wrote:
>>> On Fri, May 14, 2021 at 09:40:15AM +0800, Julien Rouhaud wrote:
>>> On Fri, May 14, 2021 at 8:13 AM Bruce Momjian wrote:
On Thu, May 13,
On 05/13/21 19:38, Bossart, Nathan wrote:
> I chose "&" as a new group name prefix for this purpose. This choice
If pg_hba syntax changes are being entertained, I would love to be able
to set ssl_min_protocol_version locally in a hostssl rule.
Some clients at $work are stuck with ancient SSL lib
Bharath Rupireddy writes:
> On Fri, May 14, 2021 at 7:58 PM vignesh C wrote:
>> I have changed it to:
>> ADD adds additional publications,
>> - DROP removes publications from the list of
>> + DROP removes publications to/from the list of
> How about "Publications are added to or droppe
Andrew Dunstan writes:
> On 5/13/21 7:38 PM, Bossart, Nathan wrote:
>> I've attached a small patch that allows specifying only direct members
>> of a group in pg_hba.conf.
> Do we really want to be creating two classes of role membership?
Yeah, this seems to be going against the clear meaning of
On Fri, May 14, 2021 at 7:58 PM vignesh C wrote:
> I have changed it to:
>ADD adds additional publications,
> - DROP removes publications from the list of
> + DROP removes publications to/from the list of
How about "Publications are added to or dropped from the existing list
of
On Thu, May 13, 2021 at 09:08:37PM -0500, Justin Pryzby wrote:
> On Thu, May 13, 2021 at 09:01:41PM -0500, Justin Pryzby wrote:
> > These should be merged:
> > > 756ab29124 Allow pageinspect to inspect GiST indexes (Andrey Borodin,
> > > Heikki Linnakangas)
> > > 9e596b65f4 Add "LP_DEAD item?" col
On Fri, May 14, 2021 at 7:41 AM Japin Li wrote:
>
>
> On Thu, 13 May 2021 at 22:13, vignesh C wrote:
> > On Wed, May 12, 2021 at 10:15 PM Bharath Rupireddy
> > wrote:
> >>
> >> On Wed, May 12, 2021 at 9:55 PM vignesh C wrote:
> >> > While I was reviewing one of the logical decoding features, I
On Fri, May 14, 2021 at 08:57:41AM -0400, Bruce Momjian wrote:
> On Fri, May 14, 2021 at 08:35:14AM -0400, Bruce Momjian wrote:
> > On Thu, May 13, 2021 at 09:41:42PM -0400, Bruce Momjian wrote:
> > > I think if we keep the output as 'auto', and document that you check
> > > pg_stat_activity for a
On Thu, May 13, 2021 at 8:13 PM Bharath Rupireddy
wrote:
>
> On Thu, May 13, 2021 at 7:43 PM vignesh C wrote:
> > I have separated the Drop publication documentation contents. There
> > are some duplicate contents but the readability is slightly better.
> > Thoughts?
>
> -ALTER SUBSCRIPTION name
Kyotaro Horiguchi writes:
> I'm not sure how much we (or people) are strcit on the distinction
> between the $SUBJECT, isn't '{' a brace generally?
+1. I tend to write "square bracket" or "curly brace" when I want to
be extra clear, but I think the bare terms are widely understood to
have those
Robert Haas writes:
> On Thu, May 13, 2021 at 6:20 PM Tom Lane wrote:
>> OTOH, the 10-cycles-to-show-progress rule could be
>> argued to be an API break.
> Not being familiar with this code, I don't really understand why 10
> cycles to show progress wouldn't, like 640kB, be enough for anyone.
Y
On 5/14/21 4:11 AM, Noah Misch wrote:
On Wed, Apr 14, 2021 at 10:25:08AM +0300, Ivan Ivanov wrote:
In Postgres we can create view with view owner privileges only. What’s the
reason that there is no option to create view with invoker privileges? Is
there any technical or security subtleties relat
Pavel Borisov writes:
> Now when checking for shortening of leaf tuple is added LongValuesOK
> become slightly redundant. I'd propose to replace it with more legible name
> as LongValuesOK doesn't mean they are warranted to be ok just that we can
> try to shorten them? What about tryShortening, t
On Fri, May 14, 2021 at 6:51 PM vignesh C wrote:
>
> On Fri, May 14, 2021 at 12:25 PM Bharath Rupireddy
> wrote:
> >
> > On Fri, May 14, 2021 at 12:00 PM vignesh C wrote:
> > >
> > > Hi,
> > >
> > > While I was reviewing one of the logical decoding features, I found
> > > Streaming and binary op
On Fri, May 14, 2021 at 12:25 PM Bharath Rupireddy
wrote:
>
> On Fri, May 14, 2021 at 12:00 PM vignesh C wrote:
> >
> > Hi,
> >
> > While I was reviewing one of the logical decoding features, I found
> > Streaming and binary options were missing in tab completion for the
> > alter subscription se
On Fri, May 14, 2021 at 08:35:14AM -0400, Bruce Momjian wrote:
> On Thu, May 13, 2021 at 09:41:42PM -0400, Bruce Momjian wrote:
> > I think if we keep the output as 'auto', and document that you check
> > pg_stat_activity for a hash to see if it is enabled, that gets us pretty
> > far.
>
> I think
On Thu, May 13, 2021 at 09:41:42PM -0400, Bruce Momjian wrote:
> On Fri, May 14, 2021 at 09:40:15AM +0800, Julien Rouhaud wrote:
> > On Fri, May 14, 2021 at 8:13 AM Bruce Momjian wrote:
> > >
> > > On Thu, May 13, 2021 at 08:04:37PM -0400, Álvaro Herrera wrote:
> > > > Here's a first attempt at wh
On Fri, May 14, 2021 at 10:43 AM Dilip Kumar wrote:
>
> On Thu, May 13, 2021 at 9:00 PM Bharath Rupireddy
> wrote:
> >
> > Done that way.
> >
> > PSA patch.
>
> Your changes look good. About changing the "non-negative integer" to
> "greater than or equal to zero", there is another thread [1], I
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
This patch looks fine. Tested on MacOS Catalina; master 09ae3
On Thu, May 13, 2021 at 6:20 PM Tom Lane wrote:
> OTOH, the 10-cycles-to-show-progress rule could be
> argued to be an API break.
Not being familiar with this code, I don't really understand why 10
cycles to show progress wouldn't, like 640kB, be enough for anyone.
But as far as back-patching the
On 5/13/21 7:38 PM, Bossart, Nathan wrote:
> Hi hackers,
>
> I've attached a small patch that allows specifying only direct members
> of a group in pg_hba.conf. The "+" prefix offered today matches both
> direct and indirect role members, which may complicate some role
> setups. For example, if
On Fri, May 14, 2021 at 12:26:23AM -0400, Tom Lane wrote:
> I then tried a really dumb xor'ing implementation, and
> that gives me a slowdown of 2.2%. This could undoubtedly
> be improved on further, say by unrolling the loop or
> processing multiple bytes at once. One problem with it
> is that I
On Fri, May 14, 2021 at 1:05 AM Etsuro Fujita
wrote:
> Hi,
>
> On Thu, May 13, 2021 at 2:23 AM Zhihong Yu wrote:
> > I was looking at
> > Fix EXPLAIN ANALYZE for async-capable nodes.
>
> Thanks for that!
>
> > which adds the following parameter / field:
> >
> > + boolasync_mode;
On Thu, 2021-05-13 at 09:44 +0530, Bharath Rupireddy wrote:
> I think it will be useful to allow foreign tables to be VACUUMed if
> the underlying FDW supports, currently VACUUM doesn't support foreign
> tables, see [1]. In case of postgres_fdw, if foreign tables are
> specified in the local VACUUM
Hi Greg,
When you get the different xmin between active snapshot and transaction
snapshot, maybe there is no coredump.
As maybe there is not tupe(xmin) between ActiveSnapshot->xmin and
TransactionSnapshot->xmin which needs to be scaned in parallel process.
There is no doubt, it
On Wed, Apr 07, 2021 at 10:13:30AM -0700, Richard Yen wrote:
> I noticed that in some situations involving the use of REVOKE ON SCHEMA,
> pg_dump
> can produce a dump that cannot be restored. This prevents successful
> pg_restore (and by corollary, pg_upgrade).
>
> An example shell script to recr
On Thursday, May 13, 2021 7:21 PM Amit Kapila wrote:
> On Thu, May 13, 2021 at 11:15 AM osumi.takami...@fujitsu.com
> wrote:
> >
> > I tried the following scenarios for trying to reproduce this.
> > Scenario2:
> > (1) set up 1 publisher and 1 subscriber
> > (2) create table with user_catalog_tabl
On Fri, May 14, 2021 at 12:25 PM Pengchengliu wrote:
>
> Hi Greg,
>
> Thanks for you replay and test.
>
>
>
> When main process gets the transaction snapshot in
> InitializeParallelDSM->GetTransactionSnapshot, the transaction snapshot xmin
> is very likely follows active snapshot xmin.
>
>
>
>
> Now when checking for shortening of leaf tuple is added LongValuesOK
> become slightly redundant. I'd propose to replace it with more legible name
> as LongValuesOK doesn't mean they are warranted to be ok just that we can
> try to shorten them? What about tryShortening, trySuffixing or
> ca
> > > > > So, users need to check count(*) for this to determine
> > > > > parallel-safety? How about if we provide a wrapper function on
> > > > > top of this function or a separate function that returns char to
> > > > > indicate whether it is safe, unsafe, or restricted to perform a
> > > > > DM
Now when checking for shortening of leaf tuple is added LongValuesOK
become slightly redundant. I'd propose to replace it with more legible name
as LongValuesOK doesn't mean they are warranted to be ok just that we can
try to shorten them? What about tryShortening, trySuffixing or
can(Try)ShortenT
On Wed, Apr 14, 2021 at 10:25:08AM +0300, Ivan Ivanov wrote:
> In Postgres we can create view with view owner privileges only. What’s the
> reason that there is no option to create view with invoker privileges? Is
> there any technical or security subtleties related to absence of this
> feature?
T
Hi,
On Thu, May 13, 2021 at 2:23 AM Zhihong Yu wrote:
> I was looking at
> Fix EXPLAIN ANALYZE for async-capable nodes.
Thanks for that!
> which adds the following parameter / field:
>
> + boolasync_mode; /* true if node is in async mode */
>
> async_mode implies an enum: {sync,
Takamichi-san,
On Fri, May 14, 2021 at 11:19 AM osumi.takami...@fujitsu.com
wrote:
> On Thursday, May 13, 2021 7:43 PM Amit Kapila wrote:
> > On Tue, Apr 20, 2021 at 8:36 AM Amit Langote
> > wrote:
> > > Back in:
> > https://www.postgresql.org/message-id/CA%2BHiwqEeU19iQgjN6HF1HTP
> > U0L5%2
>
On Thu, May 13, 2021 at 7:43 PM Amit Kapila wrote:
> On Tue, Apr 20, 2021 at 8:36 AM Amit Langote wrote:
> > On Sat, Apr 17, 2021 at 1:30 PM Amit Kapila wrote:
> > > On Fri, Apr 16, 2021 at 11:24 PM Andres Freund
> > > wrote:> > This made me take a brief look at pgoutput.c - maybe I am
> > >
69 matches
Mail list logo
