On 2019-12-02 17:39, Tom Lane wrote:
Robert Haas writes:
... However, it would be worth putting in some
effort to make sure that we give a good error message if this happens.
That's an excellent point, but it looks like we're pretty good
already. I tried the patch with openssl 0.9.8x, and go
Hi hackers.
I made a patch fixing build and install problems under MSYS2, including
llvmjit.
I have tested this in my environment and it works, of course need more
extensive testing.
Attached is a patch that fixes it. Tag REL_12_1.
--
Best regards.
Guram Duka.
postgresql-12.1-msys2-v1.patch
D
At Fri, 29 Nov 2019 15:51:15 +0900, Michael Paquier wrote
in
> Hi all,
>
> Since commit d6c55de1, we support %m in the in-core port for printf
> and such. And it seems to me that we could do better for the frontend
> code by reducing the dependency to strerror().
>
> One advantage of doing a
On Mon, Dec 02, 2019 at 07:55:45AM -0800, Andres Freund wrote:
> On 2019-11-29 11:11:25 +0900, Michael Paquier wrote:
>> diff --git a/src/include/c.h b/src/include/c.h
>> index 00e41ac546..91d6d50e76 100644
>> --- a/src/include/c.h
>> +++ b/src/include/c.h
>> [...]
>
> I think this a) needs an upd
On Wed, Dec 4, 2019 at 11:35 AM Michael Paquier wrote:
>
> On Tue, Dec 03, 2019 at 10:30:35AM +0900, Amit Langote wrote:
> > How about adding a function, say print_progress_to_stderr(const char
> > *fmt,...), exposed to the front-end utilities and use it from
> > everywhere? Needless to say that i
On Tue, Dec 03, 2019 at 09:35:00AM -0300, Alvaro Herrera wrote:
> You didn't attach anything, but I concur about the low probability
> aspect: the assertion failure does not occur in production builds
> (obviously); and only an out-of-memory situation is a real problem
> when
> an fsync fails. Any
Hello.
At Tue, 3 Dec 2019 18:01:28 +0300, Konstantin Knizhnik
wrote in
> Hi hackers,
>
> One of our customers complains about that some sessions generates "too
> much WAL records".
> Certainly WAL activity doesn't indicate a problem itself: huge
> workload cause huge WAL activity.
> But them a
Greetings,
* Andrew Gierth (and...@tao11.riddles.org.uk) wrote:
> > "Peter" == Peter Eisentraut writes:
>
> >> It seems to me that this is a bug in ProcessStartupPacket, which
> >> should accept both GSS or SSL negotiation requests on a connection
> >> (in either order). Maybe secure_done
Amit Kapila writes:
> On Tue, Dec 3, 2019 at 10:10 PM Tom Lane wrote:
>> Hmm ... just looking at the code again, could it be that there's
>> no well-placed CHECK_FOR_INTERRUPTS? Andrew, could you see if
>> injecting one in what 790026972 added to postgres.c helps?
> I also tried to analyze this
On Tue, Dec 3, 2019 at 10:10 PM Tom Lane wrote:
>
> In principle, the issue should not be there, because commits
> 790026972 et al should have ensured that the NOTIFY protocol
> message comes out before ReadyForQuery (and thus, libpq will
> absorb it before PQgetResult will return NULL). I think
On Tue, Dec 03, 2019 at 11:24:57AM -0500, Tom Lane wrote:
> So it seems that the problem might really be a faulty rule in our
> MSVC build script about when postgres.def needs to be regenerated?
> Or else it's some weird caching problem on drongo --- the lack of
> complaints from other Windows crit
Greetings,
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Jobin Augustine writes:
> > However, Checking whether the port is open is resulting in error log like:
> > 2019-11-25 14:03:44.414 IST [14475] LOG: invalid length of startup packet
> > Yes, This is different from "Incomplete startup packet" dis
On Wed, Dec 4, 2019 at 9:12 AM Amit Kapila wrote:
>
> On Wed, Dec 4, 2019 at 1:58 AM Masahiko Sawada
> wrote:
> >
> > On Tue, 3 Dec 2019 at 11:55, Amit Kapila wrote:
> > >
> > In your code, I think if two workers enter to compute_parallel_delay
> > function at the same time, they add their local
On Wed, Dec 4, 2019 at 1:58 AM Masahiko Sawada
wrote:
>
> On Tue, 3 Dec 2019 at 11:55, Amit Kapila wrote:
> >
> In your code, I think if two workers enter to compute_parallel_delay
> function at the same time, they add their local balance to
> VacuumSharedCostBalance and both workers sleep becaus
On 2019/12/01 23:58, Grigory Smolkin wrote:
On 11/29/19 11:07 AM, Artur Zakirov wrote:
New version of the patch differs from the previous:
- it doesn't generate script to revoke conflicting permissions (but
the patch can be fixed easily)
- generates file incompatible_objects_for_acl.txt to repo
On Tue, Dec 03, 2019 at 10:30:35AM +0900, Amit Langote wrote:
> How about adding a function, say print_progress_to_stderr(const char
> *fmt,...), exposed to the front-end utilities and use it from
> everywhere? Needless to say that it will contain the check for whether
> stderr points to terminal o
Hi,
I believe PostgreSQL can benefit from changing the alert level of compilation
warnings.
The current Level3 level for windows does not show any alerts, but that does
not mean that there are no problems.
Changing the level to Level4 and its equivalent for GCC in Unix environments
will show man
On Tue, Dec 03, 2019 at 01:11:27PM +0100, Fabien COELHO wrote:
> Looks fine to me: patch applies, compiles, runs.
Thanks for double-checking. Done.
--
Michael
signature.asc
Description: PGP signature
On Tue, Dec 03, 2019 at 10:07:08AM -0500, Tom Lane wrote:
> As a point of reference, I have
>
> $ cat ~/.gitexclude
> *~
> *.orig
>
> to suppress emacs backup files and patch backup files respectively.
> Somebody who prefers another editor would have no use for *~.
Here are extra entries I use
> "Peter" == Peter Eisentraut writes:
>> It seems to me that this is a bug in ProcessStartupPacket, which
>> should accept both GSS or SSL negotiation requests on a connection
>> (in either order). Maybe secure_done should be two flags rather than
>> one?
Peter> I have also seen reports
Alvaro Herrera writes:
> On 2019-Jul-30, Tom Lane wrote:
>> The portion of this below the Append is fine, but I argue that
>> the Vars above the Append should say "part", not "part_p1".
>> In that way they'd look the same regardless of which partitions
>> have been pruned or not.
> So is anyone w
> On 1 Dec 2019, at 03:32, Michael Paquier wrote:
> The latest patch does not apply, could you send a rebase? Moved it to
> next CF, waiting on author.
Attached is a rebased v14 patchset on top of maser. The Global Barriers patch
is left as a prerequisite, but it will obviously be dropped, or
On 2019-Dec-03, Alvaro Herrera wrote:
> Now, I have to say that this doesn't make me terribly happy, because I
> would like the additional ability to limit the printed values to N
> bytes. This means the new function would have to have an additional
> argument to indicate the maximum length (pass
Hi,
Attached is doc_base64_v11.patch
This addresses Tom's concerns. Functions
that operate on both strings and bytea
(e.g. length(text) and length(bytea))
are documented separately, one with
string functions and one with binary
string functions.
In this iteration I have also:
Added a sub-secti
Hi,
On 2019-11-27 16:10:20 +0300, Konstantin Knizhnik wrote:
> On 27.11.2019 15:12, Rafia Sabih wrote:
> > On Wed, 27 Nov 2019 at 12:33, Konstantin Knizhnik
> > mailto:k.knizh...@postgrespro.ru>> wrote:
> >
> > Hi hackers,
> >
> > I wonder how it is possible to prohibit parallel scan for
Hi,
On 2019-11-27 14:33:42 +0300, Konstantin Knizhnik wrote:
> I wonder how it is possible to prohibit parallel scan for the external
> storage accessed through tableam?
> For example if I want to implement specialized tableam for fast access to
> temp tables, how can I inform optimizer that
> par
On Tue, 3 Dec 2019 at 07:09, Michael Paquier wrote:
>
> On Mon, Dec 02, 2019 at 10:14:58PM +0100, Masahiko Sawada wrote:
> > Agreed. I've attached the updated version patch. Please review it.
>
> Thanks, applied on HEAD after a few edits. gettext() does not set
> errno, so the new style of issue_
On Tue, 3 Dec 2019 at 11:57, Amit Kapila wrote:
>
> On Tue, Dec 3, 2019 at 4:25 PM Amit Kapila wrote:
>>
>> Few other things, I would like you to consider.
>> 1. I think disable_parallel_leader_participation related code can be
>> extracted into a separate patch as it is mainly a debug/test aid
On Tue, Dec 3, 2019 at 6:18 PM Tom Lane wrote:
> Alexander Korotkov writes:
> > But nevertheless should we allow relocatable extension to use
> > @extschema@. Any thoughts?
>
> No. The reasoning in the comment still holds good: if you embed
> @extschema@ in an object's definition, it becomes no
On Tue, 3 Dec 2019 at 11:55, Amit Kapila wrote:
>
> On Tue, Dec 3, 2019 at 12:56 AM Masahiko Sawada
> wrote:
>>
>> On Sun, 1 Dec 2019 at 18:31, Sergei Kornilov wrote:
>> >
>> > Hi
>> >
>> > > I think I got your point. Your proposal is that it's more efficient if
>> > > we make the leader proces
On Tue, Nov 12, 2019 at 3:21 PM Peter Geoghegan wrote:
> * Decided to go back to turning deduplication on by default with
> non-unique indexes, and off by default using unique indexes.
>
> The unique index stuff was regressed enough with INSERT-heavy
> workloads that I was put off, despite my init
Got it, and that makes sense.
I hereby withdraw this patch. ;)
- David
> On Dec 3, 2019, at 10:08, Tom Lane wrote:
>
> Daniel Gustafsson writes:
On 3 Dec 2019, at 15:47, David Nedrow wrote:
>>> This patch simply adds “.idea/“ to the list of global excludes across all
>>> subdirectorie
Responding to the recent thread on bumping the default TLS version, I realized
that we don't have a way to set the minimum/maximum TLS protocol version in
clientside libpq. Setting the maximum protocol version obviously not terribly
important (possibly with the exception of misbehaving middle-boxe
Etsuro Fujita writes:
> On Tue, Dec 3, 2019 at 6:45 AM Tom Lane wrote:
>> Concretely, I'm thinking of the attached (on top of the other patch,
>> which I just pushed). This agrees exactly with what ExplainTargetRel
>> does for regular scans.
> Thanks for the patch! (The patch didn't apply to H
Mark Dilger writes:
> On 12/2/19 11:42 AM, Andrew Dunstan wrote:
>> On 12/2/19 11:23 AM, Tom Lane wrote:
>>> I'm a little baffled as to what this might be --- some sort of
>>> timing problem in our Windows signal emulation, perhaps? But
>>> if so, why haven't we found it years ago?
> I would be
I wrote:
> Also, buildfarm member drongo is not happy:
> postgres.def : error LNK2001: unresolved external symbol XLogFileNameP
> [C:\prog\bf\root\HEAD\pgsql.build\postgres.vcxproj]
> Release/postgres/postgres.lib : fatal error LNK1120: 1 unresolved externals
> [C:\prog\bf\root\HEAD\pgsql.build\p
Attached v4.
Patch applies cleanly, compiles, works for me. Put it back to ready.
--
Fabien.
Alvaro Herrera writes:
> I'm not sure that the internationalization stuff in issue_xlog_fsync is
> correct. I think the _() should be gettext_noop(), or alternatively the
> errmsg() should be errmsg_internal(); otherwise the translation is
> invoked twice. (I didn't verify this.)
Also, buildfar
On 2019-Sep-20, Andres Freund wrote:
> > > > + appendStringInfoCharMacro(¶m_str, '\'');
> > > > + for (p = pstring; *p; p++)
> > > > + {
> > > > + if (*p == '\'') /* double single quotes */
> > > > + appe
Alexander Korotkov writes:
> But nevertheless should we allow relocatable extension to use
> @extschema@. Any thoughts?
No. The reasoning in the comment still holds good: if you embed
@extschema@ in an object's definition, it becomes nonrelocatable.
regards, tom lane
On 12/2/19 11:42 AM, Andrew Dunstan wrote:
On 12/2/19 11:23 AM, Tom Lane wrote:
I see from the buildfarm status page that since commits 6b802cfc7
et al went in a week ago, frogmouth and currawong have failed that
new test case every time, with the symptom
== pgsql.build/src/
Daniel Gustafsson writes:
>> On 3 Dec 2019, at 15:47, David Nedrow wrote:
>> This patch simply adds “.idea/“ to the list of global excludes across all
>> subdirectories. This directory is created when a JetBrains IDE is used to
>> open a project. In my specific case, Clion is creating the proje
Hi hackers,
One of our customers complains about that some sessions generates "too
much WAL records".
Certainly WAL activity doesn't indicate a problem itself: huge workload
cause huge WAL activity.
But them are trying to understand which clients produces so much
database changes and complain
> On 3 Dec 2019, at 15:56, David Nedrow wrote:
> Hmmm. I can see that. However, there are already entries for Microsoft Visual
> C++ at the global level. Wouldn’t this fall into the same category?
Not really, the files in the current .gitignore are artifacts of the build-
system which is provi
> On 3 Dec 2019, at 15:47, David Nedrow wrote:
> This patch simply adds “.idea/“ to the list of global excludes across all
> subdirectories. This directory is created when a JetBrains IDE is used to
> open a project. In my specific case, Clion is creating the project directory.
>
> The ONLY ch
This patch simply adds “.idea/“ to the list of global excludes across all
subdirectories. This directory is created when a JetBrains IDE is used to open
a project. In my specific case, Clion is creating the project directory.
The ONLY change in the patch is the “.idea/“ addition to .gitignore.
Greetings,
* Craig Ringer (cr...@2ndquadrant.com) wrote:
> On Mon, 4 Nov 2019 at 12:20, Stephen Frost wrote:
> > I've long felt that the way to handle this kind of requirement is to
> > have a "trusted remote server" kind of option- where the local server
> > authenticates to the remote server as
Hello,
While going through this file I noticed some inconsistencies in the
comments. Please find attachment for the fix.
--
Regards,
Rafia Sabih
diff --git a/src/include/executor/instrument.h b/src/include/executor/instrument.h
index 70d8632305..13aaf05453 100644
--- a/src/include/executor/instr
On 2019-Dec-03, Michael Paquier wrote:
> Per the low probability of the failures, I did not backpatch that
> stuff. I quickly looked at applying that further down, and attached
> is a version for v12 FWIW, and I suspect much more conflicts the more
> you go down (wal segment size added in 11, dif
Bonjour Michaël,
Committed the patch after splitting things into two commits and after
testing things from Linux and from a Windows console: the actual
refactoring and the pgbench changes.
I have found that we have a useless declaration of CancelRequested in
common.h, which is already part
Hi!
During work on knn-btree patchset we've faced the need to move
functions/operators from contrib to core [1]. In the extension
upgrade script we need to use @extschema@ in order to distinguish
contrib and core objects. However, it appears to be possible to use
@extschema@ only in non-relocata
On Tue, 3 Dec 2019 at 16:27, Amit Kapila wrote:
> On Tue, Dec 3, 2019 at 4:25 PM Amit Kapila
> wrote:
>
>> Few other things, I would like you to consider.
>> 1. I think disable_parallel_leader_participation related code can be
>> extracted into a separate patch as it is mainly a debug/test aid.
Hello.
At Thu, 28 Nov 2019 17:23:19 -0500, Noah Misch wrote in
> On Thu, Nov 28, 2019 at 09:35:08PM +0900, Kyotaro Horiguchi wrote:
> > I measured the performance with the latest patch set.
> >
> > > 1. Determine $DDL_COUNT, a number of DDL transactions that take about one
> > >minute when
On Tue, Dec 3, 2019 at 12:09 PM Michael Paquier wrote:
> On Tue, Dec 03, 2019 at 10:10:57AM +0100, Magnus Hagander wrote:
> > Is 1.0.1 considered a separate major from 1.0.0, in this reasoning?
> Because
> > while retiring 1.0.0 should probably not be that terrible, 1.0.1 is still
> > in very wid
On Tue, Dec 03, 2019 at 10:10:57AM +0100, Magnus Hagander wrote:
> Is 1.0.1 considered a separate major from 1.0.0, in this reasoning? Because
> while retiring 1.0.0 should probably not be that terrible, 1.0.1 is still
> in very widespread use on most long term supported distributions.
1.0.1 and 1
Hi Hackers,
I hit an error when updating a view with conditional INSTEAD OF rules, the
reproduce steps are list below:
CREATE TABLE t1(a int, b int);
CREATE TABLE t2(a int, b int);
CREATE VIEW v1 AS SELECT * FROM t1 where b > 100;
INSERT INTO v1 values(1, 110);
SELECT * FROM t1;
CREATE OR R
On Tue, Nov 26, 2019 at 10:32 PM Tom Lane wrote:
> I haven't looked closely at what ecpg does with the processed
> identifiers. If it just spits them out as-is, a possible solution
> is to not do anything about de-escaping, but pass the sequence
> U&"..." (plus UESCAPE ... if any), just like tha
On Tue, Dec 3, 2019 at 4:25 PM Amit Kapila wrote:
> Few other things, I would like you to consider.
> 1. I think disable_parallel_leader_participation related code can be
> extracted into a separate patch as it is mainly a debug/test aid. You can
> also fix the problem reported by Mahendra in t
On Mon, Dec 02, 2019 at 11:54:02AM +0900, Michael Paquier wrote:
> Committed the patch after splitting things into two commits and after
> testing things from Linux and from a Windows console: the actual
> refactoring and the pgbench changes.
I have found that we have a useless declaration of Canc
On 02.12.2019 4:15, Hubert Zhang wrote:
The prototype extension is at https://github.com/zhangh43/vectorize_engine
I am very sorry, that I have no followed this link.
Few questions concerning your design decisions:
1. Will it be more efficient to use native arrays in vtype instead of
array
On Sun, Dec 1, 2019 at 4:32 PM Michael Paquier wrote:
>
> On Fri, Nov 22, 2019 at 12:24:15PM +1300, Gareth Palmer wrote:
> > Attached is an updated patch with for_locking_clause added, test-cases
> > re-use existing tables and the comments and documentation have been
> > expanded.
>
> Per the auto
On 01.12.2019 5:57, Michael Paquier wrote:
On Thu, Sep 26, 2019 at 03:08:22PM +0300, Alexey Kondratov wrote:
As Alvaro correctly pointed in the nearby thread [1], we've got an
interference regarding -R command line argument. I agree that it's a good
idea to reserve -R for recovery configuration
On Tue, Dec 3, 2019 at 4:53 AM Michael Paquier wrote:
> On Mon, Dec 02, 2019 at 12:51:26PM -0500, Tom Lane wrote:
> > Yah. Although, looking at the code in be-secure-openssl.c,
> > it doesn't look that hard to do in an extensible way.
> > Something like (untested)
>
> While we are on the topic..
On Tue, Dec 3, 2019 at 12:55 PM tushar
wrote:
> On 11/27/19 11:13 PM, Masahiko Sawada wrote:
> > Thank you for reviewing this patch. All changes you made looks good to
> me.
> >
> > I thought I already have posted all v34 patches but didn't, sorry. So
> > I've attached v35 patch set that incorpor
On Mon, Dec 2, 2019 at 2:00 PM Robert Haas wrote:
>
> ALTER INDEX idx_name DEPENDS ON COLLATION blah VERSION blah;
> -- I care about collations and I know which one and which version.
>
> ALTER INDEX idx_name DEPENDS ON SOME COLLATION;
> -- I care about collations but I don't know which one.
This
65 matches
Mail list logo
