Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > I'm not sure that the internationalization stuff in issue_xlog_fsync is > correct. I think the _() should be gettext_noop(), or alternatively the > errmsg() should be errmsg_internal(); otherwise the translation is > invoked twice. (I didn't verify this.)
Also, buildfarm member drongo is not happy: postgres.def : error LNK2001: unresolved external symbol XLogFileNameP [C:\prog\bf\root\HEAD\pgsql.build\postgres.vcxproj] Release/postgres/postgres.lib : fatal error LNK1120: 1 unresolved externals [C:\prog\bf\root\HEAD\pgsql.build\postgres.vcxproj] I'm guessing you missed a reference someplace. regards, tom lane