On Thu, 22 Aug 2019 at 15:05, Wang, Shenhao wrote:
>
> Hello, hackers:
>
> I created a patch about tab completion for command CREATE OR REPLACE in psql
> includes:
> CREATE [ OR REPLACE ] FUNCTION
> CREATE [ OR REPLACE ] PROCEDURE
> CREATE [ OR REPLACE ] LANGUAGE
>
Hello, hackers:
I created a patch about tab completion for command CREATE OR REPLACE in psql
includes:
CREATE [ OR REPLACE ] FUNCTION
CREATE [ OR REPLACE ] PROCEDURE
CREATE [ OR REPLACE ] LANGUAGE
CREATE [ OR REPLACE ] RULE name AS ON event
CREATE [ OR REPLA
On Tue, Aug 20, 2019 at 10:33 PM Jeff Davis wrote:
> > Is there any historical discussion around
> > typemods on range types?
>
> I did find a few references:
Thanks for looking those up! It's very interesting to see some of the
original discussion around range types.
Btw this is true of so much
Hello.
At Wed, 21 Aug 2019 18:06:52 +0300, Konstantin Knizhnik
wrote in
<968fc591-51d3-fd74-8a55-40aa770ba...@postgrespro.ru>
> Ok, you convinced me that there are cases when people want to combine
> logical replication with streaming replication without slot.
> But is it acceptable to have GUC
On Thu, Aug 22, 2019 at 12:36:10AM +0900, Masahiko Sawada wrote:
> I will update the patch and register to the next Commit Fest tomorrow
> if nobody is interested in.
Thanks, Sawada-san.
--
Michael
signature.asc
Description: PGP signature
On Thu, Aug 22, 2019 at 10:24 AM Andres Freund wrote:
>
> Hi,
>
> On 2019-08-22 10:19:04 +0530, Dilip Kumar wrote:
> > On Thu, Aug 22, 2019 at 9:58 AM Andres Freund wrote:
> > >
> > > Hi,
> > >
> > > On 2019-08-22 09:51:22 +0530, Dilip Kumar wrote:
> > > > We can not know the complete size of the
On Thu, Aug 22, 2019 at 9:58 AM Andres Freund wrote:
>
> Hi,
>
> On 2019-08-22 09:51:22 +0530, Dilip Kumar wrote:
> > We can not know the complete size of the record even by reading the
> > header because we have a payload that is variable part and payload
> > length are stored in the payload head
Hi,
On 2019-08-22 10:19:04 +0530, Dilip Kumar wrote:
> On Thu, Aug 22, 2019 at 9:58 AM Andres Freund wrote:
> >
> > Hi,
> >
> > On 2019-08-22 09:51:22 +0530, Dilip Kumar wrote:
> > > We can not know the complete size of the record even by reading the
> > > header because we have a payload that is
Hi,
On 2019-08-22 09:51:22 +0530, Dilip Kumar wrote:
> We can not know the complete size of the record even by reading the
> header because we have a payload that is variable part and payload
> length are stored in the payload header which again can be at random
> offset.
Wait, but that's just pu
On Wed, Aug 21, 2019 at 9:04 PM Robert Haas wrote:
>
> On Wed, Aug 21, 2019 at 3:55 AM Dilip Kumar wrote:
> > I have already attempted that part and I feel it is not making code
> > any simpler than what we have today. For packing, it's fine because I
> > can process all the member once and dire
On Wed, Aug 21, 2019 at 04:32:38PM +0900, Kyotaro Horiguchi wrote:
> At Mon, 19 Aug 2019 18:59:59 +0900 (Tokyo Standard Time), Kyotaro Horiguchi
> wrote in
> <20190819.185959.118543656.horikyota@gmail.com>
> > At Sat, 17 Aug 2019 20:52:30 -0700, Noah Misch wrote in
> > <20190818035230.gb30
On Wed, Aug 21, 2019 at 12:25:22PM -0400, Stephen Frost wrote:
> That'd be the kind of thing that I was really hoping we could provide a
> common library for.
Indeed. There could be many use cases for that. Most of the parsing
logic is in guc-file.l. There is little dependency to elog() and
the
On Wed, Aug 07, 2019 at 03:17:02PM +0300, Heikki Linnakangas wrote:
> On 07/08/2019 14:42, Thomas Munro wrote:
>> I think I'd put nowait and skip locked under a separate category "FOR
>> UPDATE" or "row locking" or something, but maybe that's just me... can
>> you call that stuff DML?
>
> Yeah, I
On Thu, Aug 22, 2019 at 12:10 AM Binguo Bao wrote:
> [v9 patch]
Thanks, looks good. I'm setting it to ready for committer.
--
John Naylorhttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Wed, Aug 21, 2019 at 11:07:19AM -0700, Melanie Plageman wrote:
> So, I think I completely misunderstood the purpose of 'dry-run'. If no
> one is using it, having a check for unused steps in dry-run may not be
> useful.
Okay. After sleeping on it and seeing how this thread evolves, it
looks tha
Hello.
At Wed, 21 Aug 2019 19:41:08 +0300, Konstantin Knizhnik
wrote in
> Hi, hackers.
>
> One of our customers complains about slow execution of PL/pgSQL
> functions comparing with Oracle.
> So he wants to compile PL/pgSQL functions (most likely just-in-time
> compilation).
> Certainly inter
Thank you for the suggestion, Heikki.
At Mon, 29 Jul 2019 22:39:57 +0300, Heikki Linnakangas wrote
in
> On 12/07/2019 10:10, Kyotaro Horiguchi wrote:
> >> Just FYI, to me this doesn't clearly enough look like an improvement,
> >> for a change of this size.
> > Thanks for the opiniton. I kinda a
From: Konstantin Knizhnik [mailto:k.knizh...@postgrespro.ru]
> PL/pgSQL: 29044.361 ms
> C/SPI: 22785.597 ms
>
> The fact that difference between PL/pgSQL and function implemented in C
> using SPI is not so large was expected by me.
This PL/pgSQL overhead is not so significant compared
Hi,
A comment in tqueue.c says that the bytes return by shm_mq_receive()
"had better be sufficiently aligned", before assigning the pointer to
htup.t_data. Then it copies htup and returns the copy (and it did so
in the earlier version that had all the remapping stuff, too, but
sometimes it deform
Hello,
After rereading some old papers recently, I wanted to share some
thoughts about XPRS and modern PostgreSQL. XPRS stood for "eXtended
Postgres on RAID and Sprite", and was a research project done nearly
three decades ago at Berkeley by the POSTGRES group working with
operating system resear
On Wed, Aug 7, 2019 at 1:47 PM Melanie Plageman
wrote:
>
>
> On Wed, Jul 24, 2019 at 11:48 AM Andres Freund wrote:
>
>> > diff --git a/src/test/isolation/specs/insert-conflict-specconflict.spec
>> b/src/test/isolation/specs/insert-conflict-specconflict.spec
>> > index 3a70484fc2..7f29fb9d02 1006
On Wed, Aug 14, 2019 at 2:57 AM Andres Freund wrote:
> - My reading of the current xact.c integration is that it's not workable
> as is. Undo is executed outside of a valid transaction state,
> exceptions aren't properly undone, logic would need to be duplicated
> to a significant degree, ne
Sergei Kornilov writes:
> I noticed appveyor build on windows is not happy:
>> perl buildsetup.pl
>> Could not determine contrib module type for alter_table
>> at buildsetup.pl line 38.
> But I have no idea why. I can't check on windows. Possible I miss some change
> while adding new module to t
Andrew Dunstan writes:
> What I have done quickly is to store a measure of the clock skew. We
> already calculated it but we didn't store it. Initial indications are
> that only a few have significant skew.
Oh, I didn't know that the server had the ability to measure that.
(Yes, I agree that the
On 2019-08-20 16:07, Tom Lane wrote:
> Peter Eisentraut writes:
>> I noticed that configure is still looking for crypt() and crypt.h.
>> Isn't that long obsolete?
>> If so, I suggest to remove it with the attached patch.
>
> +1
done
--
Peter Eisentraut http://www.2ndQuadrant.com/
Hello
I noticed appveyor build on windows is not happy:
> perl buildsetup.pl
> Could not determine contrib module type for alter_table
> at buildsetup.pl line 38.
But I have no idea why. I can't check on windows. Possible I miss some change
while adding new module to tree. Will check. Please l
On Tue, Aug 20, 2019 at 04:38:18PM +0300, Anastasia Lubennikova wrote:
> > Solving this in pg_upgrade does seem like it's probably the better
> > approach rather than trying to do it in pg_dump. Unfortunately, that
> > likely means that all we can do is have pg_upgrade point out to the user
> > wh
On 8/21/19 11:07 AM, Andrew Dunstan wrote:
> On 8/21/19 9:55 AM, Tom Lane wrote:
>> The real problem with that column though is that it relies on run start
>> times that are self-reported by the buildfarm clients, and some of them
>> have system clocks that are many hours off reality. What *I'd*
We've repeatedly kicked around the idea of getting rid of the
pg_pltemplate catalog in favor of keeping that information directly in
the languages' extension files [1][2][3][4]. The primary abstract
argument for that is that it removes a way in which our in-tree PLs
are special compared to out-of-
On 2019-Aug-21, Melanie Plageman wrote:
> In Greenplum, we mainly add new tests to a separate isolation
> framework (called isolation2) which uses a completely different
> syntax. It doesn't use isolationtester at all. So, I haven't had a use
> case to add long options to isolationtester yet :)
I
On Tue, Aug 20, 2019 at 6:34 PM Michael Paquier wrote:
> On Tue, Aug 20, 2019 at 09:54:56AM -0400, Alvaro Herrera wrote:
> > On 2019-Aug-20, Tom Lane wrote:
> >> If you can warn in both cases, that'd be OK perhaps. But Alvaro's
> >> description of the intended use of dry-run makes it sound like
On Mon, Aug 19, 2019 at 7:01 PM Michael Paquier wrote:
>
> It is rather a pain to pass down custom options to isolationtester.
> For example, I have tested the updated version attached after
> hijacking -n into isolation_start_test(). Ugly hack, but for testing
> that's enough. Do you make use
On August 21, 2019 8:36:34 AM PDT, Robert Haas wrote:
> We treat LWLockAcquire() as a no-fail operation in many
>places; in my opinion, that elog(ERROR) that we have for too many
>LWLocks should be changed to elog(PANIC) precisely because we do treat
>LWLockAcquire() as no-fail in lots of place
20.08.2019 4:04, Peter Geoghegan wrote:
On Fri, Aug 16, 2019 at 8:56 AM Anastasia Lubennikova
wrote:
It seems that now all replace operations are crash-safe. The new patch passes
all regression tests, so I think it's ready for review again.
I'm looking at it now. I'm going to spend a signific
John Naylor 于2019年8月19日周一 下午12:55写道:
> init_toast_buffer():
>
> + * Note the constrain buf->position <= buf->limit may be broken
> + * at initialization. Make sure that the constrain is satisfied
> + * when consume chars.
>
> s/constrain/constraint/ (2 times)
> s/consume/consuming/
>
> Also, this
Hi, hackers.
One of our customers complains about slow execution of PL/pgSQL
functions comparing with Oracle.
So he wants to compile PL/pgSQL functions (most likely just-in-time
compilation).
Certainly interpreter adds quite large overhead comparing with native
code (~10 times) but
most of PL/
Greetings,
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> +
> + External tools may also
> + modify postgresql.auto.conf. It is not
> + recommended to do this while the server is running, since a
> + concurrent ALTER SYSTEM command could overwrite
> + such changes. Such tools mi
On Wed, Aug 21, 2019 at 3:55 AM Dilip Kumar wrote:
> I have already attempted that part and I feel it is not making code
> any simpler than what we have today. For packing, it's fine because I
> can process all the member once and directly pack it into one memory
> chunk and I can insert that to
On Thu, Aug 22, 2019 at 12:19 AM Alvaro Herrera
wrote:
>
> Can I interest someone into updating this patch? We now have (I think)
> an agreed design, and I think the development work needed should be
> straightforward. We also already have the popcount stuff, so that's a
> few lines to be remove
On Wed, Aug 21, 2019 at 6:38 AM Amit Kapila wrote:
> > FWIW, although I also thought of doing what you are describing here, I
> > think Andres's proposal is probably preferable, because it's simpler.
> > There's not really any reason why we can't take the buffer locks from
> > within the critical
Can I interest someone into updating this patch? We now have (I think)
an agreed design, and I think the development work needed should be
straightforward. We also already have the popcount stuff, so that's a
few lines to be removed from the patch ...
--
Álvaro Herrerahttps://ww
On 8/21/19 3:40 AM, Peter Eisentraut wrote:
> I find the time displays like
>
> 01:03 ago
>
> on the buildfarm status page unhelpful.
>
> First, I can never tell whether this is hours-minutes or minutes-seconds
> -- there is probably a less ambiguous format available.
This is hours:minutes
On 8/21/19 9:55 AM, Tom Lane wrote:
>
> The real problem with that column though is that it relies on run start
> times that are self-reported by the buildfarm clients, and some of them
> have system clocks that are many hours off reality. What *I'd* like to
> see is for the column to contain ti
On 21.08.2019 14:45, Bernd Helmle wrote:
Am Mittwoch, den 21.08.2019, 13:26 +0300 schrieb Konstantin Knizhnik:
Yes, it is possible to have physical replica withotu replication
slot.
But it is not safe, because there is always a risk that lag between
master and replica becomes larger than size
On 8/21/19 8:32 AM, Dagfinn Ilmari Mannsåker wrote:
> Magnus Hagander writes:
>
>> On Wed, Aug 21, 2019 at 9:40 AM Peter Eisentraut <
>> peter.eisentr...@2ndquadrant.com> wrote:
>>
>>> I find the time displays like
>>>
>>> 01:03 ago
>>>
>>> on the buildfarm status page unhelpful.
>>>
>>> Fir
Hello. New version is attached.
At Mon, 19 Aug 2019 18:59:59 +0900 (Tokyo Standard Time), Kyotaro Horiguchi
wrote in
<20190819.185959.118543656.horikyota@gmail.com>
> Thank you for taking time.
>
> At Sat, 17 Aug 2019 20:52:30 -0700, Noah Misch wrote in
> <20190818035230.gb3021...@rfd.le
Magnus Hagander writes:
> On Wed, Aug 21, 2019 at 9:40 AM Peter Eisentraut <
> peter.eisentr...@2ndquadrant.com> wrote:
>> I find the time displays like
>> 01:03 ago
>> on the buildfarm status page unhelpful.
>>
>> I notice that the page source actually includes absolute times that are
>> then co
Peter Eisentraut writes:
> On 2019-06-19 19:04, Dagfinn Ilmari Mannsåker wrote:
>> There were some more master/slave references in the plpgsql foreign key
>> tests, which the attached chages to base/leaf instead.
>
> base/leaf doesn't sound like a good pair. I committed it with root/leaf
> inste
Hi Hackers,
I have been looking into adding parallel backup feature in pg_basebackup.
Currently pg_basebackup sends BASE_BACKUP command for taking full backup,
server scans the PGDATA and sends the files to pg_basebackup. In general,
server takes the following steps on BASE_BACKUP command:
- do p
given the following example:
postgres=# create table t2 as select generate_series(1, 10) as a,
generate_series(1, 10) as b;
SELECT 10
postgres=# create index t2_idx on t2(a);
CREATE INDEX
postgres=# set enable_seqscan = 0;
SET
postgres=# select * from t2 where a in (1, 10);
a
Magnus Hagander writes:
> On Wed, Aug 21, 2019 at 9:40 AM Peter Eisentraut <
> peter.eisentr...@2ndquadrant.com> wrote:
>
>> I find the time displays like
>>
>> 01:03 ago
>>
>> on the buildfarm status page unhelpful.
>>
>> First, I can never tell whether this is hours-minutes or minutes-secon
Am Mittwoch, den 21.08.2019, 13:26 +0300 schrieb Konstantin Knizhnik:
> Yes, it is possible to have physical replica withotu replication
> slot.
> But it is not safe, because there is always a risk that lag between
> master and replica becomes larger than size of WAL kept at master.
Sure, but tha
Hello
> Also I can't believe that DBA which explicitly sets wal_level is set to
> logical will use streaming replication without associated replication slot.
I am.
> Yes, it is possible to have physical replica withotu replication slot.
> But it is not safe, because there is always a risk that
On Tue, Aug 20, 2019 at 8:10 PM Robert Haas wrote:
>
> On Tue, Aug 20, 2019 at 2:42 AM Amit Kapila wrote:
> > > Well, my main point, which so far has largely been ignored, was that we
> > > may not acquire page locks when we still need to search for victim
> > > buffers later. If we don't need to
On 21.08.2019 12:34, Bernd Helmle wrote:
Am Mittwoch, den 21.08.2019, 12:20 +0300 schrieb Konstantin Knizhnik:
I wonder if we can check that
1. wal_revel is "logical"
2. There are no physical replication slots
3. WAL archiving is disables
Not sure i get that correctly, i can still have a ph
On 2019-06-19 19:04, Dagfinn Ilmari Mannsåker wrote:
> There were some more master/slave references in the plpgsql foreign key
> tests, which the attached chages to base/leaf instead.
base/leaf doesn't sound like a good pair. I committed it with root/leaf
instead.
--
Peter Eisentraut
Am Mittwoch, den 21.08.2019, 12:20 +0300 schrieb Konstantin Knizhnik:
> I wonder if we can check that
>
> 1. wal_revel is "logical"
> 2. There are no physical replication slots
> 3. WAL archiving is disables
Not sure i get that correctly, i can still have a physical standby
without replication sl
Hi, hackers.
Right now if replication level is rgeater or equal than "replica",
vacuum of relation copies all its data to WAL:
/*
* We need to log the copied data in WAL iff WAL archiving/streaming is
* enabled AND it's a WAL-logged rel.
*/
use_wal = XLogIsNeeded() &&
On 20.08.2019 20:01, Pavel Stehule wrote:
Another solution is wait on ZHeap storage and replica can to have own
UNDO log.
I thought about implementation of special table access method for
temporary tables.
+1
Unfortunately implementing special table access method for temporary
On Tue, Aug 20, 2019 at 7:57 PM Robert Haas wrote:
>
> On Mon, Aug 19, 2019 at 2:04 AM Dilip Kumar wrote:
> > Currently, In UnpackedUndoRecord we store all members directly which
> > are set by the caller. We store pointers to some header which are
> > allocated internally by the undo layer and
On Wed, Aug 21, 2019 at 9:40 AM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> I find the time displays like
>
> 01:03 ago
>
> on the buildfarm status page unhelpful.
>
> First, I can never tell whether this is hours-minutes or minutes-seconds
> -- there is probably a less ambig
I find the time displays like
01:03 ago
on the buildfarm status page unhelpful.
First, I can never tell whether this is hours-minutes or minutes-seconds
-- there is probably a less ambiguous format available.
But more importantly, the page doesn't say when it was generated, so a
relative ti
On Tue, Aug 20, 2019 at 04:47:41PM -0400, Alvaro Herrera wrote:
> Yeah, Alexander proposed change is correct. I just pushed it.
Thanks, Alvaro.
--
Michael
signature.asc
Description: PGP signature
On 2019-08-21 08:56, Andrey Borodin wrote:
> postgres=# create database a template template0 collation_provider icu
> lc_collate 'en_US.utf8';
> CREATE DATABASE
> postgres=# \c a
> 2019-08-21 11:43:40.379 +05 [41509] FATAL: collations with different collate
> and ctype values are not supported b
On 2019-08-17 14:57, Michael Paquier wrote:
> On Sat, Aug 17, 2019 at 10:11:27AM +0200, Peter Eisentraut wrote:
>> I was a bit confused by some of the comments around the SCRAM function
>> read_any_attr(), used to skip over extensions.
>>
>> The comment "Returns NULL if there is attribute.", beside
On Tue, Aug 20, 2019 at 07:09:25PM -0700, Jeff Davis wrote:
> OK, new patch attached. Seems like everyone is in agreement that we
> need a channel_binding param.
+
+A setting of require means that the connection must
+employ channel binding; and that the client will not respo
66 matches
Mail list logo