On Wed, Aug 21, 2019 at 04:32:38PM +0900, Kyotaro Horiguchi wrote: > At Mon, 19 Aug 2019 18:59:59 +0900 (Tokyo Standard Time), Kyotaro Horiguchi > <horikyota....@gmail.com> wrote in > <20190819.185959.118543656.horikyota....@gmail.com> > > At Sat, 17 Aug 2019 20:52:30 -0700, Noah Misch <n...@leadboat.com> wrote in > > <20190818035230.gb3021...@rfd.leadboat.com> > > > For two-phase commit, PrepareTransaction() needs to execute pending syncs. > > Now TwoPhaseFileHeader has two new members for pending syncs. It > is useless on wal-replay, but that is needed for commit-prepared.
Syncs need to happen in PrepareTransaction(), not in commit-prepared. I wrote about that in https://postgr.es/m/20190820060314.ga3086...@rfd.leadboat.com
