On Wed, Apr 17, 2019 at 9:50 PM Tom Lane wrote:
>
> Andres Freund writes:
> > On 2019-04-17 15:49:29 +0530, Amit Kapila wrote:
> >> OTOH, if we want to extend it later for whatever reason to a relation
> >> level cache, it shouldn't be that difficult as the implementation is
> >> mostly contained
On Wed, Apr 17, 2019 at 9:46 PM Andres Freund wrote:
>
> Hi,
>
> On 2019-04-17 15:49:29 +0530, Amit Kapila wrote:
> > > *and* stash the bitmap of
> > > pages that we think are used/free as a bitmap somewhere below the
> > > relcache.
> >
> > I think maintaining at relcache level will be tricky whe
Hello
Well, actually we change postgresql.conf.sample in back-branches. Recently was
yet another commit in REL_10_STABLE: fea2cab70de8d190762996c7c447143fb47bcfa3
I think we need fix incosistent comment for bgwriter_lru_maxpages
regards, Sergei
On Wed, 10 Apr 2019 at 18:14, Alexander Korotkov
wrote:
> Alternative idea is to have MVCC-aware indexes. This approach looks
> more attractive for me. In this approach you basically need xmin,
> xmax fields in index tuples. On insertion of index tuple you fill
> it's xmin. On update, previo
On Thu, Apr 18, 2019 at 4:20 AM Peter Geoghegan wrote:
>
> On Wed, Apr 17, 2019 at 10:46 AM Tom Lane wrote:
> > Yeah, if we wanted to expose these complications more directly, we
> > could think about adding or changing the main counters. I was wondering
> > about whether we should have it repor
Up until quite recently, it worked to do "make installcheck" in
src/test/recovery, following the instructions in the README
file there:
NOTE: You must have given the --enable-tap-tests argument to configure.
Also, to use "make installcheck", you must have built and installed
contrib/te
On 2019/04/17 13:10, Tom Lane wrote:
> David Rowley writes:
>> On Wed, 17 Apr 2019 at 15:54, Tom Lane wrote:
>>> What I'm more worried about is whether this breaks any internal behavior
>>> of explain.c, as the comment David quoted upthread seems to think.
>>> If we need to have a tlist to refere
Hi
I wrote a pspg pager https://github.com/okbob/pspg
This pager is designed for tabular data. It can work in fallback mode as
classic pager, but it is not designed for this purpose (and I don't plan do
it). Can we enhance a set of psql environment variables about
PSQL_TABULAR_PAGER variable. Thi
On 2019/04/18 14:06, Amit Langote wrote:
> Fujita-san,
>
> On 2019/04/17 21:49, Etsuro Fujita wrote:
>> (2019/04/11 20:31), Etsuro Fujita wrote:
>>> (2019/04/11 14:33), Amit Langote wrote:
BTW, have you noticed that the RETURNING clause returns the same row
twice?
>>>
>>> I noticed this,
Fujita-san,
On 2019/04/17 21:49, Etsuro Fujita wrote:
> (2019/04/11 20:31), Etsuro Fujita wrote:
>> (2019/04/11 14:33), Amit Langote wrote:
>>> BTW, have you noticed that the RETURNING clause returns the same row
>>> twice?
>>
>> I noticed this, but I didn't think it hard. :(
>>
>>> +update utrtes
On Thu, Apr 11, 2019 at 6:22 PM Noah Misch wrote:
> - my $iaddr = inet_aton($test_localhost);
> + my $iaddr = inet_aton('0.0.0.0');
This causes make check-world to deliver a flurry of pop-ups from
macOS's built-in Firewall asking if perl should be allo
On Wed, Apr 17, 2019 at 05:51:15PM -0700, Andres Freund wrote:
> Hi,
>
> On 2019-04-17 19:42:19 -0500, Justin Pryzby wrote:
> > diff --git a/doc/src/sgml/information_schema.sgml
> > b/doc/src/sgml/information_schema.sgml
> > index 234a3bb..9c618b1 100644
> > --- a/doc/src/sgml/information_schema.
"Zhang, Jie" writes:
> Here's a patch to fix this bug.
I took a look at this patch, but I really dislike it: it adds a mighty
ad-hoc parameter to a whole bunch of functions that shouldn't really
have anything to do with the problem. Moreover, I have little confidence
that it's really solving the
On 2019/02/23 2:23, Tom Lane wrote:
> Fix plan created for inherited UPDATE/DELETE with all tables excluded.
>
> In the case where inheritance_planner() finds that every table has
> been excluded by constraints, it thought it could get away with
> making a plan consisting of just a dummy Result no
I thought of a case that results in pathological performance due to a
behavior of my nbtree patch series:
regression=# create table uniquenulls(nully int4, constraint pp unique(nully));
CREATE TABLE
Time: 10.694 ms
regression=# insert into uniquenulls select i from generate_series(1, 1e6) i;
INSER
Hello, hackers.
I would like advice on how to design creating generic plans for child tables
gradually.
The current generic plan is created for all child tables plan by specifying
NULL in boundParams of pg_plan_queries().
Also, specifying a parameter in boundParams, custom plan is created, so
Hi all,
Fujii-san has sent me a report offline about REINDEX. And since 9.6,
trying to REINDEX directly an index of pg_class fails lamentably on an
assertion failure (mbsync failure if bypassing the assert):
#2 0x55a9c5bfcc2c in ExceptionalCondition
(conditionName=0x55a9c5ca9750
"!(!Reinde
On Thu, Apr 18, 2019 at 1:43 AM Tom Lane wrote:
>
> John Naylor writes:
> > Attached is a patch to fix some minor issues:
> > -misspelling of an error message
>
> Yeah, I'd noticed that one too :-(. I think the whole jsonpath patch
> needs a sweep to bring its error messages into line with our s
Hi,
On 2019-04-17 19:42:19 -0500, Justin Pryzby wrote:
> diff --git a/doc/src/sgml/information_schema.sgml
> b/doc/src/sgml/information_schema.sgml
> index 234a3bb..9c618b1 100644
> --- a/doc/src/sgml/information_schema.sgml
> +++ b/doc/src/sgml/information_schema.sgml
> @@ -1312,8 +1312,8 @@
>
On Wed, Apr 17, 2019 at 05:23:47PM -0700, Andres Freund wrote:
> Thanks for the patch!
Thanks for fixing it up and commiting.
Would you consider the remaining two hunks, attached ?
Justin
>From fcd6279d0681093e8741cc5a05879afc95751c40 Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Tue, 2 Ap
Hi,
On 2019-04-10 11:55:31 +0900, Michael Paquier wrote:
> Hi Andres,
>
> On Thu, Apr 04, 2019 at 12:42:06AM +, Andres Freund wrote:
> > tableam: basic documentation.
> >
> > This adds documentation about the user oriented parts of table access
> > methods (i.e. the default_table_access_meth
Hi,
On 2019-04-15 18:35:12 +0200, Daniel Verite wrote:
> Andres Freund wrote:
>
> > Yes, I was planning to commit that soon-ish. There still seemed
> > review / newer versions happening, though, so I was thinking of waiting
> > for a bit longer.
>
> You might want to apply this trivial one
Hi,
On 2019-04-10 11:59:18 -0500, Justin Pryzby wrote:
> @@ -1202,8 +1202,7 @@ CREATE TABLE circles (
>ctid will change if it is
>updated or moved by VACUUM FULL. Therefore
>ctid is useless as a long-term row
> - identifier. The OID, or even better a user-defined ser
On Wed, Apr 17, 2019 at 10:45 AM Tom Lane wrote:
> I think what we need to look for is reasons why (1) the postmaster
> never sends SIGUSR2 to the checkpointer, or (2) the checkpointer's
> main loop doesn't get to noticing shutdown_requested.
>
> A rather scary point for (2) is that said main loop
Andres Freund writes:
> On 2019-04-17 18:57:00 -0400, Tom Lane wrote:
>> What on God's green earth are these functions doing in
>> src/include/catalog/index.h?
> I'm happy to move them elsewhere, but I'm not sure there's really a good
> location. I guess we could move them to itemptr.h - but they
Hi,
On 2019-04-17 18:57:00 -0400, Tom Lane wrote:
> What on God's green earth are these functions doing in
> src/include/catalog/index.h?
> They don't have any obvious connection to indexes, let alone
> catalog operations on indexes, which is what that file is for.
Well, they were previously dec
What on God's green earth are these functions doing in
src/include/catalog/index.h?
They don't have any obvious connection to indexes, let alone
catalog operations on indexes, which is what that file is for.
They weren't there before 2a96909a4, either.
regards, tom lane
On 2019-Apr-17, Justin Pryzby wrote:
> A reminder about these.
>
> Also, I suggest renaming "On Table" to "Table", for consistency with \di.
Thanks! Pushed all three.
Please feel free to add things like these to wiki.postgresql.org/wiki/Open_Items
to serve as reminders for the project as a who
Greetings,
* Robert Haas (robertmh...@gmail.com) wrote:
> On Mon, Apr 15, 2019 at 9:01 AM Stephen Frost wrote:
> > I love the general idea of having additional facilities in core to
> > support block-level incremental backups. I've long been unhappy that
> > any such approach ends up being limit
On 2019-Apr-17, Tom Lane wrote:
> Alvaro Herrera writes:
> > 1. pg_dump now uses regular CREATE TABLE followed by ALTER TABLE / ATTACH
> >PARTITION when creating partitions, rather than CREATE TABLE
> >PARTITION OF. pg_dump --binary-upgrade was already doing that, so
> >this part mos
Fabien COELHO writes:
>> Fix unportable code in pgbench.
> Sorry for this unforseen issue... portability is a pain:-(
I think it's my fault, actually --- I don't remember how much of
that patch was yours.
> Yep, but ISTM that it is down to 32 bits,
Only on 32-bit-long machines, which are a dwi
Alvaro Herrera writes:
> 1. pg_dump now uses regular CREATE TABLE followed by ALTER TABLE / ATTACH
>PARTITION when creating partitions, rather than CREATE TABLE
>PARTITION OF. pg_dump --binary-upgrade was already doing that, so
>this part mostly removes some code. In order to make th
Hello Tom,
Fix unportable code in pgbench.
Sorry for this unforseen issue... portability is a pain:-(
The buildfarm points out that UINT64_FORMAT might not work with sscanf;
it's calibrated for our printf implementation, which might not agree
with the platform-supplied sscanf. Fall back t
On 2019-Apr-17, David Rowley wrote:
> On Mon, 15 Apr 2019 at 15:26, Alvaro Herrera wrote:
> >
> > On 2019-Apr-15, David Rowley wrote:
> >
> > > To be honest, if I'd done a better job of thinking through the
> > > implications of this tablespace inheritance in ca4103025d, then I'd
> > > probably h
Greetings,
* Robert Haas (robertmh...@gmail.com) wrote:
> On Tue, Apr 16, 2019 at 5:44 PM Stephen Frost wrote:
> > > > I love the general idea of having additional facilities in core to
> > > > support block-level incremental backups. I've long been unhappy that
> > > > any such approach ends up
> On Wed, Apr 17, 2019 at 10:25 PM Andres Freund wrote:
>
> I assume you're aware, but it's probably not going to be applied for 12...
Sure, the patch was mostly to express more clearly what I was thinking about :)
> I think most of the read-only stuff just needs to be non-optional, and most
> o
Hi!
On 2019-04-17 22:02:24 +0200, Dmitry Dolgov wrote:
> > On Fri, Apr 5, 2019 at 10:25 PM Andres Freund wrote:
> >
> > A second set of limitations is around making more of tableam
> > optional. Right now it e.g. is not possible to have an AM that doesn't
> > implement insert/update/delete. Obvio
On Wed, Apr 17, 2019 at 8:43 PM Tom Lane wrote:
> John Naylor writes:
> > Attached is a patch to fix some minor issues:
> > -misspelling of an error message
>
> Yeah, I'd noticed that one too :-(. I think the whole jsonpath patch
> needs a sweep to bring its error messages into line with our sty
Hello Tom,
We've generally felt that deferring to the behavior of the platform's
getopt() or getopt_long() is a better idea than trying to enforce some
lowest-common-denominator version of switch parsing, on the theory that
users of a given platform will be used to whatever its getopt does.
Th
> On Fri, Apr 5, 2019 at 10:25 PM Andres Freund wrote:
>
> A second set of limitations is around making more of tableam
> optional. Right now it e.g. is not possible to have an AM that doesn't
> implement insert/update/delete. Obviously an AM can just throw an error
> in the relevant callbacks, bu
On Wed, Apr 17, 2019 at 10:46 AM Tom Lane wrote:
> Yeah, if we wanted to expose these complications more directly, we
> could think about adding or changing the main counters. I was wondering
> about whether we should have it report "x bytes and y line pointers
> freed", rather than counting tupl
Masahiko Sawada writes:
> On Wed, Apr 17, 2019 at 5:00 AM Tom Lane wrote:
>>> I'm thinking that we really need to upgrade vacuum's reporting totals
>>> so that it accounts in some more-honest way for pre-existing dead
>>> line pointers. The patch as it stands has made the reporting even more
>>>
John Naylor writes:
> Attached is a patch to fix some minor issues:
> -misspelling of an error message
Yeah, I'd noticed that one too :-(. I think the whole jsonpath patch
needs a sweep to bring its error messages into line with our style
guidelines, but no harm in starting with the obvious bugs
Fabien COELHO writes:
>> I think it might be an actively bad idea. There's a pretty
>> widespread convention that "--" is a no-op switch indicating
>> the end of switches. At least some of our tools appear to
>> honor that behavior (probably because glibc's getopt_long
>> does; I do not think we
Andres Freund writes:
> On 2019-04-17 15:49:29 +0530, Amit Kapila wrote:
>> OTOH, if we want to extend it later for whatever reason to a relation
>> level cache, it shouldn't be that difficult as the implementation is
>> mostly contained in freespace.c (fsm* functions) and I think the
>> relation
Hi,
On 2019-04-17 15:49:29 +0530, Amit Kapila wrote:
> > *and* stash the bitmap of
> > pages that we think are used/free as a bitmap somewhere below the
> > relcache.
>
> I think maintaining at relcache level will be tricky when there are
> insertions and deletions happening in the small relation
This is not the problem only for pg_test_timing. If you want to
address this, the patch needs to cover all the client commands
like psql, createuser. I'm not sure if it's worth doing that.
I think it might be an actively bad idea. There's a pretty
widespread convention that "--" is a no-op s
On Wed, Apr 17, 2019 at 10:24:17AM -0400, Tom Lane wrote:
> Fujii Masao writes:
> > On Wed, Apr 17, 2019 at 6:21 PM Zhang, Jie wrote:
> >> I think "--" is a illegal option, errors should be prompted.
>
> > This is not the problem only for pg_test_timing. If you want to
> > address this, the patc
Hi,
On 2019-04-17 13:09:05 +0800, John Naylor wrote:
> On Wed, Apr 17, 2019 at 2:04 AM Andres Freund wrote:
> >
> > Hi,
> >
> > I'm somewhat unhappy in how much the no-fsm-for-small-rels exposed
> > complexity that looks like it should be purely in freespacemap.c to
> > callers.
> >
> >
> > exte
On Tue, Apr 16, 2019 at 06:40:44PM -0400, Robert Haas wrote:
> Yeah, I really hope we don't end up with dueling patches. I want to
> come up with an approach that can be widely-endorsed and then have
> everybody rowing in the same direction. On the other hand, I do think
> that we may support mul
We just had another complaint (bug #15767) about parallel dump's
inability to cope with concurrent lock requests. The problem is
well described by the comments for lockTableForWorker():
* Acquire lock on a table to be dumped by a worker process.
*
* The master process is already holding an ACC
Fujii Masao writes:
> On Wed, Apr 17, 2019 at 6:21 PM Zhang, Jie wrote:
>> I think "--" is a illegal option, errors should be prompted.
> This is not the problem only for pg_test_timing. If you want to
> address this, the patch needs to cover all the client commands
> like psql, createuser. I'm
On Wed, Apr 17, 2019 at 6:21 PM Zhang, Jie wrote:
>
> Hi all,
>
> pg_test_timing accepts the following command-line options:
> -d duration
> --duration=duration
>
> Specifies the test duration, in seconds. Longer durations give slightly
> better accuracy, and are more likely to discover probl
A reminder about these.
Also, I suggest renaming "On Table" to "Table", for consistency with \di.
Justin
>From e275a0958f0f2cd826e9683fb24b6f757d0fe6c7 Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Sun, 7 Apr 2019 18:24:22 -0500
Subject: [PATCH v2] not necessary to join pg_class, we use oid
On Wed, Apr 17, 2019 at 9:07 AM Julien Rouhaud wrote:
>
> On Wed, Apr 17, 2019 at 1:55 PM Magnus Hagander wrote:
> >
> > On Tue, Apr 16, 2019 at 5:39 PM Robert Treat wrote:
> >>
> >> On Mon, Apr 15, 2019 at 3:32 PM Julien Rouhaud wrote:
> >> >
> >> > I don't know if that counts as an open item,
On Wed, Apr 17, 2019 at 5:00 AM Tom Lane wrote:
>
> I wrote:
> > I'm thinking that we really need to upgrade vacuum's reporting totals
> > so that it accounts in some more-honest way for pre-existing dead
> > line pointers. The patch as it stands has made the reporting even more
> > confusing, ra
On Wed, Apr 17, 2019 at 12:04:35AM -0400, Tom Lane wrote:
> Bruce Momjian writes:
> > I have found that log_planner_stats only outputs stats until the generic
> > plan is chosen. For example, if you run the following commands:
>
> Uh, well, the planner doesn't get run after that point ...
Yes,
On Wed, Apr 17, 2019 at 1:55 PM Magnus Hagander wrote:
>
> On Tue, Apr 16, 2019 at 5:39 PM Robert Treat wrote:
>>
>> On Mon, Apr 15, 2019 at 3:32 PM Julien Rouhaud wrote:
>> >
>> > I don't know if that counts as an open item, but I attach a patch for
>> > all points discussed here.
>>
>> ISTM we
(2019/04/11 20:31), Etsuro Fujita wrote:
(2019/04/11 14:33), Amit Langote wrote:
BTW, have you noticed that the RETURNING clause returns the same row
twice?
I noticed this, but I didn't think it hard. :(
+update utrtest set a = 3 from (values (2), (3)) s(x) where a = s.x
returning *;
+ a | b
On Tue, Apr 16, 2019 at 5:39 PM Robert Treat wrote:
> On Mon, Apr 15, 2019 at 3:32 PM Julien Rouhaud wrote:
> >
> > Sorry for late reply,
> >
> > On Sun, Apr 14, 2019 at 7:12 PM Magnus Hagander
> wrote:
> > >
> > > On Sat, Apr 13, 2019 at 8:46 PM Robert Treat wrote:
> > >>
> > >> On Fri, Apr 1
Attached is a patch to fix some minor issues:
-misspelling of an error message
-Commit 550b9d26f80f failed to update the Makefile comment to reflect
how the build changed, and also removed the clean target, which we now
have use for since we later got rid of backtracking in the scanner.
Also, whi
On Wed, Apr 17, 2019 at 10:39 AM John Naylor
wrote:
> On Wed, Apr 17, 2019 at 2:04 AM Andres Freund wrote:
>
> > +/* Only create the FSM if the heap has greater than this many blocks */
> > +#define HEAP_FSM_CREATION_THRESHOLD 4
> >
> > Hm, this seems to be tying freespace.c closer to heap than I
On 2019/04/17 18:58, Amit Langote wrote:
> where index on queries
> column
Oops, I meant "with an index on the queried column".
Thanks,
Amit
On 2019/04/15 4:29, Tom Lane wrote:
> I think that what we ought to do for v12 is have PartitionDirectory
> copy the data, and then in v13 work on creating real reference-count
> infrastructure that would allow eliminating the copy steps with full
> safety. The $64 question is whether that really
Hi all,
pg_test_timing accepts the following command-line options:
-d duration
--duration=duration
Specifies the test duration, in seconds. Longer durations give slightly
better accuracy, and are more likely to discover problems with the system clock
moving backwards. The default test durat
Hello postgres hackers,
Recently my colleagues and I encountered an issue: a standby can
not recover after an unclean shutdown and it's related to tablespace.
The issue is that the standby re-replay some xlog that needs tablespace
directories (e.g. create a database with tablespace),
but the table
66 matches
Mail list logo
