A reminder about these.
Also, I suggest renaming "On Table" to "Table", for consistency with \di.
Justin
>From e275a0958f0f2cd826e9683fb24b6f757d0fe6c7 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Sun, 7 Apr 2019 18:24:22 -0500
Subject: [PATCH v2] not necessary to join pg_class, we use oid::regclass not
relname
---
src/bin/psql/describe.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c
index 3a04b06..3940570 100644
--- a/src/bin/psql/describe.c
+++ b/src/bin/psql/describe.c
@@ -3860,7 +3860,7 @@ listPartitionedTables(const char *reltypes, const char *pattern, bool verbose)
if (showNested || pattern)
appendPQExpBuffer(&buf,
- ",\n c3.oid::regclass as \"%s\"",
+ ",\n inh.inhparent::regclass as \"%s\"",
gettext_noop("Parent name"));
if (showIndexes)
@@ -3901,8 +3901,7 @@ listPartitionedTables(const char *reltypes, const char *pattern, bool verbose)
if (showNested || pattern)
appendPQExpBufferStr(&buf,
- "\n LEFT JOIN pg_catalog.pg_inherits inh ON c.oid = inh.inhrelid"
- "\n LEFT JOIN pg_catalog.pg_class c3 ON c3.oid = inh.inhparent");
+ "\n LEFT JOIN pg_catalog.pg_inherits inh ON c.oid = inh.inhrelid");
if (verbose)
{
--
2.7.4
>From aa499764bd11172785ac9595168e427354f3cd95 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Sun, 7 Apr 2019 18:54:04 -0500
Subject: [PATCH v2] Refer to ptn "relations" not tables. Remove incorrect
statement "(including that of their indexes)"
---
doc/src/sgml/ref/psql-ref.sgml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml
index 464c196..08f4bab 100644
--- a/doc/src/sgml/ref/psql-ref.sgml
+++ b/doc/src/sgml/ref/psql-ref.sgml
@@ -1675,15 +1675,15 @@ testdb=>
<para>
If the modifier <literal>n</literal> (<quote>nested</quote>) is used,
- or a pattern is specified, then non-root partitioned tables are
+ or a pattern is specified, then non-root partitioned relations are
included, and a column is shown displaying the parent of each
partitioned relation.
</para>
<para>
- If <literal>+</literal> is appended to the command, the sum of sizes of
- table's partitions (including that of their indexes) is also displayed,
- along with the associated description.
+ If <literal>+</literal> is appended to the command name, the sum of the
+ sizes of each relation's partitions is also displayed, along with the
+ relation's description.
If <literal>n</literal> is combined with <literal>+</literal>, two
sizes are shown: one including the total size of directly-attached
leaf partitions, and another showing the total size of all partitions,
--
2.7.4
>From eb78f32356c32dbb5b65e69a55177a7a06e863e9 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Wed, 17 Apr 2019 08:59:19 -0500
Subject: [PATCH v1] For consistency with \di, rename column to "Table"
---
src/bin/psql/describe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c
index 30d1078..0b28d4d 100644
--- a/src/bin/psql/describe.c
+++ b/src/bin/psql/describe.c
@@ -3885,7 +3885,7 @@ listPartitionedTables(const char *reltypes, const char *pattern, bool verbose)
if (showIndexes)
appendPQExpBuffer(&buf,
",\n c2.oid::regclass as \"%s\"",
- gettext_noop("On table"));
+ gettext_noop("Table"));
if (verbose)
{
--
2.7.4
