Re: PostgreSQL crashes with SIGSEGV

2018-01-15 Thread Aleksandr Parfenov
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Hi, All information is related to WIP-tuplesort-memcontext-f

Re: Rangejoin rebased

2018-01-15 Thread Jeff Davis
On Fri, Jan 12, 2018 at 11:02 AM, Alexander Kuzmenkov wrote: > The sort order isn't right for the join, it seems. I remember having similar > troubles with my full merge join implementation. I tried filtering > unsuitable paths in try_mergejoin_path, but that was not quite enough. The > planner tr

Re: [HACKERS] Deadlock in XLogInsert at AIX

2018-01-15 Thread Michael Paquier
On Fri, Feb 03, 2017 at 12:26:50AM +, Noah Misch wrote: > On Wed, Feb 01, 2017 at 02:39:25PM +0200, Heikki Linnakangas wrote: >> @@ -73,11 +73,19 @@ pg_atomic_compare_exchange_u32_impl(volatile >> pg_atomic_uint32 *ptr, >> static inline uint32 >> pg_atomic_fetch_add_u32_impl(volatile pg_atom

Re: Enhance pg_stat_wal_receiver view to display connected host

2018-01-15 Thread Haribabu Kommi
[ Including Hackers as earlier mail mistakenly removed it ] On Tue, Jan 16, 2018 at 2:55 PM, Michael Paquier wrote: > On Mon, Jan 15, 2018 at 05:51:58PM +1100, Haribabu Kommi wrote: > > Instead of effective_conninfo, I changed the column name as > > remote_serve_info and > > display only the hos

Setting BLCKSZ 4kB

2018-01-15 Thread sanyam jain
Hi, I am trying to solve WAL flooding due to FPWs. What are the cons of setting BLCKSZ as 4kB? When saw the results published on http://blog.coelho.net/database/2014/08/17/postgresql-page-size-for-SSD-2.html 4kB page is giving better performance in comparison to 8kB except when tested with

Re: [HACKERS] generated columns

2018-01-15 Thread Michael Paquier
On Wed, Dec 27, 2017 at 12:31:05PM -0500, Peter Eisentraut wrote: > On 9/12/17 15:35, Jaime Casanova wrote: >> On 10 September 2017 at 00:08, Jaime Casanova >> wrote: >>> >>> During my own tests, though, i found some problems: > > Here is an updated patch that should address the problems you have

Re: [HACKERS] Replication status in logical replication

2018-01-15 Thread Michael Paquier
On Tue, Jan 16, 2018 at 10:40:43AM +0900, Masahiko Sawada wrote: > On Sun, Jan 14, 2018 at 12:43 AM, Simon Riggs wrote: >> On 9 January 2018 at 04:36, Masahiko Sawada wrote: >> We're not talking about standbys, so the message is incorrect. > > Ah, I understood. How about "\"%s\" has now caught

Re: [HACKERS] taking stdbool.h into use

2018-01-15 Thread Michael Paquier
On Thu, Jan 11, 2018 at 06:40:05PM -0500, Tom Lane wrote: > Peter Eisentraut writes: >> That leaves the uses in rowtypes.c. Those were introduced as a >> portability fix by commit 4cbb646334b. I'm curious why these are >> necessary. The Datums they operate come from heap_deform_tuple(), which >

Re: New gist vacuum.

2018-01-15 Thread Andrey Borodin
Hi, Alexander! Many thanks for looking into patches! A little bit later I will provide answer in other branch of discussion. > 15 янв. 2018 г., в 23:34, Alexander Korotkov > написал(а): > > I do not know, should I register separate commitfest entry? The code is very > close to main GiST VACUU

Re: ALTER TABLE ADD COLUMN fast default

2018-01-15 Thread David Rowley
On 2 January 2018 at 05:01, Andrew Dunstan wrote: > New version of the patch that fills in the remaining piece in > equalTupleDescs. This no longer applies to current master. Can send an updated patch? -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: polymorphic parameters limits - correct solution?

2018-01-15 Thread Pavel Stehule
2018-01-16 3:21 GMT+01:00 Alvaro Herrera : > Pavel Stehule wrote: > > Hi > > > > I played with introduction of new pair of Polymorphic Parameters - like > > anyXelement and anyXarray. Now, I don't think so enhancing PP is good way > > now. Without significant redesign there are not practical appen

Re: [HACKERS] UPDATE of partition key

2018-01-15 Thread David Rowley
On 16 January 2018 at 01:09, Robert Haas wrote: > On Sun, Jan 14, 2018 at 6:57 AM, Amit Khandekar > wrote: >> Even where partitions are present, in the usual case where there are >> Instead of a bool array, we can even make it a Bitmapset. But I think >> access would become slower as compared to

Re: [HACKERS] Proposal: Local indexes for partitioned table

2018-01-15 Thread David Rowley
On 12 January 2018 at 07:52, Alvaro Herrera wrote: > The delta patch turned out to have at least one stupid bug, and a few > non-stupid bugs. Here's an updated version that should behave > correctly, and addresses all reported problems. Thanks for updating the patch. I've just made another pass

Re: WIP: a way forward on bootstrap data

2018-01-15 Thread Tom Lane
John Naylor writes: > On 1/14/18, Tom Lane wrote: >> So, for each catalog header pg_foo.h, there would be a >> generated file, say pg_foo_d.h, containing: >> * Natts_ and Anum_ macros for pg_foo >> * Any EXPOSE_TO_CLIENT_CODE sections copied from pg_foo.h >> * Any OID-value macros for entries in

Re: [HACKERS] postgres_fdw bug in 9.6

2018-01-15 Thread Etsuro Fujita
(2018/01/16 11:17), Tom Lane wrote: Etsuro Fujita writes: (2018/01/16 1:47), Robert Haas wrote: Hmm, I was thinking that bar and baz wouldn't be constrained to return just one tuple in that case, but I'm wrong: there would just be one tuple per relation in that case. However, that would also

Re: [HACKERS] Race between SELECT and ALTER TABLE NO INHERIT

2018-01-15 Thread Kyotaro HORIGUCHI
Hello, sorry for my late reply. At Wed, 10 Jan 2018 14:56:49 -0500, Tom Lane wrote in <26017.1515614...@sss.pgh.pa.us> > I think that there might be a much simpler solution to this, which > is to just remove make_inh_translation_list's tests of attinhcount, > as per attached. Those are really p

Re: WIP: a way forward on bootstrap data

2018-01-15 Thread John Naylor
On 1/14/18, Tom Lane wrote: > So, for each catalog header pg_foo.h, there would be a > generated file, say pg_foo_d.h, containing: > > * Natts_ and Anum_ macros for pg_foo > > * Any EXPOSE_TO_CLIENT_CODE sections copied from pg_foo.h > > * Any OID-value macros for entries in that catalog I'm on

Re: [HACKERS] Restricting maximum keep segments by repslots

2018-01-15 Thread Tom Lane
Robert Haas writes: > Since the "Stripping trailing CRs from patch" message is totally > harmless, I'm not sure why you should need to devote any effort to > avoiding it. Anyone who gets it should just ignore it. Not sure, but that might be another situation in which "patch" works and "git apply

Re: [HACKERS] Restricting maximum keep segments by repslots

2018-01-15 Thread Robert Haas
On Mon, Jan 15, 2018 at 1:05 AM, Kyotaro HORIGUCHI wrote: >> >> patch -p1 gives some "Stripping trailing CRs from patch" >> >> messages for me, but applied to current HEAD and builds. After >> > >> > Hmm. I wonder why I get that complaint so often. (It's rather >> > common? or caused by the MIME

Re: polymorphic parameters limits - correct solution?

2018-01-15 Thread Alvaro Herrera
Pavel Stehule wrote: > Hi > > I played with introduction of new pair of Polymorphic Parameters - like > anyXelement and anyXarray. Now, I don't think so enhancing PP is good way > now. Without significant redesign there are not practical append more code > there. > > Why this is a issue? The exte

Re: [HACKERS] postgres_fdw bug in 9.6

2018-01-15 Thread Tom Lane
Etsuro Fujita writes: > (2018/01/16 1:47), Robert Haas wrote: >> Hmm, I was thinking that bar and baz wouldn't be constrained to return >> just one tuple in that case, but I'm wrong: there would just be one >> tuple per relation in that case. However, that would also be true for >> a full join, w

Re: [HACKERS] postgres_fdw bug in 9.6

2018-01-15 Thread Etsuro Fujita
(2018/01/16 1:47), Robert Haas wrote: On Mon, Jan 15, 2018 at 3:09 AM, Etsuro Fujita wrote: Yeah, but I don't think the above example is good enough to explain that, because I think the bar/baz join would produce at most one tuple in an EPQ recheck since we would have only one EPQ tuple for bo

Re: [HACKERS] Replication status in logical replication

2018-01-15 Thread Masahiko Sawada
On Sun, Jan 14, 2018 at 12:43 AM, Simon Riggs wrote: > On 9 January 2018 at 04:36, Masahiko Sawada wrote: > >>> This patch appears to cause this DEBUG1 message >>> >>> "standby \"%s\" has now caught up with primary" >>> >>> which probably isn't the right message, but might be OK to backpatch. >>>

Re: jsonpath

2018-01-15 Thread Andrew Dunstan
On 01/10/2018 05:42 PM, Nikita Glukhov wrote: > Attached new 8th version of jsonpath related patches. Complete > documentation is still missing. > > The first 4 small patches are necessary datetime handling in jsonpath: > 1. simple refactoring, extracted function that will be used later in > json

Re: master make check fails on Solaris 10

2018-01-15 Thread Tom Lane
Marina Polyakova writes: > On 13-01-2018 21:10, Tom Lane wrote: >> I'm not sure there's much we can do about this. Dropping the use >> of the alignment spec isn't a workable option. If there were a >> simple way for configure to detect that the compiler generates bad >> code for that, we could h

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Chapman Flack
On 01/15/18 16:32, David Fetter wrote: > On Mon, Jan 15, 2018 at 01:24:45PM -0500, Chapman Flack wrote: >> On 01/15/18 11:56, David Fetter wrote: And while trying to find the EOF setting in libreadline might get messy, you're already assuming that ctrl-C hasn't been knobbled using st

Re: [HACKERS] Partition-wise aggregation/grouping

2018-01-15 Thread Robert Haas
On Thu, Jan 11, 2018 at 6:00 AM, Jeevan Chalke wrote: > Attached new set of patches adding this. Only patch 0007 (main patch) and > 0008 (testcase patch) has changed. > > Please have a look and let me know if I missed any. I spent a little time studying 0001 and 0002 today, as well as their rela

Re: [HACKERS] postgres_fdw bug in 9.6

2018-01-15 Thread Tom Lane
Robert Haas writes: > On Mon, Jan 15, 2018 at 12:31 PM, Tom Lane wrote: >> Hm. Simple is certainly good, but if there's multiple rows coming >> back during an EPQ recheck then I think we have a performance problem. > You are correct ... I was wrong about that part, and said so in an > email on

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread David Fetter
On Mon, Jan 15, 2018 at 01:24:45PM -0500, Chapman Flack wrote: > On 01/15/18 11:56, David Fetter wrote: > >> And while trying to find the EOF setting in libreadline might get > >> messy, you're already assuming that ctrl-C hasn't been knobbled > >> using stty intr. Unless you want to go searching f

Re: [HACKERS] WIP: Aggregation push-down

2018-01-15 Thread Robert Haas
On Fri, Dec 22, 2017 at 10:43 AM, Antonin Houska wrote: > Michael Paquier wrote: >> On Sat, Nov 4, 2017 at 12:33 AM, Antonin Houska wrote: >> > I'm not about to add any other features now. Implementation of the missing >> > parts (see the TODO comments in the code) is the next step. But what I'd

Re: Implementing SQL ASSERTION

2018-01-15 Thread Joe Wildish
Hi David, > On 15 Jan 2018, at 16:35, David Fetter wrote: > > It sounds reasonable enough that I'd like to make a couple of Modest > Proposals™, to wit: > > - We follow the SQL standard and make SERIALIZABLE the default > transaction isolation level, and > > - We disallow writes at isolation

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

2018-01-15 Thread Peter Geoghegan
On Sun, Jan 14, 2018 at 8:25 PM, Amit Kapila wrote: > On Sun, Jan 14, 2018 at 1:43 AM, Peter Geoghegan wrote: >> On Sat, Jan 13, 2018 at 4:32 AM, Amit Kapila wrote: >>> Yeah, but this would mean that now with parallel create index, it is >>> possible that some tuples from the transaction would e

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Tels
Moin, On Mon, January 15, 2018 2:34 pm, Tels wrote: > Maybe that's a Linux-specific thing, but I always use Ctrl-D to exit a > console, and this works with psql, too, even when in the middle of a query > typed. > > So maybe this could be suggested? Sorry, should have really read the thread until

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Tels
On Mon, January 15, 2018 11:10 am, Robert Haas wrote: > On Mon, Jan 15, 2018 at 10:57 AM, Tom Lane wrote: >> Robert Haas writes: >>> I've discovered one thing about this design that is not so good, which >>> is that if you open a single, double, or dollar quote, then the >>> instructions that ar

Re: [HACKERS] postgres_fdw bug in 9.6

2018-01-15 Thread Robert Haas
On Mon, Jan 15, 2018 at 12:31 PM, Tom Lane wrote: >> After some thought, it seems that there's a much simpler way that we >> could fix the problem you identified in that original email: if the >> EPQ path isn't properly sorted, have postgres_fdw's >> add_paths_with_pathkeys_for_rel stick a Sort n

Re: [PROPOSAL] Shared Ispell dictionaries

2018-01-15 Thread Arthur Zakirov
On Sat, Jan 13, 2018 at 10:33:14PM +0100, Tomas Vondra wrote: > Not sure if we really need to add the database/schema OIDs. I mentioned > the unexpected consequences (cross-db sharing) but maybe that's a > feature we should keep (it reduces memory usage). So perhaps this should > be another CREATE

Re: New gist vacuum.

2018-01-15 Thread Alexander Korotkov
Hi! On Thu, Dec 28, 2017 at 2:37 PM, Andrey Borodin wrote: > > 19 дек. 2017 г., в 15:58, Andrey Borodin > написал(а): > > Here is the patch that deletes pages during GiST VACUUM. > > Here is new version of the patch for GiST VACUUM. > There are two main changes: > 1. During rescan for page dele

Re: New gist vacuum.

2018-01-15 Thread Alexander Korotkov
Hi! On Sat, Dec 30, 2017 at 12:18 PM, Andrey Borodin wrote: > > 28 дек. 2017 г., в 16:37, Andrey Borodin > написал(а): > > Here is new version of the patch for GiST VACUUM. > > There are two main changes: > > 1. During rescan for page deletion only know to be recently empty pages > are rescanne

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Chapman Flack
On 01/15/18 11:56, David Fetter wrote: >> And while trying to find the EOF setting in libreadline might get >> messy, you're already assuming that ctrl-C hasn't been knobbled >> using stty intr. Unless you want to go searching for that too? > > I'm pretty sure changing either or both of those sett

Re: [HACKERS] proposal: psql command \graw

2018-01-15 Thread Pavel Stehule
2018-01-15 18:40 GMT+01:00 Alexander Korotkov : > Hi! > > On Mon, Dec 4, 2017 at 6:42 PM, Pavel Stehule > wrote: > >> 2017-12-04 9:29 GMT+01:00 Alexander Korotkov : >> >>> On Mon, Dec 4, 2017 at 11:21 AM, Alexander Korotkov < >>> a.korot...@postgrespro.ru> wrote: >>> The problem is that it's

Re: [HACKERS] Transaction control in procedures

2018-01-15 Thread Andrew Dunstan
On 01/05/2018 04:30 PM, Peter Eisentraut wrote: > A merge conflict has arisen, so for simplicity, here is an updated patch. > > On 12/20/17 10:08, Peter Eisentraut wrote: >> Updated patch attached. >> >> I have addressed the most recent review comments I believe. >> >> The question about what hap

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Tom Lane
Geoff Winkless writes: > At this point it depends quite how far down the rabbit-hole you want > to go to stop people googling "how do I exit psql", I suppose :p Well, I concur with Robert's comment upthread that we don't want to print any advice that's possibly wrong. So I'd rather provide hints

polymorphic parameters limits - correct solution?

2018-01-15 Thread Pavel Stehule
Hi I played with introduction of new pair of Polymorphic Parameters - like anyXelement and anyXarray. Now, I don't think so enhancing PP is good way now. Without significant redesign there are not practical append more code there. Why this is a issue? The extension's authors are not able to speci

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Geoff Winkless
On 15 January 2018 at 17:03, Tom Lane wrote: > Geoff Winkless writes: >> And while trying to find the EOF setting in libreadline might get >> messy, you're already assuming that ctrl-C hasn't been knobbled using >> stty intr. Unless you want to go searching for that too? > > Yeah, that's why I pe

Re: [HACKERS] proposal: psql command \graw

2018-01-15 Thread Alexander Korotkov
Hi! On Mon, Dec 4, 2017 at 6:42 PM, Pavel Stehule wrote: > 2017-12-04 9:29 GMT+01:00 Alexander Korotkov : > >> On Mon, Dec 4, 2017 at 11:21 AM, Alexander Korotkov < >> a.korot...@postgrespro.ru> wrote: >> >>> The problem is that it's hard to read arbitrary formatted psql output >>> from external

Re: [HACKERS] postgres_fdw bug in 9.6

2018-01-15 Thread Tom Lane
Robert Haas writes: > I started to look at this patch again today and got cold feet. It > seems to me that this entire design on the posted patch is based on > your remarks in http://postgr.es/m/13242.1481582...@sss.pgh.pa.us -- > # One way that we could make things better is to rely on the know

Re: pgbench - add \if support

2018-01-15 Thread Fabien COELHO
Here is a rebase. I made some tests use actual expressions instead of just 0 and 1. No other changes. Sigh. Better with the attachment. Sorry for the noise. Here is a very minor rebase. -- Fabien.diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgml index 3dd492c..c203c

Re: [HACKERS] Early locking option to parallel backup

2018-01-15 Thread Robert Haas
On Thu, Jan 11, 2018 at 9:02 AM, Stephen Frost wrote: > Parallel pg_dump is based on synchronized transactions though and we > have a bunch of checks in ImportSnapshot() because a pg_dump parallel > worker also can't really be quite the same as a normal backend. Perhaps > we could add on more res

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Geoff Winkless
On 15 January 2018 at 16:56, David Fetter wrote: > On Mon, Jan 15, 2018 at 04:53:27PM +, Geoff Winkless wrote: >> And while trying to find the EOF setting in libreadline might get >> messy, you're already assuming that ctrl-C hasn't been knobbled >> using stty intr. Unless you want to go searc

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Tom Lane
Geoff Winkless writes: > And while trying to find the EOF setting in libreadline might get > messy, you're already assuming that ctrl-C hasn't been knobbled using > stty intr. Unless you want to go searching for that too? Yeah, that's why I personally don't want to mention ctrl-C in this message.

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread David Fetter
On Mon, Jan 15, 2018 at 04:53:27PM +, Geoff Winkless wrote: > On 15 January 2018 at 16:48, Tom Lane wrote: > > Geoff Winkless writes: > >> Perhaps different messages on different OSes? :) > > > > It's worse than that: the EOF key is configurable. In principle > > we could look into the tty s

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Tom Lane
Robert Haas writes: > On Mon, Jan 15, 2018 at 10:57 AM, Tom Lane wrote: >> I was kind of imagining that we could make the hint text vary depending >> on the parsing state. Maybe that's too hard to get to --- but if the >> prompt-creating code knows what it is, perhaps this can too. > More broad

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Geoff Winkless
On 15 January 2018 at 16:48, Tom Lane wrote: > Geoff Winkless writes: >> Perhaps different messages on different OSes? :) > > It's worse than that: the EOF key is configurable. In principle we > could look into the tty settings and print the right thing, but > I doubt we want to go there, especi

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Tom Lane
Geoff Winkless writes: > Perhaps different messages on different OSes? :) It's worse than that: the EOF key is configurable. In principle we could look into the tty settings and print the right thing, but I doubt we want to go there, especially if there's no corresponding thing on Windows.

Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02)

2018-01-15 Thread Julian Markwort
On 01/11/2018 03:43 PM, David Fetter wrote: Is the assumption of a normal distribution reasonable for outlier plans as you've seen them? This is a difficult but fair question. First of all, I'd like to clarify that the normal distribution is assumed for the set of all execution times matching a

Re: [HACKERS] postgres_fdw bug in 9.6

2018-01-15 Thread Robert Haas
On Mon, Jan 15, 2018 at 3:09 AM, Etsuro Fujita wrote: > Yeah, but I don't think the above example is good enough to explain that, > because I think the bar/baz join would produce at most one tuple in an EPQ > recheck since we would have only one EPQ tuple for both bar and baz in that > recheck, an

Re: Implementing SQL ASSERTION

2018-01-15 Thread David Fetter
On Mon, Jan 15, 2018 at 03:40:57PM +0100, Fabien COELHO wrote: > > >>I'm wondering about the effect of MVVC on this: if the check is > >>performed when the INSERT is done, concurrent inserting transactions > >>would count the current status which would be ok, but on commit all > >>concurrent inser

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Geoff Winkless
On 15 January 2018 at 16:16, Laurenz Albe wrote: > Geoff Winkless wrote: >> Can we not just say "ctrl-D to quit" instead of \q? Doesn't that work >> everywhere? > > Not on Windows, as far as I know. Well on Windows, Ctrl-C doesn't clear the input buffer either - it quits the whole thing. Perhaps

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Stephen Frost
Geoff, all, * Geoff Winkless (pgsqlad...@geoff.dj) wrote: > On 15 January 2018 at 16:10, Robert Haas wrote: > > > > More broadly, I think what is needed here is less C-fu than > > English-fu. If we come up with something good, we can make it print > > that thing. > > Can we not just say "ctrl-D

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Laurenz Albe
Geoff Winkless wrote: > Can we not just say "ctrl-D to quit" instead of \q? Doesn't that work > everywhere? Not on Windows, as far as I know. Yours, Laurenz Albe

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Geoff Winkless
On 15 January 2018 at 16:10, Robert Haas wrote: > > More broadly, I think what is needed here is less C-fu than > English-fu. If we come up with something good, we can make it print > that thing. > Can we not just say "ctrl-D to quit" instead of \q? Doesn't that work everywhere? Geoff

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Robert Haas
On Mon, Jan 15, 2018 at 10:57 AM, Tom Lane wrote: > Robert Haas writes: >> I've discovered one thing about this design that is not so good, which >> is that if you open a single, double, or dollar quote, then the >> instructions that are provided under that design do not work: > > I was kind of i

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Robert Haas
On Mon, Jan 15, 2018 at 10:48 AM, Stephen Frost wrote: > Well, control-C would still work in that case, so I'm not sure that it's > so bad. It's certainly better than what we have now. I would have > thought to include a hint to use \? for help too but it might make the > hint too long. How abo

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Tom Lane
Robert Haas writes: > I've discovered one thing about this design that is not so good, which > is that if you open a single, double, or dollar quote, then the > instructions that are provided under that design do not work: I was kind of imagining that we could make the hint text vary depending on

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Stephen Frost
Robert, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Jan 15, 2018 at 7:28 AM, Laurenz Albe > wrote: > > Everaldo Canuto wrote: > >> Also I don't see a consensus on this thread and I don't understand how > >> decisions are taken. > > > > It's just difficult to find consensus with many

Re: Rangejoin rebased

2018-01-15 Thread Robert Haas
On Tue, Jan 9, 2018 at 11:24 PM, Jeff Davis wrote: >> Just to emphasise why we want this, it might be better for the EXPLAIN >> to say "Time Range Join" when the ranges being joined are Time Ranges, >> and for other cases to just say "Range Join". The use of the word >> Merge doesn't help much the

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Robert Haas
On Mon, Jan 15, 2018 at 7:28 AM, Laurenz Albe wrote: > Everaldo Canuto wrote: >> Also I don't see a consensus on this thread and I don't understand how >> decisions are taken. > > It's just difficult to find consensus with many people. > > There were several valid concerns with this, the most str

Re: [HACKERS] GSoC 2017: weekly progress reports (week 4) and patch for hash index

2018-01-15 Thread Shubham Barai
On 15 January 2018 at 08:03, Stephen Frost wrote: > Greeting Shubham, all, > > * Michael Paquier (michael.paqu...@gmail.com) wrote: > > On Mon, Sep 25, 2017 at 10:34 PM, Shubham Barai > > wrote: > > > I have attached the rebased version of patch here. > > > > The patch does not apply and there h

Re: WIP Patch: Precalculate stable functions, infrastructure v1

2018-01-15 Thread Aleksander Alekseev
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed I can confirm this code works. However, since this is quite a

Re: Implementing SQL ASSERTION

2018-01-15 Thread Fabien COELHO
I'm wondering about the effect of MVVC on this: if the check is performed when the INSERT is done, concurrent inserting transactions would count the current status which would be ok, but on commit all concurrent inserts would be there and the count could not be ok anymore? The patch doesn’t

Re: WIP: a way forward on bootstrap data

2018-01-15 Thread Alvaro Herrera
Tom Lane wrote: > I had a thought about how to do that. It's clearly desirable that that > sort of material remain in the manually-maintained pg_*.h files, because > that's basically where you look to find out C-level details of what's > in a particular catalog. However, that doesn't mean that t

Re: new function for tsquery creartion

2018-01-15 Thread Aleksander Alekseev
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Here are a few minor issues: ``` +/* + * Checks if 'str' sta

Re: Implementing SQL ASSERTION

2018-01-15 Thread Joe Wildish
Hi Fabien, >> * certain combinations of aggregates with comparison operations cannot be >> invalidating. >> >> As an example of the last point, the expression "CHECK (10 > (SELECT >> COUNT(*) FROM t))" cannot be invalidated by a delete or an update but can be >> invalidated by an insert. > >

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Laurenz Albe
Everaldo Canuto wrote: > Also I don't see a consensus on this thread and I don't understand how > decisions are taken. It's just difficult to find consensus with many people. There were several valid concerns with this, the most striking (to me) was Tome's concern that there are perfectly valid

Re: Implementing SQL ASSERTION

2018-01-15 Thread Fabien COELHO
Hello Joe, Just a reaction to the example, which is maybe addressed in the patch which I have not investigated. * certain combinations of aggregates with comparison operations cannot be invalidating. As an example of the last point, the expression "CHECK (10 > (SELECT COUNT(*) FROM t))" c

Re: [HACKERS] UPDATE of partition key

2018-01-15 Thread Robert Haas
On Sun, Jan 14, 2018 at 6:57 AM, Amit Khandekar wrote: > Even where partitions are present, in the usual case where there are > no transition tables we won't require per-leaf map at all [1]. So I > think we should keep mt_per_sub_plan_maps only for the case where > per-leaf map is not allocated. A

Re: master make check fails on Solaris 10

2018-01-15 Thread Marina Polyakova
Thank you very much! On 13-01-2018 21:10, Tom Lane wrote: Marina Polyakova writes: On 12-01-2018 21:00, Tom Lane wrote: Hm ... so apparently, that compiler has bugs in handling nondefault alignment specs. You said upthread it was gcc, but what version exactly? This is 5.2.0: Ugh ... pro

Re: [PATCH] Logical decoding of TRUNCATE

2018-01-15 Thread Marco Nenciarini
Hi all, After commit bbd3363e128daec0e70952c1bb2f12ab1f6f1292 that refactor subscription tests to use PostgresNode's wait_for_catchup, the patch needs to be updated to use wait_for_catchup. Attached there is the updated patch. is discussed in a separate thread https://commitfest.postgresql.org/16

Re: [HACKERS] UPDATE of partition key

2018-01-15 Thread Amit Khandekar
On 14 January 2018 at 17:27, Amit Khandekar wrote: > On 13 January 2018 at 02:56, Robert Haas wrote: > > I guess I'm inclined to keep mt_per_sub_plan_maps for the case where > > there are no partitions, but not use it when partitions are present. > > What do you think about that? > > Even where p

Re: Minor fix for pgbench documentation

2018-01-15 Thread Ildar Musin
Hello Fabien, 13/01/2018 19:30, Fabien COELHO пишет: > >> Here is a patch that adds missing random_zipfian func to the paragraph >> in pgbench documentation about random functions parameterization. > > Indeed. > > Patch applies cleanly, doc build ok. Marked as "ready". > > I have added it to the

Re: Removing WITH clause support in CREATE FUNCTION, for isCachable and isStrict

2018-01-15 Thread Daniel Gustafsson
> On 15 Jan 2018, at 03:27, Michael Paquier wrote: > > Hi all, > > As noticed by Daniel here: > https://www.postgresql.org/message-id/d5f34c9d-3ab7-4419-af2e-12f67581d...@yesql.se In that thread I proposed a patch to fix this, but I certainly don’t object to just removing it to make both syntax

Re: [HACKERS] Useless code in ExecInitModifyTable

2018-01-15 Thread Etsuro Fujita
(2018/01/15 11:35), Amit Langote wrote: On 2018/01/15 11:28, Stephen Frost wrote: Seems like this has gotten a review (and quite a bit of down-stream discussion that seemed pretty positive), and the latest patch still applies cleanly and passes the regression tests- is there some reason it's sti

Re: [HACKERS] postgres_fdw bug in 9.6

2018-01-15 Thread Etsuro Fujita
(2018/01/13 6:07), Robert Haas wrote: On Sun, Dec 3, 2017 at 2:56 PM, Tom Lane wrote: I thought some more about this. While it seems clear that we don't actually need to recheck anything within a postgres_fdw foreign join, there's still a problem: we have to be able to regurgitate the join row