Hi, Alexander! Many thanks for looking into patches! A little bit later I will provide answer in other branch of discussion.
> 15 янв. 2018 г., в 23:34, Alexander Korotkov <a.korot...@postgrespro.ru> > написал(а): > > I do not know, should I register separate commitfest entry? The code is very > close to main GiST VACUUM patch, but solves a bit different problem. > > Yes, I think it deserves separate commitfest entry. Despite it's related to > GiST VACUUM, it's a separate fix. Ok, done. https://commitfest.postgresql.org/17/1483 > I've made small improvements to this patch: variable naming, formatting, > comments. Great, thanks! > BTW, do we really need to set shouldCount depending on whether we receive > stats argument or not? What if we always set shouldCount as in the first > branch of "if"? > > shouldCount = !heap_attisnull(rel->rd_indextuple, > Anum_pg_index_indpred) || > info->estimated_count; We do not need to count if we have exact count from heap and this index is not partial. ITSM that it is quite common case. Best regards, Andrey Borodin.
