Re: Naming of network_ops vs. inet_ops for SP-GIST

On Tue, Jan 24, 2023 at 03:22:44PM -0500, Tom Lane wrote: > I wonder whether we shouldn't just revert this table to > showing opclass names, and avert our eyes from the theoretical > inconsistency. Michael, looks like it was your 7a1cd5260 > that changed it; what do you think? Yes, the docs shoul

Re: Naming of network_ops vs. inet_ops for SP-GIST

On Tue, Jan 24, 2023 at 10:38:28PM -0500, Tom Lane wrote: > Works for me. Thanks for checking, applied that. -- Michael signature.asc Description: PGP signature

Re: meson doc: Is "-Dtap-tests" a typo?

On Tue, Feb 14, 2023 at 09:06:13AM +, Katsuragi Yuta wrote: > The parameter name "-Dtap-tests" in the meson's doc seems to be a typo. > I think "-Dtap_tests" is the correct name. Attached patch fixes that. > > I got an unknown options error by using "-Dtap-tests=enabled". However, > meson_opt

Re: Add missing meson arguments in docs

On Tue, Feb 21, 2023 at 10:40:12AM +0100, Jelte Fennema wrote: > The -Dcassert and -Db_coverage of the meson build didn't show in the > docs that they needed to be passed true or false. All other options > specified the arguments they expected. This patch fixes that. Indeed, values have to be spec

Re: Add missing meson arguments in docs

On Wed, Feb 22, 2023 at 09:24:37AM +0100, Peter Eisentraut wrote: > Yeah, this is just in the long tail of things to work through. I am going through that, and found out what can be done to do coverage reports. I will post a patch separately on -hackers. -- Michael signature.asc Description: PG

Re: incorrect info in dblink examples

On Mon, Feb 27, 2023 at 07:24:37PM +, PG Doc comments form wrote: > In your examples, AS t1(proname name, prosrc text) > should actually be AS t1(proname text, prosrc text) > > This occurs frequently in the documentation at the following link: > https://www.postgresql.org/docs/cur

Re: Certificate authentication docs in multiple places

On Tue, Mar 28, 2023 at 04:28:24PM +0200, Peter Eisentraut wrote: > Sure, some cross-linking between those two sections seems sensible. Steve, would you like to propose a patch? -- Michael signature.asc Description: PGP signature

Re: Certificate authentication docs in multiple places

On Mon, Apr 10, 2023 at 09:47:08AM +0100, Steve Atkins wrote: > Yes, I’ll do that once I get some time to get the doc toolchain working. Well, if you don't want to spend time setting up a toolchain, feel free to send a patch just hacking the SGML files. I am OK to take it from there, as long as t

Re: Typo

On Tue, May 23, 2023 at 08:52:25PM +, PG Doc comments form wrote: > There appears to be a typo, here: > https://www.postgresql.org/docs/current/history.html#:~:text=Postgres95%20code%20was%20completely%20ANSI%20C. > A word or two should be added between 'completely' and 'ANSI C', such as > 're-

Re: Change "two" to "three" for decades of development in history

On Fri, Jun 23, 2023 at 03:17:26AM +0200, Erik Wienhold wrote: > An SGML entity [0] or an xsltproc stringparam [1] looks viable. Question is > how to calculate the number of decades in the Makefile. It's trivial in SQL > :) - University of California at Berkeley. With over two decades of + U

Re: Change "two" to "three" for decades of development in history

On Fri, Jun 23, 2023 at 10:50:20PM -0400, Bruce Momjian wrote: > Applied patch is "With decades of development". Thanks. -- Michael signature.asc Description: PGP signature

Re: Improvement of clarity in pg_ctl command docummentation

On Sat, Jul 15, 2023 at 05:57:40AM +, PG Doc comments form wrote: > I was reading the documentation about pg_ctl and there everything was well > written about the usage and option that can be used with the pg_ctl command > but there is not mentioned that we can not run pg_ctl command as root an

Re: Documentation does not mention that basebackup could not be used on newer major version

On Mon, Sep 18, 2023 at 10:08:30PM +0200, Laurenz Albe wrote: > On Mon, 2023-09-18 at 15:29 +, PG Doc comments form wrote: >> My main issue is that `pg_basebackup` page does not mention that this backup >> is compatible only with current version of database. I can not do basebackup >> on v11 an

Re: Minipatch concerning tags

On Fri, Oct 20, 2023 at 11:22:55AM +0300, Maxim Yablokov wrote: > PostgresPro documentation team (Ekaterina Kiryanova, Elena Indrupskaya, Oleg > Sibiryakov and me) have prepared a patch with some improvements concerning > missed/inapt tags. Please have a look. Most of what you are proposing makes

Re: Minipatch concerning tags

On Sat, Oct 21, 2023 at 04:11:50PM +0900, Michael Paquier wrote: > But not this one. This could just be "WAL senders", but we also use > the term "walsender" in physical and logical replication areas, so a > plural looks OK for me here, leaving it as it is now. I hav

Re: Minipatch concerning tags + new spelling/punctuation patch

On Mon, Oct 23, 2023 at 12:33:03PM +0300, Maxim Yablokov wrote: > We have also prepared a small patch concerning spelling, punctuation, etc. > We've decided to send it separately, so it'll be easier to review. Please > have a look. Yep, these are improvements. So applied and backpatched (all thes

Re: Typo in "43.9.1. Reporting Errors and Messages"?

On Tue, Oct 31, 2023 at 09:00:00PM +0300, Alexander Lakhin wrote: > I don't remember details, but I think the primary reason for the change > was that "RAISE_EXCEPTION" occurred in the whole tree only once (before > 66bde49d96). Now I see, that I had chosen the wrong replacement — I agree > with Eu

Re: Typo in "43.9.1. Reporting Errors and Messages"?

On Wed, Nov 01, 2023 at 09:18:47AM +0900, Michael Paquier wrote: > So you mean something like the attached then? Fixed that with f8b96c211da0 down to 11, in time for next week's release set. -- Michael signature.asc Description: PGP signature

Re: Delete description of trigger file

On Fri, Dec 01, 2023 at 11:54:14AM +0900, Shinya Kato wrote: > later disconnected, the standby goes back to step 1 and tries to > restore the file from the archive again. This loop of retries from the > archive, pg_wal, and via streaming replication goes > on until the server > -

Re: Delete description of trigger file

On Sat, Dec 02, 2023 at 05:52:50PM +0900, Shinya Kato wrote: > Thanks for the review. > Yes, that's true. A new patch is attached. Thanks, applied. -- Michael signature.asc Description: PGP signature

Re: [PATCH] Fix link to pg_ident_file_mappings

On Wed, Feb 21, 2024 at 08:50:59AM +0100, Daniel Gustafsson wrote: > On 21 Feb 2024, at 03:24, Erik Wienhold wrote: >> >> The docs on pg_reload_conf() in v15, v16, and devel have an incorrect >> link to pg_ident_file_mappings. The attached patch fixes that. > > Nice catch, will fix. Thanks you

Re: column_name of ALTER MATERIALIZED VIEW should only refer to an existing column

On Wed, May 22, 2024 at 02:59:37AM +0200, Erik Wienhold wrote: > Here's a patch for $SUBJECT. Looks like the current wording was copied > from ALTER TABLE. In ALTER VIEW we correctly state that column_name > must be an existing column. Fun. You are right, none of the patterns supported by this

Re: column_name of ALTER MATERIALIZED VIEW should only refer to an existing column

On Wed, May 22, 2024 at 02:12:36PM +0900, Michael Paquier wrote: > Will fix once we are out of release freeze time on HEAD. Thanks! And done as of dd087e1c13bf. -- Michael signature.asc Description: PGP signature

Re: A minor bug in the doc of "SQL Functions Returning Sets" in xfunc.sgml.

On Fri, Jul 19, 2024 at 10:46:04AM +0900, 日向充 wrote: > I have found executable examples that do not work correctly > in the doc of "SQL Functions Returning Sets" in xfunc.sgml. > So I fixed the examples as follows. > - Changed CREATE TABLE tab > '(y int, z int)' to '(x int, y int, z int)' > - Cha

Re: Undocumented optionality of handler_statements

On Mon, Jul 22, 2024 at 01:55:52PM +, PG Doc comments form wrote: > In > https://www.postgresql.org/docs/16/plpgsql-control-structures.html#PLPGSQL-ERROR-TRAPPING > handler_statements are documented as optional. > > However, the following example shows that handler_statements can be omitted.

Re: Table rewrite supporting functions for event triggers

On Tue, Sep 03, 2024 at 09:34:02PM +0200, Laurenz Albe wrote: > On Tue, 2024-09-03 at 11:54 -0400, Greg Sabino Mullane wrote: >> How about something like this? > > This patch looks good to me. -Returns a code explaining the reason(s) for rewriting. The exact -meaning of the codes

Re: Undocumented optionality of handler_statements

On Tue, Jul 23, 2024 at 01:25:39PM +0200, Philipp Salvisberg wrote: > read "optional" as "mandatory". They're optional, like in empty being optional. If not specified, the block goes to its END. > Therefore, I suggest to change this example by adding a NULL > statement as in other examples. This

Re: Table rewrite supporting functions for event triggers

On Wed, Sep 11, 2024 at 10:14:27AM -0400, Greg Sabino Mullane wrote: > I dunno - so would we smush them together and return something like: > > "ALTER_PERSISTENCE and COLUMN_REWRITE" If multiple are set, let's just make it text[], then. > That would be a step backwards for anyone possibly using

Re: Table rewrite supporting functions for event triggers

On Thu, Sep 12, 2024 at 08:52:00AM -0400, Greg Sabino Mullane wrote: > I do like the simplicity of the bitmap: > > if (reason & 1) > print "Table has changed from logged to unlogged" > if (reason & 2) > print "Default has been changed" > > versus with text[]: > > foreach reason in tablereaso

Re: PostgreSQLドキュメントバグ報告_9.3. 算術関数と演算子

葛西さま 2017-11-22 17:46 GMT+09:00 "葛西 裕昭(システム開発部-開発9チーム CLINKS)" : > 突然失礼いたします。 > 最新の PostgreSQL 9.6.5文書 について、 > ドキュメントのバグと思う箇所がありましたので、報告いたします。 > > 9.3. 算術関数と演算子 > 表9.5 算術関数 > 3行目　ceil(dp or numeric) > > 上記行の「戻り値型」が抜けており、「説明」以右がずれております。 > > 対象のURLは下記の通りです。 > https://www.postgresql.jp/document/9.6/h

Re: libpq options

On Wed, Nov 22, 2017 at 10:27 PM, wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.6/static/libpq-connect.html > Description: > > The documentation refers the libpq connection option "replication" > here in > "Streaming Repl

Re: libpq options

On Wed, Nov 22, 2017 at 11:36 PM, Michael Paquier wrote: > Yeah, it is mainly a developer option which is why I guess it is not > documented. Like you, I think it should be added as part of the > connection parameter, and mentioned it a couple of days back: > https://www.postgresql.or

Re: libpq options

On Tue, Nov 28, 2017 at 5:00 PM, Şahap Aşçı wrote: > I think this solves the consistency issue that i am talking about. Well, i am > just looking from documentation user point of view. Thanks. Input is always welcome. I have added an entry in the commit fest app so as this is not lost: https://c

Re: followed by example doesn't work

On Mon, Dec 4, 2017 at 11:48 PM, Tom Lane wrote: > Rudy Barbieri writes: >> But it could be better improve the documentation highlighting that in >> previous versions there was a bug. > > I see no bug here ... failing to recognize an operator that was added in > later versions can hardly be class

Re: Replication parameters in recovery.conf

On Wed, Dec 6, 2017 at 11:19 AM, Peter Eisentraut wrote: > The reasons for this are basically all historical and we are trying to > get rid of it (by moving these settings to postgresql.conf, mostly). So > I don't think we need to spend a lot of time rationalizing this at this > point. Yeah, the

Re: Missing column_constraint explanation

On Wed, Dec 20, 2017 at 6:08 PM, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.6/static/sql-altertable.html > Description: > > Missing column_constraint explanation in parameters section Those docs say

Re: Missing column_constraint explanation

On Thu, Dec 21, 2017 at 12:15 PM, Stephen Frost wrote: > Now, if we could do that in such a way that we avoid having to actually > duplicate the 'source' for these productions into different places in > the documentation, that would be fantastic because it certainly isn't > fun having to find all

Re: Missing column_constraint explanation

On Sat, Jan 13, 2018 at 09:06:22PM -0500, Stephen Frost wrote: > I'm not really sure that we want to go there for this case though. > Perhaps others disagree, but that seems like a lot to avoid this > particular duplication, which really isn't all that bad. > > This patch also seems to have gotten

Re: Missing column_constraint explanation

On Sun, Jan 14, 2018 at 09:33:13AM -0500, Stephen Frost wrote: > I'm not really sure why the thread keeps getting broken, but the > original was here: > > https://www.postgresql.org/message-id/flat/CAB_COdgOoA=G18RhWPoW8zZ+xOxTns7xD7psHA=ct+xccok...@mail.gmail.com#CAB_COdgOoA=G18RhWPoW8zZ+xOxTns7x

Re: Correction of intermediate certificate handling

On Mon, Jan 15, 2018 at 07:22:38PM -0500, Bruce Momjian wrote: > I asked Stephen Frost and David Steele for details on the arcane art of > SSL certificate creation. They showed me scripts they use and explained > that they properly pass intermediate certificates to clients. The trick > was to use

Re: Correction of intermediate certificate handling

On Tue, Jan 16, 2018 at 11:21:22AM -0500, Bruce Momjian wrote: > On Tue, Jan 16, 2018 at 02:33:05PM +0900, Michael Paquier wrote: > > This bit is important. I am happy that your patch mentions that > > intermediate certificates avoid the need to store root ones on the > > cl

Re: Correction of intermediate certificate handling

On Tue, Jan 16, 2018 at 10:23:44PM -0500, Bruce Momjian wrote: > On Wed, Jan 17, 2018 at 09:09:50AM +0900, Michael Paquier wrote: > > On Tue, Jan 16, 2018 at 11:21:22AM -0500, Bruce Momjian wrote: > > > On Tue, Jan 16, 2018 at 02:33:05PM +0900, Michael Paquier wrote: > >

Re: Correction of intermediate certificate handling

On Wed, Jan 17, 2018 at 08:39:55AM -0500, Bruce Momjian wrote: > On Wed, Jan 17, 2018 at 07:34:42AM -0500, Bruce Momjian wrote: > > > The succession of commands of commands for the intermediate certificates > > > is wild. Could it be possible to explain what each command means? Users > > > would no

Re: Correction of intermediate certificate handling

On Wed, Jan 17, 2018 at 07:34:42AM -0500, Bruce Momjian wrote: > On Wed, Jan 17, 2018 at 05:20:00PM +0900, Michael Paquier wrote: > > The succession of commands of commands for the intermediate certificates > > is wild. Could it be possible to explain what each command means? User

Re: Correction of intermediate certificate handling

On Wed, Jan 17, 2018 at 09:00:17PM -0500, Bruce Momjian wrote: > On Thu, Jan 18, 2018 at 10:25:03AM +0900, Michael Paquier wrote: > > /etc/ssl/openssl.cnf is not available on macos or Windows, which can > > lead to a bit of confusion as I would imagine that people would >

Re: What does "Table rewrite" mean?

On Fri, Jan 19, 2018 at 11:33:43AM -0500, Tom Lane wrote: > It means reading the whole table and writing it out in some modified > form (for instance, with some column transformed into a new datatype). > It's not "dangerous" in any way ... but if you've got many GB of data in > the table and you ca

Re: Correction of intermediate certificate handling

On Fri, Jan 26, 2018 at 08:09:30AM -0500, Bruce Momjian wrote: > On Thu, Jan 25, 2018 at 10:59:23PM -0500, Peter Eisentraut wrote: > > If you change the Makefile rule for generating the client CA to omit the > > -extensions v3_ca option, then the first test will fail. > > Oh, very good! Good poin

Re: i think there's a typo

On Thu, Feb 15, 2018 at 11:06:27PM +, PG Doc comments form wrote: > SELECT usename FROM pg_user; > > should be > SELECT pg_user.usename FROM pg_user; This is perfectly valid SQL. The column selected is assumed to be from pg_user. -- Michael signature.asc Description: PGP signature

Re: docu bug?

On Mon, Feb 19, 2018 at 01:54:24PM +, PG Doc comments form wrote: > The sample works with a NON-persistent connection (psql -c): > > > 25.3.6.1. Standalone Hot Backups > ... touch /var/lib/pgsql/backup_in_progress > psql -c "select pg_start_backup('hot_backup');" > tar -cf /var/lib/pgsql

Re: docu bug?

On Tue, Feb 20, 2018 at 08:00:35AM +, Zwettler Markus (OIZ) wrote: > Yes. I think the exclusive backup method should be mentioned > especially as it is the older one. Attached is a suggestion of patch. What do you think? -- Michael diff --git a/doc/src/sgml/backup.sgml b/doc/src/sgml/backup.

Re: pg_hba_file_rules permission issue

On Fri, Feb 23, 2018 at 09:41:27AM +, PG Doc comments form wrote: > According to the documentation, I assume normal users will be able to view > pg_hba_file_rules once they are granted select privileges. But for the > privileged user it's giving following error while trying to view records: >

Re: libpq options

On Thu, Mar 01, 2018 at 01:35:54AM -0800, Andres Freund wrote: > On 2017-11-25 19:05:54 +0900, Michael Paquier wrote: >> A Boolean value of true tells the backend >> + to go into walsender mode, wherein a small set of replication >> commands >> + c

Re: MacPorts xsltproc is very slow?

On Sat, Mar 03, 2018 at 09:34:58AM +1300, Thomas Munro wrote: > Recently I've been unable to build the documentation intermittently, > and I think it's because sourceforge.net has become flakey. Let me > try right now... > > $ make docs XSLTPROC=/usr/bin/xsltproc > ...blah blah blah... > warning:

Re: libpq options

On Fri, Mar 02, 2018 at 12:58:50PM +0100, Magnus Hagander wrote: > To nitpick: > > + protocol. A Boolean value of true tells the > backend > > We don't really have boolean values here, do we? It's just the string true > that's treated as a boolean by the backend. It just sounds really weird

Re: libpq options

On Tue, Mar 06, 2018 at 09:05:38PM -0500, Peter Eisentraut wrote: > I didn't like so much shrinking down the protocol section. I have often > wanted *more* detail there, not less. So I combined your patch for the > libpq chapter and added a bit more in the protocol chapter as well. > > Committed

Re: document json[b] limitation

On Wed, Apr 25, 2018 at 06:50:51PM +0300, Oleg Bartunov wrote: > Oops, it should be 256 Mb :) The numbers you are presenting are right, aka 1GB for json: =# create table aa (a json); CREATE TABLE =# insert into aa select ('{"key":"' || repeat('a', 512 * 1024 * 1024) || repeat('a', 500 * 1024

Re: authentication methods sections

On Sat, Apr 21, 2018 at 10:21:03AM -0400, Peter Eisentraut wrote: > On 4/14/18 17:20, Magnus Hagander wrote: > > On Thu, Apr 12, 2018 at 2:37 AM, Peter Eisentraut > > > > wrote: > > > > I find that the section authentication methods > >

Re: Table 28.4. wait_event description typo

On Wed, May 30, 2018 at 10:12:29AM +0300, Pavlo Golub wrote: > On monitoring statistic page [1] we have typo. Table 28.4. wait_event > description contains: > > ... > ClientRead Waiting to read data from the client. > ClientWrite Waiting to write data from the client. > ... >

Re: Table 28.4. wait_event description typo

On Wed, May 30, 2018 at 01:30:08PM -0400, Alvaro Herrera wrote: > I do not think that patch does what you think it does. Oops. Sorry another patch got on the way. Here you go. -- Michael diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index c278076e68..c2adb22dff 100644

Re: Table 28.4. wait_event description typo

On Wed, May 30, 2018 at 02:14:42PM -0400, Alvaro Herrera wrote: > Okay, pushed. Because of the sgml to xml conversion, it didn't apply to > pg10 cleanly. Thanks Álvaro. -- Michael signature.asc Description: PGP signature

Re: Typo in sql-revoke.html

On Sun, Jun 10, 2018 at 01:31:34AM +0200, Erwin Brandstetter wrote: > Replace > "and user B has in turned granted it to user C" > with > "and user B has in turn granted it to user C" > > Affects versions 7.4 - 11. Thanks for the report, Erwin! A fix has been pushed down to 9.3. -- Michael sign

Re: slight grammar error

On Fri, Jun 08, 2018 at 10:46:33PM +, PG Doc comments form wrote: > The sentence: > > "This setting will often help to reduce transaction latency, but it also can > an adverse effect on performance" > > should be: > > "This setting will often help to reduce transaction latency, but it also c

Re: Changes in serial / sequence introduced in Postgresql 10

On Tue, Jun 19, 2018 at 02:49:08PM -0400, Bruce Momjian wrote: > I don't think we realize there was a behavioral change here. I think we > were just trying to fix the case where the sequence maximum didn't match > the serial maximum. I am not sure if it is worth documenting it at this > point tho

Re: search.cpan.org is EOL, update links

On Thu, Jun 28, 2018 at 01:00:47PM +0200, Daniel Gustafsson wrote: > search.cpan.org has now been EOL’d and turned off, with all URLs redirecting > to > metacpan.org [1]. While the redirects are likely to the maintained for a long > time, we might as well update to avoid the risk of stale redirec

Re: search.cpan.org is EOL, update links

On Fri, Jun 29, 2018 at 08:29:16AM +0200, Daniel Gustafsson wrote: > Good point, we might as well do that too. Fixed those two and an additional > one in the attached updated version. Did you notice the paragraph at the top of ppport.h? This is a file automatically generated so it does not sound

Re: Dead link to hp docs

On Sun, Jul 01, 2018 at 11:29:47AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.6/static/ssl-tcp.html > Description: > > In the "18.9.1. Using Client Certificates" the link to ssl certs usage >

Re: Build PostgreSQL manually with uuid

On Sun, Jul 01, 2018 at 10:04:01PM +, PG Doc comments form wrote: > Following the documentation at > https://www.postgresql.org/docs/10/static/install-procedure.html and > configuring the option --with-uuid=ossp won't build the uuid-ossp extension > at the following make / make install steps. F

Re: Release note trimming: another modest proposal

On Mon, Aug 06, 2018 at 08:14:23AM +0100, Dean Rasheed wrote: > On 5 August 2018 at 23:57, Tom Lane wrote: >> Anyway, I'd like to propose a compromise position that I don't think >> has been discussed before: let's drop release notes for branches >> that were already EOL when a given branch was re

Re: password storage docs

On Mon, Aug 20, 2018 at 01:35:56PM +1200, Richard Hector wrote: > I can't find information about the storage format for that at all - > other than "... and supports storing passwords on the server in a > cryptographically hashed form that is thought to be secure." > > It would be nice to see more

"System roles" mentioned in psql documentation

Hi all, I have noticed that psql documentation mentions "system roles", however in all other parts of the docs, we use the term "default roles". Shouldn't we make this term more consistent and also add a link to the table describing those roles? Please see the attached. Thanks, -- Michael diff -

Re: "System roles" mentioned in psql documentation

On Thu, Aug 23, 2018 at 10:53:35AM +0200, Jürgen Purtz wrote: > This inconsistency is part of the more general problem that we miss a > chapter, where our basic terms like 'database', 'cluster', 'segment', > 'catalog', 'schema', ... are explicitly defined. You may have a point here, not in the way

Re: you need this kind of explanation

On Mon, Sep 03, 2018 at 08:05:33AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/10/static/index.html > Description: > > right off the bat, you should have this kind of explanation up there in > c

Re: Ambiguity in restore_command for recovery.conf

On Tue, Sep 18, 2018 at 04:10:17PM +, PG Doc comments form wrote: > Documentation for restore_command in recovery.conf only says, "This > parameter is required for archive recovery, but optional for streaming > replication," but it doesn't say specifically when the restore_command > string will

Re: Mention FK creation take ShareRowExclusiveLock on referenced table

On Tue, Sep 18, 2018 at 12:32:54PM +0200, Adrien NAYRAT wrote: > A few days ago I was surprised a CREATE TABLE containing FK constraint was > stuck due to an automatic vacuum freeze (which took ShareUpdateExclusiveLock > if I remember) on referenced table. Right. See the top of vacuum_rel() where

Re: Mention FK creation take ShareRowExclusiveLock on referenced table

On Thu, Sep 20, 2018 at 08:23:45AM +0200, Adrien Nayrat wrote: > Yes, here is the patch. Thanks Adrien. I have reworded a bit the thing, fixed a typo, and pushed down to v11 where this applied without conflicts. -- Michael signature.asc Description: PGP signature

Re: Mention FK creation take ShareRowExclusiveLock on referenced table

On Fri, Sep 21, 2018 at 09:09:36AM +0200, Adrien NAYRAT wrote: > Thanks! As it could happen even on previous version, should we > backpatch for the documentation? I have patched HEAD, and then down until conflicts happened, which is v10, thinking about it as a documentation improvement. The behav

Re: pgrowlocks columns do not match docs: "modes" instead of "lock_type"

On Mon, Oct 01, 2018 at 09:42:08AM +, PG Doc comments form wrote: > The description of the pgrowlocks extension says that the function returns a > column called "lock_type". However this column is really called "modes", as > shown in contrib/pgrowlocks/pgrowlocks--1.2.sql: > > CREATE FUNCTION

Re: please inform data_directory

On Wed, Oct 10, 2018 at 03:59:59PM -0400, Bruce Momjian wrote: > What do you mean by that? I can call pg_read_file() before calling > 'SHOW data_directory'. Are you saying that pg_read_file can only read > in the data_directory? It is designed that way. Please note that v11 has added a new def

Re: Using old master as new replica after clean switchover

On Thu, Oct 25, 2018 at 11:15:51AM +0200, Jehan-Guillaume de Rorthais wrote: > On Thu, 25 Oct 2018 02:57:18 -0400 > Nikolay Samokhvalov wrote: >> My research shows that some people already rely on the following when >> planned failover (aka switchover) procedure, doing it in production: >> >> 1)

Re: Change pg_attribute textual link to an actual link

On Mon, Oct 22, 2018 at 12:09:41PM +0200, Daniel Gustafsson wrote: > I think your latter suggestion pretty much covers all we need, so updated the > patch with that too. Both the patch and the suggestions made look good to me, so committed. -- Michael signature.asc Description: PGP signature

Re: A typo in release notes

On Mon, Nov 12, 2018 at 02:15:31PM +0300, Alexander Lakhin wrote: > I believe, that the name "Masahiko Sawada" was misspelled in the > latest release notes. > See: > https://www.postgresql.org/message-id/CAD21AoB5K1qJm%2Bwj%2BTTCP-sFPiSdnd0LGd_pNAfi3VXrGKfdjw%40mail.gmail.com > The patch is attache

Re: CREATE/ALTER ROLE with NULL password

On Wed, Nov 21, 2018 at 07:36:59PM +, PG Doc comments form wrote: > The current synopsis for CREATE / ALTER ROLE give one of the allowed options > as: > [ ENCRYPTED ] PASSWORD 'password' > and the current documentation for CREATE ROLE says: > "The ENCRYPTED keyword has no effect, but is accepte

Re: CREATE/ALTER ROLE with NULL password

On Wed, Nov 21, 2018 at 11:58:25PM -0700, David G. Johnston wrote: > Should tweak the paragraph to point out this exception as well. > > The ENCRYPTED keyword has no effect, but is accepted for backwards > compatibility[, except in the PASSWORD NULL form.] The docs list the following with the pa

Re: CREATE/ALTER ROLE with NULL password

On Thu, Nov 22, 2018 at 09:54:07AM -0700, David G. Johnston wrote: > On Thursday, November 22, 2018, Michael Paquier wrote: >> The docs list the following with the patch as supported grammar: >> [ ENCRYPTED ] PASSWORD 'password' | PASSWORD NULL >> And it seems t

Re: typo

On Mon, Nov 26, 2018 at 12:47:51AM +, PG Doc comments form wrote: > Correction: A table that has columns with potentially large entries will > have an associated TOAST table, which is used for out-of-line storage of > field values that are too large to keep in the table rows "PROPERLY". Thanks

Re: typo

On Mon, Nov 26, 2018 at 08:17:06AM +0100, Vik Fearing wrote: > On 26/11/2018 08:03, Magnus Hagander wrote: >> Are you sure that's right? To me the original wording of that sentence >> seems to convey the message properly, and the update done does not? > > Yeah, I just found this on the committers l

Re: typo

On Mon, Nov 26, 2018 at 09:14:18AM -0500, Tom Lane wrote: > But I can see that a lot of people might not be familiar with that usage, > so I've got no objections to rewriting it more clearly --- any > suggestions? It has been suggested upthread to use "in the table rows themselves", which does not

Re: Return codes for archive and restore commands

On Wed, Nov 28, 2018 at 11:00:31AM +, PG Doc comments form wrote: > For the archive command: > <=128 There are not errors in the PostgreSQL log (messages with severity > equal or higher than ERROR). Firstly 3 messages of type LOG about fault, > then WARNING about this and pause for 1 minute, th

Re: Return codes for archive and restore commands

On Wed, Nov 28, 2018 at 09:39:58PM -0500, Stephen Frost wrote: > Having discussed this quite a bit lately with David Steele and Magnus, > it's pretty clear that we need to completely rip out how this works > today and rewrite it based around an extension model where a background > worker can start

Re: Return codes for archive and restore commands

On Wed, Nov 28, 2018 at 10:27:31PM -0500, Stephen Frost wrote: > Yes, it couldn't be exactly the same as a generic background worker, > that's a good point. We definitely need to make sure that the > postmaster waits for the archiver to shut down, as it does for the WAL > senders. Just to be clea

Re: Typo in description of replay_lag attribute in pg_stat_replication view

On Mon, Dec 03, 2018 at 06:18:30PM +0300, Maksim Milyutin wrote: > I have noticed that in description of *flush_lag* in pg_stat_replication > view > (https://www.postgresql.org/docs/current/monitoring-stats.html#PG-STAT-REPLICATION-VIEW) > there exists unknown value of synchronous_commit parameter

Re: Typo in description of replay_lag attribute in pg_stat_replication view

On Tue, Dec 04, 2018 at 01:28:15PM +1300, Thomas Munro wrote: > On Tue, Dec 4, 2018 at 1:18 PM Michael Paquier wrote: >> Yes, you are right. It should be "on" as "remote_flush" is not a valid >> value. remote_flush is listed in SyncCommitLevel though, so t

Re: Typo in description of replay_lag attribute in pg_stat_replication view

On Wed, Dec 05, 2018 at 01:24:22AM +0300, Maksim Milyutin wrote: > Yeah, I think the notion *remote_flush level* is more appropriate especially > in the context of sync replication. Within this context maybe it makes sense > to replace the word *level* to *value* in description of *flush_lag*? I a

Re: pgBadger link needs to be updated

On Thu, Dec 13, 2018 at 10:46:22PM +, PG Doc comments form wrote: > pgBadger link needs to be updated > https://pgbadger.darold.net/ Thanks for the report. I agree that it would be nice to refresh the link to the project. Is there any objections in doing so and backpatch? -- Michael signat

Re: pgBadger link needs to be updated

On Sun, Dec 16, 2018 at 03:39:21PM +0900, Michael Paquier wrote: > Thanks for the report. I agree that it would be nice to refresh the > link to the project. Is there any objections in doing so and backpatch? Committed and back-patched, thanks Peter for the report! -- Michael signatu

Re: Broken link in JSON Types documentation

On Wed, Jan 02, 2019 at 06:11:55PM -0500, Tom Lane wrote: > In PG v10 and up this link goes to https://tools.ietf.org/html/rfc7159. > Evidently whoever updated it didn't bother to back-patch into old > branches. I don't think that really cool to have user-facing documentation which goes to the voi

Re: Broken link in JSON Types documentation

On Fri, Jan 04, 2019 at 09:50:34AM -0500, Tom Lane wrote: > I didn't quite have the energy to do something about it yesterday, > but if you do, feel free. > > (I'd suggest looking up the commit that fixed it, to see if it fixed > anything else.) Sure, that was my plan. The change is from d542859

Re: .pgpass

On Thu, Jan 10, 2019 at 11:02:08AM +0100, Daniel Gustafsson wrote: > On 10 Jan 2019, at 04:45, PG Doc comments form wrote: >> I kindly suggest to let me edit this part to create examples such as >> pg_restore -h HOST -p PORT -U SUPERUSERNAME -C -d postgres >> DBtoRESTORE.BACKUPEXTENSION >> >> th

Re: Some typos in documentation

On Sun, Jan 13, 2019 at 12:17:07AM +0300, Alexander Lakhin wrote: > While cross-checking the unique words in doc/ I found a few typos. Those are good finds, thanks for the report! > LockFileCreateWrite -- Should be spelled as LockFileCreateWRITE (as in > pgstat.c) or LockFileCreateWRITE in pg.sta

Re: Some typos in documentation

On Sun, Jan 13, 2019 at 09:34:36AM +0900, Michael Paquier wrote: > Cool, I'll see to apply them where needed. I'll just wait to see if > anybody has comments about the pgstat.c portion. And done. -- Michael signature.asc Description: PGP signature

  1   2   3   >