On Wed, May 30, 2018 at 10:12:29AM +0300, Pavlo Golub wrote: > On monitoring statistic page [1] we have typo. Table 28.4. wait_event > description contains: > > ... > ClientRead Waiting to read data from the client. > ClientWrite Waiting to write data from the client. > ... > ^^^^^ > It should state TO CLIENT.
Good catch. It seems that this is my fault as what has been done in 6f3bd98. So let's update the docs as you suggest, the attached does so FWIW. -- Michael
diff --git a/contrib/postgres_fdw/deparse.c b/contrib/postgres_fdw/deparse.c
index d272719ff4..8068e28184 100644
--- a/contrib/postgres_fdw/deparse.c
+++ b/contrib/postgres_fdw/deparse.c
@@ -1076,7 +1076,7 @@ deparseFromExpr(List *quals, deparse_expr_cxt *context)
/* Construct FROM clause */
appendStringInfoString(buf, " FROM ");
deparseFromExprForRel(buf, context->root, scanrel,
- (bms_num_members(scanrel->relids) > 1),
+ (bms_membership(scanrel->relids) == BMS_MULTIPLE),
(Index) 0, NULL, context->params_list);
/* Construct WHERE clause */
@@ -1262,7 +1262,7 @@ deparseLockingClause(deparse_expr_cxt *context)
}
/* Add the relation alias if we are here for a join relation */
- if (bms_num_members(rel->relids) > 1 &&
+ if (bms_membership(rel->relids) == BMS_MULTIPLE &&
rc->strength != LCS_NONE)
appendStringInfo(buf, " OF %s%d", REL_ALIAS_PREFIX, relid);
}
@@ -2328,7 +2328,7 @@ deparseVar(Var *node, deparse_expr_cxt *context)
int colno;
/* Qualify columns when multiple relations are involved. */
- bool qualify_col = (bms_num_members(relids) > 1);
+ bool qualify_col = (bms_membership(relids) == BMS_MULTIPLE);
/*
* If the Var belongs to the foreign relation that is deparsed as a
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index c278076e68..c2adb22dff 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -1236,7 +1236,7 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
</row>
<row>
<entry><literal>ClientWrite</literal></entry>
- <entry>Waiting to write data from the client.</entry>
+ <entry>Waiting to write data to the client.</entry>
</row>
<row>
<entry><literal>LibPQWalReceiverConnect</literal></entry>
signature.asc
Description: PGP signature
