On Tue, Feb 14, 2023 at 09:06:13AM +0000, Katsuragi Yuta wrote: > The parameter name "-Dtap-tests" in the meson's doc seems to be a typo. > I think "-Dtap_tests" is the correct name. Attached patch fixes that. > > I got an unknown options error by using "-Dtap-tests=enabled". However, > meson_options.txt told me the correct name was "-Dtap_tests".
<varlistentry id="configure-tap-tests-meson"> - <term><option>-Dtap-tests={ auto | enabled | disabled }</option></term> + <term><option>-Dtap_tests={ auto | enabled | disabled }</option></term> And meson.build refers to the same term, as of "tap_tests": # Check whether tap tests are enabled or not tap_tests_enabled = false tapopt = get_option('tap_tests') So you are indeed right. Nice catch. Will fix. -- Michael
signature.asc
Description: PGP signature