Re: Missing File weather.txt

> On 12 Jul 2025, at 18:41, Tom Lane wrote: > > Daniel Gustafsson writes: >> Or perhaps ”values are separated by a tab character”? > > WFM Thanks, I'll get this pushed once the freeze is over on REL_18_STABLE. -- Daniel Gustafsson

Re: Missing File weather.txt

Daniel Gustafsson writes: > Or perhaps ”values are separated by a tab character”? WFM regards, tom lane

Re: Missing File weather.txt

> On 12 Jul 2025, at 18:23, Tom Lane wrote: > > Fujii Masao writes: >>> On 2025/07/12 7:18, Daniel Gustafsson wrote: >>> It should, fixed in v3. > >> LGTM. Thanks! > > I'm okay with this too. I find myself niggling a bit at the > parenthetical remark "the white space on each line is actually

Re: Missing File weather.txt

Fujii Masao writes: > On 2025/07/12 7:18, Daniel Gustafsson wrote: >> It should, fixed in v3. > LGTM. Thanks! I'm okay with this too. I find myself niggling a bit at the parenthetical remark "the white space on each line is actually a tab character". There's several tabs on each line, so use o

Re: Missing File weather.txt

On 2025/07/12 7:18, Daniel Gustafsson wrote: On 11 Jul 2025, at 01:36, Fujii Masao wrote: Since the prcp column isn't specified, its value is NULL. So shouldn't the fourth field in the data line above be \N instead of 0.0? It should, fixed in v3. LGTM. Thanks! Regards, -- Fujii Masao

Re: Missing File weather.txt

> On 11 Jul 2025, at 01:36, Fujii Masao wrote: > Since the prcp column isn't specified, its value is NULL. So shouldn't > the fourth field in the data line above be \N instead of 0.0? It should, fixed in v3. -- Daniel Gustafsson v3-0001-doc-Add-example-file-for-COPY.patch Description: Binary

Re: Missing File weather.txt

On 2025/07/11 7:22, Daniel Gustafsson wrote: On 5 Jul 2025, at 19:29, Tom Lane wrote: Fujii Masao writes: On 2020/01/28 19:18, Daniel Gustafsson wrote: This is only mentioned as an example of another input method, with a link to the COPY page for more information. That being said, it's a

Re: Missing File weather.txt

> On 5 Jul 2025, at 19:29, Tom Lane wrote: > > Fujii Masao writes: >> On 2020/01/28 19:18, Daniel Gustafsson wrote: >>> This is only mentioned as an example of another input method, with a link to >>> the COPY page for more information. That being said, it's a good thing for >>> a >>> tutorial

Re: Missing File weather.txt

Fujii Masao writes: > On 2020/01/28 19:18, Daniel Gustafsson wrote: >> This is only mentioned as an example of another input method, with a link to >> the COPY page for more information. That being said, it's a good thing for a >> tutorial to be self-contained, and going from a basic tutorial to

Re: Missing File weather.txt

On 2020/01/28 19:18, Daniel Gustafsson wrote: On 28 Jan 2020, at 03:22, PG Doc comments form wrote: The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/tutorial-populate.html Description: On this page https://www.postgresql.org/docs/

Re: Missing word

What about sth like that: Normally the set of partitions established when initially defining the > table is not intended to remain static. It is common to want to remove > partitions holding old data and periodically add new partitions for new > data. One of the most important advantages of partit

Re: Missing word

=?utf-8?Q?=C3=81lvaro?= Herrera writes: > On 2025-May-13, Tom Lane wrote: >>> "Another option that is often preferable is to remove the partition >>> from the partitioned table but retain access to it as a table in its own >>> right." >> AFAICS, it's correct as written. > Yeah, but maybe it woul

Re: Missing word

On 2025-May-13, Tom Lane wrote: > PG Doc comments form writes: > > In the paragraph: > > https://www.postgresql.org/docs/current/ddl-partitioning.html#DDL-PARTITIONING-DECLARATIVE-MAINTENANCE, > > sentence "Another option that is often preferable is to remove the partition > > from the partitione

Re: Missing word

Ok you are right, I get it now but still I think this can be written more clearly. wt., 13 maj 2025, 16:19 użytkownik Tom Lane napisał: > PG Doc comments form writes: > > In the paragraph: > > > https://www.postgresql.org/docs/current/ddl-partitioning.html#DDL-PARTITIONING-DECLARATIVE-MAINTENAN

Re: Missing word

PG Doc comments form writes: > In the paragraph: > https://www.postgresql.org/docs/current/ddl-partitioning.html#DDL-PARTITIONING-DECLARATIVE-MAINTENANCE, > sentence "Another option that is often preferable is to remove the partition > from the partitioned table but retain access to it as a table

Re: Missing word

On Tuesday, May 13, 2025, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/17/ddl-partitioning.html > Description: > > In the paragraph: > https://www.postgresql.org/docs/current/ddl-partitioning. > html#DD

Re: missing command?

> On 15 Oct 2024, at 00:57, PG Doc comments form wrote: > In this list of commands: > https://www.postgresql.org/docs/current/reference-client.html > Should this one be included? --> pg_ctl pg_ctl is a server application, it is included here: https://www.postgresql.org/docs/devel/reference-se

Re: Missing information on '-X' in section 26.3.6.1.

On Fri, Feb 2, 2024 at 12:41 PM David G. Johnston < david.g.johns...@gmail.com> wrote: > > The attached patch moves this paragraph there. I distilled the paragraph > down to its essence, but am open to being a bit more wordy, and consider > more how this fits into the existing content of that pag

Re: Missing examples for hash partitioning

On Sun, 5 May 2024 at 19:27, David Rowley wrote: > There are examples of hash partitioning in [1]. Maybe we should add a > link so those can be more easily found. I see the link is already there, per: "See CREATE TABLE for more details on creating partitioned tables and partitions." David > [

Re: Missing examples for hash partitioning

On Sun, 5 May 2024 at 08:13, PG Doc comments form wrote: > Page: https://www.postgresql.org/docs/16/ddl-partitioning.html > Description: > > There is no example showing the syntax of Hash Partitioning in this section > of the documentation, it's missing. There are examples of hash partitioning in

Re: Missing | ?

Laurenz Albe writes: > On Mon, 2024-02-19 at 09:37 +, PG Doc comments form wrote: >> Page: https://www.postgresql.org/docs/16/sql-security-label.html >> FOREIGN TABLE object_name >> >> ...probably should have a following "|", I think? > Absolutely! Indeed. Will fix, thanks for report!

Re: Missing | ?

On Mon, 2024-02-19 at 09:37 +, PG Doc comments form wrote: > Page: https://www.postgresql.org/docs/16/sql-security-label.html > > FOREIGN TABLE object_name > > ...probably should have a following "|", I think? Absolutely! Yours, Laurenz Albe

Re: Missing information on '-X' in section 26.3.6.1.

On Wed, Jan 24, 2024 at 2:19 AM Daniel Gustafsson wrote: > > On 23 Jan 2024, at 21:43, David G. Johnston > wrote: > > > > On Tue, Jan 23, 2024 at 1:30 PM PG Doc comments form < > nore...@postgresql.org > wrote: > > The following documentation comment has been logge

Re: Missing information on '-X' in section 26.3.6.1.

> On 23 Jan 2024, at 21:43, David G. Johnston > wrote: > > On Tue, Jan 23, 2024 at 1:30 PM PG Doc comments form > wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/continuous-archiving.html

Re: Missing information on '-X' in section 26.3.6.1.

On Tue, Jan 23, 2024 at 1:30 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/continuous-archiving.html > Description: > > I noticed, that in section 26.3.6.1. it's not specified, what the -X > parame

Re: Missing "CONSTRAINT" keyword in ADD CONSTRAINT form?

On Monday, December 4, 2023, Tim Needham wrote: > Bah, scratch that, sorry again. It's because "CONSTRAINT" is implied by > the reference to CREATE DOMAIN, isn't it? > Yes, we require the reader to go to the create domain page to read the “domain_constraint” portion of the syntax. David J.

Re: Missing "CONSTRAINT" keyword in ADD CONSTRAINT form?

Bah, scratch that, sorry again. It's because "CONSTRAINT" is implied by the reference to CREATE DOMAIN, isn't it? Sorry. On Mon, Dec 4, 2023 at 8:29 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/s

Re: Missing documentation for FETCH FIRST in chapter 7.6

On Wed, Jun 13, 2018 at 04:17:55PM -0300, Euler Taveira wrote: > 2018-05-16 10:22 GMT-03:00 PG Doc comments form : > > The documentation of the SELECT statement lists FETCH FIRST/OFFSET as an > > alternative to the proprietary LIMIT clause. > > > > https://www.postgresql.org/docs/current/static/sql

Re: Missing ;

> On 10 Nov 2023, at 22:00, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/sql-select.html > Description: > > Hi, > > To be consistent, the "with" example should end in a ";". > > WITH t AS ( >

Re: Missing word? https://www.postgresql.org/docs/current/continuous-archiving.html#BACKUP-ARCHIVING-WAL

>>> "Another way to archive is to use a custom archive module as the >>> archive_library" >> >> shouldn't this read: >> "Another way to archive this is to use a custom archive module as the >> archive_library" >That would be worse than the original. What is "this"? >I'd suggest "Another way to

Re: Missing word? https://www.postgresql.org/docs/current/continuous-archiving.html#BACKUP-ARCHIVING-WAL

On Mon, 2023-10-30 at 13:15 +, Daniel Westermann (DWE) wrote: > "Another way to archive is to use a custom archive module as the > archive_library" > > shouldn't this read: > "Another way to archive this is to use a custom archive module as the > archive_library" That would be worse than th

Re: Missing closing ]

PG Doc comments form writes: > In the example session at > https://www.postgresql.org/docs/current/rangetypes.html#RANGETYPES-EXAMPLES > there are missing closing square bracket ] > Take a look below > CREATE TABLE reservation (room int, during tsrange); > INSERT INTO reservation VALUES > (1

Re: missing GRANTED BY explanations

On Saturday, September 30, 2023, PG Doc comments form < nore...@postgresql.org> wrote: > > > In the documentation for revoke command, there is no description for > GRANTED > BY clause. > > As the doc says read the grant page for more detailed information. Repeating everything here was deemed redund

Re: missing GRANTED BY explanations

On Sat, Sep 30, 2023 at 1:56 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/sql-revoke.html > Description: > > Hi, > In the documentation for revoke command, there is no description for > GRANTED >

Re: Missing documentation

Thanks! This helps. On Thu, Nov 3, 2022, 18:40 Alvaro Herrera wrote: > On 2022-Nov-03, Tom Lane wrote: > > > Stefan Badenhorst writes: > > > I am using a prometheus exporter: > > > https://github.com/prometheus-community/postgres_exporter/ > > > > Hmm, well, maybe prometheus is doing something

Re: Missing documentation

On 2022-Nov-03, Tom Lane wrote: > Stefan Badenhorst writes: > > I am using a prometheus exporter: > > https://github.com/prometheus-community/postgres_exporter/ > > Hmm, well, maybe prometheus is doing something with that part of the URL. > There's no such behavior in Postgres itself, though. Y

Re: Missing documentation

I am using a prometheus exporter: https://github.com/prometheus-community/postgres_exporter/ Turning JIT off definitely made a big difference to all our environments. When using JIT it causes OOM on postgres server after a few days. Adding jit=off resolved the issue. I have tested this now for seve

Re: Missing documentation

Stefan Badenhorst writes: > I am using a prometheus exporter: > https://github.com/prometheus-community/postgres_exporter/ Hmm, well, maybe prometheus is doing something with that part of the URL. There's no such behavior in Postgres itself, though. regards, tom lane

Re: Missing documentation

Stefan Badenhorst writes: > This is working: > postgresql://USERNAME:PASSWORD@server > :5432/the_database?sslmode=disable&jit=off Again, not for me: $ psql 'postgresql://postgres@localhost:5432/mydb?sslmode=disable&jit=off' psql: error: invalid URI query parameter: "jit" I suspect something in

Re: Missing documentation

This is working: postgresql://USERNAME:PASSWORD@server :5432/the_database?sslmode=disable&jit=off Maybe I was looking at the wrong documentation page? On Thu, 3 Nov 2022 at 14:58, Tom Lane wrote: > PG Doc comments form writes: > > On this page: > > > https://www.postgresql.org/docs/current/libp

Re: Missing documentation

PG Doc comments form writes: > On this page: > https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PARAMKEYWORDS > There is a list of keywords that can be specified as part of the connection > string. > Specifying `jit=off` or `jit=on` is functional in practice, but `jit` is > not i

Re: Missing example for SAVEPOINT using the same savepoint name

Hello! The new sample code looks clearer I agree! Seb From: David G. Johnston Sent: Tuesday, April 12, 2022 4:41 PM To: Sebastien Flaesch ; Pg Docs Subject: Re: Missing example for SAVEPOINT using the same savepoint name EXTERNAL: Do not click links or open

Re: Missing example for SAVEPOINT using the same savepoint name

On Mon, Apr 11, 2022 at 9:43 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/14/sql-savepoint.html > Description: > > The "Compatibility" section deserves some code example to illustrate the > behavior

Re: Missing tags ALTER ROUTINE and DROP ROUTINE in Event Trigger Firing Matrix

Hi Leslie, On Sat, Mar 05, 2022 at 10:15:33AM +, PG Doc comments form wrote: > "ALTER ROUTINE" and "DROP ROUTINE" are not listed in the "Event Trigger > Firing Matrix" documentation page, even though these tags seem supported > from PostgreSQL 11 onwards. > > It would be really useful to ment

Re: Missing information about CREATE TRIGGER on temporary tables

PG Doc comments form writes: > The reference page about CREATE TRIGGER should indicate if it's allowed to > create triggers on temp tables. > This seems to be the supported, but I was wondering what happens with the > trigger name when created on a temp table. The page already says The name

Re: Missing information about CREATE TRIGGER on temporary tables

On Tue, Mar 8, 2022 at 9:25 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/14/sql-createtrigger.html > Description: > > To be confirmed by the developer community... > The reference page about CREATE T

Re: missing a white space in the last sentence of 51.6. Executor

On 1/17/22 2:02 PM, Tom Lane wrote: PG Doc comments form writes: The last sentence of 51.6. Executor appears: "...feeding that up toModifyTable to perform the insertion." Hm, the space is definitely there in the source file: A simple INSERT ... VALUES command creates a trivial plan

Re: missing a white space in the last sentence of 51.6. Executor

PG Doc comments form writes: > The last sentence of 51.6. Executor appears: > "...feeding that up toModifyTable to perform the insertion." Hm, the space is definitely there in the source file: A simple INSERT ... VALUES command creates a trivial plan tree consisting of a single Result

Re: Missing mention of autovacuum_work_mem

On Mon, 2021-09-27 at 09:25 +0900, Michael Paquier wrote: > On Sat, Sep 25, 2021 at 07:51:15AM +0900, Michael Paquier wrote: > > WFM. > > This has been applied and backpatched as of 1ba8410. Thank you! Yours, Laurenz Albe

Re: Missing mention of autovacuum_work_mem

On Sat, Sep 25, 2021 at 07:51:15AM +0900, Michael Paquier wrote: > WFM. This has been applied and backpatched as of 1ba8410. -- Michael signature.asc Description: PGP signature

Re: Missing mention of autovacuum_work_mem

On Fri, Sep 24, 2021 at 12:21:40PM -0300, Euler Taveira wrote: > Good point. However, I prefer "if set". WFM. -- Michael signature.asc Description: PGP signature

Re: Missing mention of autovacuum_work_mem

On Thu, Sep 23, 2021, at 7:18 AM, Michael Paquier wrote: > On Thu, Sep 23, 2021 at 10:48:37AM +0200, Laurenz Albe wrote: > > Thanks, and +1 from me. > > maintenance_work_mem would be used in the context of autovacuum if > autovacuum_work_mem is -1, but it seems to me that the suggested > wording s

Re: Missing mention of autovacuum_work_mem

On Thu, Sep 23, 2021 at 10:48:37AM +0200, Laurenz Albe wrote: > Thanks, and +1 from me. maintenance_work_mem would be used in the context of autovacuum if autovacuum_work_mem is -1, but it seems to me that the suggested wording sounds like only autovacuum_work_mem is used and that it would never f

Re: Missing mention of autovacuum_work_mem

On Wed, 2021-09-22 at 17:45 -0300, Euler Taveira wrote: > On Mon, Sep 20, 2021, at 10:40 AM, nikolai.berkoff wrote: > > Yes that reads better still. > I'm attaching a patch with Laurenz's words. Thanks, and +1 from me. Yours, Laurenz Albe

Re: Missing mention of autovacuum_work_mem

On Mon, Sep 20, 2021, at 10:40 AM, nikolai.berkoff wrote: > Yes that reads better still. I'm attaching a patch with Laurenz's words. -- Euler Taveira EDB https://www.enterprisedb.com/ From 41f814b15349bcc8eb8ffa4624ed5af80f3476ac Mon Sep 17 00:00:00 2001 From: Euler Taveira Date: Wed, 22 Sep 2

Re: Missing mention of autovacuum_work_mem

> Why not keep it simple with > > "If a table has any indexes, this will happen at least once per vacuum, > > after the heap has been completely scanned. It may happen multiple times per > > vacuum if maintenance_work_mem (or, in the case of autovacuum, > > autovacuum_work_mem) is insuffici

Re: Missing mention of autovacuum_work_mem

On Mon, 2021-09-20 at 08:07 +, nikolai.berkoff wrote: > I can see in > src/backend/access/heap/vacuumlazy.c > that compute_max_dead_tuples uses autovacuum_work_mem when it is given. > > The "vacuuming indexes" documentation has: > > > "If a table has any indexes, this will happen at least once

Re: Missing mention of autovacuum_work_mem

Hi, There was no follow up to my message below so I'm raising it again. I can see in src/backend/access/heap/vacuumlazy.c that compute_max_dead_tuples uses autovacuum_work_mem when it is given. > The "vacuuming indexes" documentation has: > > "If a table has any indexes, this will happen a

Re: missing schema_name

On Mon, Mar 1, 2021 at 03:29:02PM +, Pantelis Theodosiou wrote: > > > On Mon, Mar 1, 2021 at 2:43 PM Pantelis Theodosiou wrote: > > > > On Mon, Mar 1, 2021 at 1:42 PM PG Doc comments form > > wrote: > > The following documentation comment has been logged on the website

Re: missing schema_name

On Mon, Mar 1, 2021 at 2:43 PM Pantelis Theodosiou wrote: > > > On Mon, Mar 1, 2021 at 1:42 PM PG Doc comments form < > nore...@postgresql.org> wrote: > >> The following documentation comment has been logged on the website: >> >> Page: https://www.postgresql.org/docs/13/sql-createschema.html >> D

Re: missing schema_name

On Mon, Mar 1, 2021 at 1:42 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/13/sql-createschema.html > Description: > > The second and forth syntax for CREATE SCHEMA is missing schema_name. > Right. It

Re: Missing time zone data

PG Doc comments form writes: > pg_timezone_names supposedly has the list of full time zone names (e.g., > US/Eastern) used in Postgresql, but all it has is the list of columns for > the list. The list itself appears to be missing. Hm, works for me: regression=# select * from pg_timezone_names;

Re: Missing file is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html

On Tue, Nov 10, 2020 at 07:23:12PM -0500, Bruce Momjian wrote: > On Tue, Nov 10, 2020 at 06:15:29PM -0500, Tom Lane wrote: > > Bruce Momjian writes: > > > On Fri, Oct 30, 2020 at 11:09:58AM -0400, Tom Lane wrote: > > >> Thinking about it from the perspective of someone dealing with an > > >> insta

Re: Missing file is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html

On Tue, Nov 10, 2020 at 06:15:29PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > On Fri, Oct 30, 2020 at 11:09:58AM -0400, Tom Lane wrote: > >> Thinking about it from the perspective of someone dealing with an > >> installation tree not a source tree, maybe the reference should > >> be to "se

Re: Missing file is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html

Bruce Momjian writes: > On Tue, Nov 10, 2020 at 06:15:29PM -0500, Tom Lane wrote: >> That is the path underneath the installation "include" directory >> at which that file will be found. > Uh, I don't see it: > $ ls -w 80 /usr/local/pgsql/include/ > ecpg_config.hlibpq

Re: Missing file is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html

On Tue, Nov 10, 2020 at 06:15:29PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > On Fri, Oct 30, 2020 at 11:09:58AM -0400, Tom Lane wrote: > >> Thinking about it from the perspective of someone dealing with an > >> installation tree not a source tree, maybe the reference should > >> be to "se

Re: Missing file is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html

Bruce Momjian writes: > On Fri, Oct 30, 2020 at 11:09:58AM -0400, Tom Lane wrote: >> Thinking about it from the perspective of someone dealing with an >> installation tree not a source tree, maybe the reference should >> be to "server/catalog/pg_type_d.h". That might help disabuse >> anyone who's

Re: Missing file is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html

On Fri, Oct 30, 2020 at 11:09:58AM -0400, Tom Lane wrote: > Euler Taveira writes: > > On Tue, 27 Oct 2020 at 13:54, Bruce Momjian wrote: > >> Uh, in my source tree that is a symlink to > >> src/backend/catalog/pg_type_d.h, but that file is generated by > >> src/backend/catalog/genbki.pl. Does th

Re: Missing file is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html

Euler Taveira writes: > On Tue, 27 Oct 2020 at 13:54, Bruce Momjian wrote: >> Uh, in my source tree that is a symlink to >> src/backend/catalog/pg_type_d.h, but that file is generated by >> src/backend/catalog/genbki.pl. Does that help you? > Shouldn't we replace "are defined in the file" with

Re: Missing file is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html

On Tue, 27 Oct 2020 at 13:54, Bruce Momjian wrote: > On Tue, Oct 27, 2020 at 10:48:00AM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/13/libpq-exec.html > > Description: > > > > On page http

Re: Missing directory is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html.

On Tue, Oct 27, 2020 at 01:32:49PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Tue, Oct 27, 2020 at 12:54:36PM -0400, Tom Lane wrote: > >> The removal only happened in HEAD, so I'm unclear on why you back-patched > >> this doc change? > > > Uh, at the top of all my branches, I typed: >

Re: Missing directory is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html.

Bruce Momjian writes: > On Tue, Oct 27, 2020 at 12:54:36PM -0400, Tom Lane wrote: >> The removal only happened in HEAD, so I'm unclear on why you back-patched >> this doc change? > Uh, at the top of all my branches, I typed: > ls */src/tools/thread > and saw no hits in _any_ of the branches

Re: Missing directory is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html.

On Tue, Oct 27, 2020 at 12:54:36PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I have applied the attached patch to all branches to remove the > > paragraph. > > The removal only happened in HEAD, so I'm unclear on why you back-patched > this doc change? Uh, at the top of all my branches,

Re: Missing file is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html

On Tue, Oct 27, 2020 at 10:48:00AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/13/libpq-exec.html > Description: > > On page https://www.postgresql.org/docs/13/libpq-exec.html, non-existing > fi

Re: Missing directory is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html.

Bruce Momjian writes: > I have applied the attached patch to all branches to remove the > paragraph. The removal only happened in HEAD, so I'm unclear on why you back-patched this doc change? But thanks for finding the reference; I'd only searched for test/thread, not tools/thread. Looks like s

Re: Missing directory is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html.

On Tue, Oct 27, 2020 at 10:54:57AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/13/libpq-threading.html > Description: > > On page https://www.postgresql.org/docs/13/libpq-exec.html, non-existing

Re: missing epoch timestamps literals in examples

PG Doc comments form writes: > I am missing how to work with unix (date)time(stamps) from epoch, e.g. > 1592203289.310 for 2020-06-15T06:41:29.31. regression=# select to_timestamp(1592203289.310); to_timestamp --- 2020-06-15 02:41:29.31-04 (1 row)

Re: Missing comma?

On 2020-05-20 08:26, Michael Paquier wrote: On Tue, May 19, 2020 at 11:14:56AM +0300, Marina Polyakova wrote: Here is a patch with a fixed commit message (primary index => primary key). Thanks, applied. Thank you! -- Marina Polyakova Postgres Professional: http://www.postgrespro.com The Rus

Re: Missing comma?

On Tue, May 19, 2020 at 11:14:56AM +0300, Marina Polyakova wrote: > Here is a patch with a fixed commit message (primary index => primary key). Thanks, applied. -- Michael signature.asc Description: PGP signature

Re: Missing comma?

On 2020-05-19 05:49, Michael Paquier wrote: On Mon, May 18, 2020 at 10:31:35PM +0300, Marina Polyakova wrote: On 2020-05-18 09:16, Michael Paquier wrote: Would you like to send an updated patch? Note that as the release of beta1 is planned for this week, we have a grace period until the versio

Re: Missing comma?

On Mon, May 18, 2020 at 10:31:35PM +0300, Marina Polyakova wrote: > On 2020-05-18 09:16, Michael Paquier wrote: >> Would you like to send an updated patch? Note that as the release of >> beta1 is planned for this week, we have a grace period until the >> version is tagged on HEAD. > > The patch i

Re: Missing comma?

On 2020-05-18 09:16, Michael Paquier wrote: On Sat, May 16, 2020 at 09:38:46PM +0300, Marina Polyakova wrote: I like if we can explain the situation in more detail. But IMO the phrase "same as default" sounds as if we will try to find the primary index and use it if the required index (with pg_

Re: Missing comma?

On Sat, May 16, 2020 at 09:38:46PM +0300, Marina Polyakova wrote: > I like if we can explain the situation in more detail. But IMO the phrase > "same as default" sounds as if we will try to find the primary index and use > it if the required index (with pg_index.indisreplident = true) does not > ex

Re: Missing comma?

On 2020-05-15 05:16, Michael Paquier wrote: On Thu, May 14, 2020 at 06:30:38PM +0300, Marina Polyakova wrote: Perhaps it will be useful for some users to know that relreplident = i does not mean that the required index exists (as in default case)?.. Yeah, that feels incomplete and I think tha

Re: Missing comma?

On Thu, May 14, 2020 at 06:30:38PM +0300, Marina Polyakova wrote: > Perhaps it will be useful for some users to know that relreplident = i does > not mean that the required index exists (as in default case)?.. Yeah, that feels incomplete and I think that it would be good to close the gap here, as

Re: Missing comma?

On 2020-05-14 03:07, Michael Paquier wrote: On Wed, May 13, 2020 at 05:17:43PM +0300, Marina Polyakova wrote: in my opinion it's a little unclear what "or default" means at the end, because the comma is used to separate enumeration elements ("d = default <...>, n = nothing, f = all columns, i

Re: Missing comma?

On Wed, May 13, 2020 at 05:17:43PM +0300, Marina Polyakova wrote: > in my opinion it's a little unclear what "or default" means at the end, > because the comma is used to separate enumeration elements ("d = default > <...>, n = nothing, f = all columns, i = index <...>") and inside the > element de

Re: Missing comma?

Thanks! P.S. Looking at the final sentence: "Columns used to form “replica identity” for rows: d = default (primary key, if any), n = nothing, f = all columns, i = index with indisreplident set, or default" in my opinion it's a little unclear what "or default" means at the end, because the

Re: Missing comma?

> On 13 May 2020, at 12:20, Marina Polyakova wrote: > https://www.postgresql.org/docs/current/catalog-pg-class.html says "Columns > used to form “replica identity” for rows: d = default (primary key, if any), > n = nothing, f = all columns i = index with indisreplident set, or default". > Am I

Re: Missing File weather.txt

> On 28 Jan 2020, at 03:22, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/tutorial-populate.html > Description: > > On this page https://www.postgresql.org/docs/12/tutorial-populate.html you > hav

Re: Missing preposition 'of'

PG Doc comments form writes: > By the end of section 7.2.1.5, the preposition 'of' is missing: > "(...) we could find out which ones those are like this: (...)" > should read > "(...) we could find out which ones of those are like this: (...)" I dunno, the existing wording seems like perfectly go

Re: Missing pg_seetings catalog name in table 49.1

On Monday, April 1, 2019 8:33 AM, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.5/catalogs-overview.html > Description: > > Table 49.1 on https://www.postgresql.org/docs/9.5/catalogs-overview.html > l

Re: missing windows info

On Mon, Nov 19, 2018 at 05:40:04PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/libpq-pgservice.html > Description: > > The default location for a user level connection service file on Windows

Re: Missing whitespace in pg_dump docs

On Fri, Oct 26, 2018 at 3:27 PM Daniel Gustafsson wrote: > The attached diff adds what seems to be a missing whitespace in the > discussion > on dump formats. > Pushed, thanks. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: Missing documentation for FETCH FIRST in chapter 7.6

2018-05-16 10:22 GMT-03:00 PG Doc comments form : > The documentation of the SELECT statement lists FETCH FIRST/OFFSET as an > alternative to the proprietary LIMIT clause. > > https://www.postgresql.org/docs/current/static/sql-select.html#SQL-LIMIT > > However, chapter 7.6 about LIMIT/OFFSET does n

Re: missing replaceable tags in backup.sgml

On Mon, May 14, 2018 at 11:11:36AM +0300, Liudmila Mantrova wrote: > Hi, > > One of the new examples in backup.sgml seems to be missing a couple of > tags. A trivial patch is attached. > diff --git a/doc/src/sgml/backup.sgml b/doc/src/sgml/backup.sgml > index 349834c..982776c 100644 > --- a/doc/

Re: Missing steps for "Building with Visual C++ or the Microsoft Windows SDK"

On 1 March 2018 at 00:31, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.6/static/install-windows-full.html > Description: > > Hi, > I am not very experienced and some of these corrections may be trivia

Re: Missing column_constraint explanation

On Sun, Jan 14, 2018 at 09:33:13AM -0500, Stephen Frost wrote: > I'm not really sure why the thread keeps getting broken, but the > original was here: > > https://www.postgresql.org/message-id/flat/CAB_COdgOoA=G18RhWPoW8zZ+xOxTns7xD7psHA=ct+xccok...@mail.gmail.com#CAB_COdgOoA=G18RhWPoW8zZ+xOxTns7x

Re: Missing column_constraint explanation

Michael, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Sat, Jan 13, 2018 at 09:06:22PM -0500, Stephen Frost wrote: > > I'm not really sure that we want to go there for this case though. > > Perhaps others disagree, but that seems like a lot to avoid this > > particular duplication, whi

Re: Missing column_constraint explanation

On Sat, Jan 13, 2018 at 09:06:22PM -0500, Stephen Frost wrote: > I'm not really sure that we want to go there for this case though. > Perhaps others disagree, but that seems like a lot to avoid this > particular duplication, which really isn't all that bad. > > This patch also seems to have gotten

  1   2   >