Re: Mark a reloption as indexterm

2019-04-16 Thread Fujii Masao
On Tue, Apr 16, 2019 at 12:26 PM Michael Paquier wrote: > > On Tue, Apr 16, 2019 at 12:14:01AM +0900, Fujii Masao wrote: > > So I used tag again for the above style if both reloption > > and guc with the same parameter name exist. Attached is the updated > > version of the patch. This patch also

Re: Mark a reloption as indexterm

2019-04-16 Thread Fujii Masao
On Tue, Apr 16, 2019 at 1:15 AM Alvaro Herrera wrote: > > On 2019-Apr-16, Fujii Masao wrote: > > > On Tue, Apr 16, 2019 at 12:35 AM Alvaro Herrera > > wrote: > > > > For autovacuum it says "configuration > > > parameters" rather than "configuration parameter". Other than that, it > > > looks goo

Re: Mark a reloption as indexterm

2019-04-15 Thread Michael Paquier
On Tue, Apr 16, 2019 at 12:14:01AM +0900, Fujii Masao wrote: > So I used tag again for the above style if both reloption > and guc with the same parameter name exist. Attached is the updated > version of the patch. This patch also marks index-reloption as indexterm. > > Barring any objections, I

Re: Mark a reloption as indexterm

2019-04-15 Thread Alvaro Herrera
On 2019-Apr-16, Fujii Masao wrote: > On Tue, Apr 16, 2019 at 12:35 AM Alvaro Herrera > wrote: > > For autovacuum it says "configuration > > parameters" rather than "configuration parameter". Other than that, it > > looks good to me. (I didn't check that all storage options were covered.) > >

Re: Mark a reloption as indexterm

2019-04-15 Thread Fujii Masao
On Tue, Apr 16, 2019 at 12:35 AM Alvaro Herrera wrote: > > On 2019-Apr-16, Fujii Masao wrote: > > > On Sat, Apr 13, 2019 at 1:30 AM Alvaro Herrera > > wrote: > > > > > > On 2019-Apr-12, Fujii Masao wrote: > > > > > > > > > > OTOH, originally I thought that the following style is smarter. > > > >

Re: Mark a reloption as indexterm

2019-04-15 Thread Alvaro Herrera
On 2019-Apr-16, Fujii Masao wrote: > On Sat, Apr 13, 2019 at 1:30 AM Alvaro Herrera > wrote: > > > > On 2019-Apr-12, Fujii Masao wrote: > > > > > > > OTOH, originally I thought that the following style is smarter. > > > > > > xxx > > > configuration parameter, XXX > > > stora

Re: Mark a reloption as indexterm

2019-04-15 Thread Fujii Masao
On Sat, Apr 13, 2019 at 1:30 AM Alvaro Herrera wrote: > > On 2019-Apr-12, Fujii Masao wrote: > > > > OTOH, originally I thought that the following style is smarter. > > > > xxx > > configuration parameter, XXX > > storage parameter, Storage Parameter > > Ah. Well, I like this

Re: Mark a reloption as indexterm

2019-04-12 Thread Alvaro Herrera
On 2019-Apr-12, Fujii Masao wrote: > OTOH, originally I thought that the following style is smarter. > > xxx > configuration parameter, XXX > storage parameter, Storage Parameter Ah. Well, I like this style. Let's do that. -- Álvaro Herrerahttps://www.2nd

Re: Mark a reloption as indexterm

2019-04-11 Thread Fujii Masao
On Fri, Apr 12, 2019 at 1:09 PM Michael Paquier wrote: > > On Thu, Apr 11, 2019 at 11:57:32PM -0400, Alvaro Herrera wrote: > > Are you suggesting that it should show "index storage parameters" and > > "table storage parameters"? I'm not sure about that myself ... > > particularly considering that

Re: Mark a reloption as indexterm

2019-04-11 Thread Fujii Masao
On Fri, Apr 12, 2019 at 12:54 PM Alvaro Herrera wrote: > > On 2019-Apr-12, Fujii Masao wrote: > > > On Wed, Apr 10, 2019 at 4:11 AM Alvaro Herrera > > wrote: > > > > > > On 2019-Apr-10, Fujii Masao wrote: > > > > > > > Hi, > > > > > > > > I'd like to propose to mark reloptions as indexterms, lik

Re: Mark a reloption as indexterm

2019-04-11 Thread Michael Paquier
On Thu, Apr 11, 2019 at 11:57:32PM -0400, Alvaro Herrera wrote: > Are you suggesting that it should show "index storage parameters" and > "table storage parameters"? I'm not sure about that myself ... > particularly considering that certain parameters might apply to some > index AMs and not others

Re: Mark a reloption as indexterm

2019-04-11 Thread Alvaro Herrera
On 2019-Apr-12, Michael Paquier wrote: > On Fri, Apr 12, 2019 at 12:33:45PM +0900, Fujii Masao wrote: > > Indeed. Attached is the updated version of the patch. > > On top of what Alvaro has mentioned, it seems to me that we should > make the difference between table-level configuration parameter

Re: Mark a reloption as indexterm

2019-04-11 Thread Alvaro Herrera
On 2019-Apr-12, Fujii Masao wrote: > On Wed, Apr 10, 2019 at 4:11 AM Alvaro Herrera > wrote: > > > > On 2019-Apr-10, Fujii Masao wrote: > > > > > Hi, > > > > > > I'd like to propose to mark reloptions as indexterms, like GUC, > > > so that users can more easily search the pages describing > > >

Re: Mark a reloption as indexterm

2019-04-11 Thread Michael Paquier
On Fri, Apr 12, 2019 at 12:33:45PM +0900, Fujii Masao wrote: > Indeed. Attached is the updated version of the patch. On top of what Alvaro has mentioned, it seems to me that we should make the difference between table-level configuration parameter and index-level configuration parameters, and also

Re: Mark a reloption as indexterm

2019-04-11 Thread Fujii Masao
On Wed, Apr 10, 2019 at 4:11 AM Alvaro Herrera wrote: > > On 2019-Apr-10, Fujii Masao wrote: > > > Hi, > > > > I'd like to propose to mark reloptions as indexterms, like GUC, > > so that users can more easily search the pages describing > > a reloption in document. Attached is the patch which does

Re: Mark a reloption as indexterm

2019-04-09 Thread Alvaro Herrera
On 2019-Apr-10, Fujii Masao wrote: > Hi, > > I'd like to propose to mark reloptions as indexterms, like GUC, > so that users can more easily search the pages describing > a reloption in document. Attached is the patch which does this. > Is this helpful? Thought? +1 for adding index entries to al