Re: Remove unnecessary secondary index terms for replication settings

2025-04-23 Thread Euler Taveira
_replication_origins was part of max_replication_slots, > so both needed separate index entries. But commit 04ff636cbce > split them into distinct parameters. Agreed. It was an oversight in my patch. LGTM. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: generated constraint name

2025-04-11 Thread Euler Taveira
ion without the comment characters don't make much sense. postgres=# SELECT city FROM weather WHERE temp_lo = max(temp_lo); WRONG ERROR: aggregate functions are not allowed in WHERE LINE 1: SELECT city FROM weather WHERE temp_lo = max(temp_lo);

Re: Documentation for initdb option --waldir

2025-03-27 Thread Euler Taveira
ckup documentation that has a similar option. My suggestion is that waldir option in both tools has similar sentences. The term 'WAL location' is not appropriate because this terminology is already used to indicate the LSN. I would replace it with WAL directory. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Regarding explanation to store and retrieve postgres geometric features

2025-02-28 Thread Euler Taveira
translation, rotation, and determining intersections. They are explained in Section 9.11. Hence, check the referred section. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: correction

2025-02-27 Thread Euler Taveira
s an oversight in commit a70bce43fbc that was backpatched down to v14. The attached patch should fix it. -- Euler Taveira EDB https://www.enterprisedb.com/ diff --git a/doc/src/sgml/maintenance.sgml b/doc/src/sgml/maintenance.sgml index b5b9da7f8a9..27de593a7b8 100644 --- a/doc/src/sgml

Re: pg_createsubscriber clarification

2024-07-30 Thread Euler Taveira
r initial data on the target server. It only > does the synchronization phase, which ensures each table is brought up > to a synchronized state by applying changes using standard logical > replication. I slightly modified your proposal in the attached patch. Thoughts? -- Euler Taveira E

Re: DROP TRIGGER lock

2024-06-07 Thread Euler Taveira
sExclusiveLock. If you search for AccessExclusiveLock into src/backend/commands/* you will notice that there are more commands that were not mentioned in the Table-Level Locks section. Feel free to propose a patch. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: 28.4.4. Progress Reporting phase status

2024-06-03 Thread Euler Taveira
here. You can certainly obtain the build phases from all access methods with a query like: WITH amidx AS ( SELECT oid, amname FROM pg_am WHERE amtype = 'i') SELECT a.amname, pg_indexam_progress_phasename(a.oid, i) FROM amidx a, generate_series(0, 100) i WHERE pg_indexam_prog

Re: Unclear on Publication documentation page

2024-05-20 Thread Euler Taveira
ation uses a publish and subscribe model with one or more subscribers subscribing to one or more publications on a publisher node. Unless there is a documentation bug or you want to suggest changes to any part of the documentation, use pgsql-general for questions instead. [2] https://www.postgresql.org/docs/current/logical-replication.html -- Euler Taveira EDB https://www.enterprisedb.com/

Re: documentation issue: listen_addresses does NOT take a comma-separated list of host names

2024-03-04 Thread Euler Taveira
/postgresql.conf listen_addresses = '192.168.32.3' listen_addresses = '127.0.0.1' $ pg_ctl start waiting for server to start2024-03-04 13:50:37.167 -03 [16738] LOG: redirecting log output to logging collector process 2024-03-04 13:50:37.167 -03 [16738] HINT: Future log output will appear in directory "log". done server started $ postgres -C listen_addresses 127.0.0.1 [1] https://www.postgresql.org/docs/current/runtime-config-connection.html -- Euler Taveira EDB https://www.enterprisedb.com/

Re: An inconsistency in the documentation about full text search

2023-11-29 Thread Euler Taveira
t; Section > > 12.4.3. Triggers for Automatic Updates > https://www.postgresql.org/docs/current/textsearch-features.html#TEXTSEARCH-UPDATE-TRIGGERS This section has a note at the top that this trigger-based method is obsolete and refers to section 12.2.2 (Creating Indexes). -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Clarification regarding CREATE TABLE LIKE and FOREIGN KEYS

2023-11-29 Thread Euler Taveira
re *does not* provide in general. The probability that that information will be obsolete (due to new features) is high. If the information is missing that's because it is not supported. (Of course, it can be an omission and, in this case, we need to fix it.) -- Euler Taveira EDB https://www.enterprisedb.com/

Re: 48.1. Logical Decoding Examples

2023-10-23 Thread Euler Taveira
logical | postgres | f | 0/6069300 | 0/6069338 (1 row) $ psql -c "SELECT version()" -d postgres version --- PostgreSQL 16.0 on x

Re: 48.1. Logical Decoding Examples

2023-10-23 Thread Euler Taveira
'test_decoding'. > There is no need to preload the output plugin. logical decoding will do it. The documentation is correct (see LoadOputputPlugin() function). -- Euler Taveira EDB https://www.enterprisedb.com/

Re: index access method documentation light on details on ii_AmCache

2023-09-14 Thread Euler Taveira
On Wed, Sep 13, 2023, at 6:48 PM, Seebs wrote: > On Wed, 13 Sep 2023 15:48:41 -0300 > "Euler Taveira" wrote: > > > Unless you change it, ii_Context is CurrentMemoryContext (see > > makeIndexInfo). Hence, your AM state information is freed when the > > cu

Re: index access method documentation light on details on ii_AmCache

2023-09-13 Thread Euler Taveira
maintenance after all > the inserts from a given query are complete, except to do it after every > tuple just in case it's the last tuple, I guess? > Check src/backend/utils/mmgr/README. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Kernel settings shmall

2023-09-12 Thread Euler Taveira
ntation/sysctl/kernel.txt [2] https://www.postgresql.org/docs/current/supported-platforms.html -- Euler Taveira EDB https://www.enterprisedb.com/

Re: There is no description about "Logical Replication also use or occupy max_wal_senders ",

2023-08-23 Thread Euler Taveira
s/current/glossary.html [2] https://www.postgresql.org/docs/current/logical-replication-config.html [3] https://www.postgresql.org/docs/current/runtime-config-replication.html -- Euler Taveira EDB https://www.enterprisedb.com/

Re: clarifying trigger/rule behavior on logical replication subscribers

2023-06-08 Thread Euler Taveira
quot;, AFAICS it is not used in the logical replication chapter; use "subscriber" instead. Another suggestion is to add links to the exact ALTER TABLE ... ENABLE TRIGGER and ALTER TABLE ... ENABLE RULE since we recently added it. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: pg_stat_database view column xact_commit description should be more descriptive?

2022-12-18 Thread Euler Taveira
tion does not use the transaction machinery to replicate changes. It is in a lower layer and statistics don't apply at it. [1] https://www.postgresql.org/docs/devel/logical-replication.html -- Euler Taveira EDB https://www.enterprisedb.com/

Re: 52.88. pg_shmem_allocations, missing units

2022-08-14 Thread Euler Taveira
xEnt; The unit is bytes. A patch is attached to add such information. -- Euler Taveira EDB https://www.enterprisedb.com/ diff --git a/doc/src/sgml/system-views.sgml b/doc/src/sgml/system-views.sgml index 9728039e71..44aa70a031 100644 --- a/doc/src/sgml/system-views.sgml +++ b/doc/src/sgml/sy

Re: pg document is not recorded:maintenance_work_mem can not large than 2GB in windows

2022-08-02 Thread Euler Taveira
. The documentation does not mention an upper limit and it also provides a suitable error message. Both are sufficient to provide proper functioning for Postgres. IMO that's a change that someone might be excited to address in the future. [1] https://docs.microsoft.com/en-us/cpp/build/common-visual-cpp-64-bit-migration-issues?view=msvc-170 -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Dependency Tracking to be updated with PostgreSQL 14 functions on dependencies improvement.

2022-08-02 Thread Euler Taveira
are inaccurate after the BEGIN ATOMIC feature. Patches are welcome. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Typo in "43.9.1. Reporting Errors and Messages"?

2022-08-02 Thread Euler Taveira
. I think it would be better to use the condition name (in lowercase) like it is referred to in [1]. I mean, change ERRCODE_RAISE_EXCEPTION to raise_exception. [1] https://www.postgresql.org/docs/current/errcodes-appendix.html -- Euler Taveira EDB https://www.enterprisedb.com/

Re: GENERATED ALWAYS AS - Not Consistent with MD5

2022-03-24 Thread Euler Taveira
is for documentation discussion. For general questions, use pgsql-general. For bug reports, use pgsql-bugs. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: offline print option.

2022-03-05 Thread Euler Taveira
rmat to print out. What about PDF [1]? I wouldn't print HTML if PDF is available. [1] https://www.postgresql.org/docs/ -- Euler Taveira EDB https://www.enterprisedb.com/

Re: pg_isready docs doesn't specify what exactly it is checking

2022-01-06 Thread Euler Taveira
nitialization script is involved. There is no known issues with pg_isready and that report isn't clear. He says "database and/or user wasn't available". What's the exact error message? If there is a reproducible test case, share it here. [1] https://www.postgresql.org/do

Re: include_dir - 'if_exists' logic yes or no?

2021-12-22 Thread Euler Taveira
d suggest a new feature. IMO no documentation change is required. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: ALTER TABLE ... SET DATA TYPE removes statistics

2021-10-22 Thread Euler Taveira
On Tue, Oct 19, 2021, at 12:16 PM, Alvaro Herrera wrote: > On 2021-Oct-19, Michael Paquier wrote: > > > On Mon, Oct 18, 2021 at 05:15:59PM -0300, Euler Taveira wrote: > > > I agree that it might surprise an user and it would be good to document > > > it. > >

Re: vacuumdb --analyze-in-stages

2021-10-18 Thread Euler Taveira
xisting statistics even if they use a larger > > statistic target configuration." > > .. yeah, this is another option. We might include it too but I would suggest "replace" instead of "remove" because it seems there won't be statistics after the first stage. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: ALTER TABLE ... SET DATA TYPE removes statistics

2021-10-18 Thread Euler Taveira
good to document it. However, it does not belong to the description. I would add it to the Notes section at the end of the ALTER TABLE page. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: vacuumdb --analyze-in-stages

2021-10-18 Thread Euler Taveira
_why_ (produce usable statistics faster). -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Missing mention of autovacuum_work_mem

2021-09-24 Thread Euler Taveira
uggested > wording sounds like only autovacuum_work_mem is used and that it would > never fall back to maintenance_work_mem, no? I would suggest the > addition of "if specified" in the new part within parenthesis > Good point. However, I prefer "if set". -- Eule

Re: Missing mention of autovacuum_work_mem

2021-09-22 Thread Euler Taveira
On Mon, Sep 20, 2021, at 10:40 AM, nikolai.berkoff wrote: > Yes that reads better still. I'm attaching a patch with Laurenz's words. -- Euler Taveira EDB https://www.enterprisedb.com/ From 41f814b15349bcc8eb8ffa4624ed5af80f3476ac Mon Sep 17 00:00:00 2001 From: Euler Taveira Date

Re: conventions

2021-07-07 Thread Euler Taveira
g/wiki/Submitting_a_Patch [2] https://www.postgresql.org/docs/current/docguide-build.html [3] https://www.postgresql.org/docs/current/docguide-toolsets.html -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Link missing in the 14 release notes

2021-07-02 Thread Euler Taveira
nk it is clear that "predefined roles" link contains the new roles, no? -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Link missing in the 14 release notes

2021-07-01 Thread Euler Taveira
t; pg_read_all_data links to "Predefined roles", pg_write_all_data does not. Is > that on purpose? At least it looks strange. It seems so. Once you click on the link, you will notice that pg_write_all_data is there too. Role names are similar to make the reader suspect that both descriptions wil

Re: Clarify how triggers relate to transactions

2021-05-02 Thread Euler Taveira
resql.org/33/ [2] https://wiki.postgresql.org/wiki/Submitting_a_Patch Regards, -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Inaccuracy in wal_receiver_status_interval parameter description

2021-02-21 Thread Euler Taveira
t; even forced messages are disabled if the parameter value is zero, but > I think that we should outline that this only applies to the scheduled > replies. Attached is what I get. What do you think? LGTM. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: About the return states of SPI_execute for plpy.execute().status()

2021-02-17 Thread Euler Taveira
27;t). [1] https://www.postgresql.org/docs/9.3/spi-spi-execute.html [2] https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/include/executor/spi.h;h=81310e377f6b769c5aa306cf9aab932813dbeef8;hb=refs/heads/REL9_3_STABLE#l47 -- Euler Taveira EDB https://www.enterprisedb.com/

Re: doc: cosmetic changes in index items

2020-11-21 Thread Euler Taveira
e sake of consistency. Thought? > > Good catch. +1. -- Euler Taveira http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Missing file is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html

2020-10-30 Thread Euler Taveira
the generated file"? That's the only place that mentions *_d.h files. Perhaps adding a link to BKI [1] should avoid further questions. [1] https://www.postgresql.org/docs/13/bki.html -- Euler Taveira http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: physical should be logical

2020-10-30 Thread Euler Taveira
d on any primary server.". Hence, it avoids the term "physical" that should confuse readers. -- Euler Taveira http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Signed-ness of ints is unclear in FE-BE protocol docs

2020-06-14 Thread Euler Taveira
mmit add6c3179a4d4fa3e62dd3e86a00f23303336bac - The starting point of the WAL data in this message, given in - XLogRecPtr format. + The starting point of the WAL data in this message. but it was removed for an unknown reason. [1] https://www.postgresql.org/docs/current/protocol-m

Re: pg_basebackup in tar format with -Xs

2020-06-06 Thread Euler Taveira
help" for more information > > You dont see that error since Postgres 10 instead you see a separate tar > file for wals. > ... because this is a new feature that was introduced in version 10. "Allow pg_basebackup to stream write-ahead log in tar mode" [1] [1] https://w

Re: Logical replication subscription owner

2020-05-09 Thread Euler Taveira
0.7, LOGIN are documented accordingly. I'm +0.5 to the idea of adding a WARNING when you create/alter a role that has REPLICATION but not LOGIN. -- Euler Taveira http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: pg_stat_statements showing passwords while create or alter users.

2020-04-17 Thread Euler Taveira
te user test1 with encrypted password 'test123' > create user test2 with password 'test123' > > pg_stat_statements has parameter "pg_stat_statements.track_utility" to control whether utility commands are tracked. It is on by default. Regards, -- Euler

Re: Replication: Different naming policy

2020-04-16 Thread Euler Taveira
quot;PubAll Master(192.168.1.180) Slave(192.168.1.185)" with (slot_name = foobar); NOTICE: created replication slot "foobar" on publisher CREATE SUBSCRIPTION Regards, -- Euler Taveira http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Difference options with the CREATE ROLE docs

2020-04-10 Thread Euler Taveira
ust an alias, then > they should have the same options > If it's not the "exact same", then I guess there should be some > explanations > about it > > It seems an oversight. I'm attaching patches to fix it in all supported branches. v11 can be applied cleanly t

Re: Add for ALTER TEXT SEARCH CONFIGURATION

2019-11-25 Thread Euler Taveira
GURATION. If I were monkeying around in > $SHAREDLIB/tsearch_data, I'd expect traps like this, but not when executing > things from SQL after reading the docs on the command. > Let's start with a tangible idea: add a big "caution" and also a WARNING while ALTER TEXT SE

Re: question concerning tutorial.sql

2019-04-12 Thread Euler Taveira
Em sex, 12 de abr de 2019 às 08:38, PG Doc comments form escreveu: > > How can I find and load .sql files needed for the tutorial? > Can I expect to find them in postgress 11? If so, what map? > src/tutorial -- Euler Taveira Ti

Re: self join

2019-04-10 Thread Euler Taveira
W2.city, W2.temp_lo, W2.temp_hi FROM weather W1, weather W2 WHERE W1.temp_lo < W2.temp_lo and W1.temp_hi > W2.temp_hi; -- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Re: FORMAT keyword not allowed in COPY ... FROM statement

2019-02-25 Thread Euler Taveira
',' QUOTE '"' ; > COPY 63 > This is the old syntax (check Compatibility section at the end of [1]). [1] https://www.postgresql.org/docs/11/sql-copy.html -- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Re: postgresql 11 release notes

2018-06-22 Thread Euler Taveira
2018-06-21 8:01 GMT-03:00 Brad DeJong : > When you said "I think the sentence should be ...", I took that to mean that > you know that the condition should be an OR. > There are separate conditions in the code (each one was done in separate commits). -

Re: postgresql 11 release notes

2018-06-19 Thread Euler Taveira
ould be "Exclude unlogged tables, temporary tables, and pg_internal.init files from streaming base backups". -- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Re: postgresql 11 release notes

2018-06-19 Thread Euler Taveira
nd restoring of comments (Robins Tharakan) I would suggest "Add an option to suppress dumping and restoring comments". -- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Re: FX modifier

2018-06-19 Thread Euler Taveira
only. FX must be specified as the first item in the template." FX only applies to to_timestamp and to_date. -- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Re: Missing documentation for FETCH FIRST in chapter 7.6

2018-06-13 Thread Euler Taveira
mes used in the SELECT reference page and put OFFSET in a new line (it looks visually better). -- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento From 433c22ffec27136f2867736075915ccfc

Re: Synopsis of SELECT statement: UNION, INTERSECTION, EXCEPT

2018-03-16 Thread Euler Taveira
2018-03-16 2:17 GMT-03:00 Tom Lane : > Euler Taveira writes: >> 2018-03-15 7:18 GMT-03:00 PG Doc comments form : >>> The SYNOPSIS section of the "SELECT" SQL command contains the line >>> [ { UNION | INTERSECT | EXCEPT } [ ALL | DISTINCT ] select ] >>

Re: "IS NOT DOCUMENT" is missing

2018-03-15 Thread Euler Taveira
in the "IS DOCUMENT" item. I'm afraid that NULL return wouldn't be clear. -- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento diff --git a/doc/src/sgml/func.sgml b

Re: Documentation for varbit is missing size parameter

2018-03-15 Thread Euler Taveira
2018-03-11 1:43 GMT-03:00 PG Doc comments form : > The documentation for the varbit data type is missing the size parameter "[ > (n) ]". > Good catch! It seems to be an oversight in commit 768b647ead78d0d63915c1708cad13c2468f9440. The attached patch adds it. -

Re: Synopsis of SELECT statement: UNION, INTERSECTION, EXCEPT

2018-03-15 Thread Euler Taveira
he synopsis. This is confusing. > It is a bug in the synopsis. UNION et al cannot contain some elements (such as ORDER BY) that is allowed for a sub-select. The attached patch replace "select" with the correct element ("select_statement"). -- Euler Taveira

Re: Can we only add values to enums?

2018-03-15 Thread Euler Taveira
oving a enum value requires a table rewrite. I'm not sure it is worth a note. [1] https://www.postgresql.org/message-id/4c1b95e2.6090...@dunslane.net -- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento