On Mon, Feb 24, 2025, at 3:52 AM, PG Doc comments form wrote: > hi i found a tiny error below: > https://www.postgresql.org/docs/current/routine-vacuuming.html > >Drop any old replication slots. Use pg_stat_replication to find slots where > age(xmin) or age(catalog_xmin) is large. In many cases, such slots were > created for replication to servers that no longer exist, or that have been > down for a long time. > > not pg_stat_replication but pg_replication_slots > because pg_stat_replication has neither > xmin nor catalog_xmin. >
Good catch! This seems an oversight in commit a70bce43fbc that was backpatched down to v14. The attached patch should fix it. -- Euler Taveira EDB https://www.enterprisedb.com/
diff --git a/doc/src/sgml/maintenance.sgml b/doc/src/sgml/maintenance.sgml index b5b9da7f8a9..27de593a7b8 100644 --- a/doc/src/sgml/maintenance.sgml +++ b/doc/src/sgml/maintenance.sgml @@ -714,8 +714,8 @@ HINT: Execute a database-wide VACUUM in that database. </listitem> <listitem> <simpara>Drop any old replication slots. Use - <link linkend="monitoring-pg-stat-replication-view">pg_stat_replication</link> to - find slots where <literal>age(xmin)</literal> or <literal>age(catalog_xmin)</literal> + <link linkend="view-pg-replication-slots"><structname>pg_replication_slots</structname></link> + to find slots where <literal>age(xmin)</literal> or <literal>age(catalog_xmin)</literal> is large. In many cases, such slots were created for replication to servers that no longer exist, or that have been down for a long time. If you drop a slot for a server that still exists and might still try to connect to that slot, that replica may