On Fri, 10 Apr 2020 at 08:19, PG Doc comments form <nore...@postgresql.org> wrote:
> > This page says that "CREATE GROUP is now an alias for CREATE ROLE.", > But when u check the CREATE ROLE, u see they have different options, > I don't know if this is on purpose or not, But if it's just an alias, then > they should have the same options > If it's not the "exact same", then I guess there should be some > explanations > about it > > It seems an oversight. I'm attaching patches to fix it in all supported branches. v11 can be applied cleanly to v12/master. Regards, -- Euler Taveira http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From df6932ec195d009cdb62e9f33680aff03e33dc93 Mon Sep 17 00:00:00 2001 From: Euler Taveira <euler.tave...@2ndquadrant.com> Date: Fri, 10 Apr 2020 10:29:30 -0300 Subject: [PATCH] Sync CREATE ROLE and CREATE GROUP synopsis Since CREATE GROUP is an alias to CREATE ROLE, they should provide the same options. Discussion: https://www.postgresql.org/message-id/158647836143.655.9853963229391401576%40wrigleys.postgresql.org --- doc/src/sgml/ref/create_group.sgml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/src/sgml/ref/create_group.sgml b/doc/src/sgml/ref/create_group.sgml index 158617cb93..ebdfec9b50 100644 --- a/doc/src/sgml/ref/create_group.sgml +++ b/doc/src/sgml/ref/create_group.sgml @@ -30,6 +30,9 @@ CREATE GROUP <replaceable class="PARAMETER">name</replaceable> [ [ WITH ] <repla | CREATEROLE | NOCREATEROLE | INHERIT | NOINHERIT | LOGIN | NOLOGIN + | REPLICATION | NOREPLICATION + | BYPASSRLS | NOBYPASSRLS + | CONNECTION LIMIT <replaceable class="PARAMETER">connlimit</replaceable> | [ ENCRYPTED ] PASSWORD '<replaceable class="PARAMETER">password</replaceable>' | VALID UNTIL '<replaceable class="PARAMETER">timestamp</replaceable>' | IN ROLE <replaceable class="PARAMETER">role_name</replaceable> [, ...] -- 2.20.1
From 7c732f4bc971a6b431bb9462340cd5b91f6ee957 Mon Sep 17 00:00:00 2001 From: Euler Taveira <euler.tave...@2ndquadrant.com> Date: Fri, 10 Apr 2020 10:39:34 -0300 Subject: [PATCH] Sync CREATE ROLE and CREATE GROUP synopsis Since CREATE GROUP is an alias to CREATE ROLE, they should provide the same options. Discussion: https://www.postgresql.org/message-id/158647836143.655.9853963229391401576%40wrigleys.postgresql.org --- doc/src/sgml/ref/create_group.sgml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/src/sgml/ref/create_group.sgml b/doc/src/sgml/ref/create_group.sgml index 981ce51e5f..11034a126a 100644 --- a/doc/src/sgml/ref/create_group.sgml +++ b/doc/src/sgml/ref/create_group.sgml @@ -31,6 +31,9 @@ CREATE GROUP <replaceable class="PARAMETER">name</replaceable> [ [ WITH ] <repla | CREATEUSER | NOCREATEUSER | INHERIT | NOINHERIT | LOGIN | NOLOGIN + | REPLICATION | NOREPLICATION + | BYPASSRLS | NOBYPASSRLS + | CONNECTION LIMIT <replaceable class="PARAMETER">connlimit</replaceable> | [ ENCRYPTED | UNENCRYPTED ] PASSWORD '<replaceable class="PARAMETER">password</replaceable>' | VALID UNTIL '<replaceable class="PARAMETER">timestamp</replaceable>' | IN ROLE <replaceable class="PARAMETER">role_name</replaceable> [, ...] -- 2.20.1
From 46729fbd2b35a44c4d15259b446e818aa86a6c5d Mon Sep 17 00:00:00 2001 From: Euler Taveira <euler.tave...@2ndquadrant.com> Date: Fri, 10 Apr 2020 10:36:53 -0300 Subject: [PATCH] Sync CREATE ROLE and CREATE GROUP synopsis Since CREATE GROUP is an alias to CREATE ROLE, they should provide the same options. Discussion: https://www.postgresql.org/message-id/158647836143.655.9853963229391401576%40wrigleys.postgresql.org --- doc/src/sgml/ref/create_group.sgml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/src/sgml/ref/create_group.sgml b/doc/src/sgml/ref/create_group.sgml index 1d5cc9b596..1a21f0bc87 100644 --- a/doc/src/sgml/ref/create_group.sgml +++ b/doc/src/sgml/ref/create_group.sgml @@ -30,6 +30,9 @@ CREATE GROUP <replaceable class="PARAMETER">name</replaceable> [ [ WITH ] <repla | CREATEROLE | NOCREATEROLE | INHERIT | NOINHERIT | LOGIN | NOLOGIN + | REPLICATION | NOREPLICATION + | BYPASSRLS | NOBYPASSRLS + | CONNECTION LIMIT <replaceable class="PARAMETER">connlimit</replaceable> | [ ENCRYPTED | UNENCRYPTED ] PASSWORD '<replaceable class="PARAMETER">password</replaceable>' | VALID UNTIL '<replaceable class="PARAMETER">timestamp</replaceable>' | IN ROLE <replaceable class="PARAMETER">role_name</replaceable> [, ...] -- 2.20.1
From ddaeeaf6e3e2a1545bfa47189766c18e501c1826 Mon Sep 17 00:00:00 2001 From: Euler Taveira <euler.tave...@2ndquadrant.com> Date: Fri, 10 Apr 2020 10:21:10 -0300 Subject: [PATCH] Sync CREATE ROLE and CREATE GROUP synopsis Since CREATE GROUP is an alias to CREATE ROLE, they should provide the same options. Discussion: https://www.postgresql.org/message-id/158647836143.655.9853963229391401576%40wrigleys.postgresql.org --- doc/src/sgml/ref/create_group.sgml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/src/sgml/ref/create_group.sgml b/doc/src/sgml/ref/create_group.sgml index 1b8e76e326..d124c98eb5 100644 --- a/doc/src/sgml/ref/create_group.sgml +++ b/doc/src/sgml/ref/create_group.sgml @@ -30,7 +30,10 @@ CREATE GROUP <replaceable class="parameter">name</replaceable> [ [ WITH ] <repla | CREATEROLE | NOCREATEROLE | INHERIT | NOINHERIT | LOGIN | NOLOGIN - | [ ENCRYPTED ] PASSWORD '<replaceable class="parameter">password</replaceable>' + | REPLICATION | NOREPLICATION + | BYPASSRLS | NOBYPASSRLS + | CONNECTION LIMIT <replaceable class="parameter">connlimit</replaceable> + | [ ENCRYPTED ] PASSWORD '<replaceable class="parameter">password</replaceable>' | PASSWORD NULL | VALID UNTIL '<replaceable class="parameter">timestamp</replaceable>' | IN ROLE <replaceable class="parameter">role_name</replaceable> [, ...] | IN GROUP <replaceable class="parameter">role_name</replaceable> [, ...] -- 2.20.1
