Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-12 Thread Guillaume Lelarge
Le 12/02/2011 15:22, Dave Page a écrit : > On Sat, Feb 12, 2011 at 9:23 AM, Guillaume Lelarge > wrote: >> I know Peter and Dave talked about some stuff I actually didn't >> understand, but it seems it would take some time to do. So, I prefer >> having this simple and effective fix right now :) >

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-12 Thread Peter Geoghegan
By the way, there is a macro based smart pointer class in wx 2.8, but that sounds like quite a bit more trouble than it's worth. -- Regards, Peter Geoghegan -- Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org) To make changes to your subscription: http://www.postgresql.org/

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-12 Thread Dave Page
On Saturday, February 12, 2011, Peter Geoghegan wrote: > On 12 February 2011 14:22, Dave Page wrote: >> Note the lack of a delete - that's the point here; it's not needed >> because as soon as the smart pointer goes out of scope, it's >> destructor will delete foo. That means you don't have to re

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-12 Thread Peter Geoghegan
On 12 February 2011 14:22, Dave Page wrote: > Note the lack of a delete - that's the point here; it's not needed > because as soon as the smart pointer goes out of scope, it's > destructor will delete foo. That means you don't have to remember to > include the delete in each of the many exit point

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-12 Thread Dave Page
On Sat, Feb 12, 2011 at 9:23 AM, Guillaume Lelarge wrote: > I know Peter and Dave talked about some stuff I actually didn't > understand, but it seems it would take some time to do. So, I prefer > having this simple and effective fix right now :) :-) We were talking about smart pointers - basica

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-12 Thread Julius Tuskenis
2011.02.12 10:23, Guillaume Lelarge rašė: I know Peter and Dave talked about some stuff I actually didn't understand, but it seems it would take some time to do. So, I prefer having this simple and effective fix right now:) Thank you. Is there a nightly build for windows? Thanks, Julius, for re

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-12 Thread Guillaume Lelarge
Le 11/02/2011 11:42, Julius Tuskenis a écrit : > Hello, Guillaume > > Please look at frmStatus::fillLogfileCombo(). Please note, that the set > is defined and assigned, but then as it has not enough rows to be > "interesting" the function returns 0 and exits. So "delete set;" is > never called. Ca

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-11 Thread Peter Geoghegan
On 11 February 2011 15:04, Dave Page wrote: > Ashesh had some code to implement a smart pointer a while back. I > suggested he post it here, but I know he's been too busy to do much > else with it.container I would prefer to use a stdlib smart ptr, or a well tested third party smart ptr that we

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-11 Thread Dave Page
On Fri, Feb 11, 2011 at 2:45 PM, Peter Geoghegan wrote: > On 11 February 2011 10:42, Julius Tuskenis wrote: >> Hello, Guillaume >> >> Please look at frmStatus::fillLogfileCombo(). Please note, that the set is >> defined and assigned, but then as it has not enough rows to be "interesting" >> the f

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-11 Thread Peter Geoghegan
On 11 February 2011 10:42, Julius Tuskenis wrote: > Hello, Guillaume > > Please look at frmStatus::fillLogfileCombo(). Please note, that the set is > defined and assigned, but then as it has not enough rows to be "interesting" > the function returns 0 and exits. So "delete set;" is never called. C

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-11 Thread Julius Tuskenis
Hello, Guillaume Please look at frmStatus::fillLogfileCombo(). Please note, that the set is defined and assigned, but then as it has not enough rows to be "interesting" the function returns 0 and exits. So "delete set;" is never called. Can this be the issue? int frmStatus::fillLogfileCombo(

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-11 Thread Julius Tuskenis
2011.02.10 23:55, Guillaume Lelarge rašė: I looked a bit in the source code, but can't find any memory leak in it. The code is pretty much the same for each report. The only specific thing for the lock report is that it can use a specific connection. But this doesn't trigger anything useful to fi

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-10 Thread Guillaume Lelarge
Le 08/02/2011 08:54, Julius Tuskenis a écrit : > 2011.02.07 17:05, Guillaume Lelarge rašė: >> Nope, I'll check this. Make sure you specifically set the interval for >> this report. > Thank you, Guillaume, for the hint. I did't realize there are different > intervals for every report in server statu

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-07 Thread Julius Tuskenis
2011.02.07 17:05, Guillaume Lelarge rašė: Nope, I'll check this. Make sure you specifically set the interval for this report. Thank you, Guillaume, for the hint. I did't realize there are different intervals for every report in server status window. Now I was able to isolate the window responsi

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-07 Thread Guillaume Lelarge
Le 07/02/2011 15:30, Julius Tuskenis a écrit : > Hello, all! > > Last Friday I've installed pgAdmin 1.12.2 (build Dec 13, 2010) into one > of our clients servers (Windows server 2003 SE SP2). Postgresql 8.3.3 > runs on it. As we were looking how to improve performance we were using > Server Status

[pgadmin-support] possible memory leak in Server Status window

2011-02-07 Thread Julius Tuskenis
Hello, all! Last Friday I've installed pgAdmin 1.12.2 (build Dec 13, 2010) into one of our clients servers (Windows server 2003 SE SP2). Postgresql 8.3.3 runs on it. As we were looking how to improve performance we were using Server Status tool (great tool, especially with recent changes - th