Re: [pgAdmin4][Patch] Grid on the dashboard is not getting refresh after killing the session

++ Gentle reminder On Fri, Jan 18, 2019 at 8:02 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the regression issue where a user kills the session > from the dashboard grid, but the grid was not getting refreshed and the &g

[pgAdmin4[RM#3935] Grant wizard fails to list down functions

Hi, PFA patch to fix the issue where EPAS DB instance running with *no-redwood-compat* mode fails to list down functions objects in grant wizard due to 'char' -> 'int' type cast error. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterp

Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions

Hi, PFA minor patch, To display an error on UI when there is a backend error for the grant wizard request. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jan 28, 2019 at 12:48 PM Akshay Joshi wrote: > Tha

[pgAdmin4[RM#3948] Fix backform note control style

Hi, PFA minor patch to fix the style, changed the background colour and text colour so that it can be readable. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_3948.diff Description: Binary data

Re: [pgAdmin4[RM#3948] Fix backform note control style

Hi, PFA updated patch. Regards, Murtuza > >> On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA minor patch to fix the style, changed the background

[RM#3998] Custom encode forward slashes in the grid title

. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_3998.diff Description: Binary data

[RM#4040] Fix Download CSV option on IE11

Hi, We have used download attribute to download CSV file from query tool but IE11 does not support download attribute, we will use msSaveBlob() instead for IE11. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4040.diff Description

Re: [RM#3998] Custom encode forward slashes in the grid title

ionality is working properly. > > On Fri, Mar 1, 2019 at 12:18 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hello, >> >> PFA patch for the issue RM#3998. If the URL contains the forward slash >> value in the query tool title and if p

Re: [RM#3998] Custom encode forward slashes in the grid title

t; <http://localhost:5005/datagrid/panel/3400871/true/postgrespostgres%40PostgreSQL11?query_url=&server_type=pg&;> >> type=pg&fslash=8,27 >> >> Value extracted: postgrespostgres@PostgreSQL11 >> Using fslash param, put the forward slashes in the mentioned posi

[pgAdmin4][RM#4142] Add the recommended ESLinter checks again.

that linter is not complaining about it, earlier it was. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company fix_js_linter.diff Description: Binary data

[pgAdmin4][RM#4138] Allow us to set the dropdown body when rendering Select2 control

Hi, PFA minor patch to fix the issue where Select2 dropdown position incorrectly in some cases. Ref: https://select2.org/troubleshooting/common-problems Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4138.diff

[pgAdmin4] Add API tests for Download CSV route in query tool

Hi, PFA patch to add API tests for Download CSV route in query tool. > python runtests.py --pkg tools.sqleditor.tests --exclude feature_tests -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company download_csv_tests.diff Description: Bin

Re: [pgAdmin4] Add API tests for Download CSV route in query tool

Hi Dave, PFA updated patch with suggested changes. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 11, 2019 at 6:27 PM Dave Page wrote: > Hi > > On Thu, Apr 11, 2019 at 12:21 PM Murtuza Zabuawala < >

[pgAdmin4][Rm#4246] Subnode control throws console error when used in Panels

Hi, PFA minor patch to handle a case where Subnode control used in Panels. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4246.diff Description: Binary data

[pgAdmin4][RM4269] Navigating Switch cell using Tab key throws console error

Hi, PFA patch to fix the issue where navigating Switch cell using Tab key throws console error. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4269.diff Description: Binary data

[pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list

Hi, PFA minor patch to fix the issue with Backgrid PasswordCell. In the Backgrid PasswordCell, The browser's autocomplete functionality opens up the saved password list which cause the Backgrid to lose focus from the current cell and causes issue in keyboard navigation. -- Regards, Mu

Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list

May 20, 2019 at 2:32 PM Dave Page wrote: > Hi > > On Mon, May 20, 2019 at 8:01 AM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> PFA minor patch to fix the issue with Backgrid PasswordCell. >> In the Backgrid Passwor

[RM#4307][pgAdmin4] Graphical Explain Plan - Embed images in explain plan only when user try to download it

and not when displaying the graphical plan. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4307.diff Description: Binary data

Re: [RM#4307][pgAdmin4] Graphical Explain Plan - Embed images in explain plan only when user try to download it

only one > export. Then you can use it as imageMapper.default rather than > imageMapper.imageMapper. > Otherwise, looks fine to me. I didn't test though :P > > > On Thu, May 30, 2019 at 2:41 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >

[RM#4350][pgAdmin4] User is not able to upload files using File manager.

Hi, PFA minor patch to fix the issue where user is unable to upload the files using File manager. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4350.diff Description: Binary data

Re: [GSoC][Patch] Automatic Mode Detection V1

On Thu, Jun 20, 2019 at 2:20 AM Yosry Muhammad wrote: > Hi there ! > > On Wed, Jun 19, 2019 at 4:11 PM Dave Page wrote: > >> >>> - We need to think about how data editing fits in with transaction >>> control. Right now, it seems to happen entirely outside of it - for >>> example, I tend to work

RE-SQL tests for Roles & Resource Group nodes

Hi, PFA patch to add RE-SQL tests for Roles & Resource Group nodes. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4415.diff Description: Binary data

Re: RE-SQL tests for Roles & Resource Group nodes

Hi Dave, Please find the updated patch, - Added a mechanism to check for supported minimum/maximum version and a server type in the framework. Please review. Thanks, Murtuza On Mon, Jul 1, 2019 at 7:55 PM Dave Page wrote: > Hi > > On Mon, Jul 1, 2019 at 6:31 AM Murtuza

Re: RE-SQL tests for Roles & Resource Group nodes

++ Attaching patch On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find the updated patch, > > - Added a mechanism to check for supported minimum/maximum version and a > server type in the fram

Re: RE-SQL tests for Roles & Resource Group nodes

5:52 PM Dave Page wrote: > Hi > > On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> ++ Attaching patch >> >> On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com

Re: RE-SQL tests for Roles & Resource Group nodes

Hi, PFA updated patch with corrections in the print messages. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 3, 2019 at 5:36 PM Dave Page wrote: > Hi > > On Wed, Jul 3, 2019 at 8:35 AM Akshay Joshi > wr

[RM#4468] Add RE-SQL tests for Type node

Hi, Please find patch for RE-SQL type node. - Fixed a bug in update.sql which is found during writing tests - Added logging for JSON file when it fails to load -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4468.diff Description

[RM#4468] Consistently use ROLE keyword when generating RE-SQL

Hi, Please find attached patch which will change the keyword USER to ROLE when generating RE-SQL. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4446.diff Description: Binary data

Re: [RM#4468] Add RE-SQL tests for Type node

Hi Dave, PFA patch to fix the ACL order so that it RE-SQL tests for type node works consistently on all the platforms. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 15, 2019 at 2:55 PM Dave Page wrote: > Thanks, pa

[RM#4508] Fix tab navigation issue with Backgrid Datetime cell

Hi, PFA minor patch to fix the tab navigation issue with Backgrid datetime cell. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company fix_datetime_backgrid.diff Description: Binary data

[RM#4546] Add RE-SQL tests for Column node

Hi, PFA patch to add RE-SQL tests for Column node. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company column_resql_tests.diff Description: Binary data

[RM#3605] View Data: Deleting N number of rows makes first N number of rows disable

screenshot. 2) Open view data for the table 3) Select row number 6 4) Click on Trash (delete button) 5) Click on Save grid icon 6) Try to update the first row's column b value -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_3605

Re: [RM#4546] Add RE-SQL tests for Column node

ch for both. > User is looking to provide length and precision for Integer type, which is not possible, We can close this RM. Please review the attached updated patch. Regards, Murtuza > > On Thu, Aug 1, 2019 at 5:36 PM Akshay Joshi > wrote: > >> Hi All >>

[RM#4690] MSQL tests for Resource group node

Hi, PFA patch to add MSQL tests for Resource group node. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company msql_resource_group_node.diff Description: Binary data

Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided

rdless of those information present in service file. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Sep 13, 2019 at 12:09 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Looks good to me. > > On Fri,

Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided

Hi, On Fri, Sep 13, 2019 at 2:32 PM Akshay Joshi wrote: > Hi Murtuza > > On Fri, Sep 13, 2019 at 1:40 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> We are making assumption here that all user's service file has por

MSQL tests for Roles node

Hi, PFA patch to add MSQL tests for roles node. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4415_roles_msql_tests.diff Description: Binary data

[pgAdmin4][RM#4750] Query tool history throws an error for encoding

Hi, PFA minor patch for the backend encoding error from query history. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4750.diff Description: Binary data

Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is

Hi, We need to make it configurable, we don't require middleware when we are running in Desktop mode. On Thu, Sep 19, 2019 at 3:52 PM Dave Page wrote: > > > On Thu, Sep 19, 2019 at 11:13 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Thu, Sep 19, 2019 at 3:2

Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is

sn't like compression which we expect to use noticable CPU cycles. > > On Thu, Sep 19, 2019 at 11:39 AM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> We need to make it configurable, we don't require middleware when we a

Re: [pgAdmin][RM4768] Reverse proxy on non-standard port

Hi Aditya, Tested with below version and works fine. >>> flask.__version__ '1.0.2' >>> werkzeug.__version__ '0.14.1' -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Oct 1, 2019 at 12:

Re: [pgAdmin][RM4768] Reverse proxy on non-standard port

Hi, I forgot to change the virtualenv in another terminal Tab, I am getting error TypeError: __init__() got an unexpected keyword argument ‘x_for’ with Flask 1.0.2. Regards, Murtuza On Tue, Oct 1, 2019 at 1:35 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: >

[RM#4906][pgAdmin4] Fix context menu keyboard shortcut issue with Firefox

Hello, PFA patch to fix the issue where keyboard shortcut for context menu is not working when using Firefox on CestOS7. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4906.diff Description: Binary data

[RM#4935] Accessibility related issues

keyboard shortcut navigation does not work in wcDocker iframe. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company pgadmin4_fixes.diff Description: Binary data

[pgAdmin4] Fix context menu CSS

Hi, PFA patch to fix the issue where we have context menu open along with submenu and the focus is not on context menu or submenu then it was picking the CSS from jquery.contextMenu.scss and displaying different color then the selected theme. -- Regards, Murtuza Zabuawala EnterpriseDB: http

Re: [pgAdmin4] Fix context menu CSS

Hi Dave, On Wed, Dec 4, 2019 at 4:22 PM Dave Page wrote: > Hi > > Is there an RM for this? > I've created RM#4991 <https://redmine.postgresql.org/issues/4991> Thanks, Murtuza > > On Wed, Dec 4, 2019 at 4:06 AM Murtuza Zabuawala < > murtuza.zabuaw...@enterpri

[pgAdmin4][RM#4772] Add aria-label attribute to buttons used in graphical explain plan

Hi, PFA patch for adding aria-label to buttons used in graphical explain plan section. - Fixed another minor issue where we will only use dialog tab navigator keyboard shortcuts only on visible tabs. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: pgAdmin 4 commit: Added Schema Diff tool to compare two schemas and gen

Hi Khushboo, We can create a common function in Server node to fetch the servers and then use that same function in the schema diff tool, currently we have written the same function in schema diff tool to avoid duplicate code. -- Regards, Murtuza Zabuawala EnterpriseDB: http

Re: [pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool

Hi Akshay, PFA updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jan 23, 2020 at 12:39 PM Akshay Joshi wrote: > Hi Ganesh > > Following are the review comments: > >- Focus is going on Table he

Re: [pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool

Hi Akshay, Please find a fix for two issues reported by QA team, - Show focus when the Tab key is pressed - Pressing the Enter key on C:\ drive does not open it on Windows -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jan 31

[pgAdmin4][RM#4942] Fix chrome driver download utility for Ubuntu platform.

unexpected version string: Google Chrome 80.0.3987.132 unknown . -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4942.diff Description: Binary data

[pgAdmin4][RM 5271] To change the switch control colors

Hello, As per discussion with Chethana, We need to make switch box color change for light and dark theme, Color details provided by Chethana is updated on ticket. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM 5271] To change the switch control colors

those changes in the patch in which I removed the ternary scss variable. > On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hello, >> >> As per discussion with Chethana, We need to make switch box color change

Re: [pgAdmin4][RM 5271] To change the switch control colors

Hi Chethana, No it is not, As per current dark theme implementation we have used primary color '#1a522b' for switch but the color you suggested is '#43A047' for both theme. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Co

Re: [pgAdmin4][RM 5271] To change the switch control colors

Hello, PFA updated patch with new colors provided by Chethana, As discussed we will be using the same primary success color in both theme so we don't have add new variable. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed

[pgAdmin4][RM#5279] Fixed: pgAdmin4 does not start with Python2 environment

Hi, PFA patch to remove the unicode character from source code which was causing the issue on Python2 environment. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company remove_unicode_character_from_source.diff Description: Binary data

[pgAdmin4][RM#5314] Make Switch cell sync with Switch control for accessibility

Hi, This patch will allow the screen reader software to read the actual value from Switch cell like Yes/No same as we have for Switch control. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company pgadmin4_switch_cell.diff Description

[pgAdmin4][RM#2813] Do not prompt for database server password once user saves it

Hi, There was an issue where the user used trust mode to connect to the database server and saves a blank password, and next time when the user tries to connect from pgadmin, pgadmin again asks for the password. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The

Re: [pgAdmin4][RM#2813] Do not prompt for database server password once user saves it

Hi Akshay, Thanks for reviewing, PFA updated patch, it was a minor logical conditional issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Apr 10, 2020 at 2:17 PM Akshay Joshi wrote: > Hi Murtuza > > The issue

[pgAdmin4][RM#4858] Allow user to reconnect to DB server when connection is drop

) Execute -> SELECT 1,2,3 3) Disconnect from server from browser tree 4) Click on Download CSV button Current: Python exception error Expected: It should display dialog to reconnect the server. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Comp

Re: [pgAdmin4][RM#4858] Allow user to reconnect to DB server when connection is drop

Hi Akshay, PFA updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Apr 13, 2020 at 2:28 PM Akshay Joshi wrote: > Hi Murtuza > > The issue has been fixed with your patch, but there is an existing issue &

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

Hello, We are sending the data to backend and depending on errors from backend. Any thoughts on implementation of basic fronted validations? so that we can alert user before it clicks on save button. On Wed, 15 Apr 2020, 18:08 Dave Page, wrote: > Removing the typecast will almost certainly lea

[pgAdmin4][RM#3495] Do not check for binary content if BOM marker is present in the file

Hi, PFA patch to fix the issue where the user was not able to load the file in the Query tool which contains the BOM marker, The sample file with BOM marker is already attached in the RM. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it

. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_5213.diff Description: Binary data

Re: [pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it

fixed those issues > and attached is the patch. > Please continue working on the attached patch. > > On Fri, Apr 24, 2020 at 6:27 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to fix the issue for materialized vie

Re: [pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it

Hi Akshay, Here is an updated patch fixing test cases. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Apr 27, 2020 at 12:27 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Thanks Akshay, flag n

[pgAdmin4] RESQL tests for Column & Type nodes

Hi, PFA patch to add RESQL tests for Column and Type nodes. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company msql_tests_columns_types.diff Description: Binary data

Re: Move pgAdmin git repo to Github?

Hi Dave, On Thu, May 21, 2020 at 4:38 PM Dave Page wrote: > We see a non-trivial amount of automated build failures caused by git > timeouts and Varnish cache meditation. This is only likely to get worse as > we've automated so many different build configurations, and the PostgreSQL > sysadmin t

[pgAdmin4] Fix RLS node dialog help link

Hi, PFA minor patch to fix the issue where RLS node dialog help is not opening. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company fix_RLS_dialog_help.diff Description: Binary data

Regression in of browser.js code

tps://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commit;h=830ac1cc9177c8b9ebed2304924cec1db22e45c3> -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com browser_regression.diff Description: Binary data

Re: Regression in of browser.js code

Hi Khushboo, I am already on the latest code :) *commit* ec30e6ace78a813eb5215efc5c1f0e94582ffc12 (HEAD -> master, origin/master, origin/HEAD) -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com On Thu, Jul 2, 2020 at 5:25 PM Khushboo Vashi < khush

Re: Regression in of browser.js code

On Thu, Jul 2, 2020 at 5:41 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Jul 2, 2020 at 5:33 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Khushboo, >> >> I am already on the latest code :) &g

Re: Regression in of browser.js code

Ok the commit is reverted :( On Thu, Jul 2, 2020 at 5:45 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > > > On Thu, Jul 2, 2020 at 5:41 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >>

Re: pgAdmin 4 commit: Added support for schema level restriction. Fixes #55

Hi Akshay, PFA patch to add the same changes for EPAS templates as well. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com On Tue, Jun 30, 2020 at 7:16 PM Akshay Joshi wrote: > Added support for schema level restriction. Fixes #5583 > > Allow use

[pgAdmin4][RM#5662] [Accessibility] File manager dialog was not rendering properly due to fixed width and height set in the code

Hi, PFA patch to fix the issue where few dialogs are not rendering properly when we zoomed in browser window 200% and screen resolution is low. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com RM_5662.diff Description: Binary data

[pgAdmin4 ] Limit the scope of CSS

Hi, PFA small patch to fix the `.dashboard-graph-body` CSS class scope to prevent it affecting other places. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com fix_css_scope.diff Description: Binary data

Re: pgAdmin 4 commit: Ensure that the original file format should be retain

Hi Yogesh, I see one problem with the given solution, if a user opens two files from two different locations with the same name but with different encoding then the backend dict mapper (filename -> encoding) will be overridden by the later filename. -- Regards, Murtuza Zabuawala *EDB* *POWER

Re: pgAdmin 4 commit: Fixed cognitive complexity issues and added some more

\'2049-12-31 10:30:00-08\';\n\nGRANT pg_monit[256 chars]n\';' -- Role: "Role2_$%{}[]()&*^!@""'`\/#" -- DROP ROLE "Role2_$%{}[]()&*^!@""'`\/#"; CREATE ROLE "Role2_$%{}[]()&*^!@""&#

Re: More idiomatic python3 + fix some tests

Hi, On Tue, Sep 1, 2020 at 2:36 PM Cyril Jouve wrote: > thanks :) > > and sure, I'll run the linter next time! > > have you thought of automatic code formatters instead like yapf or black? > AFAIK, yapf is not consistent with formatting & black is non-configurable. I tried both sometime back an

Re: pgAdmin 4 commit: 1) Added email id validation on the login page.

Hi Team, PFA patch to fix typo introduced with this patch. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com On Fri, Sep 11, 2020 at 8:07 PM Akshay Joshi wrote: > 1) Added email id validation on the login page. > 2) Added validation for the file m

Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

Hi Akshay, We have used aysnc=False in most ajax calls with this feature, It is causing UI hang in case of slow server response. You can try adding a time.sleep() call at the python side response and check the UI hang, I think we should avoid sync calls as much as possible. -- Regards, Murtuza

Re: pgAdmin 4 commit: Added support to download utility files at the client

Hi, PFA minor patch to remove dead code which was introduced with this patch. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com On Fri, Oct 23, 2020 at 5:17 PM Akshay Joshi wrote: > Added support to download utility files at the client-side. Fixes #3

[pgAdmin4] Enhance the Schema diff GUI validation

Hi, PFA minor patch to add the validation in schema diff which will not allow the user to compare the same objects in source and target dropdowns. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com Add_validation_schema_diff.patch Description: Binary data

Re: pgAdmin 4 commit: Fixed an issue where the validation error message is

Hello, What is the reason for adding delay *setTimeout(, 120)*? This is causing issues in automation testing and makes buttons enable/disable with slight delay. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com On Fri, Oct 30, 2020 at 3:10 PM Akshay Joshi

Re: pgAdmin 4 commit: Fixed an issue where the validation error message is

} +return this; + }, 120); +}, Here we are only making the model invalid, there is no logic to make it valid again. On Thu, Dec 3, 2020 at 11:09 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello, > > What is the reason for adding delay *setTim

Re: pgAdmin 4 commit: Fixed an issue where the validation error message is

On Thu, Dec 3, 2020 at 12:29 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > > > On Thu, Dec 3, 2020 at 11:18 AM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hello, >> >> Another observation, >> >&

Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the

Hi, It will break the WSGI. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com On Tue, Feb 9, 2021 at 4:28 PM Akshay Joshi wrote: > Use 'sys.executable' to get the absolute path of the executable binary for > the Python interpreter instead of

[pgAdmin4] Update require.js library to latest version

Hi, PFA patch to update the require.js library to the latest version. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com update_requirejs_to_latest.diff Description: Binary data

Re: [pgAdmin][RM6355]: pgAdmin is able to open external files that are dragged into it.

Hello, PFA patch to remove duplicate code and avoid DOM search operation in panel.js. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com On Wed, Apr 28, 2021 at 12:02 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Apr 27, 2021 at 8:12

Re: pgAdmin 4 commit: Hardcoded 'itsdangerous' version to <=1.1.0, as the l

Hello, 'itsdangerous' is an important module in order to keep the sessions safe & secure, Is there any specific reason for holding back on the older version? IMO we need to fix what is not working instead of using the older version. -- Regards, Murtuza Zabuawala *EDB* *POWER TO P

Re: The new workspace layout

+1 On Fri, 7 Feb, 2025, 17:38 Anthony DeBarros, wrote: > Dear Hackers, > > I have great respect for your efforts to continuously develop pgAdmin 4, > and it has certainly come a long way since version 1.0. Not to mention, > it’s free. Thank you for all your hard work. > > All that said, I think

<    1   2   3   4   5