Hi, On Tue, Sep 1, 2020 at 2:36 PM Cyril Jouve <jv.cy...@gmail.com> wrote:
> thanks :) > > and sure, I'll run the linter next time! > > have you thought of automatic code formatters instead like yapf or black? > AFAIK, yapf is not consistent with formatting & black is non-configurable. I tried both sometime back and not found useful at that time but we can give it a shot with the new release. -- Murtuza > > > > Le lun. 31 août 2020 à 13:18, Akshay Joshi <akshay.jo...@enterprisedb.com> > a écrit : > >> Hi Cyril >> >> Thanks, patch applied. Please make sure to run "yarn run pep8" before >> sending the patch. >> >> On Sat, Aug 29, 2020 at 2:28 AM Cyril Jouve <jv.cy...@gmail.com> wrote: >> >>> Hello, >>> >>> patch 1 to 6 generated mostly using 2to3: >>> 0001: https://docs.python.org/3.8/library/2to3.html#2to3fixer-asserts >>> 0002: https://docs.python.org/3.8/library/2to3.html#2to3fixer-filter >>> 0003: https://docs.python.org/3.8/library/2to3.html#2to3fixer-idioms >>> 0004: https://docs.python.org/3.8/library/2to3.html#2to3fixer-metaclass >>> 0005: https://docs.python.org/3.8/library/2to3.html#2to3fixer-xrange >>> 0006: https://docs.python.org/3.8/library/2to3.html#2to3fixer-unicode >>> >>> patch 7 fixes change_password tests: >>> Less that min length : min is 8 instead of 6 >>> Valid password : use an user different than admin user / mock mail module >>> >>> patch 8 fixes ConstraintDeleteMultipleTestCase on py3.10 (using >>> simplejson like in all other modules). >>> >>> Regards, >>> Cyril >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Sr. Software Architect* >> *EDB Postgres <http://edbpostgres.com>* >> >> *Mobile: +91 976-788-8246* >> >
