++ Attaching patch On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi Dave, > > Please find the updated patch, > > - Added a mechanism to check for supported minimum/maximum version and a > server type in the framework. > > Please review. > > > Thanks, > Murtuza > > On Mon, Jul 1, 2019 at 7:55 PM Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Mon, Jul 1, 2019 at 6:31 AM Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch to add RE-SQL tests for Roles & Resource Group nodes. >>> >> >> Resource Groups don't exist in PG.... >> >> =============Running the test cases for 'Regression - PG 11'============= >> runTest (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases) >> Reverse Engineered SQL Test Cases >> >> Create IMPLICIT Cast >> Alter IMPLICIT Cast >> Drop IMPLICIT Cast >> Create EXPLICIT Cast >> Alter EXPLICIT Cast >> Drop EXPLICIT Cast >> >> >> Create Resource groups >> ... 2019-07-01 15:24:16,930: ERROR flask.app: Failed to execute query >> (execute_scalar) for the server #2 - DB:postgres (Query-id: 1562639): >> Error Message:ERROR: syntax error at or near "RESOURCE" >> LINE 1: CREATE RESOURCE GROUP test_resql_resource_group; >> ^ >> >> FAIL >> >> ====================================================================== >> FAIL: runTest >> (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases) >> Reverse Engineered SQL Test Cases >> ---------------------------------------------------------------------- >> Traceback (most recent call last): >> File >> "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line >> 88, in runTest >> self.execute_test_case(scenarios) >> File >> "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line >> 145, in execute_test_case >> self.assertEquals(response.status_code, 200) >> AssertionError: 500 != 200 >> >> ---------------------------------------------------------------------- >> Ran 1 test in 0.767s >> >> FAILED (failures=1) >> >> ====================================================================== >> Test Result Summary >> ====================================================================== >> >> Regression - PG 11: >> >> 0 tests passed >> 1 test failed: >> ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases) >> 0 tests skipped >> >> ====================================================================== >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >
RM_4415_v1.diff
Description: Binary data
