Re: RE-SQL tests for Roles & Resource Group nodes

Hi Dave, Please find the updated patch, - Added a mechanism to check for supported minimum/maximum version and a server type in the framework. Please review. Thanks, Murtuza On Mon, Jul 1, 2019 at 7:55 PM Dave Page wrote: > Hi > > On Mon, Jul 1, 2019 at 6:31 AM Murtuza Zabuawala < > murtuza

Re: RE-SQL tests for Roles & Resource Group nodes

++ Attaching patch On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find the updated patch, > > - Added a mechanism to check for supported minimum/maximum version and a > server type in the framework. > > Please review. > > > Tha

[pgAdmin][RM4421] Inno setup script version compare fix

Hi Hackers, Attached is the patch to fix a potential issue where version compare while upgrading will be incorrect. Currently, it is comparing strings. So while comparing '4.9' and '4.10' it will consider '4.9' as greater. The patch will convert the values to float and compare. Kindly review. --

Re: [pgAdmin][RM4421] Inno setup script version compare fix

Hi Aditya I have asked Paresh to review the patch, he has given some review comments. Please fix those and the updated patch asap. On Tue, Jul 2, 2019 at 1:38 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix a potential issue where ve

Re: RE-SQL tests for Roles & Resource Group nodes

I think you missed attaching the patch! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 2 Jul 2019, at 08:16, Murtuza Zabuawala > wrote: > > Hi Dave, > > Please find the updated patch, > > -

Re: [pgAdmin][RM4421] Inno setup script version compare fix

Hi Hackers, Attached is the updated patch. Instead of float comparison, string comparison is done now with the help of a nice article here - http://www.arvydas.co.uk/2015/04/compare-version-strings-with-innosetup/ Kindly review. On Tue, Jul 2, 2019 at 2:34 PM Akshay Joshi wrote: > Hi Aditya >

pgAdmin 4 commit: Ensure the version comparision should be correct for

Ensure the version comparision should be correct for windows installer. Fixes #4421 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b76e0bea839fe3c5d59e2490713d0caba029b0ca Author: Aditya Toshniwal Modified Files -- docs/en_US/re

Re: [pgAdmin][RM4421] Inno setup script version compare fix

Thanks patch applied. On Tue, Jul 2, 2019 at 2:51 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. Instead of float comparison, string > comparison is done now with the help of a nice article here - > http://www.arvydas.co.uk/2015/04

Re: pgAdmin4 v4.10 candidate builds

Hi Fahar We have fixed RM #4421. Candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-07-02-1/ . There is some problem with the wheel packages, will check that. Meanwhile can you please test the builds for upgrade issue. On Tue, Jul 2, 2019 at 10:55 AM Fahar Abbas

Re: pgAdmin4 v4.10 candidate builds

Hi, The issue still persists. I have checked the code and found that CompareVersions(Version, '{#MyAppFullVersion}') = -1, this should be 1 and not -1. Attached is the patch. Sorry for trouble to build again. :/ On Tue, Jul 2, 2019 at 4:39 PM Akshay Joshi wrote: > Hi Fahar > > We have fixed R

Re: RE-SQL tests for Roles & Resource Group nodes

Hi On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ++ Attaching patch > > On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the updated patch, >> >> - Added a mechanism t

pgAdmin 4 commit: Correct the condition to compare version for Windows

Correct the condition to compare version for Windows installer. Regression of last commit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=15556f9f89c1268e99fcc4f0eaf6c6e9ab608ce5 Author: Aditya Toshniwal Modified Files -- pkg/wi

Re: pgAdmin4 v4.10 candidate builds

Thanks patch applied. On Tue, Jul 2, 2019 at 5:31 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > The issue still persists. I have checked the code and found that > CompareVersions(Version, '{#MyAppFullVersion}') = -1, this should be 1 > and not -1. > Attached is the pat

Re: pgAdmin4 v4.10 candidate builds

Hi Fahar, Candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-07-02-3/ Please verify the upgrade scenario and rest of the testing for the release on Thursday 4th July. On Tue, Jul 2, 2019 at 8:13 PM Akshay Joshi wrote: > Thanks patch applied. > > On Tue, Jul 2,

Re: RE-SQL tests for Roles & Resource Group nodes

Hi Dave, PFA updated patch. Please note that our framework considers test cases from all the modules as one single test case, If we need module wise detailed summary report for the reverse engineered SQL tests then we may have to change the framework. Regards, Murtuza On Tue, Jul 2, 2019 at 5