Hi On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote:
> ++ Attaching patch > > On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the updated patch, >> >> - Added a mechanism to check for supported minimum/maximum version and a >> server type in the framework. >> > There's still a problem with this I'm afraid - it says in the summary that the re_sql test cases were all skipped, which is not the case. I think we should just skip the irrelevant tests in the re_sql module, but not mark the entire module as being skipped: =============Running the test cases for 'Regression - PG 11'============= runTest (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases) Reverse Engineered SQL Test Cases Create IMPLICIT Cast Alter IMPLICIT Cast Drop IMPLICIT Cast Create EXPLICIT Cast Alter EXPLICIT Cast Drop EXPLICIT Cast ... skipped 'Server(Type: #ppas) is not supported for the Resource Groups module' ---------------------------------------------------------------------- Ran 1 test in 0.480s OK (skipped=1) ====================================================================== Test Result Summary ====================================================================== Regression - PG 11: 0 tests passed 0 tests failed 1 test skipped: ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases) ====================================================================== -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
