Re: [perl #44567] Undefined arrayref in MethodEmitter.pm

2007-08-12 Thread Bob Rogers
From: "James Keenan via RT" <[EMAIL PROTECTED]> Date: Sun, 12 Aug 2007 10:05:16 -0700 I don't know much about MethodEmitter.pm, so I don't have any preferences. I think tewk has done most of the recent work in this area, so he may have a preference. kid51 Maybe we should als

Re: [perl #44567] Undefined arrayref in MethodEmitter.pm

2007-08-12 Thread James E Keenan
Bob Rogers wrote: So far, such values have not been observed, and would probably indicate that something was broken upstream. Do you have a preference for letting these fail hard? I don't know much about MethodEmitter.pm, so I don't have any preferences. I think tewk has done most of t

Re: [perl #44567] Undefined arrayref in MethodEmitter.pm

2007-08-12 Thread chromatic
On Saturday 11 August 2007 07:57:55 Bob Rogers wrote: >I find the following patch necessary to build PMCs in r20605. I'm > using Perl 5.8.1, so it may be that newer Perls autovivify differently. > This changed since r20358, but I'm not sure it's worth tracking down. > If I hear no objections,

Re: [perl #44567] Undefined arrayref in MethodEmitter.pm

2007-08-12 Thread Bob Rogers
From: "James Keenan via RT" <[EMAIL PROTECTED]> Date: Sun, 12 Aug 2007 08:55:25 -0700 Your commit statement says: + $decs is not always defined, at least in older Perls. However, your patch required that $decs be not merely defined, but true: +$decorators = $decs && le

Re: [perl #44567] Undefined arrayref in MethodEmitter.pm

2007-08-12 Thread James E Keenan
Bob Rogers wrote: # New Ticket Created by Bob Rogers # Please include the string: [perl #44567] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=44567 > I find the following patch necessary to build PMCs in r20605. I'm