From: "James Keenan via RT" <[EMAIL PROTECTED]>
   Date: Sun, 12 Aug 2007 10:05:16 -0700

   I don't know much about MethodEmitter.pm, so I don't have any 
   preferences.  I think tewk has done most of the recent work in this 
   area, so he may have a preference.

   kid51

Maybe we should also ask particle what he was thinking (see below),
since he seems to be the one who added this line.

   ================
   From: "chromatic via RT" <[EMAIL PROTECTED]>
   Date: Sun, 12 Aug 2007 10:46:12 -0700

   length @$decs is pretty clearly wrong (in the unpatched version).

Good point.

   I'd rather figure out why you're getting bad results than make this line of 
   code worse.  What happens if you take out 'length'?

   -- c

Same thing; $decs is undef so @$decs bombs:

        /usr/bin/perl tools/build/pmc2c.pl --c src/pmc/default.pmc
        Can't use an undefined value as an ARRAY reference at 
/usr/src/parrot/tools/build/../../lib/Parrot/Pmc2c/MethodEmitter.pm line 110.
        make: *** [src/pmc/default.c] Error 255
        Sun Aug 12 15:37:31 EDT 2007

                                        -- Bob

------------------------------------------------------------------------
r20559 | particle | 2007-08-08 11:00:15 -0400 (Wed, 08 Aug 2007) | 1 line

[pmc2c]: added support for parsing and emitting PDD07-compliant types (e.g. 
'PMC *'.) we can now convert .pmc files to PDD07.
------------------------------------------------------------------------
r20545 | particle | 2007-08-07 14:13:45 -0400 (Tue, 07 Aug 2007) | 1 line

[pmc2c]: add support for decorators (e.g. PARROT_CAN_RETURN_NULL) to pmc methods
------------------------------------------------------------------------

Reply via email to