From: "James Keenan via RT" <[EMAIL PROTECTED]>
Date: Sun, 12 Aug 2007 08:55:25 -0700
Your commit statement says:
+ $decs is not always defined, at least in older Perls.
However, your patch required that $decs be not merely defined, but true:
+ $decorators = $decs && length @$decs ? join $/ => @$decs, '' : '';
Is that what you actually intend?
kid51
This is my normal idiom in these cases, which is the minimal effective
change here. AFAICS, it doesn't make much practical difference, since
there are no false values in Perl 5 that are also valid arrayrefs. So
testing "$decs" instead of "defined($decs)" merely prevents other false
values from being dereferenced.
So far, such values have not been observed, and would probably
indicate that something was broken upstream. Do you have a preference
for letting these fail hard?
-- Bob
