[PATCH firmware-utils v1 08/10] tplink-safeloader: add vendor info support

2023-02-03 Thread Sander Vanheule
Some images may contain ASCII vendor info at the start of the image header. Detect this image type, and display the info when requested. Signed-off-by: Sander Vanheule --- src/tplink-safeloader.c | 42 + 1 file changed, 42 insertions(+) diff --git a/src

[PATCH firmware-utils v1 10/10] tplink-safeloader: add Cloud image detection

2023-02-03 Thread Sander Vanheule
The vendor info in the safeloader header for some images (e.g. Archer C60 v3) starts with "fw-type:Cloud" instead of a big endian data length. Only detection is implemented at this moment, as the full header format is not yet understood. Signed-off-by: Sander Vanheule ---

[PATCH firmware-utils v1 09/10] tplink-safeloader: add QNEW image detection

2023-02-03 Thread Sander Vanheule
is not yet understood, and the preamble checksum can no longer be verified using the current md5sum salt. Devices still appear to accept images in the "old" format, so image generation is not required at this moment. Cc: Andreas Böhler Signed-off-by: Sander Vanheule --- src/tpli

[PATCH firmware-utils v1 07/10] tplink-safeloader: refactor image ingestion

2023-02-03 Thread Sander Vanheule
The tool supports three modes that ingest an existing safeloader image: -i (image info), -x (extract payloads), and -z (convert to sysupgrade). These modes all re-implement image parsing, so refactor the code to make sure there is only one place this is performed. Signed-off-by: Sander Vanheule

Re: [PATCH] realtek: fix memory leak in netevent handler

2023-02-13 Thread Sander Vanheule
Hi Jan, On Wed, 2023-02-08 at 22:53 +0100, Jan Hoffmann wrote: > The net_event_work struct is allocated, but only freed in a single case. > Move the allocation to the branch where it is actually needed, and free > it after the work has been done. > > Fixes: 03e1d93e0779 ("realtek: add driver supp

Re: [PATCH firmware-utils v1 00/10] Refactor image ingestion to support new formats

2023-03-12 Thread Sander Vanheule
On Fri, 2023-02-03 at 23:03 +0100, Sander Vanheule wrote: > TP-Link is playing fast and loose with the safeloader format, having > resulted in different types of images with their specific quirks. > > A new incompatible format is currently used in the wild, which places > the pa

Re: [PATCH 1/4] realtek: properly update port masks when port leaves bridge

2023-04-30 Thread Sander Vanheule
Hi Jan, On Sun, 2023-03-12 at 23:57 +0100, Jan Hoffmann wrote: > Correctly update the isolation mask of the port being configured. The > port_bitmap variable should contain all other bridge members and needs > to be actually removed from the isolation mask instead of added to it. > > Also actuall

Re: [PATCH 0/4] realtek: fix multiple issues with L2 forwarding

2023-04-30 Thread Sander Vanheule
Hi Jan, On Sun, 2023-03-12 at 23:57 +0100, Jan Hoffmann wrote: >   realtek: fix standalone ports in presence of static fdb entries >   realtek: handle changed flags in VLAN configuration These patches are triggering checkpatch.pl. Could you resolve the style issues, so these things don't pollute

Re: [PATCH] realtek: hpe_1920-8g: add phy-handle for SFP ports

2023-04-30 Thread Sander Vanheule
On Sat, 2023-03-11 at 21:34 +0100, Jan Hoffmann wrote: > The switch driver actually expects every port to have a PHY handle, and > several branches in the code determine if a port is valid by checking > for a non-zero phy field. > > Signed-off-by: Jan Hoffmann > --- Patch applied to master. Than

Re: [PATCH v2 0/4] realtek: fix multiple issues with L2 forwarding

2023-05-07 Thread Sander Vanheule
On Sat, 2023-05-06 at 19:28 +0200, Jan Hoffmann wrote: > This series fixes several bugs that can result in packets being > forwarded incorrectly. The port isolation and VLAN issues probably > remained unnoticed so far, because they only manifest after a port > leaves a bridge, or when an existing V

Re: [PATCH v2 0/6] realtek: fix management of mdb entries

2023-05-07 Thread Sander Vanheule
On Sun, 2023-05-07 at 01:05 +0200, Jan Hoffmann wrote: > This series fixes multiple issues related to the L2 table and multicast > table. That includes an issue that causes corruption of the port mask > for unknown multicast forwarding, which can occur even when multicast > snooping is disabled.

Re: [PATCH] ramips: add NVMEM cells with Netgear R6220 wifi EEPROMs

2023-05-09 Thread Sander Vanheule
Hi Rafał, On Mon, 2023-05-08 at 18:02 +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > This allows reading EEPROMs using NVMEM interface. OK, but why do you need to do that though? Some userspace application? > > Signed-off-by: Rafał Miłecki > --- >  target/linux/ramips/dts/mt7621_netge

[PATCH 0/2] Add support for TP-Link EAP613 v1 access point

2023-06-29 Thread Sander Vanheule
a for background DFS detection. Since the device has a MT7905, one antenna is not populated, and the other (a PCB antenna) is most likely not used. If there are no comments, I would like to merge the patches later this week. Best, Sander Sander Vanheule (2): firmware-utils: bump to git HEAD r

[PATCH 2/2] ramips: mt7621: add TP-Link EAP613 v1

2023-06-29 Thread Sander Vanheule
er image. The device uses two bootloader stages. The first stage will load the second stage from a uImage stored at flash offset 0x1. In case of a damaged second stage, the first stage should allow uploading a new image via y-modem (untested). Signed-off-by: Sander Vanheule --- .

[PATCH 1/2] firmware-utils: bump to git HEAD

2023-06-29 Thread Sander Vanheule
Add support for a number of new TP-Link devices. 9e2de8515be1 tplink-safeloader: add EAP610 v3 and EAP613 v1 bb12cf5c3fa9 tplink-safeloader: Add support for TP-Link Deco M5 a2d49fb1e188 tplink-safeloader: add RU support-list entry for Archer C6U v1 Signed-off-by: Sander Vanheule --- tools

Re: [PATCH 2/2] ramips: mt7621: add TP-Link EAP613 v1

2023-06-30 Thread Sander Vanheule
Hi, On Fri, 2023-06-30 at 18:31 +0300, Arınç ÜNAL wrote: > On 29.06.2023 17:28, Sander Vanheule wrote: > > diff --git a/target/linux/ramips/dts/mt7621_tplink_eap613-v1.dts > > b/target/linux/ramips/dts/mt7621_tplink_eap613-v1.dts > > new file mode 100644 > > index

[PATCH libubox] jshn: Do not perform double key normalisation

2023-10-22 Thread Sander Vanheule
file (modulo formatting). Fixes: a1a97eb11e89 ("jshn: support using characters in elements that do not conform to shell variable restrictions") Signed-off-by: Sander Vanheule --- This issue was uncovered by the people debugging a recent issue on Realtek switches [1]. A JSON section was used w

Re: [PATCH libubox] jshn: Do not perform double key normalisation

2023-10-22 Thread Sander Vanheule
Cc Felix's correct address. Sorry for the noise! Best, Sander On Sun, 2023-10-22 at 17:51 +0200, Sander Vanheule wrote: > jshn stores a JSON file in the shell environment using a set of > variable, using the key to an object in the shell variable name. This > restricts the allowed

Re: [PATCH] firmware-utils: bump compat_level for EAP615-Wall

2023-11-23 Thread Sander Vanheule
Hi Stijn, On Wed, 2023-11-22 at 18:39 +0100, Stijn Segers wrote: > Newer EAP615-Walls come with more recent firmware that requires a > higher soft_ver_compat_level. Bump ours from 1 to 2 to keep in step. > Tested on a newer EA615-Wall by grauheier - see forum topic: > https://forum.openwrt.org/t/1

Re: [PATCH] [23.05 / firmware-utils] tplink-safeloader: bump EAP615-Wall compat_level

2024-01-07 Thread Sander Vanheule
On Sat, 2024-01-06 at 20:14 +0100, Stijn Segers wrote: > Newer EAP615-Walls come with more recent firmware that requires a > higher soft_ver_compat_level. Bump ours from 1 to 2 to keep in step. > Tested on a newer EA615-Wall by grauheier - see forum topic: > https://forum.openwrt.org/t/173424/13. >

Re: [PATCH firmware-utils] tplink-safeloader: add RE365 v1

2024-01-07 Thread Sander Vanheule
Hi Tomasz, On Thu, 2023-12-21 at 22:15 +0100, Tomasz Maciej Nowak wrote: > From: Tomasz Maciej Nowak > > Partition layout same as RE305 v1. Values extracted from vendor > firmware. This will only be used for creating factory image. > > Signed-off-by: Tomasz Maciej Nowak Applied to master. B

Re: [PATCH v2] ramips: mt76x8: add support for TP-Link RE365 v1

2024-01-07 Thread Sander Vanheule
Hi Tomasz, On Fri, 2023-12-22 at 11:36 +0100, Tomasz Maciej Nowak wrote: > From: Tomasz Maciej Nowak > > TP-Link RE365 is a wireless range extender, hardware-wise resembles > RE305 with slight changes regarding buttons and LEDs. > > Specification > SoC: MediaTek MT7628AN > RAM: 64 MiB DDR2 > Fl

Re: [PATCH] ramips: mt76x8: enable small_flash feature

2024-01-10 Thread Sander Vanheule
5 v1) with default config + LuCI: > > kernel rootfs sysupgrade > current: 2305728 3635044 5964584 > small_flash: 1713571 3320132 5047080 > > 1. https://github.com/openwrt/openwrt/issues/14215 > > Sugge

Re: [PATCH v3] ramips: mt76x8: add support for TP-Link RE365 v1

2024-01-10 Thread Sander Vanheule
Hi Tomasz, On Wed, 2024-01-10 at 16:39 +0100, Tomasz Maciej Nowak wrote: > From: Tomasz Maciej Nowak > > TP-Link RE365 is a wireless range extender, hardware-wise resembles > RE305 with slight changes regarding buttons and LEDs. > > Specification > SoC: MediaTek MT7628AN > RAM: 64 MiB DDR2 > Fl

Re: [PATCH] ramips: mt76x8: enable small_flash feature

2024-01-22 Thread Sander Vanheule
5 v1) with default config + LuCI: > > kernel rootfs sysupgrade > current: 2305728 3635044 5964584 > small_flash: 1713571 3320132 5047080 > > 1. https://github.com/openwrt/openwrt/issues/14215 > > Suggested-b

[PATCH] package: add new poe-common package

2024-01-25 Thread Sander Vanheule
option id '1' option enable '1' config port option name 'lan7' option id '2' option enable '1' [...] Signed-off-by: Sander Vanheule --- package/network/con

Re: [PATCH] package: add new poe-common package

2024-01-25 Thread Sander Vanheule
[Added the others back in Cc] Hi Paul, On Fri, 2024-01-26 at 00:00 +0100, Paul D wrote: > > So, the power budget is a global option. Do we ever envisage that parts > of this budget can be concretely assigned to specific ports or more > abstract ? > > e.g. > >   config port >   

Re: [PATCH] realtek: fix zyxel-vers usage for XGS1250-12

2024-02-04 Thread Sander Vanheule
Hi Stijn, On Sun, 2024-02-04 at 13:20 +0100, Stijn Segers wrote: > Commit daefc646e6d fixed a shell expansion issue with > zyxel-vers usage. Commit 045baca10b1 took care of this checkpatch.pl was complaining about the format of these references, so I amended that. > for the rtl838x and rtl839x

Re: [VOTE] New member proposal: Robimarko (Robert Marko)

2024-02-07 Thread Sander Vanheule
Hi Christian, On Tue, 2024-01-30 at 19:15 +0100, Christian Marangi (Ansuel) wrote: > I think Robert is a good addition to our team and would massively help > me (Ansuel) in maintaining each IPQ target and review all the related > PR on github and patchwork. > I would like to add Robert to the Open

Re: [PATCH firmware-utils] zycast: disable build on non-Linux OS

2024-02-14 Thread Sander Vanheule
Hi Tomasz, On Mon, 2024-02-12 at 17:18 +0100, Tomasz Maciej Nowak wrote: > From: Tomasz Maciej Nowak > > Fails with following errors on MacOS builder: > > [ 96%] Building C object CMakeFiles/zycast.dir/src/zycast.c.o > /usr/bin/gcc   > -I/Users/runner/work/firmware-utils/firmware-utils/openwrt

Re: [PATCH] realtek: fix Netgear GS110TPP OEM install

2024-02-18 Thread Sander Vanheule
Hi Bjørn, On Sat, 2024-02-17 at 15:03 +0100, Bjørn Mork wrote: > Recent OEM firmware versions test the version number embedded in the uimage > "name" header field. The exact restricton is unknown, but "7.0.8.4" seems > to be the lowest number accepted on a GS110TPPv1 which already has that > versi

Re: [PATCH] realtek/rtl839x: Edgecore ECS4100-12PH support

2024-04-04 Thread Sander Vanheule
Hi Stijn, On Thu, 2024-04-04 at 17:28 +0300, st...@linux-ipv6.be wrote: > Add support for the Edgecore ECS4100-12PH, an 8-port PoE Gigabit > Ethernet switch with 2 combo RJ45/SFP and 2 SFP ports. > > Hardware: > * SoC: RTL8392M > * RAM: 256MiB > * Flash: 32MiB SPI-NOR > * Ethernet: >   * 8x GbE R

Re: [PATCH 2/2] ath79: add support for Dell SonicPoint ACi APL27-0B1

2025-02-02 Thread Sander Vanheule
Hi Tomasz, On Sun, 2025-02-02 at 16:10 +0100, Tomasz Maciej Nowak wrote: > + reg_usb_vbus: regulator-usb-vbus { > + compatible = "regulator-fixed"; > + regulator-name = "usb-vbus"; > + regulator-min-microvolt = <500>; > + regulator-max-microv

Re: [PATCH 2/2] ath79: add support for Dell SonicPoint ACi APL27-0B1

2025-02-02 Thread Sander Vanheule
Hi Tomasz, On Sun, 2025-02-02 at 21:25 +0100, to...@terefe.re wrote: > W dniu 2.02.2025 o 19:37, Sander Vanheule pisze: > > Hi Tomasz, > > Hi > > > > > On Sun, 2025-02-02 at 16:10 +0100, Tomasz Maciej Nowak wrote: > > > + reg_usb_vbus: regulato

[no subject]

2020-06-23 Thread Sander Vanheule via openwrt-devel
en I would prefer to create an extra mtdsplit_uimage.h header for the common parts. This would touch more parts of the code, but might be better moving forward. This patch was also posted on github with pull request #3130 https://github.com/openwrt/openwrt/pull/3130 Sander Vanheule (1): kernel

[no subject]

2020-06-23 Thread Sander Vanheule via openwrt-devel
atible firmware partition with a separate loader partition. Signed-off-by: Sander Vanheule --- .../drivers/mtd/mtdsplit/mtdsplit_uimage.c| 124 +- 1 file changed, 118 insertions(+), 6 deletions(-) diff --git a/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c

[no subject]

2020-06-27 Thread Sander Vanheule via openwrt-devel
om/openwrt/openwrt/pull/3130 Sander Vanheule (1): kernel: mtdsplit: support okli loader splitting .../drivers/mtd/mtdsplit/mtdsplit_uimage.c| 124 +- 1 file changed, 118 insertions(+), 6 deletions(-) -- 2.26.2 --- End Message --- _

[no subject]

2020-06-27 Thread Sander Vanheule via openwrt-devel
atible firmware partition with a separate loader partition. Signed-off-by: Sander Vanheule --- .../drivers/mtd/mtdsplit/mtdsplit_uimage.c| 124 +- 1 file changed, 118 insertions(+), 6 deletions(-) diff --git a/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c

[no subject]

2020-06-27 Thread Sander Vanheule via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- Hi everyone, Earlier today, I hav

<    1   2   3   4   5