Hi Rafał,
On Mon, 2023-05-08 at 18:02 +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <ra...@milecki.pl>
>
> This allows reading EEPROMs using NVMEM interface.
OK, but why do you need to do that though? Some userspace application?
>
> Signed-off-by: Rafał Miłecki <ra...@milecki.pl>
> ---
> target/linux/ramips/dts/mt7621_netgear_r6220.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/target/linux/ramips/dts/mt7621_netgear_r6220.dts
> b/target/linux/ramips/dts/mt7621_netgear_r6220.dts
> index 0f476ef060..2ebe58ca63 100644
> --- a/target/linux/ramips/dts/mt7621_netgear_r6220.dts
> +++ b/target/linux/ramips/dts/mt7621_netgear_r6220.dts
> @@ -42,9 +42,22 @@
> };
>
> factory: partition@2e00000 {
> + compatible = "nvmem-cells";
> label = "factory";
> reg = <0x2e00000 0x100000>;
> read-only;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x2e00000 0x100000>;
> +
> + eeprom0: eeprom@0 {
> + reg = <0x0 0x400>;
> + };
> +
> + eeprom1: eeprom@8000 {
> + reg = <0x8000 0x200>;
> + };
You're adding labels to these new nodes, but there aren't any references.
This all seemed a bit off, so I also looked at the full DTS. There's already an
nvmem-cells 'extension' of &factory at the end of the file, with macaddr@4
overlapping with the new eeprom@0 node.
Maybe I'm just missing some context here, but this patch doesn't make much sense
to me.
Best,
Sander
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
