Hi Jan,
On Sun, 2023-03-12 at 23:57 +0100, Jan Hoffmann wrote:
> Correctly update the isolation mask of the port being configured. The
> port_bitmap variable should contain all other bridge members and needs
> to be actually removed from the isolation mask instead of added to it.
>
> Also actually remove the port being configured from the pm field of the
> other ports, so that any other ports that are currently disabled will be
> configured correctly when they are enabled.
>
> Signed-off-by: Jan Hoffmann <j...@3e8.eu>
> ---
>
> I originally wanted to put a proper Fixes tag here, but I'm not sure
> which commit to choose. This bug seems to have existed since this target
> was introduced, and survived through multiple refactorings. It looks
> like the incorrect update to the pm field was even fixed in 2b88563ee5aa
> ("realtek: update the tree to the latest refactored version"), but then
> 27029277f98d ("realtek: add switch driver support for the RTL93XX based
> switches") reintroduced the issue.
I would go with the oldest commit introducing the error. You can also put the
whole history in the commit message, if you like. Helps keeping track of what
went wrong.
Best,
Sander
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
