[PATCH 6/8] realtek: fix place of fdb/mdb info messages

2022-10-06 Thread Sander Vanheule
From: INAGAKI Hiroshi Those messages should be printed when entry was found (idx >= 0). Move them to the right place to not print invalid entry indices. Signed-off-by: INAGAKI Hiroshi [amden commit message] Signed-off-by: Sander Vanheule --- target/linux/realtek/files-5.10/drivers/net/

[PATCH 7/8] realtek: swap *_phylink_mac_link_down() contents

2022-10-06 Thread Sander Vanheule
From: INAGAKI Hiroshi Fix the (accidentally?) swapped contents of rtl83xx_phylink_mac_link_down() and rtl93xx_phylink_mac_link_down(). Signed-off-by: INAGAKI Hiroshi [amend commit message] Signed-off-by: Sander Vanheule --- .../files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 15

[PATCH 8/8] realtek: cleanup rtl83{8x,9x}_enable_learning/flood

2022-10-06 Thread Sander Vanheule
-off-by: INAGAKI Hiroshi [squash RTL838x, RTL839x changes] Signed-off-by: Sander Vanheule --- .../drivers/net/dsa/rtl83xx/rtl838x.c | 32 ++--- .../drivers/net/dsa/rtl83xx/rtl839x.c | 34 ++- 2 files changed, 22 insertions(+), 44 deletions(-) diff --git

Re: [PATCH v1 1/2] realtek: remove RTL839x path in RTL838x multicast

2022-10-06 Thread Sander Vanheule
On Mon, 2022-09-12 at 22:06 +0200, Sander Vanheule wrote: > The multicast setup function rtl838x_eth_set_multicast_list() checks if > the current SoC is a RTL839x family device. However, the function is > only included in the RTL838x ops table, so this path should never be > taken,

Re: [PATCH v2 05/16] realtek: add switch port LED driver

2022-10-16 Thread Sander Vanheule
Hi Alex, On Sun, 2022-10-16 at 12:54 -0500, Alex G. wrote: > On 10/3/22 15:52, Sander Vanheule wrote: > > >    3. Port type index (0 for RJ45/primary, 1 for SFP/secondary) > > > > The driver refers to the RJ45 and SFP LEDs as "primary" and "secondary"

Re: [PATCH 2/2] realtek: use assisted learning on CPU port

2022-10-23 Thread Sander Vanheule
Hi Jan, On Fri, 2022-10-21 at 23:54 +0200, Jan Hoffmann wrote: > L2 learning on the CPU port is currently not consistently configured and > relies on the default configuration of the device. On RTL83xx, it is > disabled for packets transmitted with a TX header, as hardware learning > corrupts the

Re: [PATCH 1/2] realtek: set up L2 table entries properly

2022-10-23 Thread Sander Vanheule
Hi Jan, On Fri, 2022-10-21 at 23:54 +0200, Jan Hoffmann wrote: > Initialize the data structure using memset to avoid the possibility of > writing garbage values to the hardware. > > Always set a valid entry type, which should fix writing unicast entries > on RTL930x. > > For unicast entries, set

Re: [PATCH 3/5] realtek: add debugfs node for L2 table

2022-10-23 Thread Sander Vanheule
On Fri, 2022-10-14 at 23:06 +0200, Jan Hoffmann wrote: > This allows to view all unicast and multicast entries that are currently > in the L2 hash table and the CAM. > > Signed-off-by: Jan Hoffmann Useful patch, thanks! Best, Sander ___ openwrt-devel

Re: [PATCH 5/5] realtek: restructure rtl_table_read/write

2022-10-23 Thread Sander Vanheule
On Fri, 2022-10-14 at 23:06 +0200, Jan Hoffmann wrote: > These two functions are identical apart from writing different values to > the read/write bit. Create a new function rtl_table_exec to reduce code > duplication. > > Also replace the unbounded busy-waiting loop. As the hardware usually > res

Re: [PATCH 0/5] realtek: avoid blocking for too long

2022-10-23 Thread Sander Vanheule
On Fri, 2022-10-14 at 23:06 +0200, Jan Hoffmann wrote: > This fixes multiple instances where the realtek drivers may block for > too long. These issues were discovered on HPE 1920 devices where such > behaviour is made obvious by the short timeout of the hardware watchdog. > > This patch series in

Re: [PATCH v2 0/2] realtek: fix L2 entry setup and learning on CPU port

2022-10-26 Thread Sander Vanheule
Hi Jan, On Wed, 2022-10-26 at 00:20 +0200, Jan Hoffmann wrote: > This is a follow-up to the patch "realtek: don't set L2LEARNING flag in > rtl83xx TX header". An undesired effect of that patch is flooding of > some packets destined for the switch CPU port, which is addressed by > this additional p

Re: [PATCH v2 0/2] realtek: fix L2 entry setup and learning on CPU port

2022-10-27 Thread Sander Vanheule
On Wed, 2022-10-26 at 23:40 +0200, Jan Hoffmann wrote: > > > On 26.10.22 at 10:20, Sander Vanheule wrote: > > Hi Jan, > > > > On Wed, 2022-10-26 at 00:20 +0200, Jan Hoffmann wrote: > > > This is a follow-up to the patch "realtek: don't set L

Re: [PATCH v2 2/2] realtek: use assisted learning on CPU port

2022-10-28 Thread Sander Vanheule
On Fri, 2022-10-28 at 20:26 +0200, Jan Hoffmann wrote: > > On 26.10.22 at 23:39, Jan Hoffmann wrote: > > On 26.10.22 at 00:20, Jan Hoffmann wrote: > > > --- a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c > > > +++ b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c > >

[PATCH v3 01/13] realtek: add switch core MFD driver

2022-10-30 Thread Sander Vanheule
t yet supported. Signed-off-by: Sander Vanheule --- Changes in v3: - Merge symbol selection updates to ease bisecting --- .../drivers/mfd/realtek-switchcore.c | 217 ++ ...0-mfd-add-Realtek-switch-core-driver.patch | 46 target/linux/realtek/rtl838x/config-5.10

[PATCH v3 04/13] realtek: add system LED peripheral driver

2022-10-30 Thread Sander Vanheule
enable sys-led support. Signed-off-by: Sander Vanheule --- Changes in v3: - Merge symbol selection updates to ease bisecting --- .../files-5.10/drivers/leds/realtek/Kconfig | 9 ++ .../files-5.10/drivers/leds/realtek/Makefile | 1 + .../leds/realtek/rtl-switch-sys-leds.c| 105

[PATCH v3 00/13] realtek: pinctrl and LED drivers

2022-10-30 Thread Sander Vanheule
. Otherwise non-interactive builds would fail. Sander Vanheule (13): realtek: add switch core MFD driver realtek: add switch core pinctrl driver realtek: add base register field LED support realtek: add system LED peripheral driver realtek: add switch port LED driver realtek: rtl838x

[PATCH v3 03/13] realtek: add base register field LED support

2022-10-30 Thread Sander Vanheule
LEDs drivers can be grouped together. Signed-off-by: Sander Vanheule --- Changes in v3: - Merge symbol selection updates to ease bisecting --- .../files-5.10/drivers/leds/realtek/Kconfig | 10 ++ .../files-5.10/drivers/leds/realtek/Makefile | 2 + .../drivers/leds/realtek/led-regfield.c

[PATCH v3 02/13] realtek: add switch core pinctrl driver

2022-10-30 Thread Sander Vanheule
if (err) + return dev_err_probe(dev, err, "failed to generate function list\n"); + + err = pinctrl_enable(pctldev); + if (err) + return dev_err_probe(dev, err, "failed to enable\n"); + + return 0; +}; + +static struct pla

[PATCH v3 06/13] realtek: rtl838x: replace pinctrl nodes

2022-10-30 Thread Sander Vanheule
Replace the current "pinctrl-single" nodes by the new "realtek,maple-pinctrl" node. This allows users to specify pin groups and features without having to dig into SoC documentation. Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl838x.dtsi | 43 +

[PATCH v3 07/13] realtek: rtl838x: add sys-led node

2022-10-30 Thread Sander Vanheule
"disabled" Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl838x.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/target/linux/realtek/dts-5.10/rtl838x.dtsi b/target/linux/realtek/dts-5.10/rtl838x.dtsi index a953db7c328b..f1c5ae6a3f22 100644 --- a/ta

[PATCH v3 08/13] realtek: Zyxel GS1900-8: define port LEDs

2022-10-30 Thread Sander Vanheule
The GS1900-8 has one green status LED per port. To reproduce the same behaviour as stock firmware, the LEDs need to light up on all supported link speeds, and blink on link activity. Signed-off-by: Sander Vanheule --- Changes in v3: - Add LED triggers --- .../dts-5.10/rtl8380_zyxel_gs1900-8.dts

[PATCH v3 05/13] realtek: add switch port LED driver

2022-10-30 Thread Sander Vanheule
ader. /* Port 8, LED index 1, primary LED: Link/Act 1G LED */ led@8.1.0 { reg = <8 1 0>; color = ; function = LED_FUNCTION_LAN linux,default-trigger = "realtek-switchport"; realtek,led-port-trigger = <(RTL_LED_ACT | RTL_LED_LINK_1000)>;

[PATCH v3 10/13] realtek: rtl839x: replace pinctrl nodes

2022-10-30 Thread Sander Vanheule
Replace the current "pinctrl-single" nodes by the new "realtek,cypress-pinctrl" node. This allows users to specify pin groups and features without having to dig into SoC documentation. Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl839x.dtsi | 52 +

[PATCH v3 09/13] realtek: Netgear GS110TPPv1: define port LEDs

2022-10-30 Thread Sander Vanheule
: Sander Vanheule --- .../dts-5.10/rtl8380_netgear_gs110tpp-v1.dts | 192 ++ 1 file changed, 192 insertions(+) diff --git a/target/linux/realtek/dts-5.10/rtl8380_netgear_gs110tpp-v1.dts b/target/linux/realtek/dts-5.10/rtl8380_netgear_gs110tpp-v1.dts index b61af62ea536..d9ce5d317213

[PATCH v3 11/13] realtek: rtl839x: add sys-led node

2022-10-30 Thread Sander Vanheule
"disabled". Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl839x.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/target/linux/realtek/dts-5.10/rtl839x.dtsi b/target/linux/realtek/dts-5.10/rtl839x.dtsi index 98c4b2010c5f..095dc1e8ac53 100644 --- a/ta

[PATCH v3 13/13] realtek: add target TODO.md

2022-10-30 Thread Sander Vanheule
To keep track of current work items, add a TODO file inspired by upstream code that is still in driver/staging. This should provide room for developers to leave issues open, or features unsupported, and give new contributors a list of topics that still require attention. Signed-off-by: Sander

[PATCH v3 12/13] realtek: Zyxel GS1900-48: define port LEDs

2022-10-30 Thread Sander Vanheule
The GS1900-48 has 48 RJ45 ports, and two dedicated SFP ports, each having one associated green LED to indicate port status. Add 50 nodes to allow individual control of each LED. Signed-off-by: Sander Vanheule --- Changes in v3: - Add triggers matching device label --- .../dts-5.10

Re: [PATCH v2 05/16] realtek: add switch port LED driver

2022-10-30 Thread Sander Vanheule
Hi Alex, On Tue, 2022-10-18 at 15:23 -0500, Alex G. wrote: > On 10/16/22 16:58, Sander Vanheule wrote: > > Hi Alex, > Hi > > [snip] > > > > > + > > > > +   if (current_trigger != rtl_trigger && !bitmap_empty(group- > > > >

[PATCH] realtek: mark clock source as continuous

2022-10-31 Thread Sander Vanheule
resolution timers. This allows readx_poll_timeout() to sleep for less than one system timer interval, reducing system dead time. Link: https://github.com/openwrt/openwrt/issues/7 Reported-by: INAGAKI Hiroshi Cc: Markus Stockhausen Signed-off-by: Sander Vanheule --- With this patch, initialisation

Re: [PATCH] realtek: mark clock source as continuous

2022-10-31 Thread Sander Vanheule
Hi Jan, On Mon, 2022-10-31 at 21:21 +0100, Jan Hoffmann wrote: > On 31.10.22 at 10:11, Sander Vanheule wrote: > > After replacing the R4K event timer and clock source with the new > > Realtek Otto timer, performance for RTL839x devices was severely > > impacted, a

Re: [PATCH] realtek: fix dell typo

2022-12-01 Thread Sander Vanheule
On Mon, 2022-11-28 at 17:58 +0100, Jan-Niklas Burfeind wrote: > should be add/delete or abbreviated add/del > > Signed-off-by: Jan-Niklas Burfeind Merged to master. Thanks! Sander ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https:/

Re: [PATCH] realtek: update GPIO bindings for DGS-1210-10P

2022-12-04 Thread Sander Vanheule
Hi Jan-Niklas, On Fri, 2022-12-02 at 14:55 +0100, Jan-Niklas Burfeind wrote: > add three missing LEDs >  - PoE-Max >  - Link/Act >  - PoE Do the latter two LEDs indicate which LED mode is currently selected (on stock FW)? Users can do with these LEDs what they like, of course, but it would be goo

Re: tplink-safeloader: add TP-Link CPE605 v1 Support

2022-12-07 Thread Sander Vanheule
Hi Andrew, On Wed, 2022-11-09 at 13:23 +, Andrew Cameron wrote: > From: Andrew Cameron > > Enable creating images compatible with the TP-Link CPE605 v1 Router Could you also add the original layout as defined in the vendor FW? See for example commit 71e1db65a548 ("tplink-safeloader: add TP

Re: tplink-safeloader: add TP-Link CPE605 v1 Support

2022-12-15 Thread Sander Vanheule
On Wed, 2022-11-09 at 13:23 +, Andrew Cameron wrote: > From: Andrew Cameron > > Enable creating images compatible with the TP-Link CPE605 v1 Router > > Signed-off-by: Andrew Cameron Merged to firmware-utils (with some of the differences mentioned earlier), and bumped the package version in

Re: [PATCH v2] realtek: don't set L2LEARNING flag in rtl83xx TX header

2022-12-27 Thread Sander Vanheule
On Sat, 2022-12-17 at 21:39 +0100, Jan Hoffmann wrote: > As learning for the CPU port is now disabled globally, the bit in the > TX header doesn't have any effect anymore. Remove it to make the header > consistent with the global configuration. > > Originally, this change was intended to be applie

Re: [PATCH v2 0/3] realtek: avoid blocking for too long

2022-12-27 Thread Sander Vanheule
On Sat, 2022-12-17 at 21:45 +0100, Jan Hoffmann wrote: > This fixes multiple instances where the realtek drivers may block for > too long. These issues were discovered on HPE 1920 devices where such > behaviour is made obvious by the short timeout of the hardware watchdog. > > Changes in v2: > - r

Re: [PATCH] realtek: don't relocate kernel on HPE 1920 series

2023-01-07 Thread Sander Vanheule
On Thu, 2023-01-05 at 22:36 +0100, Jan Hoffmann wrote: > This is no longer needed now that the kernel is built with a load > address that matches the one hard-coded in the bootloader. > > Signed-off-by: Jan Hoffmann > --- Thanks for keeping things up to date! Merged to master. Best, Sander ___

[RFC PATCH 1/1] kernel: mtdsplit: support ELF loader splitting

2020-07-08 Thread Sander Vanheule
some offset behind the loader (OKLI-style loader), the rootfs must be aligned to an erase-block after the loader and kernel image. Some improvements were suggested by Julien Dusser. Signed-off-by: Sander Vanheule --- .../files/drivers/mtd/mtdsplit/Kconfig| 5 + .../files/drivers/mtd

[RFC PATCH 0/1] Introduce mtd splitter for ELF kernel loader

2020-07-08 Thread Sander Vanheule
with squashfs rootfs). Sander Vanheule (1): kernel: mtdsplit: support ELF loader splitting .../files/drivers/mtd/mtdsplit/Kconfig| 5 + .../files/drivers/mtd/mtdsplit/Makefile | 1 + .../files/drivers/mtd/mtdsplit/mtdsplit_elf.c | 216 ++ 3 files changed, 222

[RFC PATCH v2 1/1] kernel: mtdsplit: support ELF loader splitting

2020-07-11 Thread Sander Vanheule
be aligned to an erase-block after the loader and kernel image. Includes some suggestions by Julien Dusser. Signed-off-by: Sander Vanheule Tested-by: Julien Dusser --- .../files/drivers/mtd/mtdsplit/Kconfig| 5 + .../files/drivers/mtd/mtdsplit/Makefile | 1 + .../files

[RFC PATCH v2 0/1] Introduce mtd splitter for ELF kernel loader

2020-07-11 Thread Sander Vanheule
with squashfs root). Changes since v1: - Fix whitespace issues - Rename elf_header.class* to elf_header.elf* - Use stack for elf header instead of vmalloc mtdsplit_tplink uses a much larger header on the stack, so using vmalloc doesn't seem justified. Sander Vanheule (1): k

[RFC PATCH 3/7] ath79: add QCA956x SERDES init workaround

2020-07-17 Thread Sander Vanheule
for QCA956x. Note that reset is the same on QCA955x and QCA956x, same register offset and values. Auto calibration is done on u-boot, but always fall back to default value 0x7. Add a DTS entry serdes-cal in case a device require another value. Signed-off-by: Julien Dusser Signed-off-by: Sander

[RFC PATCH 5/7] ath79: support for TP-Link EAP245 v1

2020-07-17 Thread Sander Vanheule
holding CTRL+B during boot * tftp initramfs to flash via Luci web-interface Tested on the EAP245v1 running the latest firmware (v1.4.0). The binary patch might not apply to uclited from other firmware versions. Signed-off-by: Sander Vanheule --- .../ath79/dts/qca9563_tplink_eap245-v1.dts| 26 ++

[RFC PATCH 7/7] ath79: support for TP-Link EAP225 v3

2020-07-17 Thread Sander Vanheule
address incremented by 1. From OEM boot log: Using interface ath0 with hwaddr b0:...:3e and ssid "..." Using interface ath10 with hwaddr b0:...:3f and ssid "..." Tested by forum user blinkstar88 Signed-off-by: Sander Vanheule --- .../ath79/dts/qca9563_tplink_e

[RFC PATCH 4/7] ath79: prepare for 1-port TP-Link EAP2x5 devices

2020-07-17 Thread Sander Vanheule
* Ethernet: AR8033-AL1A, one 1GbE port (802.3at PoE) This patch was originally developed by Julien Dusser for the EAP245 v1, and was adapted by Sander Vanheule to support more devices. Signed-off-by: Julien Dusser Signed-off-by: Sander Vanheule --- .../dts/qca9563_tplink_eap2x5_1port.dtsi | 174

[RFC PATCH 0/7] ath79: support for TP-Link EAP2x5 devices

2020-07-17 Thread Sander Vanheule
settings to DT ath79: add QCA956x SERDES init workaround Sander Vanheule (4): ath79: prepare for 1-port TP-Link EAP2x5 devices ath79: support for TP-Link EAP245 v1 ath79: support for TP-Link EAP225-Outdoor v1 ath79: support for TP-Link EAP225 v3 .../ath79/dts/qca9563_tplink_eap225-

[RFC PATCH 6/7] ath79: support for TP-Link EAP225-Outdoor v1

2020-07-17 Thread Sander Vanheule
by forum user PolynomialDivision on firmware v1.7.0. Signed-off-by: Sander Vanheule --- .../ath79/dts/qca9563_tplink_eap225od-v1.dts | 21 ++ .../generic/base-files/etc/board.d/02_network | 1 + .../etc/hotplug.d/firmware/11-ath10k-caldata | 6 target/linux/ath79/image/generic

[RFC PATCH 2/7] ath79: export more QCA956x GMAC settings to DT

2020-07-17 Thread Sander Vanheule
Allow configuration of rgmii-ge0, mii-ge0, gmii-ge0, mii-ge0-master, mii-ge0-slave, ge0-sgmii, txen-delay, txd-delay, rxdv-delay and rxd-delay in device-tree for qca956x SoCs. Signed-off-by: Julien Dusser Signed-off-by: Sander Vanheule --- .../net/ethernet/atheros/ag71xx/ag71xx_gmac.c

[RFC PATCH 1/7] ath79: add lots of missing regs for QCA956x

2020-07-17 Thread Sander Vanheule
-by: Sander Vanheule --- .../920-qca956x-add-more-registers.patch | 186 ++ .../920-qca956x-add-more-registers.patch | 186 ++ 2 files changed, 372 insertions(+) create mode 100644 target/linux/ath79/patches-4.19/920-qca956x-add-more-registers.patch

Re: [RFC PATCH 6/7] ath79: support for TP-Link EAP225-Outdoor v1

2020-07-18 Thread Sander Vanheule
Hi Adrian, On Fri, 2020-07-17 at 15:01 +0200, m...@adrianschmutzler.de wrote: > Hi, > > > diff --git a/target/linux/ath79/dts/qca9563_tplink_eap225od-v1.dts > > b/target/linux/ath79/dts/qca9563_tplink_eap225od-v1.dts > > new file mode 100644 > > index 00..dcfdb7e524 > > --- /dev/null > >

Re: [RFC PATCH 5/7] ath79: support for TP-Link EAP245 v1

2020-07-18 Thread Sander Vanheule
Hi Adrian, On Fri, 2020-07-17 at 14:54 +0200, m...@adrianschmutzler.de wrote: > Hi, > > > diff --git a/target/linux/ath79/dts/qca9563_tplink_eap245-v1.dts > > b/target/linux/ath79/dts/qca9563_tplink_eap245-v1.dts > > new file mode 100644 > > index 00..8a11d2e469 > > --- /dev/null > > +++

Re: [RFC PATCH 4/7] ath79: prepare for 1-port TP-Link EAP2x5 devices

2020-07-18 Thread Sander Vanheule
On Fri, 2020-07-17 at 14:49 +0200, m...@adrianschmutzler.de wrote: > Hi, Hi Adrian, Thanks for the quick feedback. > > diff --git > > a/target/linux/ath79/dts/qca9563_tplink_eap2x5_1port.dtsi > > b/target/linux/ath79/dts/qca9563_tplink_eap2x5_1port.dtsi > > new file mode 100644 > > index 000

Re: [RFC PATCH 4/7] ath79: prepare for 1-port TP-Link EAP2x5 devices

2020-07-18 Thread Sander Vanheule
On Sat, 2020-07-18 at 13:03 +0200, m...@adrianschmutzler.de wrote: > > I tried 80MHz and 65MHz, but that didn't result in proper reads. > > 50MHz, > > 55MHz, and 60MHz do appear to work on my eap245-v1, so I really > > wouldn't > > risk going above 50MHz. > > If you've taken the 25 MHz somewhere r

Re: [RFC PATCH 4/7] ath79: prepare for 1-port TP-Link EAP2x5 devices

2020-07-18 Thread Sander Vanheule
Hi David, On Sat, 2020-07-18 at 21:45 +0200, David Bauer wrote: > > + gmac-config { > > + device = <&gmac>; > > + > > + rgmii-ge0 = <1>; > > + ge0-sgmii = <1>; > > + rxdv-delay = <3>; > > + rxd-delay = <3>; > > This does not make a lot of sense

[RFC PATCH v2 4/6] ath79: support for TP-Link EAP245 v1

2020-07-19 Thread Sander Vanheule
holding CTRL+B during boot * tftp initramfs to flash via the LuCI web interface Tested on the EAP245 v1 running the latest firmware (v1.4.0). The binary patch might not apply to uclited from other firmware versions. Signed-off-by: Sander Vanheule --- .../ath79/dts/qca9563_tplink_eap245-v1.dts| 36

[RFC PATCH v2 0/6] ath79: support for TP-Link EAP2x5 1-port devices

2020-07-19 Thread Sander Vanheule
t phy-mode in the correct device node (eth0, not phy4) * Ensure QCA956X_ETH_CFG_GE0_SGMII is set when required. Removes the need for the device tree extension patch. Julien Dusser (1): ath79: add QCA956x SERDES init workaround Sander Vanheule (5): ath79: ensure QCA956x gmac0 mux selects sgm

[RFC PATCH v2 5/6] ath79: support for TP-Link EAP225-Outdoor v1

2020-07-19 Thread Sander Vanheule
by forum user PolynomialDivision on firmware v1.7.0. Signed-off-by: Sander Vanheule --- .../dts/qca9563_tplink_eap225-outdoor-v1.dts | 31 +++ .../generic/base-files/etc/board.d/02_network | 1 + .../etc/hotplug.d/firmware/11-ath10k-caldata | 6 target/linux/ath79/image/gene

[RFC PATCH v2 3/6] ath79: prepare for 1-port TP-Link EAP2x5 devices

2020-07-19 Thread Sander Vanheule
on PCIe * Ethernet: AR8033-AL1A, one 1GbE port (802.3at PoE) This patch was originally developed by Julien Dusser for the EAP245 v1, and was adapted by Sander Vanheule to support more devices. Signed-off-by: Julien Dusser Signed-off-by: Sander Vanheule --- .../dts

[RFC PATCH v2 1/6] ath79: ensure QCA956x gmac0 mux selects sgmii

2020-07-19 Thread Sander Vanheule
Some bootloaders do not set up gmac0 properly, leaving it disconnected from the sgmii interface. If the user specificies phy-mode sgmii, then use the gmac-config/device node to ensure the mux is configured correctly. Signed-off-by: Sander Vanheule Cc: David Bauer --- .../net/ethernet/atheros

[RFC PATCH v2 6/6] ath79: support for TP-Link EAP225 v3

2020-07-19 Thread Sander Vanheule
incremented by 1. From OEM boot log: Using interface ath0 with hwaddr b0:...:3e and ssid "..." Using interface ath10 with hwaddr b0:...:3f and ssid "..." Tested by forum user blinkstar88 Signed-off-by: Sander Vanheule --- .../ath79/dts/qca9563_tplink_e

[RFC PATCH v2 2/6] ath79: add QCA956x SERDES init workaround

2020-07-19 Thread Sander Vanheule
Signed-off-by: Sander Vanheule --- .../net/ethernet/atheros/ag71xx/ag71xx_main.c | 78 +++ 1 file changed, 78 insertions(+) diff --git a/target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c b/target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx

Re: [RFC PATCH v2 3/6] ath79: prepare for 1-port TP-Link EAP2x5 devices

2020-07-20 Thread Sander Vanheule
Hi Adrian, On Mon, 2020-07-20 at 00:25 +0200, m...@adrianschmutzler.de wrote: > Hi, > > > Signed-off-by: Julien Dusser > > Signed-off-by: Sander Vanheule > > technically, if Julien is first SoB, you should also put him in the > author (From:) field. The DTSI is de

Re: [RFC PATCH v2 4/6] ath79: support for TP-Link EAP245 v1

2020-07-20 Thread Sander Vanheule
Hi Adrian, On Sun, 2020-07-19 at 23:24 +0200, Sander Vanheule wrote: > TP-Link EAP245 v1 is an AC1750 (802.11ac Wave-1) ceiling mount access > point. > > Device specifications: > * SoC: QCA9563 @ 775MHz > * RAM: 128MiB DDR2 > * Flash: 16MiB SPI-NOR > * Wireless

Re: [RFC PATCH v2 4/6] ath79: support for TP-Link EAP245 v1

2020-07-21 Thread Sander Vanheule
are > > > versions. > > > > > > Signed-off-by: Sander Vanheule > > > > Seems like I was overdue on a proper read of the kernel patch > > submission > > guidelines. My understanding from the guidelines and your previous > > mail [1], > > is that t

Re: [RFC PATCH v2 1/6] ath79: ensure QCA956x gmac0 mux selects sgmii

2020-07-22 Thread Sander Vanheule
Hi David, On Wed, 2020-07-22 at 12:28 +0200, David Bauer wrote: > Hi Sander, > > this looks good, however there are two minor improvements still open. > > > + int err = 0; > > Remove this, as it is only assigned but never accessed. > > > + u32 serdes_cal; > > This is never used. > I had

[PATCH] tools/firmware-utils: use UTC for image timestamps

2020-08-06 Thread Sander Vanheule
By using localtime() to determine the timestamp that goes into factory images, the resulting image depends on the timezone of the build system. Use gmtime() instead, which results in more reproducible images. Signed-off-by: Sander Vanheule --- Tested by building factory images with tplink

[PATCH v2] tools/firmware-utils: use UTC for image timestamps

2020-08-06 Thread Sander Vanheule
By using localtime() to determine the timestamp that goes into factory images, the resulting image depends on the timezone of the build system. Use gmtime() instead, which results in more reproducible images. Signed-off-by: Sander Vanheule --- tools/firmware-utils/Makefile| 2

Re: [RFC] Policy for PKG_RELEASE bumps

2020-08-09 Thread Sander Vanheule
Hi Paul, Following our brief discussion on IRC, here are my remarks again, so others can also comment on them. I'm still pretty new to this packaging stuff, so some arguments may already have been made in the past. On Fri, 2020-08-07 at 12:32 -1000, Paul Spooren wrote: > Hi team, > > currently e

Re: jffs2 errors with 5.4 kernel

2020-08-17 Thread Sander Vanheule
On Mon, 2020-08-17 at 21:19 +0200, Nick wrote: > Logs AVM Fritz!Box: > - > https://gist.github.com/PolynomialDivision/96bfd98d723f288c617fd96f8ff04c22 > > I think many more devices are affected. Keep an eye out for jffs2 > errors. > > We believe that the mx25l12835f (16-pin package) chip is causi

[PATCH] kernel: mtdsplit: support ELF loader splitting

2020-08-19 Thread Sander Vanheule
aligned to an erase-block after the loader and kernel image. In case section header table is empty, determine the elf loader size by finding the end of the last segment, as defined by the program header table. Signed-off-by: Sander Vanheule --- This patch was tested on a number of ath79 devices

Re: tplink-safeloader support-list on CPE/WBS devices

2020-08-31 Thread Sander Vanheule
Hi Adrian, On Sun, 2020-08-30 at 22:43 +0200, Adrian Schmutzler wrote: > Hi, > > while increasing the kernel partition for the TP-Link CPE devices, I > found that the partitions called "soft-version" and "support-list" > are handled as a part of the file-system/firmware partition, in > contrast t

Re: [PATCH] ath10k-ct: update to version 2018-08-25

2020-09-02 Thread Sander Vanheule
On Wed, 2020-09-02 at 02:14 +0300, Stijn Tintel wrote: > And since we are using mac80211 5.8, let's also switch the ath10k-ct > driver to the new 5.8 version. > > Signed-off-by: Stijn Tintel Built and run-tested on ath79 (TP-Link EAP245 v3: qca9563+qca9982) Tested-by

[PATCH] ath79: switch to kernel loader for ar9344 CPE/WBS

2020-09-27 Thread Sander Vanheule
the new tplink-safeloader-elf base device. Signed-off-by: Sander Vanheule --- I've build tested this patch for all affected devices, but I cannot test these new images on the CPE/WBS devices as I do not have these. Any volunteer willing to test this patch on their device would be welcome to

[PATCH] rtl838x: clean up build instructions

2020-09-29 Thread Sander Vanheule
-netgear.mk does it. Signed-off-by: Sander Vanheule --- target/linux/rtl838x/image/Makefile | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/target/linux/rtl838x/image/Makefile b/target/linux/rtl838x/image/Makefile index eef1fe0a33..0174e47449 100644

Re: [PATCH] rtl838x: clean up build instructions

2020-09-29 Thread Sander Vanheule
Hi Adrian, On Tue, 2020-09-29 at 19:44 +0200, Adrian Schmutzler wrote: > > -define Build/custom-uimage > > - mkimage -A $(LINUX_KARCH) \ > > - -O linux -T kernel \ > > - -C gzip -a $(KERNEL_LOADADDR) $(if $(UIMAGE_MAGIC),-M > > $(UIMAGE_MAGIC),) \ > > - -e $(if > >

[PATCH 2/6] ath79: add QCA956x SERDES init workaround

2020-10-20 Thread Sander Vanheule
[Sander Vanheule: Minor code style fixes, Remove hunk adding qca956x-serdes-fixup to a missing DTS, Remove variable err that was only assigned, Rename function to sgmii_serdes_init, Lower priority of serdes call message to pr_debug] Signed-off-by: Sander Vanheule --- .../net

[PATCH 5/6] ath79: support for TP-Link EAP225-Outdoor v1

2020-10-20 Thread Sander Vanheule
D8:...:2E Tested by forum user PolynomialDivision on firmware v1.7.0. UART access tested by forum user arinc9. Signed-off-by: Sander Vanheule --- .../dts/qca9563_tplink_eap225-outdoor-v1.dts | 30 +++ .../generic/base-files/etc/board.d/02_network | 1 + .../etc/hotplug.d/firmw

[PATCH 3/6] ath79: prepare for 1-port TP-Link EAP2x5 devices

2020-10-20 Thread Sander Vanheule
on PCIe * Ethernet: AR8033-AL1A, one 1GbE port (802.3at PoE) Signed-off-by: Sander Vanheule --- .../dts/qca9563_tplink_eap2x5-1port.dtsi | 135 ++ 1 file changed, 135 insertions(+) create mode 100644 target/linux/ath79/dts/qca9563_tplink_eap2x5-1port.dtsi diff --git a

[PATCH 4/6] ath79: support for TP-Link EAP245 v1

2020-10-20 Thread Sander Vanheule
EAP2x5 devices" are based on that work. Signed-off-by: Sander Vanheule --- .../ath79/dts/qca9563_tplink_eap245-v1.dts| 44 +++ .../generic/base-files/etc/board.d/02_network | 1 + .../etc/hotplug.d/firmware/11-ath10k-caldata | 11 ++--- target/linux/ath79/image/generic-tp-lin

[PATCH 6/6] ath79: support for TP-Link EAP225 v3

2020-10-20 Thread Sander Vanheule
with hwaddr b0:...:3e and ssid "..." Using interface ath10 with hwaddr b0:...:3f and ssid "..." Tested by forum user blinkstar88 Signed-off-by: Sander Vanheule --- .../ath79/dts/qca9563_tplink_eap225-v3.dts| 30 +++ .../generic/base-files/etc/boa

[PATCH 1/6] ath79: ensure QCA956x gmac0 mux selects sgmii

2020-10-20 Thread Sander Vanheule
Some bootloaders do not set up gmac0 properly, leaving it disconnected from the sgmii interface. If the user specificies phy-mode sgmii, then use the gmac-config/device node to ensure the mux is configured correctly. Signed-off-by: Sander Vanheule --- .../net/ethernet/atheros/ag71xx

[PATCH 0/6] ath79: support for TP-Link single-port EAP2x5 devices

2020-10-20 Thread Sander Vanheule
e-working-on-tp-link-eap225/33956/105 Julien Dusser (1): ath79: add QCA956x SERDES init workaround Sander Vanheule (5): ath79: ensure QCA956x gmac0 mux selects sgmii ath79: prepare for 1-port TP-Link EAP2x5 devices ath79: support for TP-Link EAP245 v1 ath79: support for TP-Link EAP22

[PATCH 4/5] ath79: netgear: trim down uImage customisations

2020-11-04 Thread Sander Vanheule
Replace NETGEAR_KERNEL_MAGIC by UIMAGE_MAGIC to better match the variable's purpose. This allows to drop UIMAGE_MAGIC where it equals the default for uImages, and remove the custom Build/netgear-uImage. Signed-off-by: Sander Vanheule --- Build tested for Netgear WNDR3700v2 and EX6400. t

[PATCH 5/5] rtl83xx: drop custom mkimage build function

2020-11-04 Thread Sander Vanheule
UIMAGE_MAGIC is now supported by Build/uImage, in addition to UIMAGE_NAME. This removes the need for a custom mkimage call, so let's remove it. Signed-off-by: Sander Vanheule --- target/linux/rtl838x/image/Makefile | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff

[PATCH 2/5] ramips: mt7621: drop custom uImage function

2020-11-04 Thread Sander Vanheule
Use the mkimage argument overrides provided by uImage to implement the customisations required for the initramfs, instead of the near-identical custom function. Signed-off-by: Sander Vanheule --- Build tested for iodata_wn1167gr2, where uImage lzma -M 0x434f4d42 -n '3.10(XBC.

[PATCH 0/5] Make Build/uImage more flexible

2020-11-04 Thread Sander Vanheule
: https://patchwork.ozlabs.org/project/openwrt/patch/20200929162006.236206-1-san...@svanheule.net/ Sander Vanheule (5): build: uImage: allow override of default arguments ramips: mt7621: drop custom uImage function build: add UIMAGE_MAGIC to device variables ath79: netgear: trim down u

[PATCH 3/5] build: add UIMAGE_MAGIC to device variables

2020-11-04 Thread Sander Vanheule
45678 ... endef Fixes df8e6be59a "rtl838x: add new architecture" where UIMAGE_MAGIC was not declared as a device variable. Signed-off-by: Sander Vanheule --- include/image-commands.mk | 2 +- include/image.mk | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 1/5] build: uImage: allow override of default arguments

2020-11-04 Thread Sander Vanheule
of the call arguments to override the provided defaults. Only the input file name (-d) and the output file name cannot overriden. Signed-off-by: Sander Vanheule --- include/image-commands.mk | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/image-commands.mk b

Re: [PATCH] firmware-utils: tplink-safeloader: Add alternative partition table offset

2023-01-28 Thread Sander Vanheule
Hi Andreas, On Sun, 2023-01-22 at 22:36 +0100, Andreas Böhler wrote: > Some newer OEM firmware files, even for existing devices, have the > fwup-ptn at offset 0x1050 instead of 0x1014. If the fwup-ptn header is not > found at 0x1014, the alternative offset at 0x1050 is tried. > > Signed-off-by: A

Re: [PATCH] firmware-utils: tplink-safeloader: Add support for Deco M4R V4

2023-01-28 Thread Sander Vanheule
Hi Mark, On Sun, 2023-01-22 at 12:46 +0100, Mark Ceeha wrote: > Software version: > soft_ver:1.0.3 Build 20220426 Rel. 32976 I assume this is the FW image you've based this on? > > Partition table: > 0004 fs-uboot > 0004 0040 os-image > 0044 00b6 file-system > 00fa0

Re: [PATCH] firmware-utils: tplink-safeloader: Add support for Deco M4R V4

2023-01-28 Thread Sander Vanheule
Hi, On Sat, 2023-01-28 at 18:19 +0100, Shiz wrote: > Hi Sander, > > Thanks for reviewing my patch! > > > On 28 Jan Reiwa 5, at 17:09, Sander Vanheule wrote: > > > > Hi Mark, > > > > On Sun, 2023-01-22 at 12:46 +0100, Mark Ceeha wrote: > >

Re: [PATCH v2] tplink-safeloader: Add support for Deco M4R V4

2023-01-29 Thread Sander Vanheule
Hi Mark, On Sun, 2023-01-29 at 15:28 +0100, Mark Ceeha wrote: > Software version: >   soft_ver:1.0.0 Build 20211202 Rel. 69482 > > Partition table: >   0004 fs-uboot >   0004 0040 os-image >   0044 00b6 file-system >   00fa 0300 default-mac >   00fa0300 01

Re: [PATCH] firmware-utils: tplink-safeloader: Add alternative partition table offset

2023-01-31 Thread Sander Vanheule
Hi Andreas, On Tue, 2023-01-31 at 12:20 +0100, Andreas Böhler wrote: > Hi Sander, > > thanks for the review. > > > On 28/01/2023 16:42, Sander Vanheule wrote: > > Hi Andreas, > > > > On Sun, 2023-01-22 at 22:36 +0100, Andreas Böhler wrote: > >

[PATCH firmware-utils v1 04/10] tplink-safeloader: stop at nameless partition

2023-02-03 Thread Sander Vanheule
Current code only skips all-zero partition table entries, but nameless partitions with zero size don't make much sense either. Assume that any entry without a partition name is invalid, and stop processing entry lists at that point. Signed-off-by: Sander Vanheule --- src/tplink-safeloa

[PATCH firmware-utils v1 00/10] Refactor image ingestion to support new formats

2023-02-03 Thread Sander Vanheule
rt at the moment, so the patch serves mostly as documentation. [1] https://forum.openwrt.org/t/148982 Best, Sander Sander Vanheule (10): tplink-safeloader: stricter free_image_partition() tplink-safeloader: use enum for table types tplink-safeloader: replace hardcoded offsets tplink-safel

[PATCH firmware-utils v1 01/10] tplink-safeloader: stricter free_image_partition()

2023-02-03 Thread Sander Vanheule
Instead of only free()-ing the allocated data block, also clear the name and size of a payload entry to indicate that it's become invalid. Signed-off-by: Sander Vanheule --- src/tplink-safeloader.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/t

[PATCH firmware-utils v1 02/10] tplink-safeloader: use enum for table types

2023-02-03 Thread Sander Vanheule
the code, also fix the switch-case indentation. Signed-off-by: Sander Vanheule --- src/tplink-safeloader.c | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/src/tplink-safeloader.c b/src/tplink-safeloader.c index 6c4689c2f67c..79aefd973232

[PATCH firmware-utils v1 05/10] tplink-safeloader: don't end-pad sysupgrade file

2023-02-03 Thread Sander Vanheule
of the generated image. This can reduce the generated image size by several MiB. Signed-off-by: Sander Vanheule --- src/tplink-safeloader.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/tplink-safeloader.c b/src/tplink-safeloader.c index 5b19e8726821..05b7ca17f786 100644 --- a/src

[PATCH firmware-utils v1 03/10] tplink-safeloader: replace hardcoded offsets

2023-02-03 Thread Sander Vanheule
A number of data offsets are used as plain numbers throughout the code. This is a bit fragile, and the magic numbers make the code harder to read. Use a set of macros instead. Signed-off-by: Sander Vanheule --- src/tplink-safeloader.c | 39 ++- 1 file changed

[PATCH firmware-utils v1 06/10] tplink-safeloader: ignore NULLs in version info

2023-02-03 Thread Sander Vanheule
printing the contained data to avoid outputting NULLs to stdout. Signed-off-by: Sander Vanheule --- src/tplink-safeloader.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/tplink-safeloader.c b/src/tplink-safeloader.c index 05b7ca17f786..51f6683c802a

<    1   2   3   4   5   >