[PATCH] firewall4: add DSCP Least Effort class

2022-01-10 Thread Rui Salvaterra
In compliance with RFC-8622 [1]. A similar patch was also applied to firewall3. [1] https://datatracker.ietf.org/doc/html/rfc8622 Signed-off-by: Rui Salvaterra --- root/usr/share/ucode/fw4.uc | 1 + 1 file changed, 1 insertion(+) diff --git a/root/usr/share/ucode/fw4.uc b/root/usr/share/ucode

Re: [PATCH] kernel/5.10: remove CONFIG_DEVTMPFS{, _MOUNT} from kconfigs

2022-01-16 Thread Rui Salvaterra
Please don't merge this, removing the ksyms from the generic kconfigs will make make kernel_oldconfig prompt back for them, which definitely isn't what I intended. Will fix an resend a v2. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org ht

[PATCH v2] kernel/5.10: remove CONFIG_DEVTMPFS{, _MOUNT} from kconfigs

2022-01-16 Thread Rui Salvaterra
They are required for container support, but are handled in Config-kernel.in. Signed-off-by: Rui Salvaterra --- v2: keep both ksyms (disabled) in the generic kconfig. target/linux/archs38/config-5.10 | 1 - target/linux/layerscape/armv7/config-5.10 | 2 -- target/linux

Re: [maintainer-tools PATCH] update_kernel.sh: update it to new kernel hash/version file way

2022-01-16 Thread Rui Salvaterra
-i include/kernel-${KERNEL} \ > -e "s|LINUX_VERSION-${KERNEL} =.*|LINUX_VERSION-${KERNEL} = > ${NEWVER}|" \ > -e > "s|LINUX_KERNEL_HASH-${KERNEL}.*|LINUX_KERNEL_HASH-${PATCHVER} = ${CHECKSUM}|" > fi > -- > 2.33.1 Looks good to me.

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-20 Thread Rui Salvaterra
Hi, Ansuel, On Thu, 20 Jan 2022 at 15:11, Ansuel Smith wrote: > > Add support for link set useful to set CPU port for dsa drivers. > > Signed-off-by: Ansuel Smith > --- > ...-iplink_allow_to_change_iplink_value.patch | 94 +++ > 1 file changed, 94 insertions(+) > create mode 10

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-20 Thread Rui Salvaterra
Hi again, On Thu, 20 Jan 2022 at 15:56, Rui Salvaterra wrote: > > Nice, but we'll need to do the same for BusyBox's ip applet. Let's not > force everyone who needs multi-CPU DSA to install iproute2's ip just > for this case. ;) Just to clarify, I'll ta

Re: [PATCH v2] kernel/5.10: remove CONFIG_DEVTMPFS{, _MOUNT} from kconfigs

2022-01-21 Thread Rui Salvaterra
Hi, Adrian On Thu, 20 Jan 2022 at 18:48, Adrian Schmutzler wrote: > > Hi, > > just a nitpick: Commit title prefix should be "kernel: 5.10: ...". Sure, no problem. May I push it with that fix? Cheers, Rui ___ openwrt-devel mailing list openwrt-devel@l

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-21 Thread Rui Salvaterra
[Apologies for resending, Gmail turned my message into HTML behind my back.] Hi, Ansuel, After reading the patch more carefully, I have to say I'm really not fond of it in its current form, especially considering that the original feedback from Stephen Hemminger and Vladimir Oltean [1] hasn't bee

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-21 Thread Rui Salvaterra
On Fri, 21 Jan 2022 at 21:11, Ansuel Smith wrote: > > > Should we follow the suggestion and add a specific attribute just for DSA? I believe that would be the right thing to do, but I'd like to know what Daniel and Marek think about it too. ___ openwrt

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-22 Thread Rui Salvaterra
Hi, Ansuel, On Sat, 22 Jan 2022 at 01:08, Ansuel Smith wrote: > > > So.. how should we proceed with this? From what I understand the idea is to > merge this ASAP. But not a moment sooner. ;) I'm sure we agree that this patch won't be merged upstream in its current form, according to the comment

Re: [PATCH] bcm63xx: Remove patch already in Linux stable

2022-02-01 Thread Rui Salvaterra
return ret; > - } > - > -- > 2.30.2 Oh, my…! I have no idea how I've missed this (or how quilt happily refreshed it without complaints, since the context doesn't seem to match at all). Reviewed-by: Rui Salvaterra Thanks, Rui ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] octeon: Switch to kernel 5.10 and mark source only

2022-02-04 Thread Rui Salvaterra
Hi, Hauke, On Fri, 4 Feb 2022 at 00:10, Hauke Mehrtens wrote: > > Stijn Tintel reported a memory leak in octeon with kernel 5.10. With > kernel 5.4 it worked fine. The memory leak was seen with IPsec tunnels, > VRRP IPs, conntrack syncing, full IPv6 BGP feed, etc. > See details here: https://gith

[PATCH] update_kernel.sh: fix unified version file updates

2022-02-08 Thread Rui Salvaterra
7;re using the unified file and do the version update accordingly. Fixes: cbb9d08 ("update_kernel.sh: update it to new kernel hash/version file way") Signed-off-by: Rui Salvaterra --- update_kernel.sh | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] firewall3: remove unnecessary fw3_has_table

2022-02-11 Thread Rui Salvaterra
Hi, Wenli, On Thu, 10 Feb 2022 at 19:19, Wenli Looi wrote: > > Hi Rui and Ansuel, > > Can you take a look at this patch I sent a while ago for firewall3? I > think it is a better solution for the problem in kernel 5.15+ that is > identified here. > > http://lists.openwrt.org/pipermail/openwrt-dev

Re: [PATCH] firewall3: remove unnecessary fw3_has_table

2022-02-17 Thread Rui Salvaterra
Hi, guys, On Fri, 11 Feb 2022 at 19:12, Wenli Looi wrote: > > Sorry, forgot to reply all > > On Fri, Feb 11, 2022 at 11:09 AM Wenli Looi wrote: > > > > Hi Rui, > > > > Yes, I believe it still works. Every place where fw3_has_table is > > called, we check immediately after if fw3_ipt_open succeed

Re: [PATCH] firewall3: remove unnecessary fw3_has_table

2022-02-21 Thread Rui Salvaterra
Hi, Ansuel, On Mon, 21 Feb 2022 at 16:09, Ansuel Smith wrote: > > Hi, sorry for the delay... I reverted my patch and applied this > and I can confirm that this works correctly on linux 5.15. No worries, thanks for confirming. I'll take it from here. :) Cheers, Rui _

[PATCH] kernel: generic: add missing 5.10 symbols

2022-02-24 Thread Rui Salvaterra
Add the following kconfig symbols (disabled): CONFIG_DEFAULT_FQ CONFIG_DEFAULT_CODEL CONFIG_DEFAULT_SFQ Also resort the config with the kconfig.pl script. Fixes: f39872d966 ("kernel: generic: select the fq_codel qdisc by default") Signed-off-by: Rui Salvaterra --- I screwed up, s

[PATCH] firewall3: bump to latest git HEAD

2022-02-25 Thread Rui Salvaterra
4cd7d4f Revert "firewall3: support table load on access on Linux 5.15+" 50979cc firewall3: remove unnecessary fw3_has_table Signed-off-by: Rui Salvaterra --- package/network/config/firewall/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/netw

[PATCH] ath9k: backport hw_random API support

2022-03-02 Thread Rui Salvaterra
https://lore.kernel.org/all/20220216113323.53332-1-ja...@zx2c4.com/ Acked-by: Petr Štetiar Signed-off-by: Rui Salvaterra --- ...dom-API-instead-of-directly-dumping-.patch | 145 ++ 1 file changed, 145 insertions(+) create mode 100644 package/kernel/mac80211/patches/ath9k/020-v5.18-

Re: Drop CONFIG_IPV6 ?

2022-03-14 Thread Rui Salvaterra
Hi, Etienne, On Sun, 13 Mar 2022 at 23:33, Etienne Champetier wrote: > > We currently have some circular dependencies caused by the usage of > PROVIDES and @IPV6 > https://github.com/openwrt/openwrt/issues/9407 These don't seem unfixable. > One radical way to fix, suggested by Jow, is to comple

Re: [PATCH] kernel: enable SERIAL_8250_16550A_VARIANTS

2022-03-14 Thread Rui Salvaterra
Tintel [patch snipped] Seems sensible to me. Reviewed-by: Rui Salvaterra Cheers, Rui ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] ath9k: backport hw_random API support

2022-03-23 Thread Rui Salvaterra
Hi again, On Wed, 2 Mar 2022 at 13:31, Rui Salvaterra wrote: > > Backport Jason's patch [1] implementing proper hw_random API support for the > ath9k hwrng. The original code invoked add_hwgenerator_randomness to directly > feed ADC entropy into the system pool. Since add_hwgen

[PATCH v2] ath9k: backport hw_random API support

2022-03-23 Thread Rui Salvaterra
https://lore.kernel.org/all/20220216113323.53332-1-ja...@zx2c4.com/ Acked-by: Petr Štetiar Signed-off-by: Rui Salvaterra --- v2: make it actually build when CONFIG_ATH9K_HWRNG is selected (and rng-core.ko isn't built-in). package/kernel/mac80211/ath.mk| 2 +- ...dom-API-

[PATCH] x86: remove an upstreamed patch

2022-04-07 Thread Rui Salvaterra
012-pcengines-apu2-detect-apuv4-board.patch is upstream since Linux 5.5 [1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/platform/x86/pcengines-apuv2.c?h=v5.5&id=3d00da1de3ea36ba44f4a7ba76c8c8b16f98204b Signed-off-by: Rui Salvaterra --- ...12-pceng

Re: [PATCH] toolchain: musl: Update to version 1.2.3

2022-04-11 Thread Rui Salvaterra
look useful also for OpenWrt 22.03. For 22.03, this is definitely Acked-by: Rui Salvaterra Running without issues on my Omnia (master, though), so it's also Tested-by: Rui Salvaterra Thanks, Rui ___ openwrt-devel mailing list openwrt-devel@l

Re: [PATCH 1/4] pcre2: adds pcre2 to base

2022-05-20 Thread Rui Salvaterra
On Thu, 19 May 2022 at 18:35, Daniel Golle wrote: > > On Thu, May 19, 2022 at 06:37:28PM +0200, Dominick Grift wrote: > > libselinux-3.4 requires pcre2 > > > > Signed-off-by: Dominick Grift > > --- > > package/libs/pcre2/Config.in | 30 > > package/libs/pcre2/Makefile | 92

[PATCH] kernel 5.15: x86-64: enable CONFIG_SLS

2022-06-10 Thread Rui Salvaterra
Starting with GCC 12, we have the possibility of mitigating straight-line speculation vulnerabilities in x86-64 targets. Make it so. Reported-by: Stefan Lippers-Hollmann Signed-off-by: Rui Salvaterra --- target/linux/x86/64/config-5.15 | 1 + 1 file changed, 1 insertion(+) diff --git a/target

Fwd: Testing network / NAT performance

2022-06-14 Thread Rui Salvaterra
[Ugh, now with less HTML, sorry about that…] Hi, Rafał, On Tue, 14 Jun 2022 at 14:20, Rafał Miłecki wrote: > > As you can see 4e0c54bc5bc8 has accidentally moved -fno-reorder-blocks > from !CONFIG_CC_OPTIMIZE_FOR_SIZE to CONFIG_CC_OPTIMIZE_FOR_SIZE. > > I've noticed problem with -fno-reorder-blo

Re: [PATCH] kernel 5.15: x86-64: enable CONFIG_SLS

2022-06-22 Thread Rui Salvaterra
Hi, everyone, On Fri, 10 Jun 2022 at 09:20, Rui Salvaterra wrote: > > Starting with GCC 12, we have the possibility of mitigating straight-line > speculation vulnerabilities in x86-64 targets. Make it so. [patch snipped] I've made this part of the 5.15 pull request [1], so I

Re: [PATCH v2] utrace: fix memory leak

2022-06-24 Thread Rui Salvaterra
free(_envp[0]); > + if (newenv == 2 && _envp[1]) > + free(_envp[1]); > free(_envp); > return ret; > } > -- > 2.21.0.windows.1 I'm not a C expert, but I see those array positions being allocated with asprintf

Re: [PATCH] x86/c3000: Add Intel SoC C3000 series

2022-06-24 Thread Rui Salvaterra
Hi, jialelux, On Fri, 24 Jun 2022 at 09:50, wrote: > [snipped] > +SUBTARGETS:=generic legacy geode 64 c3000 [snipped] The Atom C3000 is a x86-64 CPU. What makes it so special as to require a dedicated subtarget? Cheers, Rui ___ openwrt-devel maili

[OpenWrt-Devel] [PATCH] fw3: robustify flow table detection.

2020-01-24 Thread Rui Salvaterra
since it's looking for the module itself. Create a generic helper and instead check for existence of the FLOWOFFLOAD target in /proc/net/ip_tables_targets. Signed-off-by: Rui Salvaterra --- defaults.c | 25 +++-- utils.c| 27 +++ utils.h| 2 +

Re: [OpenWrt-Devel] [PATCH] fw3: robustify flow table detection.

2020-01-24 Thread Rui Salvaterra
Gah, I messed up the subject line. Will resend shortly, sorry for the noise. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH v3] fw3: robustify flow table detection.

2020-01-24 Thread Rui Salvaterra
since it's looking for the module itself. Create a generic helper and instead check for existence of the FLOWOFFLOAD target in /proc/net/ip_tables_targets. Signed-off-by: Rui Salvaterra --- defaults.c | 25 +++-- utils.c| 27 +++ utils.h| 2 +

[OpenWrt-Devel] [RFC PATCH] ath9k: enable hardware random number generator.

2020-01-27 Thread Rui Salvaterra
ath9k driver is initialised. Signed-off-by: Rui Salvaterra --- config/Config-kernel.in | 4 + package/kernel/mac80211/ath.mk| 7 + .../ath/543-ath9k_entropy_from_adc.patch | 186 -- 3 files changed, 11 insertions(+), 186 deletions

[OpenWrt-Devel] [PATCH] ath9k: allow enabling hardware random number generator support.

2020-01-28 Thread Rui Salvaterra
required. Expose this feature in the build system. Signed-off-by: Rui Salvaterra --- config/Config-kernel.in| 4 package/kernel/mac80211/ath.mk | 7 +++ 2 files changed, 11 insertions(+) diff --git a/config/Config-kernel.in b/config/Config-kernel.in index 20930326ca..2f4cda4275

[OpenWrt-Devel] [PATCH] firewall3: utils: create a common helper to find strings is files.

2020-01-29 Thread Rui Salvaterra
Both fw3_has_table and fw3_has_target do the same thing. Factor out the common code into a separate function. Signed-off-by: Rui Salvaterra --- utils.c | 42 ++ 1 file changed, 14 insertions(+), 28 deletions(-) diff --git a/utils.c b/utils.c index

Re: [OpenWrt-Devel] [PATCH] firewall3: utils: create a common helper to find strings is files.

2020-01-29 Thread Rui Salvaterra
Please ignore this one for the moment, it seems to be bugged. Sorry for the noise. A quarta, 29/01/2020, 11:50, Rui Salvaterra escreveu: > Both fw3_has_table and fw3_has_target do the same thing. Factor out the > common code into a separate function. > > Signed-off-by: Ru

[OpenWrt-Devel] [PATCH v2] firewall3: utils: create a common helper to find strings in files

2020-01-30 Thread Rui Salvaterra
v2: Actually make it work. Use strncmp instead of strcmp (strangely enough, strcmp fails for the ip*names case, but I don't understand why). Both fw3_has_table and fw3_has_target do the same thing. Factor out the common code into a separate function. Signed-off-by: Rui Salvaterra --- ut

Re: [OpenWrt-Devel] [PATCH] ath9k: allow enabling hardware random number generator support.

2020-01-30 Thread Rui Salvaterra
Please ignore this patch too. I'm going to send a more complete one (against master), implementing ath9k-rng support for both AR5008 and AR9002 (in addition to the already supported AR9003). A terça, 28/01/2020, 12:58, Rui Salvaterra escreveu: > Changes since RFC: keep the current entro

[OpenWrt-Devel] [RFC/RFT PATCH] ath9k: implement kthread entropy collection for AR5008 and AR9002 PHYs.

2020-01-30 Thread Rui Salvaterra
collection support to both AR5008 and AR9002 PHYs. Signed-off-by: Rui Salvaterra --- package/kernel/mac80211/ath.mk| 7 + .../ath/543-ath9k_entropy_from_adc.patch | 216 ++ 2 files changed, 134 insertions(+), 89 deletions(-) diff --git a/package/kernel

Re: [OpenWrt-Devel] [RFC/RFT PATCH] ath9k: implement kthread entropy collection for AR5008 and AR9002 PHYs.

2020-01-31 Thread Rui Salvaterra
Hi, Felix, On Fri, 31 Jan 2020 at 08:12, Felix Fietkau wrote: > For at least AR5008 and AR9002, but probably also for AR9003 I would > like to keep the behavior of collecting entropy only once at driver > initialization. Well, you could have told me this before I started working on it, but I gue

Re: [OpenWrt-Devel] [RFC/RFT PATCH] ath9k: implement kthread entropy collection for AR5008 and AR9002 PHYs.

2020-01-31 Thread Rui Salvaterra
On Fri, 31 Jan 2020 at 09:06, Rui Salvaterra wrote: > > Like I wrote in the forum, I don't have (yet) AR5008 hardware to test. And I just ordered an AR5BXB72* for testing purposes. I can configure it as AP on my Turris Omnia. * https://www.aliexpress.com/item/32356

Re: [OpenWrt-Devel] [RFC/RFT PATCH] ath9k: implement kthread entropy collection for AR5008 and AR9002 PHYs.

2020-02-10 Thread Rui Salvaterra
On Fri, 31 Jan 2020 at 08:12, Felix Fietkau wrote: > > For at least AR5008 and AR9002, but probably also for AR9003 I would > like to keep the behavior of collecting entropy only once at driver > initialization. > Last time I worked on this I noticed that on several chips, sampling > entropy durin

Re: [OpenWrt-Devel] [RFC/RFT PATCH] ath9k: implement kthread entropy collection for AR5008 and AR9002 PHYs.

2020-02-10 Thread Rui Salvaterra
Hi again, Felix, On Mon, 10 Feb 2020 at 13:37, Felix Fietkau wrote: > The issues that were reported years ago were mainly stuck beacons, > increase in hardware resets, connection stability issues. Thanks for the info, I'll keep an eye out for those. The dmesg is clean, I haven't enabled any debu

Re: [OpenWrt-Devel] [RFC/RFT PATCH] ath9k: implement kthread entropy collection for AR5008 and AR9002 PHYs.

2020-02-13 Thread Rui Salvaterra
Hi again, Felix, On Mon, 10 Feb 2020 at 15:46, Rui Salvaterra wrote: > > As an aside, this WZR-HP-AG300H is running as an AP, at a public > institution, with 12 STAs connected, at the moment (8 at 2,4 GHz, 4 at > 5 GHz), without any reported issues. So, since Tuesday, I've been

Re: [OpenWrt-Devel] [RFC PATCH] ath9k: enable hardware random number generator.

2020-03-01 Thread Rui Salvaterra
Hi, Petr! Writing from my phone, pardon the terseness (and HTML crap). A domingo, 1/03/2020, 13:06, Petr Štetiar escreveu: > Rui Salvaterra [2020-01-27 18:19:46]: > > why is this RFC, are there any gotchas? > This has only been thoroughly tested on AR9003 and AR9002 hardware. I j

Re: [OpenWrt-Devel] [RFC PATCH] ath9k: enable hardware random number generator.

2020-03-01 Thread Rui Salvaterra
Ah, silly me, you're absolutely right. This is just half the patch, and it's perfectly fine the way it is, so I'm not enabling anything new, just exposing the existing kconfig. Please ignore my previous email. Thanks, Rui A domingo, 1/03/2020, 13:34, Rui Salvaterra escrev

Re: [OpenWrt-Devel] [RFC PATCH] ath9k: enable hardware random number generator.

2020-03-01 Thread Rui Salvaterra
Hi again, Petr. A domingo, 1/03/2020, 13:47, Petr Štetiar escreveu: > Rui Salvaterra [2020-03-01 13:39:37]: > > > Ah, silly me, you're absolutely right. This is just half the patch, and > > it's perfectly fine the way it is, so I'm not enabling anything ne

[OpenWrt-Devel] wireguard: unknown relocation: 102 [ARMv7 Thumb-2]

2020-06-10 Thread Rui Salvaterra
Hi, Jason, I'm trying to build OpenWrt master with Thumb-2 instructions for my Turris Omnia (both kernel and userspace) with GCC 9.3.0 and Binutils 2.34 from the toolchain. [1] Everything seems to work apart from WireGuard, for some reason the module won't load, throwing the relocation error in $s

Re: [OpenWrt-Devel] wireguard: unknown relocation: 102 [ARMv7 Thumb-2]

2020-06-10 Thread Rui Salvaterra
Hi, Jason, Thanks for the quick reply! On Wed, 10 Jun 2020 at 10:20, Jason A. Donenfeld wrote: > > Is there some config combination you can stick into the test harness > to repro what you're seeing? Good question. :) You're testing in QEMU (which I personally never used), right? I don't know ho

[OpenWrt-Devel] master (mvebu): irq 77: nobody cared

2020-06-15 Thread Rui Salvaterra
Hi, guys, After some time, the pca953x on my Turris Omnia decides it's not having any more of it. I thought I had screwed up my configuration somewhere, so I installed the current (r13563-69e7d14e1b) snapshot and tried to reproduce the issue. Stack trace follows. [12865.018034] irq 77: nobody car

[OpenWrt-Devel] master: mvebu (Turris Omnia): pca953x: unhandled interrupts on Linux 5.4.45

2020-06-15 Thread Rui Salvaterra
Hi, again, As a follow-up on this morning's email [1], I narrowed down the issue to the PCA9538 expander driver. For some reason, when CONFIG_GPIO_PCA953X_IRQ is enabled, interrupts will eventually go unhandled, causing the kernel to complain loudly and disable the respective interrupt line. I nev

Re: [OpenWrt-Devel] wireguard: unknown relocation: 102 [ARMv7 Thumb-2]

2020-06-17 Thread Rui Salvaterra
Hi again, Jason, On Wed, 10 Jun 2020 at 11:09, Jason A. Donenfeld wrote: > > Eventually I can probably get this building and testing and find some > hardware for this and such. But if you'd like things to move faster, > trying to reproduce the issue in the qemu test suite will result in a > quick

[OpenWrt-Devel] [PATCH] mvebu: refresh config

2020-06-17 Thread Rui Salvaterra
CONFIG_GRO_CELLS and CONFIG_PAGE_POOL added. Signed-off-by: Rui Salvaterra --- target/linux/mvebu/config-5.4 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/linux/mvebu/config-5.4 b/target/linux/mvebu/config-5.4 index ac3e73c7f0..feb1ccac8c 100644 --- a/target/linux/mvebu/config

[OpenWrt-Devel] [RFC PATCH] mvebu: compile the kernel in Thumb-2 mode for ARMv7 targets

2020-06-17 Thread Rui Salvaterra
[1] https://static.docs.arm.com/ihi0044/e/IHI0044E_aaelf.pdf (page 28) [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm/Makefile?h=linux-5.4.y#n129 Signed-off-by: Rui Salvaterra --- target/linux/mvebu/cortexa9/config-default | 2 ++ 1 file changed, 2 insertions(+) create mode 100

Re: [OpenWrt-Devel] Any progress on R_ARM_THM_JUMP11 issues?

2020-06-17 Thread Rui Salvaterra
Hi again, Jason, [Adding a bit of extra context for linux-arm-kernel.] On Wed, 17 Jun 2020 at 22:02, Jason A. Donenfeld wrote: > > But I am wondering: has anybody heard about toolchain progress toward > fixing this? Couldn't the compiler reorder functions itself more > intelligently? Or avoid em

Re: [OpenWrt-Devel] [RFC PATCH] mvebu: compile the kernel in Thumb-2 mode for ARMv7 targets

2020-06-18 Thread Rui Salvaterra
Please ignore this one, I'll send an updated patch shortly (only for 5.4, which I've tested). On Wed, 17 Jun 2020 at 18:37, Rui Salvaterra wrote: > > (Sending as RFC due to the note below.) > > The Thumb-2 instruction set generates denser code, allowing for more efficient

[OpenWrt-Devel] [RFC PATCH v2] mvebu: compile the kernel in Thumb-2 mode for ARMv7 targets

2020-06-18 Thread Rui Salvaterra
git/stable/linux.git/tree/arch/arm/Makefile?h=linux-5.4.y#n129 Signed-off-by: Rui Salvaterra --- target/linux/mvebu/cortexa9/config-5.4 | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 target/linux/mvebu/cortexa9/config-5.4 diff --git a/target/linux/mvebu/cortexa9/config-5.4 b/target/l

Re: [OpenWrt-Devel] wireguard: unknown relocation: 102 [ARMv7 Thumb-2]

2020-06-19 Thread Rui Salvaterra
Good morning, Jason! On Fri, 19 Jun 2020 at 00:50, Jason A. Donenfeld wrote: > > Hey Rui, > > I fixed it! It turned out to be caused by -fvisibility=hidden undoing > the effect of the binutils fix from a while back. Here's the patch > that makes the problem go away: > > https://git.zx2c4.com/wire

[OpenWrt-Devel] [RFC PATCH] ARM Cortex-A9: build the userspace with Thumb-2 instructions

2020-06-19 Thread Rui Salvaterra
Thumb-2 code is denser than pure ARM, reducing RAM usage and improving performance due to better instruction cache footprint. There's no reason for not enabling this feature on other ARMv7 targets (cortex-a7 and cortex-a8), but I don't have the hardware to test it. Signed-off-by: Rui

Re: [OpenWrt-Devel] [PATCH] mvebu: refresh config

2020-06-22 Thread Rui Salvaterra
Hi, Petr, On Mon, 22 Jun 2020 at 09:25, Petr Štetiar wrote: > > well I can see that in the diff already, but I'm missing the answer to 'Why?' > question. No particular reason, I ran make kernel_oldconfig and these new options were set automatically, which means they're probably non-optional. We

[PATCH] zram-swap: enable swap discard

2020-06-23 Thread Rui Salvaterra
kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/block/zram/zram_drv.c?h=linux-4.14.y&id=f4659d8e620d08bd1a84a8aec5d2f5294a242764 Signed-off-by: Rui Salvaterra --- package/system/zram-swap/files/zram.init | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [PATCH] zram-swap: enable swap discard

2020-06-24 Thread Rui Salvaterra
Hi, Emil, On Wed, 24 Jun 2020 at 20:30, Emil Muratov wrote: > > zram swap discard is enabled by default, no need to specify additional > option. Pls, check for example info output in > https://github.com/openwrt/openwrt/pull/1515 Unfortunately, that's not quite right. This has nothing to do with

Re: [PATCH] zram-swap: enable swap discard

2020-06-25 Thread Rui Salvaterra
Hi, Emil, On Thu, 25 Jun 2020 at 10:05, Emil Muratov wrote: > > Hmm... that looks weird at first, > I was checking kernel counters at /sys/block/zram0/io_stat, > which is zram device for swap. And if there was positive counter for > discards for zram device while swap was not sending any discards

Re: [PATCH] zram-swap: enable swap discard

2020-06-25 Thread Rui Salvaterra
Hi, Emil, On Thu, 25 Jun 2020 at 13:57, Emil Muratov wrote: > > Could you, please, describe you test case scenarios and measurements > where you've hit memory waste for zram dev when swap shrinks? I don't have a specific procedure to test this, but I believe I showed you proof that it's a good i

[RFC PATCH] kernel: kmod-zram: break the strict dependency from lz4

2020-06-25 Thread Rui Salvaterra
Zram is only strictly dependent on lzo, not lz4. Break this dependency and make the lz4 module visible in the configuration, in order for the user to have the choice of enabling/disabling it, if (s)he sees fit. Signed-off-by: Rui Salvaterra --- package/kernel/linux/modules/lib.mk | 1

[RFC PATCH] kernel: zstd: enable crypto API support on Linux 4.19+

2020-06-29 Thread Rui Salvaterra
Zstd is supported by the crypto API since Linux 4.18. Enable this feature and reveal the package in the configuration section, so the user can select it. This allows zstd to be used as a compression algorithm in zram, for example. Signed-off-by: Rui Salvaterra --- package/kernel/linux/modules

[RFC PATCH] procd: don't let the user choose to mount /tmp on zram

2020-06-29 Thread Rui Salvaterra
ocd tmp-on-zram support altogether. [1] https://www.kernel.org/doc/Documentation/filesystems/tmpfs.txt Signed-off-by: Rui Salvaterra --- package/system/procd/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/package/system/procd/Makefile b/package/system/procd/Makefile index 5647a47

[RFC PATCH] procd: completely remove tmp-on-zram support

2020-06-29 Thread Rui Salvaterra
This is the follow-up patch to "procd: don't let the user choose to mount /tmp on zram". As explained there, this feature is both redundant and more limited than using a zram swap device, as already provided by the zram-swap package. Signed-off-by: Rui Salvaterra --- CMake

[RFC PATCH] procd: Remove the remnants of tmp-on-zram from the makefile

2020-06-29 Thread Rui Salvaterra
Now that this feature is gone, clean-up the makefile accordingly. Signed-off-by: Rui Salvaterra --- package/system/procd/Makefile | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/package/system/procd/Makefile b/package/system/procd/Makefile index 8553b4e304

[PATCH] dropbear: init: replace backticks with $()

2020-06-30 Thread Rui Salvaterra
Signed-off-by: Rui Salvaterra --- package/network/services/dropbear/files/dropbear.init | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/network/services/dropbear/files/dropbear.init b/package/network/services/dropbear/files/dropbear.init index daf111fadb

[PATCH] zram-swap: init: replace backticks with $()

2020-06-30 Thread Rui Salvaterra
Signed-off-by: Rui Salvaterra --- package/system/zram-swap/files/zram.init | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/package/system/zram-swap/files/zram.init b/package/system/zram-swap/files/zram.init index d33e779850..a6126e578f 100755 --- a/package/system

Re: [PATCH] dropbear: init: replace backticks with $()

2020-06-30 Thread Rui Salvaterra
Hi, Adrian, On Tue, 30 Jun 2020 at 18:05, wrote: > > Merged your two patches, please add a commit description next time. > Will do, thanks a lot. Cheers, Rui ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org http://lists.infradead.org/ma

Re: [RFC PATCH v2] mvebu: compile the kernel in Thumb-2 mode for ARMv7 targets

2020-06-30 Thread Rui Salvaterra
Hi, Hauke, On Tue, 30 Jun 2020 at 21:32, Hauke Mehrtens wrote: > > Did you run a benchmark to test how much faster it is? I haven't done any performance testing, but I expect it to be a wash (improvements/regressions within around 2-3 % across the board). The big win here is in the memory/icache

Re: [RFC PATCH v2] mvebu: compile the kernel in Thumb-2 mode for ARMv7 targets

2020-07-01 Thread Rui Salvaterra
Hi again, Hauke, On Tue, 30 Jun 2020 at 23:30, Rui Salvaterra wrote: > > There's no reason gcc 8 won't work fine too, the only snag we hit was > with gas, and that's already fixed (see below). I'll test with gcc 8 > too, though, just to make sure (and 10, as soo

[PATCH] busybox: store applet usage messages uncompressed

2020-07-07 Thread Rui Salvaterra
The rootfs squashfs is already highly (XZ) compressed. Storing the applet messages in compressed form will increase the entropy and reduce the overall image compression ratio. Signed-off-by: Rui Salvaterra --- package/utils/busybox/Config-defaults.in | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] busybox: use CLOCK_MONOTONIC instead of gettimeofday

2020-07-08 Thread Rui Salvaterra
(time moving backwards). [1] https://linux.die.net/man/2/clock_gettime Signed-off-by: Rui Salvaterra --- package/utils/busybox/Config-defaults.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/utils/busybox/Config-defaults.in b/package/utils/busybox/Config-defaults.in

[PATCH] busybox: disable SUSv2 compatibility by default

2020-07-08 Thread Rui Salvaterra
The Single UNIX Specification, Version 3, came out on the 30th January 2002 [1]. There's nothing in the OpenWrt userspace which needs support for legacy SUSv2 compatibility. [1] http://www.unix.org/version3/pr.html Signed-off-by: Rui Salvaterra --- package/utils/busybox/Config-defaults.i

[PATCH] zram-swap: correctly express the required dependencies

2020-07-08 Thread Rui Salvaterra
The block-mount swapon implementation doesn't support discard, so make zram-swap depend only on the default BusyBox implementation or, when unavailable, on the one present in the swap-utils package. Signed-off-by: Rui Salvaterra --- package/system/zram-swap/Makefile | 2 +- 1 file chang

[PATCH] treewide: switch head to SUSv3-style arguments

2020-07-09 Thread Rui Salvaterra
Before disabling support for SUSv2 by default on BusyBox, care must be taken to ensure the arguments are SUSv3-compliant. Make it so. Signed-off-by: Rui Salvaterra --- package/base-files/files/lib/preinit/02_sysinfo | 2 +- package/base-files/files/lib/preinit/99_10_failsafe_login

Re: [PATCH] treewide: switch head to SUSv3-style arguments

2020-07-09 Thread Rui Salvaterra
Hi, Henrique, On Thu, 9 Jul 2020 at 14:00, Henrique de Moraes Holschuh wrote: > > Unless the size savings are very high to justify it, it is probably a > very bad idea to disable SuS-v2 support in busybox. > > And it would need to be a sizeable reduction to be worth it indeed: as > you already no

Re: [PATCH] busybox: disable SUSv2 compatibility by default

2020-07-09 Thread Rui Salvaterra
Hi, Henrique, On Thu, 9 Jul 2020 at 14:27, Henrique de Moraes Holschuh wrote: > > As you found yourself ("head -1", "tail -1"...), this is hard to access, > and it is going to introduce (sometimes subtle) bugs in scripts not just > from openwrt upstream, but also downstream and users. > > Unless

Re: [PATCH] busybox: store applet usage messages uncompressed

2020-07-09 Thread Rui Salvaterra
Hi, Petr! On Thu, 9 Jul 2020 at 16:46, Petr Štetiar wrote: > > Numbers please! :) Here you go (compressed vs uncompressed): busybox (the executable): 364596 vs 384804 bytes. OpenWrt target images (the kernel image is unchanged, obviously): omnia-medkit-openwrt-mvebu-cortexa9-cznic_turris-omni

[PATCH] procd: don't let the user choose to mount /tmp on zram

2020-07-12 Thread Rui Salvaterra
ocd tmp-on-zram support altogether. [1] https://www.kernel.org/doc/Documentation/filesystems/tmpfs.txt Signed-off-by: Rui Salvaterra --- package/system/procd/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/package/system/procd/Makefile b/package/system/procd/Makefile index 3b88c76

[PATCH] kernel: kmod-lib-zstd: enable crypto API support on Linux 4.19+

2020-07-12 Thread Rui Salvaterra
Zstd is supported by the crypto API since Linux 4.18. Enable this feature and reveal the package in the configuration section, so the user can select it. This allows zstd to be used as a compression algorithm in zram, for example. Signed-off-by: Rui Salvaterra --- package/kernel/linux/modules

[PATCH] procd: Remove the remnants of tmp-on-zram from the makefile

2020-07-12 Thread Rui Salvaterra
Now that this feature is gone, clean-up the makefile accordingly. This patch is a follow-up to "procd: completely remove tmp-on-zram support" Signed-off-by: Rui Salvaterra --- package/system/procd/Makefile | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git

[PATCH] procd: completely remove tmp-on-zram support

2020-07-12 Thread Rui Salvaterra
This is the follow-up patch to "procd: don't let the user choose to mount /tmp on zram". As explained there, this feature is both redundant and more limited than using a zram swap device, as already provided by the zram-swap package. Signed-off-by: Rui Salvaterra --- CMake

[PATCH] zram-swap: drop the conditional dependency on swap-utils

2020-07-14 Thread Rui Salvaterra
SYBOX_* symbols. Signed-off-by: Rui Salvaterra --- package/system/zram-swap/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/system/zram-swap/Makefile b/package/system/zram-swap/Makefile index a6661ce5e9..0d809c10e4 100644 --- a/package/system/zram-swap/Makefile +++ b

[PATCH] fstools: disable swapon/swapoff symlink creation

2020-07-15 Thread Rui Salvaterra
elves from the block executable. Signed-off-by: Rui Salvaterra --- package/system/fstools/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/package/system/fstools/Makefile b/package/system/fstools/Makefile index 6b813cb433..ed0b3a7a80 100644 --- a/package/system/fstools/Makefile

[PATCH] fstools: block: remove the swapon/swapoff applets

2020-07-15 Thread Rui Salvaterra
off a few bytes from the block executable: Before: 92724 bytes After: 89532 bytes Signed-off-by: Rui Salvaterra --- block.c | 127 1 file changed, 127 deletions(-) diff --git a/block.c b/block.c index 569bf56..ffb92d9 100644 --- a/bl

[PATCH] dropbear: allow disabling the RSA public key algorithm

2020-07-17 Thread Rui Salvaterra
kiB of savings. Signed-off-by: Rui Salvaterra --- package/network/services/dropbear/Config.in| 7 +++ package/network/services/dropbear/Makefile | 7 +-- ...0-signkey-fix-use-of-rsa-sha2-256-pubkeys.patch | 14 +- 3 files changed, 21 insertions(+), 7 deletions

[PATCH v2] dropbear: allow disabling the RSA public key algorithm

2020-07-17 Thread Rui Salvaterra
Signed-off-by: Rui Salvaterra --- package/network/services/dropbear/Config.in| 7 +++ package/network/services/dropbear/Makefile | 9 ++--- ...0-signkey-fix-use-of-rsa-sha2-256-pubkeys.patch | 14 +- 3 files changed, 22 insertions(+), 8 deletions(-) diff

[PATCH v3] dropbear: allow disabling the RSA public key algorithm

2020-07-18 Thread Rui Salvaterra
Signed-off-by: Rui Salvaterra --- package/network/services/dropbear/Config.in| 7 +++ package/network/services/dropbear/Makefile | 9 ++--- ...0-signkey-fix-use-of-rsa-sha2-256-pubkeys.patch | 14 +- 3 files changed, 22 insertions(+), 8 deletions(-) diff

[PATCH] dropbear: fix the alternatives when dbclient isn't built

2020-07-18 Thread Rui Salvaterra
The ssh and scp symlinks were still being created even when dbclient was disabled in the build configuration. Fix this annoyance. Signed-off-by: Rui Salvaterra --- package/network/services/dropbear/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package

[PATCH] dropbear: fix ssh alternative when dbclient isn't built

2020-07-20 Thread Rui Salvaterra
The ssh symlink was still being created even when dbclient was disabled in the build configuration. Fix this annoyance. Signed-off-by: Rui Salvaterra --- package/network/services/dropbear/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/network/services

[PATCH] dropbear: allow disabling support for scp

2020-07-22 Thread Rui Salvaterra
27;t built"] Signed-off-by: Rui Salvaterra --- package/network/services/dropbear/Config.in | 4 package/network/services/dropbear/Makefile | 8 +--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/package/network/services/dropbear/Config.in b/package/network/services/dro

[PATCH] wireguard-tools: allow compiling with MIPS16 instructions

2020-07-24 Thread Rui Salvaterra
the crypto heavy-lifting is done on the kernel side. wg sizes for both modes: MIPS32: 64309 bytes MIPS16: 42501 bytes Signed-off-by: Rui Salvaterra --- package/network/utils/wireguard-tools/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/package/network/utils/wireguard-tools/Makefile

Re: zram-swap is broken

2020-07-24 Thread Rui Salvaterra
Hi, On Fri, 24 Jul 2020 at 08:43, e9hack wrote: > > Hi, > > zram-swap is since commit 'zram-swap: enable swap discard' broken. Starting > zram results in this: > > root@WLAN-DSL8:~# /etc/init.d/zram start > zram_start: activating '/dev/zram2' for swapping (60 MegaBytes) > zram_reset: enforcing d

Re: [PATCH] wireguard-tools: allow compiling with MIPS16 instructions

2020-07-24 Thread Rui Salvaterra
Well… On Fri, 24 Jul 2020 at 09:32, Rosen Penev wrote: > > > On Jul 24, 2020, at 1:14 AM, Jason A. Donenfeld wrote: > > > > Seems probably fine to me, but would you let me know if the > > performance of `wg pubkey` suffers as a result? > Of course. I imagine it’s very tiny. Logging in to the rou

<    1   2   3   4   >