Hi, Hauke, On Tue, 1 Feb 2022 at 22:03, Hauke Mehrtens <[email protected]> wrote: > > Remove the 434-nand-brcmnand-fix-OOB-R-W-with-Hamming-ECC.patch, it was > already applied to Linux 5.10.37 and is not needed any more. > > Signed-off-by: Hauke Mehrtens <[email protected]> > --- > ...rcmnand-fix-OOB-R-W-with-Hamming-ECC.patch | 34 ------------------- > 1 file changed, 34 deletions(-) > delete mode 100644 > target/linux/bcm63xx/patches-5.10/434-nand-brcmnand-fix-OOB-R-W-with-Hamming-ECC.patch > > diff --git > a/target/linux/bcm63xx/patches-5.10/434-nand-brcmnand-fix-OOB-R-W-with-Hamming-ECC.patch > > b/target/linux/bcm63xx/patches-5.10/434-nand-brcmnand-fix-OOB-R-W-with-Hamming-ECC.patch > deleted file mode 100644 > index 33e27d215359..000000000000 > --- > a/target/linux/bcm63xx/patches-5.10/434-nand-brcmnand-fix-OOB-R-W-with-Hamming-ECC.patch > +++ /dev/null > @@ -1,34 +0,0 @@ > -From cf0d2fbaae9e962d91a321de75e0d4f9f9ccbdfe Mon Sep 17 00:00:00 2001 > -From: =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= <[email protected]> > -Date: Thu, 21 Jan 2021 18:17:37 +0100 > -Subject: [PATCH] nand: brcmnand: fix OOB R/W with Hamming ECC > -MIME-Version: 1.0 > -Content-Type: text/plain; charset=UTF-8 > -Content-Transfer-Encoding: 8bit > - > -Hamming ECC doesn't cover the OOB data, so reading or writing OOB shall > -always be done without ECC enabled. > -This is a problem when adding JFFS2 cleanmarkers to erased blocks. When JFFS2 > -clenmarkers are added to the OOB with ECC enabled, OOB bytes will be changed > -from ff ff ff to 00 00 00, reporting incorrect ECC errors. > - > -Signed-off-by: Álvaro Fernández Rojas <[email protected]> > ---- > - drivers/mtd/nand/raw/brcmnand/brcmnand.c | 6 ++++++ > - 1 file changed, 6 insertions(+) > - > ---- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c > -+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > -@@ -2694,6 +2694,12 @@ static int brcmnand_attach_chip(struct n > - chip->ecc.read_oob = brcmnand_read_oob_raw; > - } > - > -+ /* If OOB is written with ECC enabled it will cause ECC errors */ > -+ if (is_hamming_ecc(host->ctrl, &host->hwcfg)) { > -+ chip->ecc.write_oob = brcmnand_write_oob_raw; > -+ chip->ecc.read_oob = brcmnand_read_oob_raw; > -+ } > -+ > - return ret; > - } > - > -- > 2.30.2
Oh, my…! I have no idea how I've missed this (or how quilt happily refreshed it without complaints, since the context doesn't seem to match at all). Reviewed-by: Rui Salvaterra <[email protected]> Thanks, Rui _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
