Re: [OpenWrt-Devel] [PATCH] Configure IPv6 kernel options in config/Config-kernel.in

2015-09-22 Thread John Crispin
On 22/09/2015 19:31, Arjen de Korte wrote: > Revision 46834 changed IPv6 support from a module to builtin. But > since the configuration of the IPv6 kernel options was left in > package/kernel/linux/modules/netsupport.mk, this means that an > empty kmod-ipv6 module was still being generated (not

Re: [OpenWrt-Devel] [PATCH] Configure IPv6 kernel options in config/Config-kernel.in

2015-09-22 Thread John Crispin
On 22/09/2015 22:17, Arjen de Korte wrote: > Citeren John Crispin : > >> On 22/09/2015 19:31, Arjen de Korte wrote: >>> Revision 46834 changed IPv6 support from a module to builtin. But >>> since the configuration of the IPv6 kernel options was left in &g

Re: [OpenWrt-Devel] [PATCH] [SIGNED-OFF] Add WeIO Board Support

2015-09-24 Thread John Crispin
its in trunk finally, sorry for the delay On 23/09/2015 20:23, Drasko DRASKOVIC wrote: > A kind reminder, > please someone take a look at this patch and integrate it if it is OK. > > BR, > Drasko > > > On Sun, Sep 20, 2015 at 7:27 PM, Drasko DRASKOVIC > wrote: >> Add support for WeIO board (ht

Re: [OpenWrt-Devel] [PATCH] procd: make nand_do_platform_check check image only

2015-09-24 Thread John Crispin
On 24/09/2015 11:32, Rafał Miłecki wrote: > Recently all targets have been updated to call nand_do_upgrade directly. > It's not needed anymore to leave a magic /tmp/sysupgrade-nand-path mark > during image check. > > Signed-off-by: Rafał Miłecki Acked-by: John Crispin

Re: [OpenWrt-Devel] [PATCH procd] watchdog: shutdown the kernel watchdog when stopping

2015-09-28 Thread John Crispin
On 28/09/2015 14:14, Helmut Schaa wrote: > On Mon, Sep 28, 2015 at 12:58 AM, Alexander Couzens wrote: >> The kernel wdt counting down even when not pinged. >> Shutdown the filehandler to /dev/watchdog with magic cookie >> to prevent this. >> >> Signed-off-by: Alexander Couzens >> --- >> watchd

Re: [OpenWrt-Devel] [PATCH] Support broadcast sockets in usock

2015-10-02 Thread John Crispin
Hi, comments inline On 02/10/2015 14:13, javier...@gmail.com wrote: > From: Javier Domingo Cansino > > Signed-off-by: Javier Domingo Cansino > --- > usock.c | 5 - > usock.h | 1 + > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/usock.c b/usock.c > index 6748ef3..58f16

Re: [OpenWrt-Devel] [PATCH procd v3 0/7] jail work

2015-10-05 Thread John Crispin
On 27/08/2015 01:26, Etienne CHAMPETIER wrote: > v3 of my (u)jail work, you can now use separately > namespaces jail, capabilities and seccomp > > Openwrt procd Makefile patch v2 is still ok > ___ > openwrt-devel mailing list > openwrt-devel@lists.open

Re: [OpenWrt-Devel] [PATCH] [SIGNED-OFF] Correct WeIO board name

2015-10-05 Thread John Crispin
On 29/09/2015 13:20, Drasko DRASKOVIC wrote: > Trivial parch to correct WeIO board name in the system. > > Signed-off-by: Drasko DRASKOVIC looks good but somehow your subject lines are always wrong. id should be [PATCH] ar71xx: Correct WeIO board name please make sure to send correct subject

Re: [OpenWrt-Devel] [PATCH 2/4] ramips: Fix setting of rx buffer length

2015-10-05 Thread John Crispin
On 25/09/2015 13:11, Sven Eckelmann wrote: > The length of the DMA rx buffer was always set to 0 because the function > for extracting the length was used to calculate the value for setting it. > Instead the macro has to be split in a get and set function similar to the > TX_DMA_(GET_|)PLEN(0|1)

Re: [OpenWrt-Devel] [PATCH 5/7] ramips: fix mt7621 cpu clock speed. set spi clock to system clock

2015-10-05 Thread John Crispin
gt; a/target/linux/ramips/patches-3.18/0012-MIPS-ralink-add-MT7621-support.patch > +++ > b/target/linux/ramips/patches-3.18/0012-MIPS-ralink-add-MT7621-support.patch > @@ -520,7 +520,7 @@ Signed-off-by: John Crispin > +} > --- /dev/null > +++ b/arch/mips/ralink/mt7621.c > -@@ -

Re: [OpenWrt-Devel] [PATCH 2/2] packages: Remove dependencies to kmod-ipv6

2015-10-05 Thread John Crispin
Hi, On 20/09/2015 10:54, Arjen de Korte wrote: > Since r46834, IPv6 support is builtin if selected. Therefor, dependencies > on kmod-ipv6 can no longer be fulfilled, since it is not a module anymore. > > Signed-off-by: Arjen de Korte > --- > ipv6/tayga/Makefile | 2 +- > libs/libwebsock

Re: [OpenWrt-Devel] [PATCH 5/7] ramips: fix mt7621 cpu clock speed. set spi clock to system clock

2015-10-05 Thread John Crispin
On 05/10/2015 12:29, Mingyu Li wrote: > according to mtk sdk 4300 at kernel version linux-2.6.36.x > at 40Mhz Xtal it use 20 not 40. > > #elif defined (CONFIG_RALINK_MT7621) > case 0: > reg = (*(volatile u32 *)(RALINK_SYSCTL_BASE + 0x44)); > cpu_fdiv = ((r

Re: [OpenWrt-Devel] Jails current broken due to not following symlinks

2015-10-07 Thread John Crispin
On 08/10/2015 06:01, Daniel Dickinson wrote: > Hi again, > > It turns out the problem isn't Etienne's code, it is the fstools update > in revision 47083. > > This causes symlinks to not be followed which breaks procd-jail even > though the real issue is that procd-jail was in fact only working

Re: [OpenWrt-Devel] [PATCH] generic: add 8139cp fixes, enable hardware csum/tso on 4.0+

2015-10-08 Thread John Crispin
Hi, SoB is missing from this and the CC backport patch John On 05/10/2015 22:26, David Woodhouse wrote: > For all kernels, add the fixes which are already in 4.3-rc4. > > For 4.0+, also add the fixes currently in net-next which fix and enable > hardware checksum and TSO support. > > --

Re: [OpenWrt-Devel] [PATCH] generic: add 8139cp fixes, enable hardware csum/tso on 4.0+

2015-10-08 Thread John Crispin
correction, one has a SoB, the other has a description. having both in both patches would be nice John On 08/10/2015 10:06, John Crispin wrote: > Hi, > > SoB is missing from this and the CC backport patch > > John > > On 05/10/2015 22:26, David Woodho

Re: [OpenWrt-Devel] [PATCH] CC-x86: add support for LEDs on PCEngines APU

2015-10-08 Thread John Crispin
On 01/10/2015 17:21, Ben Pfountz wrote: > These 2 patches add support for the front 3 LEDs on the PCEngines APU > board: > > - Create a subtarget for the PCEngines APU, which selects all the > supported options I could find for this board. > - Adds a kmod-leds-apu kernel module package which sup

Re: [OpenWrt-Devel] SVN to GIT transition

2015-10-11 Thread John Crispin
On 11/10/2015 14:09, Jan Čermák wrote: > Hello, > > thanks for pointing that out, Steven. Yes, this is basically the main reason > why > Bedrich opened this topic. If you need to maintain sustainable OpenWrt fork > (no > flame please, there are some situations - like running "heavyweight" Open

Re: [OpenWrt-Devel] [PATCH] [ar71xx] Send power to USB port on WNR2200

2015-10-11 Thread John Crispin
comments inline On 10/10/2015 04:44, Riley Baird wrote: > This patch fixes ticket #15267 by enabling power on the > WNR2200's USB port. At present, the USB port on the WNR2200 > is non-functional due to it not receiving power. > > This patch defines an additional GPIO pin, but none of the > curre

Re: [OpenWrt-Devel] [PATCH][ar71xx] add support for tp-link wr841n v10 image generation

2015-10-11 Thread John Crispin
Hi, On 07/10/2015 17:34, Daniel Petre wrote: > This adds support to generate images for tp-link wr841n v10 which is almost > identical with tp-link wr841n v9 but with a faster cpu at 650 Mhz. Tested on > a european version. > > Signed-off-by: Daniel Petre > > --- a/target/linux/ar71xx/image/M

Re: [OpenWrt-Devel] SVN to GIT transition

2015-10-11 Thread John Crispin
On 12/10/2015 08:38, Steven Barth wrote: > Let's face it though: the current workflow wrt. core patches is crappy. > > 1. Go to patchwork, see if there is a patch > 2. If you want to comment, switch to mail client, find thread, write reply. > 3. If you want to commit: download patch, go to comma

Re: [OpenWrt-Devel] SVN to GIT transition

2015-10-12 Thread John Crispin
On 12/10/2015 09:07, Steven Barth wrote: > And don't get me started about having a completely different Issuetracker with > different credentials etc. indeed there i this thing called trac which i wonder if people actually use/look at. so we really have 3 issues at hand 1) switch the core tree

Re: [OpenWrt-Devel] SVN to GIT transition

2015-10-12 Thread John Crispin
On 12/10/2015 09:36, Felix Fietkau wrote: >> Sure could use pwclient and ocassionally do, however it does essentially one >> thing >> > only: save me the download step. Yes, I can also save me the click back to >> > the >> > browser to hit accept and can do that via CLI (if I remember the crypt

Re: [OpenWrt-Devel] [PATCH 6/8] ramips: improve mt7621 spi chip select

2015-10-13 Thread John Crispin
2 comments inline On 11/10/2015 05:54, Michael Lee wrote: > * use chip select register to control chip select function instead of > use chip select polarity > * should support use gpio as cs pin > * deselected the spi device when setup and add debug info > > Signed-off-by: Michael Lee > --- >

Re: [OpenWrt-Devel] Broken SPI transfers on TD-W8970 (latest trunk)

2015-10-14 Thread John Crispin
bummer. i had hoped that my patch fixed the issue. did you try the patch graham posted ? John On 14/10/2015 20:38, Martin Blumenstingl wrote: > Hi John, > > I am getting SPI errors on latest trunk. > It seems that those might be related to your SPI changes from last week. > > I found t

Re: [OpenWrt-Devel] [PATCH] target/ramips: NixCore X1 Board Support

2015-10-15 Thread John Crispin
On 15/10/2015 17:49, Andrew Gaylo wrote: > from: Andrew Gaylo > > This submission is for support of the NixCore X1 board at > http://nixcores.com. This board uses the RT5350 Ralink processor > already supported by a number of boards in the OpenWRT repository. > > Signed-off-by: Andrew Gaylo

Re: [OpenWrt-Devel] [PATCH] target/ramips: NixCore X1 Board Support

2015-10-15 Thread John Crispin
.openwrt.org/pipermail/openwrt-devel/2015-October/036563.html > > Drew > > On 2015-10-15 09:53, John Crispin wrote: >> On 15/10/2015 17:49, Andrew Gaylo wrote: >>> from: Andrew Gaylo >>> >>> This submission is for support of the NixCore X1 board at &g

Re: [OpenWrt-Devel] how to stop a inittab service without reboot

2015-10-19 Thread John Crispin
there is no dynamic reload feature for this in procd yet On 19/10/2015 11:20, Claudio Thomas wrote: > Hi, > on my /etc/inittab I've the following line > >ttyQE1::askfirst:/bin/ash --login > > I've already removed the line and killed the process, but its restarts > again. > > I know that co

Re: [OpenWrt-Devel] [PATCH] gpsd: initial add to packages

2015-10-19 Thread John Crispin
Hi, please send a PR against the packages feed hosted on github John On 16/10/2015 23:26, Pushpal Sidhu wrote: > This package is currently in oldpackages. Add here to keep support for gpsd. > > From oldpackages, this was bumped from 3.10 -> 3.15 and includes an upstream > patch to allow

Re: [OpenWrt-Devel] [PATCH] package/devel/perf: fix build for kernel 4.1

2015-10-21 Thread John Crispin
On 15/10/2015 15:01, Alexandru Ardelean wrote: > This fix contains 2 parts: > - kernel 4.1: backport upstream patch "perf build: Do not fail on missing > Build file" > - add +liblzma dependency > did you find out why there is suddenly a dependency on lzma ? John > Signed-off-by: Al

Re: [OpenWrt-Devel] [PATCH] kernel: Fix environment pointer setup in ar71xx/ath79

2015-10-26 Thread John Crispin
On 21/10/2015 17:53, Ted Hess wrote: > Observed on ar71xx/ath79 platforms such as Ubiquiti RouterStations.Reported > in #20642.: > (https://dev.openwrt.org/ticket/20642). > > If embedded command-line text exists with CONFIG_IMAGE_CMDLINE_HACK=y,firmware > init doesn't initialize environment po

Re: [OpenWrt-Devel] Broadcom Wireless AC Driver

2015-10-26 Thread John Crispin
On 26/10/2015 10:40, Felix Kaechele wrote: > On 25/10/15 23:27, openwr...@ruggedinbox.com wrote: >> I came across the source code for the broadcom >> wireless AC driver in a GPL release(I won't say from where so that they >> don't get in trouble). I've attached the driver to this email. > > This

Re: [OpenWrt-Devel] [PATCH] package/devel/perf: fix build for kernel 4.1

2015-10-26 Thread John Crispin
On 21/10/2015 20:03, John Crispin wrote: > > > On 15/10/2015 15:01, Alexandru Ardelean wrote: >> This fix contains 2 parts: >> - kernel 4.1: backport upstream patch "perf build: Do not fail on missing >> Build file" >> - add +liblzma dependency >

Re: [OpenWrt-Devel] Broadcom Wireless AC Driver

2015-10-26 Thread John Crispin
On 26/10/2015 11:22, Imre Kaloz wrote: > On Mon, 26 Oct 2015 10:50:41 +0100, John Crispin > wrote: > > > >>> This is where your good intentions likely will yield bad results. >> >> intentionally breaking the license/law is not "good intentions"

Re: [OpenWrt-Devel] [PATCH] package/devel/perf: fix build for kernel 4.1

2015-10-26 Thread John Crispin
nswer > asap (hopefully today/tomorrow). > > > On Mon, Oct 26, 2015 at 12:13 PM, John Crispin <mailto:blo...@openwrt.org>> wrote: > > > > On 21/10/2015 20:03, John Crispin wrote: > > > > > > On 15/10/2015 15:01, Alexandru Ardelea

Re: [OpenWrt-Devel] [PATCH] package/devel/perf: fix build for kernel 4.1

2015-10-26 Thread John Crispin
On 26/10/2015 12:48, Alexandru Ardelean wrote: > Looks like it did not take much to actually come back with an answer. > So, > > In file: > https://github.com/torvalds/linux/blob/v4.1/tools/perf/Makefile.perf > Line 75: # Define NO_LZMA if you do not want to support compressed > (xz) kernel mo

Re: [OpenWrt-Devel] [PATCH libubox v2] Support broadcast sockets in usock

2015-10-26 Thread John Crispin
Hi, was about to merge this but then ... see inline On 02/10/2015 15:53, Javier Domingo Cansino wrote: > Signed-off-by: Javier Domingo Cansino > --- > usock.c | 4 +++- > usock.h | 1 + > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/usock.c b/usock.c > index 6748ef3..3dd995

Re: [OpenWrt-Devel] [PATCH 2/8] ramips: remove rt2880 spi lock and clean bit operation

2015-10-26 Thread John Crispin
18/0050-SPI-ralink-add-Ralink-SoC-spi-driver.patch > @@ -41,7 +41,7 @@ Acked-by: John Crispin > spi-s3c24xx-hw-$(CONFIG_SPI_S3C24XX_FIQ) += spi-s3c24xx-fiq.o > --- /dev/null > +++ b/drivers/spi/spi-rt2880.c > -@@ -0,0 +1,493 @@ > +@@ -0,0 +1,480 @@ > +/* > + * spi-rt2880

Re: [OpenWrt-Devel] backport 46936 (procd: rework makefile, split ujail/seccomp)

2015-10-28 Thread John Crispin
if you send a patch it would be faster :) i just got into the office and will be here all day so i can merge it promptly. John On 28/10/2015 00:10, Etienne Champetier wrote: > Hi John, > > since 47268, we need -DUTRACE_SUPPORT=1 to compile utrace > https://dev.openwrt.org/changeset/47268

Re: [OpenWrt-Devel] [PATCH 1/3] ramips: mt7620 add icplus phy driver kernel config symbol

2015-10-28 Thread John Crispin
Hi, On 29/10/2015 02:26, Andrej Vlasic wrote: > Add missing icplus phy driver kernel config symbol to mt7620 subtarget. > This is needed since some mt7620 devices have icplus ip1001 ethernet > transceiver > > Signed-off-by: Andrej Vlasic are you sure this is needed ? older IC+ phys worked with

Re: [OpenWrt-Devel] [PATCH 1/3] ramips: mt7620 add icplus phy driver kernel config symbol

2015-10-29 Thread John Crispin
Hi Andrej, On 29/10/2015 12:52, Andrej Vlašić wrote: > Hi John, > > On 29 October 2015 at 06:38, John Crispin wrote: >> Hi, >> >> On 29/10/2015 02:26, Andrej Vlasic wrote: >>> Add missing icplus phy driver kernel config symbol to mt7620 subtarget. >>

Re: [OpenWrt-Devel] [PATCH] uboot-lantiq: Add SoC version 1.2 support for Arcadyan VGV7510KW22

2015-11-01 Thread John Crispin
Hi, On 31/10/2015 18:00, Martin Blumenstingl wrote: > This fixes #20409 > > Signed-off-by: Martin Blumenstingl > --- > .../0043-MIPS-add-board-support-for-Arcadyan-VGV7510KW22.patch | 7 > +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git > a/package/boot/uboot-lan

Re: [OpenWrt-Devel] [PATCH] Wallys DR-344 support

2015-11-02 Thread John Crispin
Hi, On 29/10/2015 12:55, Philippe DUCHEIN wrote: > This patch is for Wallys DR344 support under OpenWRT > need ar8035-a patch for gigabit ethernet : [OpenWrt-Devel] [PATCH] Atheros > AR8035-A support > i cannot see the phy patch in the patchwork list. also this patch should have a prefix of ar7

Re: [OpenWrt-Devel] [RFC] ar71xx: add Arduino Yun

2015-11-03 Thread John Crispin
Hi, On 01/11/2015 15:15, Hauke Mehrtens wrote: > This is based on patches from Federico Fissore > especially this one: > https://github.com/arduino/openwrt-yun/commit/7e2976fa83fb0d72a955574499178c387a1b3c92 > > The console is running with 25 baud which is a non standard baud > rate and need

Re: [OpenWrt-Devel] [PATCH] [packages] generic :add-missing-ubi*-in-ramfs-when-sysupgrade

2015-11-03 Thread John Crispin
Hi, this patch looks weird. please explain the error you are seeing and what HW you are using. John On 30/10/2015 06:45, 未命名 wrote: > This patch may fix the sysupgrade with xxx-squashfs-sysupgrade.tar file > by adding missing other ubi* in ramfs. > > Signed-off-by: Shonn Lu > --- > di

Re: [OpenWrt-Devel] [PATCH] ramips:Allow funcs in multiple groups in pinctrl-rt2880.c for UARTF pin sharing

2015-11-03 Thread John Crispin
Hi, the patch is white space broken and for some reason this seems to be a forwarding. could you fix and resend please John On 03/11/2015 13:26, Noble Pepper wrote: > > Signed-off-by: Noble Pepper > --- > Existing pinctrl-rt2880.c code only kept track of one pin group that > functions

Re: [OpenWrt-Devel] Enable BPF JIT by default?

2015-11-05 Thread John Crispin
On 05/11/2015 17:54, Helmut Schaa wrote: > Hi, > > Since lots of architectures now support BPF JIT would it make sense to > enable it by default for all openwrt builds? > Any opinions on that? > > Thanks, > Helmut can you grab some stats so we can compare kernel size on a few targets ? >

Re: [OpenWrt-Devel] [PATCH 1/1] GL AR150 AR300 Domino patches

2015-11-05 Thread John Crispin
Hi, lots of alphabetic order errors (see inline). also split the patch up so it is one board / patch John On 06/11/2015 08:01, alz...@gmail.com wrote: > From: alzhao > > --- > .../ar71xx/base-files/etc/uci-defaults/01_leds | 12 ++ > .../ar71xx/base-files/etc/uci-defaults/02_netw

Re: [OpenWrt-Devel] [PATCH] pinctrl/lantiq: split xway_mfp into dedicated tables

2015-11-16 Thread John Crispin
t; index 136483a..130823d 100644 > --- a/target/linux/lantiq/dts/vr9.dtsi > +++ b/target/linux/lantiq/dts/vr9.dtsi > @@ -108,7 +108,7 @@ > }; > > gpio: pinmux@E100B10 { > - compatible = "lantiq,pinctrl-xr9"; > +

Re: [OpenWrt-Devel] [PATCH v3 1/2] pinctrl/lantiq: introduce new dedicated tables

2015-11-17 Thread John Crispin
On 17/11/2015 16:06, Daniel Schwierzeck wrote: > 2015-11-17 13:48 GMT+01:00 Martin Schiller : >> This patch introduces new dedicated "pinctrl-ase", "pinctrl-danube", >> "pinctrl-xrx100" and "pinctrl-xrx200" configuration tables. >> >> Based on the newest Lantiq Hardware Description it turend out,

Re: [OpenWrt-Devel] Review of 0012-pinctrl-lantiq-fix-up-pinmux.patch

2015-11-18 Thread John Crispin
7a1409f53ddbafd661636e47ea34 Mon Sep 17 00:00:00 >> 2001 >>> From: John Crispin >>> Date: Fri, 9 Aug 2013 20:38:15 +0200 >>> Subject: [PATCH 12/36] pinctrl/lantiq: fix up pinmux >>> >>> We found out how to set the gphy led

Re: [OpenWrt-Devel] [PATCH procd 2/2] ujail: rework file dependencies detection (use ldd)

2015-11-21 Thread John Crispin
> INSTALL(TARGETS ujail > RUNTIME DESTINATION ${CMAKE_INSTALL_SBINDIR} > diff --git a/jail/deps.c b/jail/deps.c > new file mode 100644 > index 000..0141cef > --- /dev/null > +++ b/jail/deps.c > @@ -0,0 +1,198 @@ > +/* > + * Copyright (C) 2015 John Crisp

Re: [OpenWrt-Devel] [PATCH procd 2/2] ujail: rework file dependencies detection (use ldd)

2015-11-21 Thread John Crispin
il/jail.c jail/deps.c jail/capabilities.c) > TARGET_LINK_LIBRARIES(ujail ubox blobmsg_json) > INSTALL(TARGETS ujail > RUNTIME DESTINATION ${CMAKE_INSTALL_SBINDIR} > diff --git a/jail/deps.c b/jail/deps.c > new file mode 100644 > index 000..0141cef > --- /dev/null >

Re: [OpenWrt-Devel] [PATCH] Add support for Huawei WS880

2015-11-21 Thread John Crispin
Hi, can you please resend the patch with a proper prefix. in this case "bcm53xx:" John On 20/11/2015 14:06, Prototik wrote: > --- > target/linux/bcm53xx/image/Makefile| 14 +++ > .../910-ARM-BCM5301X-Add-DT-for-Huawei-WS880.patch | 115 > + > .../9

Re: [OpenWrt-Devel] [PATCH v2 5/6] brcm2708: add device detection and use it for network, leds and preinit

2015-11-21 Thread John Crispin
Hi, do you have time to rework this code to make use of the new board detection layer ? i am currently starting to convert all targets to it. would be a shame if we add this ode just to replace it again in a few weeks. John On 19/11/2015 19:18, Álvaro Fernández Rojas wrote: > Signed-off-

Re: [OpenWrt-Devel] [PATCH procd 2/2] ujail: rework file dependencies detection (use ldd)

2015-11-21 Thread John Crispin
can you be more specific on what C++ ism i'm using ? // is c++ /* this is the c version */ void foo() should be replaced with static void foo(void) i am a bit suprised that procd compiled without warning for you. i'll verify the compiler flags later today John > >

Re: [OpenWrt-Devel] [PATCH 1/3] ar71xx: add GL-AR150 support V2

2015-11-21 Thread John Crispin
Hi comment 1 inline On 17/11/2015 04:37, alzhao wrote: > Added GL-AR150 support to latest trunk. Tested and works good. > > Signed-off-by: Alzhao > --- > .../ar71xx/base-files/etc/uci-defaults/01_leds | 4 + > .../ar71xx/base-files/etc/uci-defaults/02_network | 1 + > target/linux/ar71

Re: [OpenWrt-Devel] [PATCH 2/3] ar71xx: add GL-AR300 support V2

2015-11-21 Thread John Crispin
Hi, 1 comment inline On 17/11/2015 04:37, alzhao wrote: > Add support for GL-AR300 for latest trunk. Tested and works well. > > Signed-off-by: Alzhao > --- > .../ar71xx/base-files/etc/uci-defaults/01_leds | 4 + > .../ar71xx/base-files/etc/uci-defaults/02_network | 6 ++ > target/linu

Re: [OpenWrt-Devel] [PATCH] [001/001] TL-WR710N: create image for v2.1

2015-11-21 Thread John Crispin
Hi, the patch is unfortunately line wrapped and whitespace broken. try sending the patch using "git send-email" John On 17/11/2015 20:41, Norbert Wegener wrote: > This patch just extends target/linux/ar71xx/image/Makefile to build > images also for version 2.1 of TL-WR710N > > diff --gi

Re: [OpenWrt-Devel] [PATCH v2] lantiq: add phy led config support over devicetree bindings

2015-11-21 Thread John Crispin
0023-NET-PHY-adds-driver-for-lantiq-PHY11G.patch > +++ > b/target/linux/lantiq/patches-3.18/0023-NET-PHY-adds-driver-for-lantiq-PHY11G.patch > @@ -37,7 +37,7 @@ Signed-off-by: John Crispin > obj-$(CONFIG_AT803X_PHY)+= at803x.o > --- /dev/null > +++ b/drivers/net/phy/

Re: [OpenWrt-Devel] [PATCH v2] ar71xx: Add support for Wallys DR344

2015-11-21 Thread John Crispin
Hi, 1 comment inline On 08/11/2015 10:46, Philippe DUCHEIN wrote: > This patch is for Wallys DR344 support under OpenWRT > > Signed-off-by: Philippe DUCHEIN > > — > > diff -Nru a/target/linux/ar71xx/base-files/etc/diag.sh > b/target/linux/ar71xx/base-files/etc/diag.sh > --- a/target/linux/ar

Re: [OpenWrt-Devel] [PATCH] oxnas: add some default packages of router

2015-11-21 Thread John Crispin
Hi, On 07/11/2015 21:12, Shonn Lu wrote: > Signed-off-by: Shonn Lu > --- > target/linux/oxnas/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/linux/oxnas/Makefile b/target/linux/oxnas/Makefile > index 32bcab8..87b9489 100644 > --- a/target/linux/oxnas/

Re: [OpenWrt-Devel] [PATCH] ramips: add support for Youku YK1

2015-11-21 Thread John Crispin
Hi 1 comment inline On 08/11/2015 07:08, Shonn Lu wrote: > Signed-off-by: Shonn Lu > --- > target/linux/ramips/base-files/etc/board.d/01_leds | 5 + > .../linux/ramips/base-files/etc/board.d/02_network | 1 + > target/linux/ramips/base-files/lib/ramips.sh | 3 + > .../ramips/base-fi

Re: [OpenWrt-Devel] [PATCH v2] [ramips] mt7621: add support for netis WF-2881‏

2015-11-21 Thread John Crispin
Hi, the patch does not apply. is this against trunk or CC ? John On 14/11/2015 15:32, YounJaeRho wrote: > netis WF-2881 is an MT7621AT based router with MT7602EN, MT7612EN. > It has 128MB DDR3, 128MB SLC NAND FLASH, 5-port Gbps switch and 1x USB 3.0. > The following patch adds support fo

Re: [OpenWrt-Devel] [PATCH] lantiq: spi-max-frequency

2015-11-21 Thread John Crispin
Hi, common, you know how to send a patch and put a SoB under it. i've seen you do it lots of times ;) John On 09/11/2015 20:36, Daniel Gimpelevich wrote: > On Thu, 2015-02-26 at 16:02 +0100, Joerg Jungermann wrote: >> Hi, >> >> I have here multiple TD-W8970 with Annex A and Annex B. >> >

Re: [OpenWrt-Devel] [PATCH] [packages] add mt-st package to write to tape devices

2015-11-21 Thread John Crispin
Hi this really belongs into the feed. please submit a PR via github. John On 10/11/2015 12:44, Giuseppe Magnotta wrote: > Add mt-st package in order to write to tape devices > > Signed-off-by: Giuseppe Magnotta > > > diff --git a/package/utils/mt-st

Re: [OpenWrt-Devel] [PATCH] Quagga 0.99.23 CISCO EIGRP support

2015-11-21 Thread John Crispin
Hi, package is hosted on github and not part of the core. please send a PR via using github. John On 09/11/2015 03:28, Lucian Cristian wrote: > On 04.11.2015 22:35, Lucian Cristian wrote: >> >> based on git: https://github.com/janovic/Quagga-EIGRP >> tested with opennhrp (gre tunnels, no

Re: [OpenWrt-Devel] [RFC] A patch for mt7621 nand controler. Revision 2.

2015-11-21 Thread John Crispin
Hi, ugly patch to make an ugly driver work. i am sure you had a lot of fun debugging this one. thanks ! John On 13/11/2015 08:55, Kirill Berezin wrote: > Hello, > > It turned out that mtk_nand driver uses some sophisticated accounting > and a general nand code must be patched. > > This

Re: [OpenWrt-Devel] [PATCH v2] lantiq: add phy led config support over devicetree bindings

2015-11-21 Thread John Crispin
isread it and did not see the OF_ part. fine in this case John > > Am 21.11.2015 6:55 nachm. schrieb "John Crispin" <mailto:blo...@openwrt.org>>: >> >> Hi >> >> 1 comment inline >> >> On 09/11/2015 13:44, Florian Eckert wrote: &

Re: [OpenWrt-Devel] [PATCH] lantiq: spi-max-frequency

2015-11-21 Thread John Crispin
On 21/11/2015 20:05, Daniel Gimpelevich wrote: > On Sat, 2015-11-21 at 10:27 -0800, Daniel Gimpelevich wrote: >> On Sat, 2015-11-21 at 19:15 +0100, John Crispin wrote: >>> Hi, >>> >>> common, you know how to send a patch and put a SoB under it. i

Re: [OpenWrt-Devel] [PATCH] lantiq: spi-max-frequency

2015-11-21 Thread John Crispin
On 21/11/2015 20:17, Daniel Gimpelevich wrote: > On Sat, 2015-11-21 at 20:15 +0100, John Crispin wrote: >> On 21/11/2015 20:05, Daniel Gimpelevich wrote: >>> On Sat, 2015-11-21 at 10:27 -0800, Daniel Gimpelevich wrote: >>>> On Sat, 2015-11-21 at 19:15 +0100

Re: [OpenWrt-Devel] [PATCH v5 1/5] ar71xx: add eth rx delay for qca955x platforms

2015-11-21 Thread John Crispin
Hi, sorry to jump in this late at a V5 but i have a few concerns. see inline On 22/09/2015 18:49, Chris R Blake wrote: > From: Chris R Blake > > This patch is to add support for qca955x_eth_rx_delay > to work with the qca955x SoC. > > Signed-off-by: Chris R Blake > --- > ...42-MIPS-ath79-add

Re: [OpenWrt-Devel] [PATCH v5 2/5] ar71xx: add support for qca955x sgmii/serdes calibration

2015-11-21 Thread John Crispin
Hi, same as on 1/5 the registers are not set in the right part of the code John On 22/09/2015 18:49, Chris R Blake wrote: > From: Chris R Blake > > This patch is to add support for sgmii/serdes calibration from > within the OpenWRT environment. This is needed on boards that > do not us

Re: [OpenWrt-Devel] [PATCH v5 4/5] ar71xx: add LED driver NU801

2015-11-21 Thread John Crispin
Hi, 1 comment inline On 22/09/2015 19:07, Chris R Blake wrote: > From: Chris R Blake > > The MR18 uses a 3-channel 16-bit PWM Constant Current Driver > for its status LED. > > Signed-off-by: Chris R Blake > --- > package/base-files/files/etc/init.d/led| 2 +- > .../linux/ar71xx

Re: [OpenWrt-Devel] [PATCH v5 5/5] ar71xx: add support for Cisco's MR18

2015-11-21 Thread John Crispin
Hi comments inline On 22/09/2015 19:08, Chris R Blake wrote: > From: Chris R Blake > > This patch adds support for Cisco's MR18. > Detailed instructions for the flashing the device can > be found in the OpenWrt forum thread: > > > Signed-off

Re: [OpenWrt-Devel] [PATCH procd 2/2] ujail: rework file dependencies detection (use ldd)

2015-11-21 Thread John Crispin
On 21/11/2015 20:50, Paul Fertser wrote: > Hello, > > John Crispin writes: >> // is c++ >> >> /* this is the c version */ > > Strictly speaking, // is a valid way to add one-line comments since C99. > ok, let me be more precise.

Re: [OpenWrt-Devel] [PATCH] kernel/generic: 3.18, 4.y: Add support for Quectel EC20 Mini PCIe module

2015-11-21 Thread John Crispin
Thanks, i dropped the 4.0 part as we dont have that in trunk anymore John On 11/11/2015 14:18, Petr Štetiar wrote: > * both patches (qcserial/qmi_wwan) were submitted upstream[1,2] > * build tested on 3.18 and 4.1 > * run tested on imx6 platform with 4.1 > > 1. http://article.gmane.org/g

Re: [OpenWrt-Devel] [PATCH] Fix Busybox “uname -o”

2015-11-21 Thread John Crispin
Hi, patch does not apply to current trunk John On 21/11/2015 19:34, Mark Mentovai wrote: > Since r47288, “uname -o” shows “n”. It used to be “GNU/Linux”. > > root@gw1 sh# uname -a > Linux gw1.nyc 4.1.11 #1 Sat Nov 21 12:50:41 EST 2015 mips n > root@gw1 sh# uname -o > n > > It looks lik

Re: [OpenWrt-Devel] [PATCH] ramips:Allow funcs in multiple groups in pinctrl-rt2880.c for UARTF pin sharing

2015-11-21 Thread John Crispin
Hi, i had a closer look at the code. what you want to do instead of adding 2 dummy muxes is to modify static int rt2880_pmx_group_enable(struct pinctrl_dev *pctrldev, and change this part /* mark the pins as gpio */ for (i = 0; i < p->groups[group].func[0].pin_count; i++)

Re: [OpenWrt-Devel] [PATCH v2] ar71xx: Add support for Wallys DR344

2015-11-21 Thread John Crispin
344_setup(void) > +{ > +u8 *art = (u8 *) KSEG1ADDR(0x1fff); > + > +ath79_register_m25p80(NULL); > +ath79_register_leds_gpio(-1, ARRAY_SIZE(dr344_leds_gpio), > +dr344_leds_gpio); > +ath79_register_gpio_keys_polled(-1, DR344_KEYS_POLL_INTERVAL, > +ARRAY_SIZE(dr344_gpio_keys), >

Re: [OpenWrt-Devel] 回复:[PATCH] ramips: reset m25p80 when shutdown

2015-11-21 Thread John Crispin
Hi, one more request On 16/11/2015 18:03, 未命名 wrote: > Instead of use the set_4byte function in spi-nor.c, I use this patch > for simplest modification. In fact, set_4byte also send 0xe9 command to > the spi flash. > > Signed-off-by: Shonn Lu > --- > .../0064-reset-m25p80-when-shutdown.patch

Re: [OpenWrt-Devel] [PATCH v2 1/5] kernel: other: add PWM controller support

2015-11-22 Thread John Crispin
Hi Tim, On 19/11/2015 18:53, Tim Harvey wrote: > This adds basic PWM controller support and support for i.MX > > Signed-off-by: Tim Harvey > --- > v2: > - add TARGET_imx6 dep for pwm-imx > > package/kernel/linux/modules/other.mk | 36 > +++ > 1 file changed,

Re: [OpenWrt-Devel] [PATCH 8/8] ramips: update dtsi files to support second spi device

2015-11-22 Thread John Crispin
reset-names = "spi"; >> + >> +pinctrl-names = "default"; >> +pinctrl-0 = <&spi_cs1>; >> + >> +status = "disabled"; >> +}; >> + >> uartlite@c00 { >>

Re: [OpenWrt-Devel] [PATCH v3] [ramips] mt7621: add support for netis WF-2881‏

2015-11-22 Thread John Crispin
nfig-3.18 > index fb05d1e..bf1b3f9 100644 > --- a/target/linux/ramips/mt7621/config-3.18 > +++ b/target/linux/ramips/mt7621/config-3.18 > @@ -117,18 +117,20 @@ CONFIG_MIPS_MT_FPAFF=y > CONFIG_MIPS_MT_SMP=y > CONFIG_MIPS_PERF_SHARED_TC_COUNTERS=y > # CONFIG_MIPS_VPE_LOADER is

Re: [OpenWrt-Devel] [PATCH] ramips:Allow funcs in multiple groups in pinctrl-rt2880.c for UARTF pin sharing

2015-11-22 Thread John Crispin
ms to imply that a group is a fixed set of pins and pinmux.c and > core.c look to have been written assuming this is true. > > Regards, Noble > > On Sat, 2015-11-21 at 21:32 +0100, John Crispin wrote: >> Hi, >> >> i had a closer look at the code. what you want t

Re: [OpenWrt-Devel] [PATCH 8/8] ramips: update dtsi files to support second spi device

2015-11-22 Thread John Crispin
add("1b00.spi", sys_rate); > +ralink_clk_add("1b40.spi", sys_rate); > ralink_clk_add("1100.timer", wdt_rate); > > please let me know if the second spi works. if works > i will commit a patch about the second spi clock include > all other targe

Re: [OpenWrt-Devel] [PATCH] oxnas: set irq of usb&sata to cpu1

2015-11-22 Thread John Crispin
What is the difference between this and the previous version ? John On 23/11/2015 07:30, Shonn Lu wrote: > Signed-off-by: Shonn Lu > --- > .../linux/oxnas/base-files/init.d/set-irq-affinity | 22 > ++ > 1 file changed, 22 insertions(+) > create mode 100755 target/l

Re: [OpenWrt-Devel] [PATCH] ramips: add support for Youku YK1

2015-11-22 Thread John Crispin
Hi, you need to add the version info to you patches and the change history. as in add [PATCH V3] if it is version 3 and inside the description add text Changes since V2: * change A ... John On 23/11/2015 08:08, Shonn Lu wrote: > Signed-off-by: Shonn Lu > --- > target/linux/ramips/b

Re: [OpenWrt-Devel] [PATCH procd 2/4] ujail: remove useless arg in clone call

2015-11-22 Thread John Crispin
On 23/11/2015 01:39, Etienne CHAMPETIER wrote: > spawn_jail(void) produce a compilation error, > so we use spawn_jail() > > Signed-off-by: Etienne CHAMPETIER > --- > jail/jail.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/jail/jail.c b/jail/jail.c > index 56dc

Re: [OpenWrt-Devel] [PATCH procd 3/4] ujail: use const, stop using extern

2015-11-22 Thread John Crispin
Hi, subject relates to extern but then the patch adds const. please make the description consistent with the content John On 23/11/2015 01:39, Etienne CHAMPETIER wrote: > extern for function declaration in '.h' doesn't make sense > > Signed-off-by: Etienne CHAMPETIER > --- > jail/elf.

Re: [OpenWrt-Devel] [PATCH procd 4/4] ujail: rework fs jail part

2015-11-22 Thread John Crispin
if (!fgets(line, sizeof(line), fp)) > break; > len = strlen(line); > if (len < 2) > @@ -355,3 +308,12 @@ void load_ldso_conf(const char *conf) > > fclose(fp); > } > + > +void init_library_path(void) &

Re: [OpenWrt-Devel] [PATCH procd 2/4] ujail: remove useless arg in clone call

2015-11-23 Thread John Crispin
On 23/11/2015 09:09, Etienne Champetier wrote: > Hi, > > Le 23 nov. 2015 08:18, "John Crispin" <mailto:blo...@openwrt.org>> a écrit : >> >> >> >> On 23/11/2015 01:39, Etienne CHAMPETIER wrote: >> > spawn_jail(void) produce a compil

Re: [OpenWrt-Devel] [PATCH procd 2/4] ujail: remove useless arg in clone call

2015-11-24 Thread John Crispin
On 23/11/2015 13:12, Etienne Champetier wrote: > Hey, > > 2015-11-23 12:52 GMT+01:00 Paul Fertser >: > > Hey Etienne, > > Etienne Champetier > writes: > > i know that spawn_jail(void) is valid code, but then the

Re: [OpenWrt-Devel] [PATCH procd 3/4] ujail: use const, stop using extern

2015-11-24 Thread John Crispin
ok, subject and description are not consistent. please split this up properly. one kind of change / patch On 23/11/2015 09:09, Etienne Champetier wrote: > Hi > Le 23 nov. 2015 08:19, "John Crispin" <mailto:blo...@openwrt.org>> a écrit : >> >> Hi, >>

Re: [OpenWrt-Devel] [PATCH 2/3] authsae: Use kbit/s as mcast_rate unit like wpad

2015-11-24 Thread John Crispin
On 24/11/2015 16:17, Sven Eckelmann wrote: > The OpenWrt wireless configuration for mcast_rate is defined as > Kbit/s when using wpa_supplicant for IBSS/802.11s and iw for > unencrypted IBSS/802.11s. But when using authsae, the unit for the > same option is redefined as Mbit/s. making stuff cons

Re: [OpenWrt-Devel] [PATCH 1/1] TL-WR710N-v2.1

2015-11-24 Thread John Crispin
Hi On 22/11/2015 12:01, Norbert Wegener wrote: > # now with a git send-email working... > :) it looks good, however it does not apply to current trunk. did you make sure to base this patch on latest HEAD ? John > # This patch just extends target/linux/ar71xx/image/Makefile to build > #

Re: [OpenWrt-Devel] [PATCH v2 1/5] kernel: other: add PWM controller support

2015-11-24 Thread John Crispin
On 23/11/2015 17:41, Tim Harvey wrote: > On Sun, Nov 22, 2015 at 12:55 AM, John Crispin wrote: >> Hi Tim, >> >> >> >> On 19/11/2015 18:53, Tim Harvey wrote: >>> This adds basic PWM controller support and support for i.MX >>> >>> Signed-o

Re: [OpenWrt-Devel] [PATCH 2/2] firmware-utils: fix various compiler warnings

2015-11-24 Thread John Crispin
On 24/11/2015 17:57, Felix Kaechele wrote: > diff --git a/tools/firmware-utils/src/srec2bin.c > b/tools/firmware-utils/src/srec2bin.c > index 1cffbae..5cc71bd 100644 > --- a/tools/firmware-utils/src/srec2bin.c > +++ b/tools/firmware-utils/src/srec2bin.c > @@ -513,7 +513,7 @@ int srec2bin(int arg

Re: [OpenWrt-Devel] [PATCH 2/8] lantiq: add dsl-vr9-firmware-xdsl

2015-11-25 Thread John Crispin
On 25/11/2015 10:53, Andre Heider wrote: > Hi, > > On Tue, Nov 24, 2015 at 9:24 PM, Hauke Mehrtens wrote: >> +define Package/dsl-vr9-firmware-xdsl/install >> + $(INSTALL_DIR) $(1)/lib/firmware/ >> + $(INSTALL_DATA) $(PKG_BUILD_DIR)/LICENSE >> $(1)/lib/firmware/xcpe_574306_571801.LI

Re: [OpenWrt-Devel] [PATCH] Add support for WiTi Board

2015-11-25 Thread John Crispin
Hi, please fix the following things and resend. * missing ar71xx: [refix in the subject * no patch description * missing SoB John On 25/11/2015 11:00, Sebastian Careba wrote: > From: Sebastian Careba > > --- > target/linux/ramips/base-files/etc/diag.sh | 1 + > target/linux

Re: [OpenWrt-Devel] [PATCH] Add support for WiTi Board

2015-11-25 Thread John Crispin
On 25/11/2015 11:30, John Crispin wrote: > Hi, > > please fix the following things and resend. > > * missing ar71xx: [refix in the subject correction, should be ralink: > * no patch description > * missing SoB > > John > > On 25/11/2015 11:00

<    1   2   3   4   5   6   7   8   9   10   >