Re: [OpenWrt-Devel] [PATCH] [RESEND] swconfig: swlib.c: Fix another memleak

2015-07-08 Thread Helmut Schaa
On Wed, Jul 8, 2015 at 2:05 PM, Felix Fietkau wrote: > On 2015-07-08 08:37, Alexandru Ardelean wrote: >> From: Helmut Schaa >> >> Signed-off-by: Helmut Schaa > Erm... The author is supposed to add the Signed-off-by himself, as > described in https://dev.openwrt.org/wi

Re: [OpenWrt-Devel] [PATCH] [RFC] [RESEND] swconfig: Split libsw out of swconfig for reuse in other packages

2015-07-08 Thread Helmut Schaa
On Wed, Jul 8, 2015 at 8:37 AM, Alexandru Ardelean wrote: > From: Helmut Schaa > > Signed-off-by: Helmut Schaa Just for completeness here's my SoB. Signed-off-by: Helmut Schaa Helmut > --- > package/network/config/swconfig/Makefile | 9 + > package/netw

[OpenWrt-Devel] [PATCH] hostapd: Add eapol_version config option

2015-09-01 Thread Helmut Schaa
Add eapol_version to the openwrt wireless config ssid section. Only eapol_version=1 and 2 will get passed to hostapd, the default in hostapd is 2. This is only useful for really old client devices that don't accept eapol_version=2. Signed-off-by: Helmut Schaa --- package/network/ser

[OpenWrt-Devel] [PATCH] openwrt/hardening: Fix CFLAGS usage for -D_FORTIFY_SOURCE

2015-09-07 Thread Helmut Schaa
-off-by: Helmut Schaa --- include/hardening.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hardening.mk b/include/hardening.mk index c277081..4de9cfc 100644 --- a/include/hardening.mk +++ b/include/hardening.mk @@ -27,12 +27,12 @@ ifdef

Re: [OpenWrt-Devel] [PATCH] openwrt/hardening: Fix CFLAGS usage for -D_FORTIFY_SOURCE

2015-09-08 Thread Helmut Schaa
On Mon, Sep 7, 2015 at 6:19 PM, Steven Barth wrote: > NAK. > Not many package build systems honors CPPFLAGS so this solution is > impractical, > since it effectively disables fortification for many of them. > > To my knowledge c-ares is the only package enforcing this kind of behavior > so it sho

Re: [OpenWrt-Devel] [PATCH] openwrt/hardening: Fix CFLAGS usage for -D_FORTIFY_SOURCE

2015-09-08 Thread Helmut Schaa
On Tue, Sep 8, 2015 at 9:03 AM, Stefan Peter wrote: > Hi > Am 07.09.2015 um 17:32 schrieb Helmut Schaa: >> Fix the following configure error with c-ares by using CPPFLAGS for >> -D_FORTIFY_SOURCE. >> Not sure if any other packages suffer from the same issue. >> &

[OpenWrt-Devel] [PATCH] base-files: fix ramoverlay function with kernels 3.18+

2015-09-17 Thread Helmut Schaa
Even though there are not many users left within the OpenWrt tree it seems this function broke during the kernel 3.18 transition. Fix it by providing a workdir as required by overlayfs. Signed-off-by: Helmut Schaa --- package/base-files/files/lib/functions/preinit.sh | 9 + 1 file

Re: [OpenWrt-Devel] procd warning about respawn

2016-03-11 Thread Helmut Schaa
On Tue, Mar 8, 2016 at 9:39 PM, John Crispin wrote: > > > On 08/03/2016 21:33, Ted Hess wrote: >> [ Sorry if duplicate -- first attempt was returned as spam!? ] >> >> John C. -- rather than continue this on a closed Github PR... >> >> Since changeset (https://dev.openwrt.org/changeset/48915), >> p

Re: [OpenWrt-Devel] procd warning about respawn

2016-03-11 Thread Helmut Schaa
On Fri, Mar 11, 2016 at 10:58 AM, John Crispin wrote: > > > On 11/03/2016 10:57, John Crispin wrote: >> >> >> On 11/03/2016 10:54, Helmut Schaa wrote: >>> On Tue, Mar 8, 2016 at 9:39 PM, John Crispin wrote: >>>> >>>> >>>>

[OpenWrt-Devel] [PATCH] base-files: fix __network_ifstatus with lots of interfaces

2016-03-22 Thread Helmut Schaa
caching or similar things. Signed-off-by: Helmut Schaa --- FYI I've tried using a temp-file as cache but no real speed-up could be observed. Hence, it might make sense to look into per-interface caching instead. package/base-files/files/lib/functions/network.sh | 7 ++- 1 file changed, 2 i

[OpenWrt-Devel] [PATCH] mpc85xx: Add T4240 sub-target

2016-04-26 Thread Helmut Schaa
x27;t compile properly on that sub-target yet, hence we'd select glibc by default for T4240. Networking is not yet supported as the required fman/bman/qman/dpaa drivers are not yet included in mainline. Signed-off-by: Helmut Schaa --- config/Config-devel.in| 2 +- ta

Re: [OpenWrt-Devel] [PATCH] mpc85xx: Add T4240 sub-target

2016-04-26 Thread Helmut Schaa
Hi John, On Tue, Apr 26, 2016 at 3:33 PM, John Crispin wrote: > > > On 26/04/2016 11:48, Helmut Schaa wrote: >> The Freescale T4240 is a 12 core (24 threads) SoC. >> Add a sub-target to the mpc85xx target to build images for the T4240 >> Reference Design Board. >>

[OpenWrt-Devel] [PATCH] procd: Allow override of default respawn parameters

2015-09-18 Thread Helmut Schaa
Allow to pass RESPAWN_THESHOLD_DEFAULT, DRESPAWN_TIMEOUT_DEFAULT and RESPAWN_RETRY_DEFAULT as parameters to cmake to change the default respawn behavior. This can be used to set the default respawn mode to infinite retries for example. Signed-off-by: Helmut Schaa --- CMakeLists.txt | 12

Re: [OpenWrt-Devel] [PATCH] procd: Allow override of default respawn parameters

2015-09-18 Thread Helmut Schaa
Hi John, On Fri, Sep 18, 2015 at 10:18 AM, John Crispin wrote: > Hi > > On 18/09/2015 09:59, Helmut Schaa wrote: >> Allow to pass RESPAWN_THESHOLD_DEFAULT, DRESPAWN_TIMEOUT_DEFAULT >> and RESPAWN_RETRY_DEFAULT as parameters to cmake to change the >> default respawn b

Re: [OpenWrt-Devel] [PATCH] procd: Allow override of default respawn parameters

2015-09-18 Thread Helmut Schaa
On Fri, Sep 18, 2015 at 11:52 AM, John Crispin wrote: > > > On 18/09/2015 11:40, Etienne Champetier wrote: >> Hi, >> >> 2015-09-18 11:03 GMT+02:00 Helmut Schaa > <mailto:helmut.sc...@googlemail.com>>: >> >> Hi John, >> >> O

[OpenWrt-Devel] [RFC] procd: Allow to enable endless respawning of services

2015-09-21 Thread Helmut Schaa
s set respawn_retry will be set to -1. This makes procd to respawn the service forever. Signed-off-by: Helmut Schaa --- package/system/procd/files/procd.sh | 12 1 file changed, 12 insertions(+) diff --git a/package/system/procd/files/procd.sh b/package/system/procd/files/procd.sh index e8

Re: [OpenWrt-Devel] [RFC] procd: Allow to enable endless respawning of services

2015-09-22 Thread Helmut Schaa
On Mon, Sep 21, 2015 at 6:14 PM, Yousong Zhou wrote: > Hi, Helmut > > On 21 September 2015 at 23:26, Helmut Schaa > wrote: >> Extend /etc/config/system with a parameter to enable >> infinite respawn mode: >> >> config system >>

[OpenWrt-Devel] [PATCH] procd: Allow to configure default respawn retry count

2015-09-22 Thread Helmut Schaa
cd.sh. If respawn_retry is specified in /etc/config/system the default retry limit will be set to this value by procd. Signed-off-by: Helmut Schaa --- package/system/procd/files/procd.sh | 10 ++ 1 file changed, 10 insertions(+) diff --git a/package/system/procd/files/procd.sh b/pa

Re: [OpenWrt-Devel] [PATCH procd] watchdog: shutdown the kernel watchdog when stopping

2015-09-28 Thread Helmut Schaa
On Mon, Sep 28, 2015 at 12:58 AM, Alexander Couzens wrote: > The kernel wdt counting down even when not pinged. > Shutdown the filehandler to /dev/watchdog with magic cookie > to prevent this. > > Signed-off-by: Alexander Couzens > --- > watchdog.c | 17 ++--- > 1 file changed, 14 in

[OpenWrt-Devel] [PATCH] mac80211: restricted automatic channel selection

2015-10-27 Thread Helmut Schaa
Signed-off-by: Helmut Schaa --- package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh b/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh index 2a8d2f9..7fc7d

Re: [OpenWrt-Devel] [PATCH] mac80211: restricted automatic channel selection

2015-10-27 Thread Helmut Schaa
On Tue, Oct 27, 2015 at 5:58 PM, Karl Palsson wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Helmut Schaa wrote: >> Add a new config option "channels" for mac80211 wifi devices. >> It's only valid if automatic channel selection is used and &g

[OpenWrt-Devel] Enable BPF JIT by default?

2015-11-05 Thread Helmut Schaa
Hi, Since lots of architectures now support BPF JIT would it make sense to enable it by default for all openwrt builds? Any opinions on that? Thanks, Helmut ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin

Re: [OpenWrt-Devel] Enable BPF JIT by default?

2015-11-06 Thread Helmut Schaa
On Thu, Nov 5, 2015 at 5:56 PM, John Crispin wrote: > On 05/11/2015 17:54, Helmut Schaa wrote: >> Since lots of architectures now support BPF JIT would it make sense to >> enable it by default for all openwrt builds? >> Any opinions on that? > > can you grab some sta

[OpenWrt-Devel] [PATCH] kernel: fix building RTC drivers

2015-11-09 Thread Helmut Schaa
All RTC drivers require the kernel to be built with CONFIG_RTC_CLASS=y. Set it accordingly. Tested only with DS1307. Signed-off-by: Helmut Schaa --- package/kernel/linux/modules/other.mk | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/package

[OpenWrt-Devel] [RFC] openwrt: Allow extraction of debuginfo from all binaries

2014-07-24 Thread Helmut Schaa
oading the debuginfo into gdb. Signed-off-by: Helmut Schaa --- Any comments? Helmut config/Config-build.in | 10 ++ include/package-ipkg.mk | 5 - rules.mk | 9 + scripts/extract-debug.sh | 41 + 4 files changed, 64 insert

Re: [OpenWrt-Devel] [RFC] openwrt: Allow extraction of debuginfo from all binaries

2014-08-04 Thread Helmut Schaa
Hi Felix, On Fri, Aug 1, 2014 at 1:27 PM, Felix Fietkau wrote: > On 2014-07-24 17:26, Helmut Schaa wrote: >> Introduce a new config symbol EXTRACT_DEBUGINFO to extract debuginfo >> from all binaries. This depends on USE_STRIP and DEBUG. >> >> The debuginfo of all pack

Re: [OpenWrt-Devel] Status of ACS survey with rt2x00 driver using hostapd

2014-08-21 Thread Helmut Schaa
Hi, On Mon, Aug 18, 2014 at 3:27 PM, Yousong Zhou wrote: > Hi, > > I am trying to get ACS working on my available devices. > > What I have noticed is that the command `iw phy phy0 survey dump` > returned different result between HiWiFi HC6361 which uses ath9k > driver and a MT7620A based device us

[OpenWrt-Devel] AR9344 pcie fails to start (sometimes)

2014-12-10 Thread Helmut Schaa
Hi, Did anyone else see issues with ar9344 PCIe not coming up sometimes (it is really rare in my case)? Good boot dmesg: [0.07] registering PCI controller with io_map_base unset [0.28] bio: create slab at 0 [0.28] PCI host bridge to bus :00 [0.28] pci_bus 000

Re: [OpenWrt-Devel] AR9344 pcie fails to start (sometimes)

2014-12-10 Thread Helmut Schaa
On Wed, Dec 10, 2014 at 1:54 PM, John Crispin wrote: > > > On 10/12/2014 13:43, Helmut Schaa wrote: >> Hi, >> >> Did anyone else see issues with ar9344 PCIe not coming up sometimes >> (it is really rare in my case)? >> >> Good boot dmesg: >>

[OpenWrt-Devel] [PATCH] toolchain: Add libatomic when using external toolchain

2015-01-13 Thread Helmut Schaa
Otherwise libatomic cannot be used in conjunction with external toolchains. Signed-off-by: Helmut Schaa --- package/libs/toolchain/Makefile | 9 + 1 file changed, 9 insertions(+) diff --git a/package/libs/toolchain/Makefile b/package/libs/toolchain/Makefile index 1a75e90..42b9935

[OpenWrt-Devel] elfutils with external toolchain uClibc

2015-02-02 Thread Helmut Schaa
Hi, elfutils fails to build with an external toolchain using uClibc due to the following dependency: PKG_BUILD_DEPENDS:=USE_UCLIBC:argp-standalone I tried to select USE_UCLIBC as part of the external toolchain settings but that is used at quite some points within the toolchain config. Any ideas

[OpenWrt-Devel] [PATCH] kernel: watchdog modules should be loaded on boot

2015-04-02 Thread Helmut Schaa
Otherwise procd cannot initialize the watchdog since the module will be loaded later. Tested with booke_wdt. Signed-off-by: Helmut Schaa --- package/kernel/linux/modules/other.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/kernel/linux/modules/other.mk b

[OpenWrt-Devel] [PATCH] kernel: Allow talitos crypto hw module selection

2013-03-28 Thread Helmut Schaa
Signed-off-by: Helmut Schaa --- package/kernel/modules/crypto.mk | 14 ++ 1 file changed, 14 insertions(+) diff --git a/package/kernel/modules/crypto.mk b/package/kernel/modules/crypto.mk index 6a3b5a6..be76f53 100644 --- a/package/kernel/modules/crypto.mk +++ b/package/kernel

[OpenWrt-Devel] [PATCH 1/2] mpc85xx: Add P1020RDB board support

2013-04-09 Thread Helmut Schaa
Signed-off-by: Helmut Schaa --- Or should we just enable all boards that are available in mainline instead of enabling them one by one? Thanks, Helmut target/linux/mpc85xx/config-3.8 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/mpc85xx/config-3.8 b

[OpenWrt-Devel] [PATCH 2/2] mpc85xx: Generate fdt for P1020RDB

2013-04-09 Thread Helmut Schaa
Signed-off-by: Helmut Schaa --- target/linux/mpc85xx/image/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/mpc85xx/image/Makefile b/target/linux/mpc85xx/image/Makefile index 40db1df..a5db79e 100644 --- a/target/linux/mpc85xx/image/Makefile +++ b

Re: [OpenWrt-Devel] [PATCH 1/2] mpc85xx: Add P1020RDB board support

2013-04-09 Thread Helmut Schaa
On Tue, Apr 9, 2013 at 12:35 PM, Florian Fainelli wrote: > > > Le 04/09/13 10:08, Helmut Schaa a écrit : > >> >> Signed-off-by: Helmut Schaa >> --- >> >> Or should we just enable all boards that are available in mainline instead >> of enabling the

[OpenWrt-Devel] [PATCH] mpc85xx: Add subtargets Generic and P1020

2013-04-16 Thread Helmut Schaa
Only difference between Generic and P1020 is that P1020 enables SMP with two CPUs in the kernel config. Signed-off-by: Helmut Schaa --- I think this makes sense since some mpc85xx systems are SMP capable while others are not. And by using subtargets we can avoid building a kernel with SMP

[OpenWrt-Devel] [PATCH] grub2: Add sub package grub-editenv for target installation

2013-04-17 Thread Helmut Schaa
grub-editenv allows to modify grub2 environment files. Add a new package that build grub2 for the target and packs up grub-editenv. Signed-off-by: Helmut Schaa --- package/boot/grub2/Makefile | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/package

Re: [OpenWrt-Devel] [PATCH] grub2: Add sub package grub-editenv for target installation

2013-05-07 Thread Helmut Schaa
Any update on this patch? Thanks, Helmut On Wed, Apr 17, 2013 at 5:15 PM, Helmut Schaa wrote: > grub-editenv allows to modify grub2 environment files. Add a new package > that build grub2 for the target and packs up grub-editenv. > > Signed-off-by: Helmut Schaa > --- >

[OpenWrt-Devel] [PATCH] libubox: Allow to build against libjson-c > 0.9

2013-05-07 Thread Helmut Schaa
Signed-off-by: Helmut Schaa --- Not sure where to send libubox patches to, openwrt-devel? Helmut CMakeLists.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index c574bf7..015b8bd 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt

[OpenWrt-Devel] [PATCH 1/2] libubox: Update to current git trunk

2013-05-08 Thread Helmut Schaa
Fixes build against libjson-c > 0.9. Signed-off-by: Helmut Schaa --- package/libs/libubox/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/libs/libubox/Makefile b/package/libs/libubox/Makefile index 9865dc2..cd47887 100644 --- a/package/libs/libu

[OpenWrt-Devel] [PATCH 2/2] libjson-c: Update to 0.11

2013-05-08 Thread Helmut Schaa
Signed-off-by: Helmut Schaa --- package/libs/libjson-c/Makefile | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/package/libs/libjson-c/Makefile b/package/libs/libjson-c/Makefile index 5dd83f2..e0af413 100644 --- a/package/libs/libjson-c/Makefile +++ b/package

[OpenWrt-Devel] [PATCH] packages: curl: Allow fine grained protocol configuration

2013-05-14 Thread Helmut Schaa
Disabling unused protocols in libcurl can save more then 100K, hence add some build time config options to enable/disable protocols. Signed-off-by: Helmut Schaa --- libs/curl/Config.in | 60 +++ libs/curl/Makefile | 28

Re: [OpenWrt-Devel] [PATCH] packages: curl: Allow fine grained protocol configuration

2013-05-29 Thread Helmut Schaa
On Tue, May 14, 2013 at 11:19 AM, Helmut Schaa wrote: > Disabling unused protocols in libcurl can save more then 100K, hence add > some build time config options to enable/disable protocols. Any update on this patch? Helmut ___ openwrt-devel m

Re: [OpenWrt-Devel] [PATCH] [package] hostapd: updated dynamic vlan support

2013-06-04 Thread Helmut Schaa
Hi Felix, On Tue, Oct 16, 2012 at 11:30 PM, Zenon Mousmoulas wrote: > This is based on the patches submitted by Matthew Bowman: > http://patchwork.openwrt.org/patch/1258/ > http://patchwork.openwrt.org/patch/1261/ > > More recently hostapd has added support for setting the VLAN naming > scheme (e

[OpenWrt-Devel] [PATCH] mklibs: Fix mklibs usage when libs reside in subdirs

2013-06-25 Thread Helmut Schaa
Currently package/Makefile only passes /lib /usr/lib and /usr/lib/ebtables to mklibs. However, other libs can also reside in different subdirectories (in my case /usr/lib/ipsec). Hence, create the list of library directories dynamically. Signed-off-by: Helmut Schaa --- package/Makefile |8

Re: [OpenWrt-Devel] [PATCH] mklibs: Fix mklibs usage when libs reside in subdirs

2013-06-26 Thread Helmut Schaa
On Tue, Jun 25, 2013 at 10:49 AM, Helmut Schaa wrote: > - -L /lib \ > - -L /usr/lib \ > - -L /usr/lib/ebtables \ > + `cat $(TMP_DIR)/mklibs-libs | xargs dirname | uniq | sed > 's:^$(STAGING_DIR_ROOT):-L :'` \

[OpenWrt-Devel] [PATCHv2] mklibs: Fix mklibs usage when *.so files reside in subdirs

2013-06-26 Thread Helmut Schaa
Currently package/Makefile only passes /lib /usr/lib and /usr/lib/ebtables to mklibs. However, other libs can also reside in different subdirectories (in my case /usr/lib/ipsec). Hence, create the list of library directories dynamically. Signed-off-by: Helmut Schaa --- v2: Replace dirname with

[OpenWrt-Devel] [PATCH][packages] protobuf-c: Also build protoc-c utility for host environment

2013-06-27 Thread Helmut Schaa
Signed-off-by: Helmut Schaa --- libs/protobuf-c/Makefile |3 +++ 1 file changed, 3 insertions(+) diff --git a/libs/protobuf-c/Makefile b/libs/protobuf-c/Makefile index fd1e4f6..360ff25 100644 --- a/libs/protobuf-c/Makefile +++ b/libs/protobuf-c/Makefile @@ -18,6 +18,7 @@ PKG_MD5SUM

[OpenWrt-Devel] [PATCHv2][packages] protobuf-c: Also build protoc-c utility for host environment

2013-06-28 Thread Helmut Schaa
Signed-off-by: Helmut Schaa --- Changes in v2: Depend upon protobuf/host libs/protobuf-c/Makefile |5 + 1 file changed, 5 insertions(+) diff --git a/libs/protobuf-c/Makefile b/libs/protobuf-c/Makefile index fd1e4f6..7a3c5d6 100644 --- a/libs/protobuf-c/Makefile +++ b/libs/protobuf-c

Re: [OpenWrt-Devel] [PATCHv2][packages] protobuf-c: Also build protoc-c utility for host environment

2013-07-03 Thread Helmut Schaa
Hi Jonas, On Tue, Jul 2, 2013 at 12:52 PM, Jonas Gorski wrote: > On Fri, Jun 28, 2013 at 10:03 AM, Helmut Schaa > wrote: >> >> Signed-off-by: Helmut Schaa > > Some info why you need a host build would be nice, because currently I > don't see the point of it

Re: [OpenWrt-Devel] [PATCH] packages: curl: Allow fine grained protocol configuration

2013-07-03 Thread Helmut Schaa
On Tue, Jul 2, 2013 at 12:30 PM, Jonas Gorski wrote: > On Wed, May 29, 2013 at 9:52 AM, Helmut Schaa > wrote: >> On Tue, May 14, 2013 at 11:19 AM, Helmut Schaa >> wrote: >>> Disabling unused protocols in libcurl can save more then 100K, hence add >>> some

[OpenWrt-Devel] [PATCH] button-hotplug: Add KEY_POWER handling

2013-07-04 Thread Helmut Schaa
When running OpenWrt within KVM KEY_POWER is generated from the ACPI button driver when restarting or powering down the VM. Extend button-hotplug to allow user space handlers for these events. Signed-off-by: Helmut Schaa --- package/kernel/button-hotplug/src/button-hotplug.c |1 + 1 file

Re: [OpenWrt-Devel] ubus x86: Failed to connect to ubus

2013-07-09 Thread Helmut Schaa
On Sun, Jun 23, 2013 at 4:54 AM, Remzi AKYÜZ wrote: > I tried to use openwrt r36979 but i got this error message "Failed to > connect to ubus". Same here, culprit seems to be the following commit: commit 4f6a8df9b3f2f02c3cdcc0719d9e6ef7280eac51 Author: cyrus Date: Mon Jun 24 12:38:30 2013 +

Re: [OpenWrt-Devel] ubus x86: Failed to connect to ubus

2013-07-09 Thread Helmut Schaa
Hey John, On Tue, Jul 9, 2013 at 1:51 PM, John Crispin wrote: > does this happen on latest trunk ? Pulled yesterday. Just found out that procd should start ubus, not sure yet whats happening ... Helmut ___ openwrt-devel mailing list openwrt-devel@lists

Re: [OpenWrt-Devel] ubus x86: Failed to connect to ubus

2013-07-09 Thread Helmut Schaa
On Tue, Jul 9, 2013 at 1:59 PM, John Crispin wrote: > there was a bug in the delay timer, that tried to reconnect to ubus every > minute. ... maybe you can add some debug code to it and see whats wrong. its > inside ubus.c in the procd source Hmm, there is no procd init file anymore? However, pro

Re: [OpenWrt-Devel] ubus x86: Failed to connect to ubus

2013-07-09 Thread Helmut Schaa
On Tue, Jul 9, 2013 at 2:18 PM, Helmut Schaa wrote: > How is procd supposed to get started? Only as init replacement? Hmm, ubusd should still get started from state_enter in STATE_INIT :) ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.

Re: [OpenWrt-Devel] ubus x86: Failed to connect to ubus

2013-07-09 Thread Helmut Schaa
On Tue, Jul 9, 2013 at 2:14 PM, John Crispin wrote: > On 09/07/13 14:18, Helmut Schaa wrote: >> How is procd supposed to get started? Only as init replacement? > > Hi, > > From state.c: > case STATE_INIT: > LOG("- init -

Re: [OpenWrt-Devel] ubus x86: Failed to connect to ubus

2013-07-09 Thread Helmut Schaa
On Tue, Jul 9, 2013 at 2:19 PM, John Crispin wrote: > On 09/07/13 14:22, Helmut Schaa wrote: >> >> On Tue, Jul 9, 2013 at 2:14 PM, John Crispin wrote: >>> >>> On 09/07/13 14:18, Helmut Schaa wrote: >>>> >>>> How is procd supposed

Re: [OpenWrt-Devel] ubus x86: Failed to connect to ubus

2013-07-10 Thread Helmut Schaa
On Tue, Jul 9, 2013 at 2:34 PM, Helmut Schaa wrote: > On Tue, Jul 9, 2013 at 2:19 PM, John Crispin wrote: >> ok, i just started a build for a qemu image > > Thanks, I'm not entirely sure if it is 100% reproducible. > Rebooting again gave me a working ubusd again. S

Re: [OpenWrt-Devel] ubus x86: Failed to connect to ubus

2013-07-11 Thread Helmut Schaa
On Wed, Jul 10, 2013 at 2:19 PM, John Crispin wrote: > On 10/07/13 14:17, Helmut Schaa wrote: >> >> On Tue, Jul 9, 2013 at 2:34 PM, Helmut Schaa >> wrote: >>> >>> On Tue, Jul 9, 2013 at 2:19 PM, John Crispin wrote: >>>> >>>> ok,

[OpenWrt-Devel] [PATCH] libubox: Fix incorrect uloop timeout

2013-07-24 Thread Helmut Schaa
-by: Helmut Schaa --- uloop.c |1 + 1 file changed, 1 insertion(+) diff --git a/uloop.c b/uloop.c index 54ebe8d..deb08a3 100644 --- a/uloop.c +++ b/uloop.c @@ -632,6 +632,7 @@ void uloop_run(void) if (do_sigchld) uloop_handle_processes

Re: [OpenWrt-Devel] [PATCHv2] mklibs: Fix mklibs usage when *.so files reside in subdirs

2013-07-29 Thread Helmut Schaa
On Wed, Jun 26, 2013 at 1:55 PM, Helmut Schaa wrote: > Currently package/Makefile only passes /lib /usr/lib and /usr/lib/ebtables > to mklibs. However, other libs can also reside in different subdirectories > (in my case /usr/lib/ipsec). Hence, create the list of library directories >

[OpenWrt-Devel] [PATCH] kernel: crashlog: Avoid out-of-bounds write

2013-08-21 Thread Helmut Schaa
e_t which makes a negative input a big positive number allowing kmsg_dump_get_buffer to write out of bounds. Fix this by using vscnprintf which returns the actually written number of chars. Signed-off-by: Helmut Schaa --- Only tested on 3.10. target/linux/generic/patches-3.10/930-crashlog.pa

[OpenWrt-Devel] b44 module errors on x86

2013-09-04 Thread Helmut Schaa
Hi Hauke, Booting a pretty decent x86 OpenWrt within KVM gives me a bunch of Symbol errors in b44: [2.291153] b44: Unknown symbol ssb_device_is_enabled (err 0) [2.294154] b44: Unknown symbol ssb_pcicore_dev_irqvecs_enable (err 0) [2.298384] b44: Unknown symbol ssb_bus_may_powerdown (e

[OpenWrt-Devel] [PATCH] [packages] avahi: Clean up dependencies

2013-09-06 Thread Helmut Schaa
libavahi does not require libdaemon nor libgdbm. Move the dependencies into the right avahi sub-packages to allow smaller footprint when only using libavahi. Signed-off-by: Helmut Schaa --- libs/avahi/Makefile | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libs

[OpenWrt-Devel] [PATCH] procd: Exit askfirst on read error

2013-09-17 Thread Helmut Schaa
When running askfirst on an unused tty device askfirst starts busylooping forever. Fix this by returning an error if we read an EOF. Signed-off-by: Helmut Schaa --- askfirst.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/askfirst.c b/askfirst.c index 9916486

[OpenWrt-Devel] [RFC] netifd: Avoid concurrent calls to "wifi up/down"

2013-10-11 Thread Helmut Schaa
e the usage of "wifi up/down". Signed-off-by: Helmut Schaa --- Sending as RFC since I consider this an ugly hack and somebody else might have a better idea. Helmut .../network/config/netifd/files/etc/init.d/network | 23 1 file changed, 23 insertions(+) diff

Re: [OpenWrt-Devel] [RFC] netifd: Avoid concurrent calls to "wifi up/down"

2013-10-17 Thread Helmut Schaa
On Thu, Oct 17, 2013 at 4:11 PM, Felix Fietkau wrote: > On 2013-10-11 10:33 AM, Helmut Schaa wrote: >> Multiple "wifi up/down" invocations can conflict badly with each other >> resulting in a somehow broken wifi setup. >> >> This can be triggered by calling

[OpenWrt-Devel] [PATCH] base-files: Make /etc/init.d/boot restartable

2013-11-05 Thread Helmut Schaa
Only reload hostname and timezone config on /etc/init.d/boot restart. Module loading and basic boot setup is only done during boot. Signed-off-by: Helmut Schaa --- package/base-files/files/etc/init.d/boot | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/package

[OpenWrt-Devel] procd: service_running hook?

2013-11-05 Thread Helmut Schaa
Hi, just noticed that the service_running hook is executed by procd in parallel to the startup of further init scripts. If another service depends on the service_running hook of an earlier service this can lead to strange effects. For example the network script setting up wireless (in service_run

Re: [OpenWrt-Devel] [OpenWRT-Devel][PATCH] add openvswitch 2.0.0 package

2013-11-11 Thread Helmut Schaa
Hi, On Fri, Nov 8, 2013 at 11:42 PM, Pete Holland wrote: > This is a patch for the most recent stable build of OpenvSwitch (2.0.0). It > supports kernels 2.6.32 - 3.10.x > > It was taken and updated from Julius Shulz-Zander's work: > https://github.com/schuza/openvswitch Nice, I've been playing

Re: [OpenWrt-Devel] [OpenWRT-Devel][PATCH] add openvswitch 2.0.0 package

2013-11-12 Thread Helmut Schaa
On Mon, Nov 11, 2013 at 6:45 PM, Pete Holland wrote: > The protocol daemon manages > interface up/down events as well as adding/removing necessary flows for the > policy routing, so we aren't using netifd. Ah, ok, so no netifd and no brcompat module for you :D Thanks, Helmut

[OpenWrt-Devel] [PATCH] procd: Allow process respawning forever

2013-11-15 Thread Helmut Schaa
Use respawn_retry==0 as indication to respawn a process forever. Signed-off-by: Helmut Schaa --- instance.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/instance.c b/instance.c index 05b0f99..2db1ded 100644 --- a/instance.c +++ b/instance.c @@ -162,7 +162,7

Re: [OpenWrt-Devel] [PATCH] procd: Allow process respawning forever

2013-11-20 Thread Helmut Schaa
On Tue, Nov 19, 2013 at 5:33 PM, John Crispin wrote: > i just pushed this fix. I also pushed a fix for the running trigger bug you > reported. Nice, haven't found time to fix it myself yet! Thanks, Helmut ___ openwrt-devel mailing list openwrt-devel@l

[OpenWrt-Devel] [PATCH] netifd: Fix possible segfault in bridge code

2013-11-29 Thread Helmut Schaa
Need to check calloc result. In case of failure the bridge member will be missing. Signed-off-by: Helmut Schaa --- bridge.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bridge.c b/bridge.c index 0e06cc2..4ef0d7e 100644 --- a/bridge.c +++ b/bridge.c @@ -318,6 +318,9

Re: [OpenWrt-Devel] [PATCH] netifd: Fix possible segfault in bridge code

2013-11-29 Thread Helmut Schaa
On Fri, Nov 29, 2013 at 3:34 PM, Felix Fietkau wrote: > On 2013-11-29 15:22, Helmut Schaa wrote: >> Need to check calloc result. In case of failure the bridge member will be >> missing. >> >> Signed-off-by: Helmut Schaa > Pushed to git, thanks. > It will be c

[OpenWrt-Devel] [RFC/RFT] netifd: Initial OpenVSwitch support

2013-11-29 Thread Helmut Schaa
Add a new device type "ovs" to define openvswitch (pseudo-) bridges. For setting up oppenvswitch bridges the "ovs-vsctl" utility is used within system-ovs.* and might be replaced with plain JSON-RPC in the future. Signed-off-by: Helmut Schaa --- This is a first RFC of openvs

Re: [OpenWrt-Devel] [PATCH] rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER respectively

2012-05-18 Thread Helmut Schaa
Hi, On Fri, May 18, 2012 at 1:04 AM, Tobias Diedrich wrote: > rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER > respectively, similar to how it is already done in rt2[45]00pci.c > > rt2800lib.c doesn't initialize max_power and thus after > http://git.kernel.org/?p=linux/kernel/g

Re: [OpenWrt-Devel] [PATCH] rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER respectively

2012-05-19 Thread Helmut Schaa
On Fri, May 18, 2012 at 6:21 PM, Tobias Diedrich wrote: >> So, maybe we should do it the safe way and just register a safe default >> of 20dBm for all channels? > > AFAIU that would cap you to 20dBm even if you are in a country that > has higher limits (e.g. 27dBm in the US?). Not necessarily bec

Re: [OpenWrt-Devel] [PATCH] rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER respectively

2012-05-22 Thread Helmut Schaa
On Fri, May 18, 2012 at 1:04 AM, Tobias Diedrich wrote: > rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER > respectively, similar to how it is already done in rt2[45]00pci.c > > rt2800lib.c doesn't initialize max_power and thus after > http://git.kernel.org/?p=linux/kernel/git/li

Re: [OpenWrt-Devel] [PATCH] rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER respectively

2012-05-23 Thread Helmut Schaa
On Tue, May 22, 2012 at 10:58 PM, Tobias Diedrich wrote: > Helmut Schaa wrote: >> On Fri, May 18, 2012 at 1:04 AM, Tobias Diedrich >> wrote: >> > rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER >> > respectively, similar to how it

Re: [OpenWrt-Devel] [PATCH] rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER respectively

2012-05-23 Thread Helmut Schaa
Hi, On Wed, May 23, 2012 at 3:55 PM, Tobias Diedrich wrote: > Helmut Schaa wrote: >> On Tue, May 22, 2012 at 10:58 PM, Tobias Diedrich >> wrote: >> > Helmut Schaa wrote: >> >> On Fri, May 18, 2012 at 1:04 AM, Tobias Diedrich >> >> wrote: >>

[OpenWrt-Devel] [PATCH] netifd: call /etc/udhcp.user from the netifd dhcp.script

2012-11-22 Thread Helmut Schaa
This was done previously when dhcp was handled by the network scripts. So netifd should behave the same. Signed-off-by: Helmut Schaa --- .../config/netifd/files/lib/netifd/dhcp.script |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/package/network/config/netifd

[OpenWrt-Devel] [PATCH] mac80211, hostapd: Fix macfilter for multi bssid setups

2012-12-04 Thread Helmut Schaa
Previously only the first macfilter configuration would have been used on all interfaces. However, the configuration was always done per vif already. Hence, move the macfilter setup into hostapd.sh where and create one mac list file per vif. Signed-off-by: Helmut Schaa --- package/mac80211

Re: [OpenWrt-Devel] [PATCH] mac80211, hostapd: Fix macfilter for multi bssid setups

2012-12-04 Thread Helmut Schaa
Hi, On Tue, Dec 4, 2012 at 5:23 PM, Antonio Quartulli wrote: > This is in mac80211_hostapd_setup_base() which is invoked in > mac80211_hostapd_setup_bss() that is already invoked per-vif. > > So I don't think this change was really needed. >From mac80211.sh: 138 if [ -f "$cfgfile" ]; th

Re: [OpenWrt-Devel] [PATCH] mac80211, hostapd: Fix macfilter for multi bssid setups

2012-12-05 Thread Helmut Schaa
On Tue, Dec 4, 2012 at 10:39 PM, Antonio Quartulli wrote: > On Tue, Dec 04, 2012 at 10:05:10PM +0100, Helmut Schaa wrote: >> Hi, >> >> On Tue, Dec 4, 2012 at 5:23 PM, Antonio Quartulli >> wrote: >> > This is in mac80211_hostapd_setup_base() which is invoke

Re: [OpenWrt-Devel] [PATCH] mac80211, hostapd: Fix macfilter for multi bssid setups

2012-12-05 Thread Helmut Schaa
On Wed, Dec 5, 2012 at 12:12 PM, Antonio Quartulli wrote: > Thanks for pointing this out. Looking at this snippet I can clearly see that > you > are right. > > And now the puzzle starts: why is it working here? We are already using > this code and it seems to be working as expected...I'm concerne

Re: [OpenWrt-Devel] [PATCH v3] mac80211: Fix multi-bss operation issue on rt2800

2012-12-10 Thread Helmut Schaa
t; > Should fix #12133. > > 1. http://marc.info/?l=linux-wireless&m=135387062429809&w=2 > > Thanks to Paul Fertser and Helmut Schaa. > > Signed-off-by: Petr Štetiar > --- > package/mac80211/files/lib/wifi/mac80211.sh | 19 +-- > 1 file change

Re: [OpenWrt-Devel] [PATCH v3] mac80211: Fix multi-bss operation issue on rt2800

2012-12-12 Thread Helmut Schaa
On Tue, Dec 11, 2012 at 10:49 PM, Petr Štetiar wrote: >> I've just submitted a rt2x00 patch that registers a valid address mask with >> mac80211. So, you could actually use this information to generate valid MAC >> addresses for this device: >> >> /sys/class/ieee80211/phy0/macaddress >> /sys/class

[OpenWrt-Devel] [PATCH] libevent2: Configure with --disable-debug-mode

2013-12-09 Thread Helmut Schaa
Saves around 10K. Signed-off-by: Helmut Schaa --- package/libs/libevent2/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/libs/libevent2/Makefile b/package/libs/libevent2/Makefile index e260e12..42ec94d 100644 --- a/package/libs/libevent2/Makefile +++ b

[OpenWrt-Devel] [PATCH] packages: strongswan: Add second download mirror

2013-12-13 Thread Helmut Schaa
Signed-off-by: Helmut Schaa --- net/strongswan/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/strongswan/Makefile b/net/strongswan/Makefile index 07253be..de8bcca 100644 --- a/net/strongswan/Makefile +++ b/net/strongswan/Makefile @@ -12,7 +12,7 @@ PKG_VERSION

Re: [OpenWrt-Devel] [OpenWRT-Devel][PATCH] add openvswitch 2.0.0 package

2013-12-20 Thread Helmut Schaa
On Fri, Dec 20, 2013 at 2:43 PM, Roberto Riggio wrote: > On 11/08/2013 11:42 PM, Pete Holland wrote: >> This is a patch for the most recent stable build of OpenvSwitch (2.0.0). It >> supports kernels 2.6.32 - 3.10.x >> >> It was taken and updated from Julius Shulz-Zander's work: >> https://gith

Re: [OpenWrt-Devel] [OpenWRT-Devel][PATCH] add openvswitch 2.0.0 package

2013-12-20 Thread Helmut Schaa
On Fri, Dec 20, 2013 at 3:09 PM, Roberto Riggio wrote: > On 12/20/2013 03:02 PM, Helmut Schaa wrote: >> Yep, that was me. I'm using the patch on openwrt since >> some time now and am quite happy. > > I looked at it and I;m not sure if you can define a device > as br

[OpenWrt-Devel] procd: reboot sometimes hangs

2014-01-14 Thread Helmut Schaa
Hi All, sometimes I experience hangs when rebooting. As far as I can see procd does not try to kill any started services but relies on them to exit gracefully. Would it make sense to kill the services after a reasonable timeout? Helmut ___ openwrt-deve

Re: [OpenWrt-Devel] procd: reboot sometimes hangs

2014-01-15 Thread Helmut Schaa
On Tue, Jan 14, 2014 at 6:36 PM, John Crispin wrote: > Hi Helmut, > > i have not seen this happen, do you have a reliable testcase or is this > just an observation you made ? Unfortunately not, however I have several non-default services running (in particular openvswitch). > yes, a forced shutd

Re: [OpenWrt-Devel] procd: reboot sometimes hangs

2014-01-15 Thread Helmut Schaa
On Tue, Jan 14, 2014 at 8:19 PM, Bastian Bittorf wrote: > * John Crispin [14.01.2014 19:55]: >> > sometimes I experience hangs when rebooting. > > there are already some bugs on tra open regarding this. > >> > As far as I can see procd does not try to kill any >> > started services but relies on

Re: [OpenWrt-Devel] procd: reboot sometimes hangs

2014-01-15 Thread Helmut Schaa
On Wed, Jan 15, 2014 at 2:57 PM, John Crispin wrote: > Hi > > i had a look at this last night and have the same fix in my local tree > already. i need to think about it to see if it is enough, however seeing > that you came up with the same fix tells me it must be correct :) However, it makes my

Re: [OpenWrt-Devel] procd: reboot sometimes hangs

2014-01-15 Thread Helmut Schaa
On Wed, Jan 15, 2014 at 4:57 PM, Helmut Schaa wrote: > On Wed, Jan 15, 2014 at 2:57 PM, John Crispin wrote: >> Hi >> >> i had a look at this last night and have the same fix in my local tree >> already. i need to think about it to see if it is enough, however seeing &

[OpenWrt-Devel] [PATCH] libubox: runqueue: Cancel task timeout when completeing task

2014-01-15 Thread Helmut Schaa
Signed-off-by: Helmut Schaa --- runqueue.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/runqueue.c b/runqueue.c index 1784e30..1d9fa4b 100644 --- a/runqueue.c +++ b/runqueue.c @@ -224,6 +224,8 @@ void runqueue_task_complete(struct runqueue_task *t) if (t->runn

  1   2   3   >