Re: [OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

2018-08-23 Thread Dmitry Tunin
It may have sense of doing the ack this in some cases. I need to do some hardware testing to look at it more closely. I think we can leave it is is. It's not important as I said before for slow devices. But the miscintc is redefined in ar7100.dtsi. So I am happy with that. We need to have change i

Re: [OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

2018-08-23 Thread Dmitry Tunin
> This is true for ar7100. On other chips the entire > RST_MISC_INTERRUPT_STATUS block is marked as Read/Write-to-Clear. Do you have the ar7240 datasheet with those specs? > > It makes no sense to have a separate ack done this way. It slow things down. > You can use an implementation without ack f

Re: [OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

2018-08-22 Thread Chuanhong Guo
Dmitry Tunin 于2018年8月23日周四 下午2:07写道: > > чт, 23 авг. 2018 г. в 6:36, Chuanhong Guo : > > > > Dmitry Tunin 于2018年8月23日周四 上午1:24写道: > > > > > > I looked into the specs and now I see that the > > > AR71XX_RESET_REG_MISC_INT_STATUS is read-only on ar7100, so we need to > > > change the compatible > >

Re: [OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

2018-08-22 Thread Dmitry Tunin
чт, 23 авг. 2018 г. в 6:36, Chuanhong Guo : > > Dmitry Tunin 于2018年8月23日周四 上午1:24写道: > > > > I looked into the specs and now I see that the > > AR71XX_RESET_REG_MISC_INT_STATUS is read-only on ar7100, so we need to > > change the compatible > > to "qca,ar7100-misc-intc" and also change it for the

Re: [OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

2018-08-22 Thread Chuanhong Guo
Dmitry Tunin 于2018年8月23日周四 上午1:24写道: > > I looked into the specs and now I see that the > AR71XX_RESET_REG_MISC_INT_STATUS is read-only on ar7100, so we need to > change the compatible > to "qca,ar7100-misc-intc" and also change it for the "real" misc > controller. Writing to RO register makes no

Re: [OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

2018-08-22 Thread Dmitry Tunin
> > I see no reason of having two different ways of mask-ack for similar > > hardware. We need to chose one that looks better and drop the other. > I suggest discussing any irq-ath79-misc changes with the upstream developers > Alban Bedel did *a lot* of work to make the ath79 code devicetree > comp

Re: [OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

2018-08-22 Thread Martin Blumenstingl via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- On Wed, Aug 22, 2018 at 6:58 PM Dm

Re: [OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

2018-08-22 Thread Dmitry Tunin
I looked into the specs and now I see that the AR71XX_RESET_REG_MISC_INT_STATUS is read-only on ar7100, so we need to change the compatible to "qca,ar7100-misc-intc" and also change it for the "real" misc controller. Writing to RO register makes no sense at all. Nothing is said about these registe

Re: [OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

2018-08-22 Thread Dmitry Tunin
Looking into irq-ath79-misc.c I found a few things to cleanup. 1. It appears that two chips are declared: "qca,ar7100-misc-intc" and "qca,ar7240-misc-intc". The only difference is mask-ack proc. The registers seem to work the same way and practically we are using "qca,ar7240-misc-intc" on ar7100 a

Re: [OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

2018-08-22 Thread Chuanhong Guo
Dmitry Tunin 于2018年8月22日周三 下午5:07写道: > > Currently all PCI devices get the same IRQ that affects performance badly. > > This commit adresses this problem and cleans the code. > > ar7100 has a special PCI interrupt controller@18060018 that works exactly > the same way as misc interrupt controller.

Re: [OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

2018-08-22 Thread Dmitry Tunin
I looked now and I think ro ar724x we need only https://github.com/openwrt/openwrt/pull/1299/commits/0d2c51cc04b6f3872806970b1de6967ccd30289c It looks OK in that case that IRQ is handled inside PCIE. ср, 22 авг. 2018 г. в 12:27, Dmitry Tunin : > > > we need a comparable patch for ar724x, right ? a

Re: [OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

2018-08-22 Thread Dmitry Tunin
> we need a comparable patch for ar724x, right ? and then these 2 patches > obsolete the PR on github ? > > John Frankly speaking I didn't look into ar724x code. It has a PCIE, not a PCI controller, so it wasn't affected that badly. Chuanhong Guo knows that better. __

Re: [OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

2018-08-22 Thread John Crispin
On 22/08/18 11:06, Dmitry Tunin wrote: Currently all PCI devices get the same IRQ that affects performance badly. This commit adresses this problem and cleans the code. ar7100 has a special PCI interrupt controller@18060018 that works exactly the same way as misc interrupt controller. This p

Re: [OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

2018-08-22 Thread John Crispin
On 22/08/18 11:06, Dmitry Tunin wrote: Currently all PCI devices get the same IRQ that affects performance badly. This commit adresses this problem and cleans the code. ar7100 has a special PCI interrupt controller@18060018 that works exactly the same way as misc interrupt controller. This p

[OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

2018-08-22 Thread Dmitry Tunin
Currently all PCI devices get the same IRQ that affects performance badly. This commit adresses this problem and cleans the code. ar7100 has a special PCI interrupt controller@18060018 that works exactly the same way as misc interrupt controller. This patch does the following: 1. Removes all IR