The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header.
To mitigate this problem, the original message has been wrapped automatically by the mailing list software.
--- Begin Message ---On Wed, Aug 22, 2018 at 6:58 PM Dmitry Tunin <hanipouspi...@gmail.com> wrote: > > Looking into irq-ath79-misc.c I found a few things to cleanup. > > 1. It appears that two chips are declared: "qca,ar7100-misc-intc" and > "qca,ar7240-misc-intc". > The only difference is mask-ack proc. The registers seem to work the > same way and practically we are using "qca,ar7240-misc-intc" on ar7100 > according to dtsi. > I found that the other chip was declared only when looking into the code. > > At the same time the code I removed from the PCI driver used the > ar7100 type of mask-ack, that worked also OK. > > I see no reason of having two different ways of mask-ack for similar > hardware. We need to chose one that looks better and drop the other. I suggest discussing any irq-ath79-misc changes with the upstream developers Alban Bedel did *a lot* of work to make the ath79 code devicetree compatible. it would be a shame not to "use" his knowledge by including him in the discussion upstream > 2. Instead of declaring two different chips this way, since we are > reusing this driver for PCI, I suggest to declare also > "qca,ath79-pci-intc" that will > have a different chip name = "PCI", so that "MISC and "PCI" will be > seen separately in /proc/interrupts. some existing irqchip drivers: - set the name dynamically, see drivers/irqchip/irq-ts4800.c for example - have a different number of interrupts per "compatible", see drivers/irqchip/irq-meson-gpio.c for example you may need the latter for your other patch which tries to reduce ATH79_MISC_IRQ_COUNT anyways > 3. I suggest removing legacy __init ath79_misc_irq_init() and leaving > only the OF stuff. I suggest coordinating this with the upstream developers as well as that function is part of the upstream code > Any comments? slightly off-topic: please try not to top-post as it can be confusing Regards Martin
--- End Message ---
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
