On 11/12/2015 11:11, Alexander Dahl wrote:
> Hei hei,
>
> Am 2015-12-11 10:53, schrieb John Crispin:
>> 2) split the variable into 2 variables for no apparent reason.
>
> There is a reason, see:
>
>>> + http://www.openssl.org/source/old/$(PKG_BASE)/ \
>
yep i had just noticed. sorry my ba
On 11/12/2015 11:07, Kevin Kirsch wrote:
> Hi,
>
> Am 11.12.2015 um 11:01 schrieb John Crispin:
>> On 11/12/2015 10:59, Kevin Kirsch wrote:
>>> Am 11.12.2015 um 10:53 schrieb John Crispin:
technically correct but you make 2 changes int he patch.
1) add a new url
2) split the
Hei hei,
Am 2015-12-11 10:53, schrieb John Crispin:
> 2) split the variable into 2 variables for no apparent reason.
There is a reason, see:
>> +http://www.openssl.org/source/old/$(PKG_BASE)/ \
You could use a fix URL here like:
http://www.openssl.org/source/old/1.0.2/
But what if OpenSS
Hi,
Am 11.12.2015 um 11:01 schrieb John Crispin:
> On 11/12/2015 10:59, Kevin Kirsch wrote:
>> Am 11.12.2015 um 10:53 schrieb John Crispin:
>>> technically correct but you make 2 changes int he patch.
>>>
>>> 1) add a new url
>>> 2) split the variable into 2 variables for no apparent reason.
> i
On 11/12/2015 10:59, Kevin Kirsch wrote:
> Hi,
>
> Am 11.12.2015 um 10:53 schrieb John Crispin:
>> technically correct but you make 2 changes int he patch.
>>
>> 1) add a new url
>> 2) split the variable into 2 variables for no apparent reason.
>
> I do the split to avoid hardcoding the PKG_BAS
Hi,
Am 11.12.2015 um 10:53 schrieb John Crispin:
> technically correct but you make 2 changes int he patch.
>
> 1) add a new url
> 2) split the variable into 2 variables for no apparent reason.
I do the split to avoid hardcoding the PKG_BASE in the URI. Should I
split the patch in 2 patches (firs
Hi,
technically correct but you make 2 changes int he patch.
1) add a new url
2) split the variable into 2 variables for no apparent reason.
i would sugegst you drop 2) and we just merge 1)
John
On 07/12/2015 21:10, Kevin Kirsch wrote:
> OpenSSL moves old versions of the library from
>
> Signed-off-by: Kevin Kirsch
Reviewed-by: Alexander Dahl
---
> ---
> @Alexander: Great idea, I updated my patch for master.
> @OpenWRT-Maintainers: Should I somehow mention Alexanders work in the
> commit-message?
For me the reviewed by would be sufficient, but thanks for asking.
Greets
Ale
OpenSSL moves old versions of the library from
http://www.openssl.org/source/ to
http://www.openssl.org/source/old/$version/ breaking the old links.
That behavior breaks the OpenWRT-build every time OpenSSL releases
a new version.
This patch adds http://www.openssl.org/source/old/$version/ to the
Hei hei,
I try to comment without directly replying, I was not on the list
before and hope to get this right.
The proposed solution works for openssl 1.0.2 branch. However a more
generic solution would be possible. I tried the following successfully
on master and it can be merged to chaos calmer
From: Kevin Kirsch
OpenSSL moves old versions of the library from http://www.openssl.org/source/
to http://www.openssl.org/source/old/1.0.2/ breaking the old links. That
behavior breaks the OpenWRT-build every time OpenSSL releases a new version.
This patch adds http://www.openssl.org/source/old
11 matches
Mail list logo
