[PATCH 2/2] ltq-vdsl-vr9-mei: avoid unnecessary usage of unsafe_memcpy

2025-02-06 Thread Jan Hoffmann
that anyway. Signed-off-by: Jan Hoffmann --- .../kernel/lantiq/ltq-vdsl-vr9-mei/Makefile | 2 +- ...ld-spanning-write-mei-mailbox-packed.patch | 179 ++ ...for-intentional-field-spanning-write.patch | 15 -- 3 files changed, 180 insertions(+), 16 deletions(-) create mode 10

[PATCH 1/2] ltq-vdsl-vr11-mei: fix field-spanning write warning

2025-02-06 Thread Jan Hoffmann
t it, also adjust all places where similar code is used to copy from a CMV_STD_MESSAGE_T struct. Also mark all related structs as packed, because the code (and the driver in general) seems to rely on that anyway. Fixes: https://github.com/openwrt/openwrt/issues/17142 Signed-off-by: Jan Hoffmann --- .../ke

[PATCH 2/2] ltq-vdsl-vr11-app: exit more quickly if orderly shutdown fails

2025-01-30 Thread Jan Hoffmann
exit within 4 seconds is killed. This means that the DSL connection might not be stopped at all before the actual system upgrade begins. To avoid this, use the newly added option in the driver to not retry the L3 request on failure. Signed-off-by: Jan Hoffmann --- package/network/config/ltq-vdsl-vr1

[PATCH 1/2] ltq-vdsl-vr11: add option for L3 request without retry on failure

2025-01-30 Thread Jan Hoffmann
This allows to attempt an orderly shutdown via L3 request while avoiding excessive delay in the failure case (up to 6 seconds with the currently hard-coded 3 attempts). Signed-off-by: Jan Hoffmann --- package/kernel/lantiq/ltq-vdsl-vr11/Makefile | 2 +- .../patches/300-l3-request-no

[PATCH 0/2] ltq-vdsl-vr11(-app): don't retry L3 requests to stop more quickly

2025-01-30 Thread Jan Hoffmann
the driver, because the modem never responds. It works when using a Planet VC-231G as a "DSLAM", so it is clear the feature in the driver/modem does work in general.) Jan Hoffmann (2): ltq-vdsl-vr11: add option for L3 request without retry on failure ltq-vdsl-vr11-app: exit more quickly

Re: [PATCH 1/3] kernel: vrx518_tc: fix RX desc phys to virt mapping

2025-01-11 Thread Jan Hoffmann
rt() as is and apply byte_off later on mapped virtual address when copying RXed data into the skb. VDSL still works with this patch. Tested-by: Jan Hoffmann Maybe the PKG_RELEASE should be increased? (Although it looks like it also wasn't done for the last few changes to the package.)

Quick Question About Collaboration

2024-10-31 Thread Jan Polasek via openwrt-devel
ttract at least 200,000 visits per month. How about a short, no-obligation conversation? Best regards Jan Polasek --- End Message --- ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[PATCH 0/3] ltq-adsl: add dsl_cpe_pipe.sh

2024-10-19 Thread Jan Hoffmann
use I don't have access to an actual ADSL line) Jan Hoffmann (3): ltq-adsl: align config more closely to VDSL variants ltq-adsl-app: align config more closely to VDSL variants ltq-adsl-app: add dsl_cpe_pipe.sh script package/kernel/lantiq/ltq-adsl/Makefile | 19 packa

[PATCH 3/3] ltq-adsl-app: add dsl_cpe_pipe.sh script

2024-10-19 Thread Jan Hoffmann
This allows to obtain detailed diagnostic information about the DSL connection from the modem. The script is copied from the corresponding packages for VDSL modems. Signed-off-by: Jan Hoffmann --- package/network/config/ltq-adsl-app/Makefile | 3 ++- .../config/ltq-adsl-app/files

[PATCH 1/3] ltq-adsl: align config more closely to VDSL variants

2024-10-19 Thread Jan Hoffmann
ly enabled options stay like that. However, ReTx options stay disabled, because of incompatibility with the ubus code. Signed-off-by: Jan Hoffmann --- package/kernel/lantiq/ltq-adsl/Makefile | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/package/kernel/lanti

[PATCH 2/3] ltq-adsl-app: align config more closely to VDSL variants

2024-10-19 Thread Jan Hoffmann
ly enabled options stay like that. However, ReTx options stay disabled, because of incompatibility with the ubus code. Signed-off-by: Jan Hoffmann --- package/network/config/ltq-adsl-app/Makefile | 28 +++- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git a/package/network/

Affiliate Marketing

2024-10-11 Thread Jan Polasek via openwrt-devel
echnologies and AdPolice, ensure clean traffic and protect your brand. We work with market giants like IKEA, Biedronka, and Nespresso. If you are ready to take your affiliate marketing efforts to the next level, let me know! I’d be happy to discuss how we can achieve the desired results together. B

[PATCH] linux-firmware: add Bluetooth firmware for Realtek RTL8821C

2024-07-13 Thread Jan Hoffmann
RTL8821C has built-in Bluetooth, but it requires additional firmware. Add it to the existing rtl8821ce-firmware package. Signed-off-by: Jan Hoffmann --- package/firmware/linux-firmware/realtek.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package/firmware/linux-firmware/realtek.mk

[PATCH 1/2] omap: switch back to old cpsw ethernet driver

2024-07-13 Thread Jan Hoffmann
The new cpsw-switch driver reserves VLAN 1 for internal use, which conflicts with the default network configuration of OpenWrt. Switch back to the older cpsw driver to make the network connection on the affected devices (BeagleBone Black and AM335x EVM) usable again. Signed-off-by: Jan Hoffmann

[PATCH 2/2] omap: re-enable target

2024-07-13 Thread Jan Hoffmann
The target was marked source-only due do the broken Ethernet port on some devices. With that fixed, it can be enabled again. Signed-off-by: Jan Hoffmann --- target/linux/omap/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/omap/Makefile b/target/linux

[PATCH 5/5] ltq-vdsl-vr11-app: perform orderly shutdown on exit

2024-07-12 Thread Jan Hoffmann
Try to do a clean disconnection via L3 request before the connection is stopped. Because this might take up to 6 seconds (the driver does 3 attempts with a timeout of 2 seconds each), a termination timeout needs to be defined in the init script. Signed-off-by: Jan Hoffmann --- .../network

[PATCH 3/5] ltq-vdsl-vr9-app: always disconnect on exit

2024-07-12 Thread Jan Hoffmann
Move the code for disconnection on exit to a separate function, and also call it in the code path for the "quit" CLI command. While at it, make the patch description a bit clearer. Signed-off-by: Jan Hoffmann --- .../network/config/ltq-vdsl-vr9-app/Makefile | 2 +- .../p

[PATCH 4/5] ltq-vdsl-vr11-app: always disconnect on exit

2024-07-12 Thread Jan Hoffmann
Move the code for disconnection on exit to a separate function, and also call it in the code paths for SIGINT and the "quit" CLI command. While at it, make the patch description a bit clearer. Signed-off-by: Jan Hoffmann --- .../network/config/ltq-vdsl-vr11-app/Makefile | 2 +- .

[PATCH 0/5] ltq-vdsl-*-app: improve shutdown handling

2024-07-12 Thread Jan Hoffmann
stopping, while the L3 request may take a few seconds to become effective. However, I don't see any way to fix this other than moving the call of the hotplug script to the daemon, which is probably not worth it.) Jan Hoffmann (5): ltq-vdsl-vr9-app: fix error handling during disconnection lt

[PATCH 2/5] ltq-vdsl-vr11-app: fix error handling during disconnection

2024-07-12 Thread Jan Hoffmann
Use the correct return value in error message. Fixes: 6e4c9738bed0 ("ltq-vdsl-vr11-app: add version 4.23.1 for vr11 targets") Signed-off-by: Jan Hoffmann --- package/network/config/ltq-vdsl-vr11-app/Makefile | 2 +- .../network/config/ltq-vdsl-vr11-app/patches/200-auto

[PATCH 1/5] ltq-vdsl-vr9-app: fix error handling during disconnection

2024-07-12 Thread Jan Hoffmann
Use the correct return value in error message. Fixes: 1daaef31b352 ("ltq-vdsl-app: disconnect when service is stopped") Signed-off-by: Jan Hoffmann --- package/network/config/ltq-vdsl-vr9-app/Makefile| 2 +- .../network/config/ltq-vdsl-vr9-app/patches/200-autoboot.

Re: [PATCH uci] uci: decrease the n_section when section is freed

2023-09-14 Thread Jan Venekamp
On 14/09/2023 23:36, Leon Busch-George wrote: > Before finding and applying Jeff's patch I had written a small test > application that creates a few random sections in the 'dhcp' UCI > package and deletes them again (uci_set). > Afterwards, it iterates all packages (uci_list_configs), prints a line

[PATCH uci] reduce code complexity of uci_show_package

2023-09-08 Thread Jan Venekamp
s the code complexity of uci_show_package, uci_show_section and uci_show_option. Signed-off-by: Jan Venekamp --- cli.c | 132 +- .../references/show_parsing_multiline.data| 3 + .../show_parsing_multiline_package.result | 2 + 3 fil

Re: [PATCH netifd] system-linux: Do not unconditionally activate IPv6 on devices

2023-09-07 Thread Jan Venekamp
I overlooked this patch when submitting [1]. Slightly different argumentation, exact same conclusion. Hauke can you apply this? Kind regards, Jan Venekamp [1] https://patchwork.ozlabs.org/project/openwrt/patch/20230626193755.25155-1-...@venekamp.net/ Reviewed-by: Jan Venekamp

Re: [PATCH uci] uci: decrease the n_section when section is freed

2023-09-07 Thread Jan Venekamp
this behaviour? Kind regards, Jan Venekamp [1] https://git.openwrt.org/?p=project/uci.git;a=commitdiff;h=16e8a3b1 --- .../references/batch_anonymous_section.result | 7 +++ tests/shunit2/tests.d/060_batch | 17 + 2 files changed, 24 insertions(+) create mo

Re: [PATCH uci 2/2] remove internal usage of redundant uci_ptr.last

2023-08-01 Thread Jan Venekamp
On 01/08/2023 22:27, Hauke Mehrtens wrote: On 7/14/23 20:28, Jan Venekamp wrote: In uci_lookup_ptr and uci_set the pointer uci_ptr ptr.last is set to the element corresponding to the first of: ptr.o, ptr.s, ptr.p. Thus, ptr.last is redundant and in case of uci_set is (and was) not always

Re: [PATCH uci] file: Fix uci -m import command

2023-07-14 Thread Jan Venekamp
ekamp.net/ https://patchwork.ozlabs.org/project/openwrt/patch/sy4p282mb39395204ae37bc45d35d834cc5...@sy4p282mb3939.ausp282.prod.outlook.com/ Kind regards, Jan Venekamp ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.or

[PATCH uci 2/2] remove internal usage of redundant uci_ptr.last

2023-07-14 Thread Jan Venekamp
ptr.last in uci_lookup_ptr intact. Signed-off-by: Jan Venekamp --- cli.c | 39 +++ delta.c | 10 ++ list.c| 6 -- lua/uci.c | 42 +++--- 4 files changed, 32 insertions(+), 65 deletions(-) diff --git a

[PATCH uci 0/2] remove internal usage of redundant uci_ptr.last

2023-07-14 Thread Jan Venekamp
Remove internal usage of redundant uci_ptr.last in order to fix issue and simplify code. Jan Venekamp (2): file: Fix uci -m import command remove internal usage of redundant uci_ptr.last cli.c | 39 +++ delta.c | 10 ++ file.c| 2

[PATCH uci 1/2] file: Fix uci -m import command

2023-07-14 Thread Jan Venekamp
) Co-authored-by: Hauke Mehrtens Signed-off-by: Jan Venekamp --- file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file.c b/file.c index 93abfae..6610f53 100644 --- a/file.c +++ b/file.c @@ -459,7 +459,7 @@ static void uci_parse_config(struct uci_context *ctx)

[PATCH] netifd: Do not set disable_ipv6=0 in system_if_clear_state()

2023-06-26 Thread Jan Venekamp
[1] https://git.openwrt.org/?p=project/netifd.git;a=commitdiff;h=53f8ed2c [2] https://git.openwrt.org/?p=project/netifd.git;a=commitdiff;h=98ca6746 Signed-off-by: Jan Venekamp --- system-linux.c | 1 - 1 file changed, 1 deletion(-) diff --git a/system-linux.c b/system-linux.c index 0760e73..4cfd95b 10

[PATCH v2 6/6] realtek: remove redundant is_lagmember checks

2023-05-06 Thread Jan Hoffmann
as 0 is a valid multicast group entry index. Fixes: cde31976e375 ("realtek: Add support for Layer 2 Multicast") Signed-off-by: Jan Hoffmann --- .../files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 15 ++- .../files-5.15/drivers/net/dsa/rtl83xx/dsa.c | 15 ++-

[PATCH v2 5/6] realtek: remove store_mcgroups/load_mcgroups

2023-05-06 Thread Jan Hoffmann
roups entirely, as the original commit message doesn't offer a convincing reason why this would be necessary in the first place. Fixes: 724e4af530cd ("realtek: Store and Restore MC memberships for port enable/disable") Signed-off-by: Jan Hoffmann --- .../files-5.10/drivers/net/dsa

[PATCH v2 4/6] realtek: don't add CPU port to multicast portmasks

2023-05-06 Thread Jan Hoffmann
s only the CPU port, even if it was explicitly created. Fixes: 724e4af530cd ("realtek: Store and Restore MC memberships for port enable/disable") Signed-off-by: Jan Hoffmann --- .../linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 7 ++- .../linux/realtek/files-5.15/drivers/n

[PATCH v2 2/6] realtek: don't treat first multicast portmask entry as reserved

2023-05-06 Thread Jan Hoffmann
es, a corresponding decrement was missing, causing the wrong entry to be marked as free. Fixes: cde31976e375 ("realtek: Add support for Layer 2 Multicast") Signed-off-by: Jan Hoffmann --- target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 1 - target/linux/realtek/files-5

[PATCH v2 3/6] realtek: actually remove port from multicast portmask

2023-05-06 Thread Jan Hoffmann
Fixes: 724e4af530cd ("realtek: Store and Restore MC memberships for port enable/disable") Signed-off-by: Jan Hoffmann --- target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 1 + target/linux/realtek/files-5.15/drivers/net/dsa/rtl83xx/dsa.c | 1 + 2 files changed, 2

[PATCH v2 1/6] realtek: fix writing/deletion of CAM entries

2023-05-06 Thread Jan Hoffmann
Actually use the index returned by rtl83xx_find_l2_cam_entry. Fixes: cde31976e375 ("realtek: Add support for Layer 2 Multicast") Signed-off-by: Jan Hoffmann --- .../realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 8 .../realtek/files-5.15/drivers/net/dsa/rtl83xx/dsa.

[PATCH v2 0/6] realtek: fix management of mdb entries

2023-05-06 Thread Jan Hoffmann
rmail/openwrt-devel/2023-March/040621.html [2] https://lore.kernel.org/netdev/20230306134636.p2ufzoqk6kf3hu3y@skbuf/ Jan Hoffmann (6): realtek: fix writing/deletion of CAM entries realtek: don't treat first multicast portmask entry as reserved realtek: actually remove port from multicas

[PATCH v2 3/4] realtek: fix standalone ports in presence of static fdb entries

2023-05-06 Thread Jan Hoffmann
learning feature. For now, this is only implemented for RTL838x/RTL839x, as the available set of registers differs for the other devices. Signed-off-by: Jan Hoffmann --- .../files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 15 +++ .../files-5.10/drivers/net/dsa/rtl83xx/rtl838x.c | 10

[PATCH v2 4/4] realtek: handle changed flags in VLAN configuration

2023-05-06 Thread Jan Hoffmann
function. Signed-off-by: Jan Hoffmann --- .../files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 42 ++- .../files-5.15/drivers/net/dsa/rtl83xx/dsa.c | 38 + 2 files changed, 43 insertions(+), 37 deletions(-) diff --git a/target/linux/realtek/files-5.10/drivers/net/dsa

[PATCH v2 1/4] realtek: properly update port masks when port leaves bridge

2023-05-06 Thread Jan Hoffmann
quot;) [reintroduced incorrect pm field update] Fixes: 27029277f98d ("realtek: add switch driver support for the RTL93XX based switches") Signed-off-by: Jan Hoffmann --- .../realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 10 +- .../realtek/files-5.15/drivers/net/dsa/rtl83xx/ds

[PATCH v2 2/4] realtek: initialize port masks to match the default state

2023-05-06 Thread Jan Hoffmann
the traffic_set method in rtl83xx_setup, instead of writing to the RTL838x_PORT_ISO_CTRL(i) registers directly. Signed-off-by: Jan Hoffmann --- .../files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 23 +-- .../files-5.15/drivers/net/dsa/rtl83xx/dsa.c | 23 +-- 2 files

[PATCH v2 0/4] realtek: fix multiple issues with L2 forwarding

2023-05-06 Thread Jan Hoffmann
warnings - Removed comment about RTL838X_PORT_ISO_CTRL, as the traffic_set method is now used instead of accessing the register directly - Added Fixes tags for first commit Jan Hoffmann (4): realtek: properly update port masks when port leaves bridge realtek: initialize port masks to match the

Re: [PATCH 0/4] realtek: fix multiple issues with L2 forwarding

2023-05-06 Thread Jan Hoffmann
Hi Sander, Thank you for reviewing the patches! On 2023-0430 at 22:39, Sander Vanheule wrote: Hi Jan, On Sun, 2023-03-12 at 23:57 +0100, Jan Hoffmann wrote:   realtek: fix standalone ports in presence of static fdb entries   realtek: handle changed flags in VLAN configuration These

Re: [PATCH] ipq40xx: add PCIe magic hack to improve VRX518 compatibility

2023-04-25 Thread Jan Hoffmann
On 2023-01-30 at 23:40, Jan Hoffmann wrote: Some VRX518 modems fail to initialize properly with the error message "dc_ep_clk_on failed". As a result, the DSL data path doesn't work. This hack, which is based on code from the FRITZ!Box 7530 GPL archive, fixes the issue. It c

[PATCH 4/4] realtek: handle changed flags in VLAN configuration

2023-03-12 Thread Jan Hoffmann
function. Signed-off-by: Jan Hoffmann --- .../files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 41 ++- .../files-5.15/drivers/net/dsa/rtl83xx/dsa.c | 37 + 2 files changed, 43 insertions(+), 35 deletions(-) diff --git a/target/linux/realtek/files-5.10/drivers/net/dsa

[PATCH 3/4] realtek: fix standalone ports in presence of static fdb entries

2023-03-12 Thread Jan Hoffmann
learning feature. For now, this is only implemented for RTL838x/RTL839x, as the available set of registers differs for the other devices. Signed-off-by: Jan Hoffmann --- .../files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 16 .../files-5.10/drivers/net/dsa/rtl83xx/rtl838x.c | 10

[PATCH 1/4] realtek: properly update port masks when port leaves bridge

2023-03-12 Thread Jan Hoffmann
, so that any other ports that are currently disabled will be configured correctly when they are enabled. Signed-off-by: Jan Hoffmann --- I originally wanted to put a proper Fixes tag here, but I'm not sure which commit to choose. This bug seems to have existed since this target was introduced

[PATCH 2/4] realtek: initialize port masks to match the default state

2023-03-12 Thread Jan Hoffmann
the traffic_set method in rtl83xx_setup. Signed-off-by: Jan Hoffmann --- .../files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 22 ++- .../files-5.15/drivers/net/dsa/rtl83xx/dsa.c | 22 ++- 2 files changed, 24 insertions(+), 20 deletions(-) diff --git a/target/linux

[PATCH 0/4] realtek: fix multiple issues with L2 forwarding

2023-03-12 Thread Jan Hoffmann
This series fixes several bugs that can result in packets being forwarded incorrectly. The port isolation and VLAN issues probably remained unnoticed so far, because they only manifest when after a port leaves a bridge, or an existing VLAN membership is changed. Jan Hoffmann (4): realtek

[PATCH] realtek: hpe_1920-8g: add phy-handle for SFP ports

2023-03-11 Thread Jan Hoffmann
The switch driver actually expects every port to have a PHY handle, and several branches in the code determine if a port is valid by checking for a non-zero phy field. Signed-off-by: Jan Hoffmann --- target/linux/realtek/dts-5.10/rtl8380_hpe_1920-8g.dts | 2 ++ target/linux/realtek/dts-5.15

Re: [PATCH 0/6] realtek: fix management of mdb entries

2023-03-10 Thread Jan Hoffmann
Hi Vladimir, Thank you for having a look at this! On 06.03.2023 14:46, Vladimir Oltean wrote: On Sat, Mar 04, 2023 at 01:52:32PM +0300, Arınç ÜNAL wrote: On 4.03.2023 00:48, Jan Hoffmann wrote: This series fixes multiple issues related to the L2 table and multicast table. That includes an

Re: [PATCH 2/6] realtek: don't return 0 from rtl83xx_mc_group_alloc on failure

2023-03-03 Thread Jan Hoffmann
On 2023-03-03 at 22:48, Jan Hoffmann wrote: This function returns the index of the allocated multicast group entry, so the return value should be negative when no entry was allocated. Fixes: cde31976e375 ("realtek: Add support for Layer 2 Multicast") Signed-off-by: Jan Hoffmann --

[PATCH 6/6] realtek: remove store_mcgroups/load_mcgroups

2023-03-03 Thread Jan Hoffmann
roups entirely, as the original commit message doesn't offer a convincing reason why this would be necessary in the first place. Fixes: 724e4af530cd ("realtek: Store and Restore MC memberships for port enable/disable") Signed-off-by: Jan Hoffmann --- .../files-5.10/drivers/net/dsa

[PATCH 3/6] realtek: don't treat first multicast portmask entry as reserved

2023-03-03 Thread Jan Hoffmann
es, a corresponding decrement was missing, causing the wrong entry to be marked as free. Fixes: cde31976e375 ("realtek: Add support for Layer 2 Multicast") Signed-off-by: Jan Hoffmann --- target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 1 - target/linux/realtek/files-5

[PATCH 5/6] realtek: don't add CPU port to multicast portmasks

2023-03-03 Thread Jan Hoffmann
s only the CPU port, even if it was explicitly created. Fixes: 724e4af530cd ("realtek: Store and Restore MC memberships for port enable/disable") Signed-off-by: Jan Hoffmann --- .../linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 7 ++- .../linux/realtek/files-5.15/drivers/n

[PATCH 2/6] realtek: don't return 0 from rtl83xx_mc_group_alloc on failure

2023-03-03 Thread Jan Hoffmann
This function returns the index of the allocated multicast group entry, so the return value should be negative when no entry was allocated. Fixes: cde31976e375 ("realtek: Add support for Layer 2 Multicast") Signed-off-by: Jan Hoffmann --- I'm not entirely sure about t

[PATCH 4/6] realtek: actually remove port from multicast portmask

2023-03-03 Thread Jan Hoffmann
Fixes: 724e4af530cd ("realtek: Store and Restore MC memberships for port enable/disable") Signed-off-by: Jan Hoffmann --- target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 1 + target/linux/realtek/files-5.15/drivers/net/dsa/rtl83xx/dsa.c | 1 + 2 files changed, 2

[PATCH 1/6] realtek: fix writing/deletion of CAM entries

2023-03-03 Thread Jan Hoffmann
Actually use the index returned by rtl83xx_find_l2_cam_entry. Fixes: cde31976e375 ("realtek: Add support for Layer 2 Multicast") Signed-off-by: Jan Hoffmann --- .../realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 8 .../realtek/files-5.15/drivers/net/dsa/rtl83xx/dsa.

[PATCH 0/6] realtek: fix management of mdb entries

2023-03-03 Thread Jan Hoffmann
working. However, one important missing piece is forwarding of all multicast traffic to multicast router ports (as specified in section 2.1.2-1 of RFC4541). As far as I can see, this is a general issue that affects all DSA switches, and cannot be fixed without changes to the DSA subsystem. Jan

Re: m7621 i2c read failure

2023-02-16 Thread Jan Breuer
On 16. 2. 2023 16:21, Peter Naulls wrote: > > On 2/15/23 13:31, Peter Naulls wrote: > > > > I'm trying to track yet another vendor vs current OpenWrt driver > > mishandling. > > > x00 Can you please provide info about the exact SoC and hardware you are using? > > > > In particular, for the first

[PATCH] realtek: fix memory leak in netevent handler

2023-02-08 Thread Jan Hoffmann
The net_event_work struct is allocated, but only freed in a single case. Move the allocation to the branch where it is actually needed, and free it after the work has been done. Fixes: 03e1d93e0779 ("realtek: add driver support for routing offload") Signed-off-by: Jan Hoffmann --- I no

Re: [PATCH] ipq40xx: add PCIe magic hack to improve VRX518 compatibility

2023-02-04 Thread Jan Hoffmann
Am 02.02.23 um 11:54 schrieb Robert Marko: On Tue, 31 Jan 2023 at 23:52, Jan Hoffmann wrote: Hi Robert, On 2023-01-30 at 00:08, Robert Marko wrote: Shouldn't it be possible for the modem driver itself to be fixed instead of faking the PCI details? This hack is definitely far from

Re: [PATCH] ipq40xx: add PCIe magic hack to improve VRX518 compatibility

2023-01-31 Thread Jan Hoffmann
disabled in the device tree. So this is not just a bug in the data path driver. Regards, Jan Especially considering that now modem support is not self-contained and will require patching the DWC Qualcomm PCI driver forever. Regards, Robert [0] https://forum.openwrt.org/t/adding-supp

[PATCH] ipq40xx: add PCIe magic hack to improve VRX518 compatibility

2023-01-30 Thread Jan Hoffmann
so this shouldn't affect any devices other than FRITZ!Box 7530/7520. Signed-off-by: Jan Hoffmann --- .../boot/dts/qcom-ipq4019-fritzbox-7530.dts | 2 + .../997-pcie-qcom-host-magic.patch| 215 ++ 2 files changed, 217 insertions(+) create mode 100644 target/

[PATCH] ltq-*-app: extend ubus metrics/statistics

2023-01-28 Thread Jan Hoffmann
Expose a few additional useful values via ubus: - Channel error counters (CRC, FEC) - Retransmission counters (MINEFTR, LEFTRS) - Impulse noise protection level - Rate adaptation mode - OLR statistics (Bitswap, SRA, SOS) - Pilot tones - Upstream/downstream band information Signed-off-by: Jan

[PATCH] ltq-vdsl-vr9: fix upstream MINEFTR

2023-01-28 Thread Jan Hoffmann
The upstream value read from the device seems to already be in bits per second, so there is no need to multiply by 1000 again (which for typical values causes an overflow of the 32-bit unsigned integer). Signed-off-by: Jan Hoffmann --- This patch is already applied for ltq-vdsl-vr11. It is not

[PATCH] ramips: use on-flash partition table for Sercomm BZV/CHJ

2023-01-27 Thread Jan Hoffmann
these issues. Replace the two reserved partitions by the full partition list, as the driver does not allow merging them. Signed-off-by: Jan Hoffmann --- I only tested on a WAC124 without any bad blocks, but the kernel log shows that the partition map parser is used. This issue seems to be quite c

[PATCH-22.03 2/2] sunxi: ensure NanoPi R1 has unique MAC address

2023-01-06 Thread Jan-Niklas Burfeind
o-authored-by: David Bauer Signed-off-by: Jan-Niklas Burfeind (cherry picked from commit c7d3bbb909bdcccd4f26f18b18cc1cb00500a874) --- .../base-files/files/lib/functions/system.sh | 8 ++ .../armv8/base-files/etc/board.d/02_network | 13 ++ .../sunxi/base-files/etc/board.d/02_netw

[PATCH-22.03 1/2] uboot-sunxi: use UUID of bootdev and bootpart

2023-01-06 Thread Jan-Niklas Burfeind
ce image, and this method has been proven to work fine for a64, let's just change the default u-boot env file to do the same. Fixes: #10080 Fixes: e6d9f6fdff ("sunxi: add support for FriendlyARM NanoPi R1") Co-authored-by: Karl Palsson Signed-off-by: Jan-Niklas Burfeind [use UU

Re: [PATCH] ramips: add support for D-Link DAP-X1860 A1

2023-01-06 Thread Jan-Niklas Burfeind
get_mac_binary factory 0x4)" + [ "$PHYNBR" = "0" ] && \ + macaddr_add $hw_mac_addr 1 > /sys${DEVPATH}/macaddress + [ "$PHYNBR" = "1" ] && \ + macaddr_add $hw_mac_addr 4 > /sys${DEVPATH}/macaddress + ;; dlink,dir-853-a3) [ "$PHYNBR" = "0" ] && \ macaddr_setbit_la "$(mtd_get_mac_binary factory 0xe000)" \ diff --git a/target/linux/ramips/mt7621/base-files/lib/upgrade/platform.sh b/target/linux/ramips/mt7621/base-files/lib/upgrade/platform.sh index 06a35077dc..15bab1958a 100755 --- a/target/linux/ramips/mt7621/base-files/lib/upgrade/platform.sh +++ b/target/linux/ramips/mt7621/base-files/lib/upgrade/platform.sh @@ -59,6 +59,7 @@ platform_do_upgrade() { beeline,smartbox-giga|\ beeline,smartbox-turbo|\ belkin,rt1800|\ + dlink,dap-x1860-a1|\ dlink,dir-1960-a1|\ dlink,dir-2640-a1|\ dlink,dir-2660-a1|\ I tested the patch on tonights master. Does work as described in his message. Whoever merges this can add: Jan-Niklas Burfeind ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[PATCH] realtek: don't relocate kernel on HPE 1920 series

2023-01-05 Thread Jan Hoffmann
This is no longer needed now that the kernel is built with a load address that matches the one hard-coded in the bootloader. Signed-off-by: Jan Hoffmann --- target/linux/realtek/image/Makefile | 14 -- target/linux/realtek/image/common.mk | 2 -- 2 files changed, 16 deletions

[PATCH-22.03] lantiq-xrx200: fix wan LED on o2 box 6431

2023-01-05 Thread Jan-Niklas Burfeind
device fixes #7757 (and FS#2987) Signed-off-by: Florian Maurer (cherry picked from commit 0820d620123a03b6db6642acb6e950d22ffb030f) Signed-off-by: Jan-Niklas Burfeind --- target/linux/lantiq/xrx200/base-files/etc/board.d/01_leds | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[PATCH] sunxi: enable CONFIG_NVMEM_SYSFS

2022-12-29 Thread Jan-Niklas Burfeind
in both the stable and the testing kernel h2+/h3/h5 devices have a Secure ID that can be read from `/sys/bus/nvmem/devices/sunxi-sid0/nvmem`. Enabling CONFIG_NVMEM_SYSFS grants sysfs access from userspace. Signed-off-by: Jan-Niklas Burfeind --- Hauke suggested enabling it for the whole sunxi

[PATCH v2] sunxi: ensure NanoPi R1 has unique MAC address

2022-12-23 Thread Jan-Niklas Burfeind
o-authored-by: David Bauer Signed-off-by: Jan-Niklas Burfeind --- .../base-files/files/lib/functions/system.sh | 8 ++ .../armv8/base-files/etc/board.d/02_network | 13 ++ .../sunxi/base-files/etc/board.d/02_network | 25 +++ 3 files changed, 35 insertions(+), 11

[PATCH] sunxi: ensure NanoPi R1 has unique MAC address

2022-12-22 Thread Jan-Niklas Burfeind
uthored-by: David Bauer Signed-off-by: Jan-Niklas Burfeind --- .../sunxi/base-files/etc/board.d/02_network | 34 +++ 1 file changed, 34 insertions(+) diff --git a/target/linux/sunxi/base-files/etc/board.d/02_network b/target/linux/sunxi/base-files/etc/board.d/02_network index

Re: Ethernet switch with linux/openwrt and DSA

2022-12-22 Thread Jan Hoffmann
occur even without multicast snooping enabled and results in corruption of the unknown multicast port mask. Best, Jan [1] https://github.com/janh/openwrt/commits/realtek-multicast-snooping ___ openwrt-devel mailing list openwrt-devel@lists.openwr

[PATCH v2] uboot-sunxi: use UUID of bootdev and bootpart

2022-12-20 Thread Jan-Niklas Burfeind
for the NanoPi R1 instead of the hardcoded `mmcblk0p2` to support its multiple mmcs. Fixes: e6d9f6fdff ("sunxi: add support for FriendlyARM NanoPi R1") Co-authored-by: Karl Palsson Signed-off-by: Jan-Niklas Burfeind --- package/boot/uboot-sunxi/Makefile| 1 + package/boot/u

[PATCH v2 2/3] realtek: restructure rtl_table_read/write

2022-12-17 Thread Jan Hoffmann
poll, any callers doing many table accesses still need to make sure not to block other kernel tasks themselves. So far, polling timeout errors are only handled by logging an error, but a return value is added to allow proper handling in the future. Signed-off-by: Jan Hoffmann --- .../drivers/net

[PATCH v2 3/3] realtek: add cond_resched to loops accessing the FDB table

2022-12-17 Thread Jan Hoffmann
A full loop accessing all FDB entries can take several milliseconds (on RTL839x about 20 ms), so give other kernel tasks a chance to run. This is especially important for rtl83xx_port_fdb_dump which is itself called in a loop for all ports by the kernel. Signed-off-by: Jan Hoffmann

[PATCH v2 1/3] realtek: simplify log messages in rtl83xx_mdio_probe

2022-12-17 Thread Jan Hoffmann
This function currently prints three messages for every switch port at KERN_INFO level. This takes a considerable amount of time during bootup and can even trigger an external watchdog. Replace these log messages by a single one at KERN_DEBUG level. Signed-off-by: Jan Hoffmann --- .../realtek

[PATCH v2 0/3] realtek: avoid blocking for too long

2022-12-17 Thread Jan Hoffmann
rtl83xx_mdio_probe - move cond_resched to loops - support kernel 5.15 Jan Hoffmann (3): realtek: simplify log messages in rtl83xx_mdio_probe realtek: restructure rtl_table_read/write realtek: add cond_resched to loops accessing the FDB table .../drivers/net/dsa/rtl83xx/common.c | 49

[PATCH v2] realtek: don't set L2LEARNING flag in rtl83xx TX header

2022-12-17 Thread Jan Hoffmann
U to other ports. In that case, the switch would incorrectly learn the CPU port as source. An example that triggered this issue are Multicast Listener Reports and IGMP membership reports. Signed-off-by: Jan Hoffmann --- Changes in v2: - update commit message - support kernel 5.15 .../realtek/fi

Re: [PATCH] uboot-sunxi: use UUID of bootdev and bootpart

2022-12-15 Thread Jan-Niklas Burfeind
On 12/15/22 15:18, Jan-Niklas Burfeind wrote: instead of the hardcoded `mmcblk0p2` to support devices with multiple mmcs, like the NanoPi R1. Fixes: e6d9f6fdff ("sunxi: add support for FriendlyARM NanoPi R1") Signed-off-by: Jan-Niklas Burfeind --- Good afternoon. I just had a discu

[PATCH] uboot-sunxi: use UUID of bootdev and bootpart

2022-12-15 Thread Jan-Niklas Burfeind
instead of the hardcoded `mmcblk0p2` to support devices with multiple mmcs, like the NanoPi R1. Fixes: e6d9f6fdff ("sunxi: add support for FriendlyARM NanoPi R1") Signed-off-by: Jan-Niklas Burfeind --- Good afternoon. I just had a discussion with karlp in openwrt-devel, where we ta

Re: Ethernet switch with linux/openwrt and DSA

2022-12-14 Thread Jan Hoffmann
. For 1920-24G, the patches 2 and 5 from [1] are probably still necessary, as the device will reset during boot otherwise. I should really send updated versions of these to finally get that issue fixed. Best, Jan [1] http://lists.openwrt.org/pipermail/openwrt-devel/2022-October

Re: Ethernet switch with linux/openwrt and DSA

2022-12-14 Thread Jan Hoffmann
ot otherwise. I should really send updated versions of these to finally get that issue fixed. Best, Jan [1] http://lists.openwrt.org/pipermail/openwrt-devel/2022-October/039565.html ___ openwrt-devel mailing list openwrt-devel@lists.openw

[PATCH] sunxi: remove frequency for NanoPi R1

2022-12-11 Thread Jan-Niklas Burfeind
The frequency appears as unlisted initial frequency. Removed it as Hauke suggested. Signed-off-by: Jan-Niklas Burfeind --- This resolves part of the problem in #11104 on GitHub [1]. The "Waiting for root device /dev/mmcblk0p2..."-issue still remains and leaves the device unbootable

[BACKPORT 22.03 v2 1/2] comgt-ncm: add support for quectel modem EC200T-EU

2022-12-07 Thread Jan-Niklas Burfeind
context_type is an integer mapping of pdptype: 1: IPV4 2: IPV6 3: IPV4V6 Signed-off-by: Jan-Niklas Burfeind (cherry picked from commit 13f82ce264ed2d02c66cb2cae8f013c8f64a979f) --- I sent the patch a few hours eatlier, but missed the development list. Commit-ID changed as I wrongly changed the

[BACKPORT 22.03 v2 2/2] ramips: add support for Wavlink WS-WN572HP3 4G

2022-12-07 Thread Jan-Niklas Burfeind
-off-by: Jan-Niklas Burfeind Acked-by: Arınç ÜNAL (cherry picked from commit dce66899bf243d78689afcc693340b891bbf4c2d) --- .../dts/mt7621_wavlink_ws-wn572hp3-4g.dts | 184 ++ target/linux/ramips/image/mt7621.mk | 17 ++ .../mt7621/base-files/etc/board.d/02_network

Re: [PATCH] realtek: update GPIO bindings for DGS-1210-10P

2022-12-05 Thread Jan-Niklas Burfeind
On 12/5/22 00:02, Jan-Niklas Burfeind wrote: On 12/4/22 20:45, Sander Vanheule wrote: Hi Jan-Niklas, On Fri, 2022-12-02 at 14:55 +0100, Jan-Niklas Burfeind wrote: add three missing LEDs   - PoE-Max   - Link/Act   - PoE Do the latter two LEDs indicate which LED mode is currently selected

Re: [PATCH] realtek: update GPIO bindings for DGS-1210-10P

2022-12-04 Thread Jan-Niklas Burfeind
On 12/4/22 20:45, Sander Vanheule wrote: Hi Jan-Niklas, On Fri, 2022-12-02 at 14:55 +0100, Jan-Niklas Burfeind wrote: add three missing LEDs  - PoE-Max  - Link/Act  - PoE Do the latter two LEDs indicate which LED mode is currently selected (on stock FW)? Users can do with these LEDs what

[PATCH] realtek: update GPIO bindings for DGS-1210-10P

2022-12-02 Thread Jan-Niklas Burfeind
add three missing LEDs - PoE-Max - Link/Act - PoE add two missing buttons - mode - reset The last was dropped in commit 61a3d0075b15 ("realtek: update GPIO bindings in the dts files in dts-5.10") Signed-off-by: Jan-Niklas Burfeind --- Hello everyone, I just tested the mi

Re: [PATCH v4 2/2] ramips: add support for Wavlink WS-WN572HP3 4G

2022-12-01 Thread Jan-Niklas Burfeind
On 12/1/22 09:25, Arınç ÜNAL wrote: On 30.11.2022 23:35, Jan-Niklas Burfeind wrote: Wavlink WS-WN572HP3 4G is an 802.11ac dual-band outdoor router with LTE support. Specifications; * Soc: MT7621DAT * RAM: 128MiB * Flash: NOR 16MiB GD-25Q128ESIG3 * Wi-Fi:    * MT7613BEN: 5GHz    * MT7603EN

[PATCH v4 1/2] comgt-ncm: add support for quectel modem EC200T-EU

2022-11-30 Thread Jan-Niklas Burfeind
context_type is an integer mapping of pdptype: 1: IPV4 2: IPV6 3: IPV4V6 Signed-off-by: Jan-Niklas Burfeind --- package/network/utils/comgt/files/ncm.json | 16 package/network/utils/comgt/files/ncm.sh | 6 ++ 2 files changed, 22 insertions(+) diff --git a/package

[PATCH v4 2/2] ramips: add support for Wavlink WS-WN572HP3 4G

2022-11-30 Thread Jan-Niklas Burfeind
-off-by: Jan-Niklas Burfeind --- Huge thanks to Znevna, he suggested using gpio adresses modulo banksize. No clue where the system get's the info that bank three is the "LED-gpio-bank" but it works. Other than that I added the missing label-mac-alias to the 5GHz wifi device. Thanks

Re: [PATCH v3 2/2] ramips: add support for Wavlink WS-WN572HP3 4G

2022-11-30 Thread Jan-Niklas Burfeind
On 11/30/22 19:54, Jan-Niklas Burfeind wrote: On 11/30/22 18:27, Arınç ÜNAL wrote: On 30.11.2022 19:44, Jan-Niklas Burfeind wrote: Wavlink WS-WN572HP3 4G is an 802.11ac dual-band outdoor router with LTE support. Specifications; * Soc: MT7621DAT * RAM: 128MiB * Flash: NOR 16MiB GD

Re: [PATCH v3 2/2] ramips: add support for Wavlink WS-WN572HP3 4G

2022-11-30 Thread Jan-Niklas Burfeind
On 11/30/22 18:27, Arınç ÜNAL wrote: On 30.11.2022 19:44, Jan-Niklas Burfeind wrote: Wavlink WS-WN572HP3 4G is an 802.11ac dual-band outdoor router with LTE support. Specifications; * Soc: MT7621DAT * RAM: 128MiB * Flash: NOR 16MiB GD-25Q128ESIG3 * Wi-Fi:    * MT7613BEN: 5GHz    * MT7603EN

Re: [PATCH v3 2/2] ramips: add support for Wavlink WS-WN572HP3 4G

2022-11-30 Thread Jan-Niklas Burfeind
s-2 made me aware of an LED rssi issue; this is not ready to merge yet. On 11/30/22 17:44, Jan-Niklas Burfeind wrote: Wavlink WS-WN572HP3 4G is an 802.11ac dual-band outdoor router with LTE support. Specifications; * Soc: MT7621DAT * RAM: 128MiB * Flash: NOR 16MiB GD-25Q128ESIG3 * Wi-Fi

[PATCH v3 1/2] comgt-ncm: add support for quectel modem EC200T-EU

2022-11-30 Thread Jan-Niklas Burfeind
context_type is an integer mapping of pdptype: 1: IPV4 2: IPV6 3: IPV4V6 Signed-off-by: Jan-Niklas Burfeind --- package/network/utils/comgt/files/ncm.json | 16 package/network/utils/comgt/files/ncm.sh | 6 ++ 2 files changed, 22 insertions(+) diff --git a/package

  1   2   3   4   >