[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread plaisthos (Code Review)
Attention is currently required from: cron2, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets .. Pat

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread plaisthos (Code Review)
Attention is currently required from: cron2, ordex. ordex has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets .. dco: d

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread plaisthos (Code Review)
Attention is currently required from: cron2, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets .. Pat

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread plaisthos (Code Review)
Attention is currently required from: cron2, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets .. Pat

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread plaisthos (Code Review)
Attention is currently required from: cron2, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets .. Pat

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-13 Thread plaisthos (Code Review)
plaisthos has uploaded a new patch set (#6) to the change originally created by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: dco: don't use NetLink to exchange control packets

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-13 Thread plaisthos (Code Review)
plaisthos has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets .. dco: don't use NetLink to exchange control packets Using NetLink

[Openvpn-devel] [XS] Change in openvpn[master]: options: Do not hide variables from parent scope

2023-08-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/320?usp=email ) Change subject: options: Do not hide variables from parent scope .. Patc

[Openvpn-devel] [S] Change in openvpn[master]: Add warning if a p2p NCP client connects to a p2mp server

2023-08-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/323?usp=email to review the following change. Change subject: Add warning if a p2p NCP client connects to a p2mp server

[Openvpn-devel] [M] Change in openvpn[master]: Remove ability to use configurations without TLS by default

2023-08-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/325?usp=email to look at the new patch set (#2). Change subject: Remove ability to use configurations without TLS by default

[Openvpn-devel] [M] Change in openvpn[master]: Remove ability to use configurations without TLS by default

2023-08-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/325?usp=email to review the following change. Change subject: Remove ability to use configurations without TLS by default ..

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Support for long INFO/INFO_PRE messages

2023-09-05 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, stipa. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/327?usp=email ) Change subject: Support for long INFO/INFO_PRE messages .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: dns option: make server id/priority optional

2023-09-12 Thread plaisthos (Code Review)
Attention is currently required from: d12fk, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/40?usp=email ) Change subject: dns option: make server id/priority optional .. Pa

[Openvpn-devel] [M] Change in openvpn[master]: dns option: make server id/priority optional

2023-09-12 Thread plaisthos (Code Review)
Attention is currently required from: d12fk, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/40?usp=email ) Change subject: dns option: make server id/priority optional .. Pa

[Openvpn-devel] [S] Change in openvpn[master]: CMake: fix broken daemonization and syslog functionality

2023-09-15 Thread plaisthos (Code Review)
Attention is currently required from: stipa. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/341?usp=email ) Change subject: CMake: fix broken daemonization and syslog functionality .. Pat

[Openvpn-devel] [M] Change in openvpn[master]: Remove ability to use configurations without TLS by default

2023-10-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/325?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [S] Change in openvpn[master]: Add warning if a p2p NCP client connects to a p2mp server

2023-10-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/323?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [M] Change in openvpn[master]: Print SSL peer signature information in handshake debug details

2023-10-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/365?usp=email to review the following change. Change subject: Print SSL peer signature information in handshake debug details ..

[Openvpn-devel] [XS] Change in openvpn[master]: Add warning for the --show-groups command that some groups are missing

2023-10-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/366?usp=email to review the following change. Change subject: Add warning for the --show-groups command that some groups are missin

[Openvpn-devel] [M] Change in openvpn[master]: Print server temp key details

2023-10-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/364?usp=email to review the following change. Change subject: Print server temp key details

[Openvpn-devel] [M] Change in openvpn[master]: Print SSL peer signature information in handshake debug details

2023-10-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/365?usp=email to look at the new patch set (#2). Change subject: Print SSL peer signature information in handshake debug details

[Openvpn-devel] [M] Change in openvpn[master]: Print server temp key details

2023-10-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/364?usp=email to look at the new patch set (#2). Change subject: Print server temp key details ..

[Openvpn-devel] [S] Change in openvpn[master]: Fix various "Uninitialized scalar variable" warnings from Coverity

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/318?usp=email ) Change subject: Fix various "Uninitialized scalar variable" warnings from Coverity ..

[Openvpn-devel] [S] Change in openvpn[master]: Remove last uses of inet_ntoa

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/326?usp=email ) Change subject: Remove last uses of inet_ntoa .. Patch Set 1: Code-Revie

[Openvpn-devel] [M] Change in openvpn[master]: dns option: make server id/priority optional

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: d12fk, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/40?usp=email ) Change subject: dns option: make server id/priority optional .. Pa

[Openvpn-devel] [M] Change in openvpn[master]: Print server temp key details

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/364?usp=email to look at the new patch set (#3). Change subject: Print server temp key details ..

[Openvpn-devel] [M] Change in openvpn[master]: Remove ability to use configurations without TLS by default

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/325?usp=email ) Change subject: Remove ability to use configurations without TLS by default ..

[Openvpn-devel] [S] Change in openvpn[master]: Add warning if a p2p NCP client connects to a p2mp server

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/323?usp=email ) Change subject: Add warning if a p2p NCP client connects to a p2mp server

[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco: warn if DATA_V1 packets are sent to userspace

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: stipa. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/368?usp=email ) Change subject: dco: warn if DATA_V1 packets are sent to userspace .. Patch Set

[Openvpn-devel] [S] Change in openvpn[master]: generate_auth_token: simplify code

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/310?usp=email ) Change subject: generate_auth_token: simplify code .. Patch Set 2: Code-

[Openvpn-devel] [M] Change in openvpn[master]: Print server temp key details

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/364?usp=email to look at the new patch set (#4). Change subject: Print server temp key details ..

[Openvpn-devel] [M] Change in openvpn[master]: Print SSL peer signature information in handshake debug details

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/365?usp=email to look at the new patch set (#5). Change subject: Print SSL peer signature information in handshake debug details

[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco-win: get driver version

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, stipa. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/367?usp=email ) Change subject: dco-win: get driver version .. Patch Set 3: Code-

[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patch...

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: cron2, d12fk, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/361?usp=email ) Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork .

[Openvpn-devel] [S] Change in openvpn[master]: Add warning if a p2p NCP client connects to a p2mp server

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/323?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [S] Change in openvpn[master]: Change type of frame.mss_fix to uint16_t

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/268?usp=email ) Change subject: Change type of frame.mss_fix to uint16_t .. Patch

[Openvpn-devel] [S] Change in openvpn[master]: Add warning if a p2p NCP client connects to a p2mp server

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/323?usp=email ) Change subject: Add warning if a p2p NCP client connects to a p2mp server

[Openvpn-devel] [M] Change in openvpn[master]: Print peer temporary key details

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/364?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by

[Openvpn-devel] [XS] Change in openvpn[master]: Add warning for the --show-groups command that some groups are missing

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/366?usp=email to look at the new patch set (#6). The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now. Ch

[Openvpn-devel] [M] Change in openvpn[master]: Print peer temporary key details

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/364?usp=email to look at the new patch set (#6). Change subject: Print peer temporary key details .

[Openvpn-devel] [XS] Change in openvpn[master]: Add warning for the --show-groups command that some groups are missing

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/366?usp=email to look at the new patch set (#7). The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now. Ch

[Openvpn-devel] [M] Change in openvpn[master]: Remove ability to use configurations without TLS by default

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/325?usp=email ) Change subject: Remove ability to use configurations without TLS by default ..

[Openvpn-devel] [M] Change in openvpn[master]: Remove ability to use configurations without TLS by default

2023-10-08 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/325?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review-1 by flichtenh

[Openvpn-devel] [L] Change in openvpn[master]: Add compatibility functions for mbedtls 2.X.Y

2023-10-18 Thread plaisthos (Code Review)
Attention is currently required from: MaxF, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/371?usp=email ) Change subject: Add compatibility functions for mbedtls 2.X.Y .. P

[Openvpn-devel] [M] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-18 Thread plaisthos (Code Review)
Attention is currently required from: MaxF. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email ) Change subject: Add support for mbedtls 3.X.Y .. Patch Set 1: (1 comment) Patc

[Openvpn-devel] [L] Change in openvpn[master]: Add compatibility functions for mbedtls 2.X.Y

2023-10-18 Thread plaisthos (Code Review)
Attention is currently required from: MaxF, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/371?usp=email ) Change subject: Add compatibility functions for mbedtls 2.X.Y .. P

[Openvpn-devel] [L] Change in openvpn[master]: Remove openssl engine method for loading the key

2023-10-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/373?usp=email to review the following change. Change subject: Remove openssl engine method for loading the key .

[Openvpn-devel] [L] Change in openvpn[master]: Remove openssl engine method for loading the key

2023-10-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/373?usp=email ) Change subject: Remove openssl engine method for loading the key .. Patc

[Openvpn-devel] [L] Change in openvpn[master]: Remove openssl engine method for loading the key

2023-10-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/373?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [XS] Change in openvpn[master]: Test change

2023-10-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, unauthorized. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/401?usp=email ) Change subject: Test change .. Patch Set 1: Code-Review-1

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-18 Thread plaisthos (Code Review)
Attention is currently required from: MaxF, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email ) Change subject: Add support for mbedtls 3.X.Y .. Patch Set 3: (1

[Openvpn-devel] [XS] Change in openvpn[master]: Remove CMake custom compiler flags for RELEASE and DEBUG build

2023-10-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/374?usp=email to review the following change. Change subject: Remove CMake custom compiler flags for RELEASE and DEBUG build ...

[Openvpn-devel] [XS] Change in openvpn[master]: Add --enable-werror to all platforms in Github Actions

2023-10-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/376?usp=email to review the following change. Change subject: Add --enable-werror to all platforms in Github Actions ...

[Openvpn-devel] [S] Change in openvpn[master]: Add undefined and abort on error to clang sanaitize builds

2023-10-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/375?usp=email to review the following change. Change subject: Add undefined and abort on error to clang sanaitize builds ...

[Openvpn-devel] [XS] Change in openvpn[master]: Add --enable-werror to all platforms in Github Actions

2023-10-22 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/376?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-27 Thread plaisthos (Code Review)
Attention is currently required from: MaxF. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email ) Change subject: Add support for mbedtls 3.X.Y .. Patch Set 7: (1 comment) Patc

[Openvpn-devel] [S] Change in openvpn[master]: Fix building with cmake and mbed TLS

2023-10-28 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/377?usp=email to review the following change. Change subject: Fix building with cmake and mbed TLS .

[Openvpn-devel] [S] Change in openvpn[master]: Fix building with cmake and mbed TLS

2023-10-28 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/377?usp=email ) Change subject: Fix building with cmake and mbed TLS .. Patch Set 1: Cod

[Openvpn-devel] [S] Change in openvpn[master]: Fix building with cmake and mbed TLS

2023-10-28 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/377?usp=email ) Change subject: Fix building with cmake and mbed TLS .. Patch Set 1: -Co

[Openvpn-devel] [XS] Change in openvpn[master]: Do not check key_state buffers that are in S_UNDEF state

2023-11-11 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/426?usp=email to review the following change. Change subject: Do not check key_state buffers that are in S_UNDEF state .

[Openvpn-devel] [M] Change in openvpn[master]: Enable key export with mbed TLS 3.x.y

2023-11-11 Thread plaisthos (Code Review)
Attention is currently required from: MaxF, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/402?usp=email ) Change subject: Enable key export with mbed TLS 3.x.y .. Patch Set

[Openvpn-devel] [S] Change in openvpn[master]: protocol_dump: tls-crypt support

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/442?usp=email to review the following change. Change subject: protocol_dump: tls-crypt support .

[Openvpn-devel] [S] Change in openvpn[master]: Remove unused defined from configure and cmake config

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/443?usp=email to review the following change. Change subject: Remove unused defined from configure and cmake config

[Openvpn-devel] [S] Change in openvpn[master]: Allow specifying custom mbed TLS directories with CMake

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/377?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by

[Openvpn-devel] [XS] Change in openvpn[master]: Add check for nice in cmake config

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/444?usp=email to review the following change. Change subject: Add check for nice in cmake config ...

[Openvpn-devel] [S] Change in openvpn[master]: protocol_dump: tls-crypt support

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/442?usp=email ) Change subject: protocol_dump: tls-crypt support .. Patch Set 1: Code-Re

[Openvpn-devel] [M] Change in openvpn[master]: Various fixes for -Wconversion errors

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/267?usp=email ) Change subject: Various fixes for -Wconversion errors .. Patch Set 4: Co

[Openvpn-devel] [M] Change in openvpn[master]: tun: use is_tun_p2p more consistently

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/380?usp=email ) Change subject: tun: use is_tun_p2p more consistently .. Patch Set 1: Co

[Openvpn-devel] [M] Change in openvpn[master]: Remove compat versionhelpers.h and remove cmake/configure check for it

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/445?usp=email to review the following change. Change subject: Remove compat versionhelpers.h and remove cmake/configure check for i

[Openvpn-devel] [L] Change in openvpn[master]: Remove support for NTLM v1 proxy authentication

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/379?usp=email ) Change subject: Remove support for NTLM v1 proxy authentication .. Patch

[Openvpn-devel] [XL] Change in openvpn[master]: sample-keys: renew for the next 10 years

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/422?usp=email ) Change subject: sample-keys: renew for the next 10 years .. Patch Set 1:

[Openvpn-devel] [M] Change in openvpn[master]: Remove dead list test code

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/446?usp=email to review the following change. Change subject: Remove dead list test code ...

[Openvpn-devel] [M] Change in openvpn[master]: Print SSL peer signature information in handshake debug details

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/365?usp=email to look at the new patch set (#8). Change subject: Print SSL peer signature information in handshake debug details

[Openvpn-devel] [XS] Change in openvpn[master]: Deprecate tls-exit option

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/447?usp=email to review the following change. Change subject: Deprecate tls-exit option

[Openvpn-devel] [M] Change in openvpn[master]: Allow the TLS session to send out TLS alerts

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/449?usp=email to review the following change. Change subject: Allow the TLS session to send out TLS alerts .

[Openvpn-devel] [XS] Change in openvpn[master]: Log SSL alerts more prominently

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/448?usp=email to review the following change. Change subject: Log SSL alerts more prominently ..

[Openvpn-devel] [S] Change in openvpn[master]: Introduce report_command_status helper function

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/450?usp=email to review the following change. Change subject: Introduce report_command_status helper function ..

[Openvpn-devel] [XS] Change in openvpn[master]: Remove unused function prototype crypto_adjust_frame_parameters

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/451?usp=email to review the following change. Change subject: Remove unused function prototype crypto_adjust_frame_parameters ..

[Openvpn-devel] [XS] Change in openvpn[master]: Add check for nice in cmake config

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/444?usp=email to look at the new patch set (#2). The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now. Ch

[Openvpn-devel] [S] Change in openvpn[master]: Remove unused/uneeded defines from configure and cmake config

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/443?usp=email to look at the new patch set (#2). Change subject: Remove unused/uneeded defines from configure and cmake config ..

[Openvpn-devel] [S] Change in openvpn[master]: Remove unused/uneeded defines from configure and cmake config

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/443?usp=email ) Change subject: Remove unused/uneeded defines from configure and cmake config

[Openvpn-devel] [XS] Change in openvpn[master]: Deprecate tls-exit option

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/447?usp=email ) Change subject: Deprecate tls-exit option .. Patch Set 1: (1 comment)

[Openvpn-devel] [M] Change in openvpn[master]: Remove compat versionhelpers.h and remove cmake/configure check for it

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/445?usp=email ) Change subject: Remove compat versionhelpers.h and remove cmake/configure check for it ..

[Openvpn-devel] [M] Change in openvpn[master]: Remove compat versionhelpers.h and remove cmake/configure check for it

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/445?usp=email ) Change subject: Remove compat versionhelpers.h and remove cmake/configure check for it ..

[Openvpn-devel] [M] Change in openvpn[master]: Remove compat versionhelpers.h and remove cmake/configure check for it

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/445?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by flichtenh

[Openvpn-devel] [M] Change in openvpn[master]: Allow the TLS session to send out TLS alerts

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/449?usp=email ) Change subject: Allow the TLS session to send out TLS alerts .. Patch Se

[Openvpn-devel] [M] Change in openvpn[master]: Allow the TLS session to send out TLS alerts

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/449?usp=email to look at the new patch set (#2). Change subject: Allow the TLS session to send out TLS alerts ...

[Openvpn-devel] [S] Change in openvpn[master]: Rename state_change to continue_tls_process

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/452?usp=email to review the following change. Change subject: Rename state_change to continue_tls_process ..

[Openvpn-devel] [XS] Change in openvpn[master]: Log SSL alerts more prominently

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/448?usp=email to look at the new patch set (#2). The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now. Ch

[Openvpn-devel] [S] Change in openvpn[master]: Rename state_change to continue_tls_process

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/452?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [M] Change in openvpn[master]: Allow the TLS session to send out TLS alerts

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/449?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by

[Openvpn-devel] [M] Change in openvpn[master]: Allow the TLS session to send out TLS alerts

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/449?usp=email to look at the new patch set (#4). Change subject: Allow the TLS session to send out TLS alerts .

[Openvpn-devel] [M] Change in openvpn[master]: Rename state_change to continue_tls_process

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/452?usp=email ) Change subject: Rename state_change to continue_tls_process .. Patch Set

[Openvpn-devel] [XS] Change in openvpn[master]: Log SSL alerts more prominently

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/448?usp=email to look at the new patch set (#3). The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now. Ch

[Openvpn-devel] [M] Change in openvpn[master]: Rename state_change to continue_tls_process

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/452?usp=email to look at the new patch set (#3). Change subject: Rename state_change to continue_tls_process

[Openvpn-devel] [M] Change in openvpn[master]: Allow the TLS session to send out TLS alerts

2023-11-20 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/449?usp=email to look at the new patch set (#5). Change subject: Allow the TLS session to send out TLS alerts .

[Openvpn-devel] [S] Change in openvpn[master]: Remove unused/uneeded defines from configure and cmake config

2023-11-21 Thread plaisthos (Code Review)
Attention is currently required from: plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/443?usp=email to look at the new patch set (#3). Change subject: Remove unused/uneeded defines from configure and cmake config ..

[Openvpn-devel] [S] Change in openvpn[master]: configure: allow to disable NTLM

2023-11-21 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/378?usp=email ) Change subject: configure: allow to disable NTLM .. Patch Set 1: Code-Re

[Openvpn-devel] [S] Change in openvpn[master]: configure: allow to disable NTLM

2023-11-21 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/378?usp=email ) Change subject: configure: allow to disable NTLM .. Patch Set 1: (1 com

[Openvpn-devel] [XS] Change in openvpn[master]: configure.ac: Remove unused AC_TYPE_SIGNAL macro

2023-11-21 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/453?usp=email ) Change subject: configure.ac: Remove unused AC_TYPE_SIGNAL macro .. Patc

  1   2   3   4   5   6   7   >