Attention is currently required from: cron2, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email )
Change subject: dco: don't use NetLink to exchange control packets ...................................................................... Patch Set 4: (5 comments) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/28/comment/79ae6092_3d114668 PS4, Line 1702: */ Maybe move that comment (the part that still applies) to the new socket_is_dco_win method? File src/openvpn/ovpn_dco_linux.h: http://gerrit.openvpn.net/c/openvpn/+/28/comment/7e5b2aa7_22504803 PS4, Line 30: OVPN_CMD_NEW_PEER, Didn't you want to add a length field for the residual TCP buffer and just 0 here to avoid another API revision? File src/openvpn/socket.h: http://gerrit.openvpn.net/c/openvpn/+/28/comment/4472fe5d_39cf056b PS4, Line 1184: /* unified UDPv4 and UDPv6 and DCO (kernel adds size header) */ But here we remove the comment, even though it is also true here. http://gerrit.openvpn.net/c/openvpn/+/28/comment/f0531361_fcbd90ef PS4, Line 209: #define SF_DCO_WIN (1<<5) Is using a flag really better than a bool here? http://gerrit.openvpn.net/c/openvpn/+/28/comment/b7557dab_78851b42 PS4, Line 1069: * will strip the length header */ here the comment is kept (since it is still true) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/28?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia1297c3ae9a28b188ed21ad21ae96fff3d02ee4d Gerrit-Change-Number: 28 Gerrit-PatchSet: 4 Gerrit-Owner: ordex <a...@unstable.cc> Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: cron2 Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Thu, 09 Mar 2023 14:04:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
